From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:36:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:36:47 +0000 Subject: [Koha-bugs] [Bug 32774] New: Add information about patron type to suggestion management tables Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Bug ID: 32774 Summary: Add information about patron type to suggestion management tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some librarians would find it useful if the suggestion management tables on suggestion.tt included some information about the patron type in the Suggested by column. This could help staff make rapid decisions regarding suggestions based on the patron type. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:43:45 +0000 Subject: [Koha-bugs] [Bug 32774] Add information about patron type to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:43:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:43:48 +0000 Subject: [Koha-bugs] [Bug 32774] Add information about patron type to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #1 from Lucas Gass --- Created attachment 145917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145917&action=edit Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:44:07 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #15 from Andrew Nugged --- ah... and now it's totally incompatible with koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl buy a huge lump, so even rebase is not straight. I also need to "digging", because this also wasn't mine at the start :). Let's check further, what we can do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:44:09 +0000 Subject: [Koha-bugs] [Bug 32774] Add information about patron type to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2023 23:44:34 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add information about |Add patron category to |patron type to suggestion |suggestion management |management tables |tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 01:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 00:09:56 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- Im confused by this step: 10) If you are logged out of the OPAC it should now be logging both the message from global and from the branch level and the background should be blue (if not you will need to log out) If I log out of the OPAC I should be seeing the branch level JS/CSS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:41:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 01:41:44 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #33 from David Cook --- (In reply to Martin Renvoize from comment #32) > Indeed, that's why I was hesitant to put the 'yarn install' within the PL. > I'm sure there must be something we can pass there to ensure it installed > pinned versions from our committed lock file.. but I'm damned if I can spot > such an option. I think "yarn install --frozen-lockfile" might do the trick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 01:45:29 +0000 Subject: [Koha-bugs] [Bug 32775] New: Ordering when there are multiple languages within a language group is wrong Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Bug ID: 32775 Summary: Ordering when there are multiple languages within a language group is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you have en-NZ (ordered first), and a different non-en language (ordered second) enabled on your Koha instance then you can encounter the non-en language displaying first in the 'language' and 'OPACLanguages' system preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:57:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 01:57:09 +0000 Subject: [Koha-bugs] [Bug 32776] New: Choose to convert oldest reserve or all possible reserves to recalls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 Bug ID: 32776 Summary: Choose to convert oldest reserve or all possible reserves to recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 31415 introduces a script to convert reserves to recalls. By default, it will take the oldest reserve on a record and convert it to a recall. We should be able to customise which reserve(s) are converted to recalls. Options may include: - oldest reserve - one reserve for each issued item available to be recalled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 01:57:27 +0000 Subject: [Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Depends on| |31415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 [Bug 31415] Script to automate converting reserves to recalls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 01:57:27 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:02:13 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #34 from David Cook --- (In reply to Jonathan Druart from comment #31) > I have one concern about the `yarn install` step. At some point we want to > freeze the node_modules directory, or we may get expected regressions at a > very bad time. > Imagine we are testing a beta version D-15 before the release, everything is > working great, we decide to release on D-day, package maintainer releases > using `yarn install && yarn build:prod`. If something changed in the node > modules, we haven't tested it and we release a broken version. If we use "yarn install --frozen-lockfile" when running via Makefile.PL, that should avoid that scenario. We'd be using only the versions from yarn.lock that hypothetically were tested. That said, testing will be interesting. I suppose you'll get generated files at ktd startup time, and those should be OK until you change branches. At that point, you might have the wrong generated files and not know it. When it comes to local dev/test, we might need to just get into the habit of being mindful of doing yarn install/build when we switch branches (if required). Sandboxes shouldn't be a problem since we could automate the file re-generation... > It's tricky and I don't have a solution right now, but we need to: > * Let developers yarn install whenever they want > (/kohadevbox/koha/node_modules will be used/tested) > * Have a generated (when?) version (/kohadevbox/node_modules) that would be > used to generate the compiled files on ktd startup (sandboxes and devs). We > could run build:prod to avoid last minute bugs to popup. > * Pick the last generated version for the release I suppose test/QA theoretically should catch if there's a problem with generated files. So the "last generated version for the release" will just be what's in the package.json and yarn.lock files. Maybe we're overthinking it a bit? Although I think changing "yarn install" to "yarn install --frozen-lockfile" sounds necessary for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:02:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:02:56 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #1 from Alex Buckley --- Created attachment 145918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145918&action=edit Bug 32775: Do not order language directories based on when they were created Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:03:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:03:24 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #2 from Alex Buckley --- Created attachment 145919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145919&action=edit Bug 32775: Correctly display language order in sysprefs when you have multiple languages in a group Test plan: 1. Apply first patch 2. Install en-NZ and another language - e.g. mi-NZ - so you have three languages showing in your sysprefs en-NZ (selected), en (unselected) and mi-NZ (selected) 3. Tick en-NZ and mi-NZ in language and OPACLanguages sysprefs. Order en-NZ above mi-NZ and save 4. Refresh the syspref page and confirm mi-NZ is displaying above en-NZ, even though you ordered en-NZ first 5. Refresh the syspref page multiple times and observe the order of the languages changes 6. Apply this (second) patch 7. Restart plack 8. Refresh syspref page several times confirming that en-NZ is always ordered first - as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:03:40 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:43:24 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #7) > (In reply to David Cook from comment #6) > > (In reply to Jonathan Druart from comment #5) > > > That's actually not a solution. The worker will call Koha methods which will > > > log using Koha::Logger. > > > > Koha::Logger can be configured to log to STDERR which would then be handled > > via "daemon", so it should work. > > Are you referring to Koha::Logger->debug_to_screen? No, I mean in log4perl.conf. We typically use Log::Log4perl::Appender::File in Koha but you can use Log::Log4perl::Appender::Screen instead. You can then choose STDERR instead of STDOUT for that "screen" output. Looks like it's been mentioned (mostly by me) on bug 25284, bug 28477, bug 16357, and bug 8190. Not enough time and too much inertia to change existing things on those bugs, but we have a chance here to use Log::Log4perl::Appender::Screen from the start. Happy to chat more about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 02:44:31 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 --- Comment #19 from David Cook --- (In reply to Jonathan Druart from comment #18) > Shouldn't we move misc/background_jobs_worker.pl to misc/workers/ as well? > On another bug? +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 07:45:06 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #35 from Jonathan Druart --- (In reply to David Cook from comment #34) > (In reply to Jonathan Druart from comment #31) > > I have one concern about the `yarn install` step. At some point we want to > > freeze the node_modules directory, or we may get expected regressions at a > > very bad time. > > Imagine we are testing a beta version D-15 before the release, everything is > > working great, we decide to release on D-day, package maintainer releases > > using `yarn install && yarn build:prod`. If something changed in the node > > modules, we haven't tested it and we release a broken version. > > If we use "yarn install --frozen-lockfile" when running via Makefile.PL, > that should avoid that scenario. We'd be using only the versions from > yarn.lock that hypothetically were tested. Indeed, we discussed that already but forgot. Good :) > That said, testing will be interesting. I suppose you'll get generated files > at ktd startup time, and those should be OK until you change branches. At > that point, you might have the wrong generated files and not know it. > > When it comes to local dev/test, we might need to just get into the habit of > being mindful of doing yarn install/build when we switch branches (if > required). Or use watch :) > Sandboxes shouldn't be a problem since we could automate the file > re-generation... > > > It's tricky and I don't have a solution right now, but we need to: > > * Let developers yarn install whenever they want > > (/kohadevbox/koha/node_modules will be used/tested) > > * Have a generated (when?) version (/kohadevbox/node_modules) that would be > > used to generate the compiled files on ktd startup (sandboxes and devs). We > > could run build:prod to avoid last minute bugs to popup. > > * Pick the last generated version for the release > > I suppose test/QA theoretically should catch if there's a problem with > generated files. So the "last generated version for the release" will just > be what's in the package.json and yarn.lock files. > > Maybe we're overthinking it a bit? I did overthink it yesterday, yes! Glad we have an easy solution. The question is then when do we run `yarn install` and update the lock file? But we can discuss that later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 07:49:04 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #36 from Jonathan Druart --- New commit added to the remote branch: "Bug 32609: Use the current yarn.lock to generate node_modules" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 07:51:38 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 07:51:53 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #37 from Jonathan Druart --- This is ready to be tested! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 07:58:42 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:01:09 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #6 from Martin Renvoize --- Updateing to NSO.. both patches work as described so I'd be happy to sign off.. However, I'm not entirely sure which we should adopt.. the addition of `^` to turn a search into 'starts_with' or the addition of `%` to turn a search into 'contains'. My gut says, users were comfortable with default being `starts_with` and so documenting the addition of `%` switching it to `contains` may be the least friction approach. Asking colleagues to weight in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:07:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:07:50 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #38 from Martin Renvoize --- Awesome teamwork here chaps.. I'll resume testing today, should be able to get a signoff done. Do we need a list of other tasks that need taking care as part of pushing this.. i.e. we'll need to update the sandboxes and ktd to run the new yarn commands (or perhaps point them at the new build_resources.PL script alternatively). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:10:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:10:39 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:21:34 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:21:39 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #27 from Thibaud Guillot --- Created attachment 145920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145920&action=edit Bug 18064: (follow up) rebase on master and reorder syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:22:24 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #28 from Thibaud Guillot --- (In reply to Lucas Gass from comment #26) > It appears like this one no longer applies in current master. I think the > fix is an easy one though in installer/data/mysql/mandatory/sysprefs.sql. Thanks for your feedback, patch actually rebased on fresh master :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:35:19 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:35:25 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 --- Comment #1 from Jonathan Druart --- Created attachment 145921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145921&action=edit Bug 32770: Restore patron search on all emails and phone numbers Prior to bug 30063 we had "Email" and "Phone" in the search field list that allowed a search on all email or phone attributes. This patch restores that (in an a bit ugly way, but cannot do easier). Test plan: Confirm that "Email" and "Phone" are displayed in the search field list when searching for patrons. Note that "Phone" was there already, but was only searching on the first "phone" attribute. Confirm that the search works as expected. Note for QA: I was not expecting the REST API to handle search on attributes with the DB column names, I think this is a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:35:47 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:39:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:39:45 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #39 from Jonathan Druart --- (In reply to Martin Renvoize from comment #38) > Do we need a list of other tasks that need taking care as part of pushing > this.. i.e. we'll need to update the sandboxes and ktd to run the new yarn > commands (or perhaps point them at the new build_resources.PL script > alternatively). This is for https://gitlab.com/koha-community/koha-misc4dev/-/issues/60 I have a patch almost done, but I need a DB rev number to finish it (yes, that's not nice, we will depend on a DB rev for something not DB related...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:44:21 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29805 --- Comment #10 from Jonathan Druart --- (In reply to Nick Clemens from comment #9) > (In reply to Jonathan Druart from comment #8) > > What's the version of the DBMS, Nick? > > Server version: 5.7.12 MySQL Community Server (GPL) If this is a MySQL 5.7 thing, are we still supporting it? See also bug 29805. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:44:21 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32162 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 08:44:33 +0000 Subject: [Koha-bugs] [Bug 32162] erm_eholdings_packages_agreements does not have a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:03:50 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #14 from Jonathan Druart --- I am all for this change, but I don't think it should be pushed before we stabilize this area a bit. There are bug fixes with higher priority. I would like to note 2 things here: 1. the tidy in Koha/BackgroundJob/BatchUpdateItem.pm goes against my config, so we have a problem here if people go after others to tidy differently their code.. 2. I was intrigued by the removal of - $self->discard_changes; and it seems safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:05:15 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #15 from Jonathan Druart --- Also, as discussed earlier, I would suggest to rename (on a separate bug report) ->start and ->finish to ->mark_as_started and ->mark_as_finished (or anything similar) to remove the ambiguity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:20:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:20:25 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #10 from Matt Blenkinsop --- Hi Lucas, if you are logged in then your user will have a default branch - you should see the UserJs and CSS for that patron branch which may be different to the branch that you set in your Apache config. For example if you set the OPAC as having a default code of FPL and you are logged into the OPAC with a patron that has a branch code of CPL, you will see the settings for CPL and not FPL as the patron will override the default. Therefore you would need to log out to see your UserJS and CSS changes for the FPL branch. You can also set specific UserJS and CSS for the CPL branch and that will appear when you are logged in as a CPL user. Hope that makes sense! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:25:29 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145605|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 145922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145922&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:26:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:26:23 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Jonathan Druart --- (In reply to David Nind from comment #20) > I had an issue with: > - Steps 6 and 7: if there is an invalid patron category, there should be no > "Register here" link I dealt with the main page only. The new page is hiding all "register here" links. > - Step 10: dateexpiry and categorycode fields I am not sure I understand, what you are describing is the expected behaviour: we want to force categorycode and dateexpiry in PatronSelfRegistrationBorrowerUnwantedField (and so prevent their removal). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:35:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:35:09 +0000 Subject: [Koha-bugs] [Bug 32664] Remove test and dev module dependencies from koha-common pkg In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32664 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I am suggesting to remove the scripts, and so the problematic dependency, on > libhttpd-bench-apachebench-perl. on... bug 32673. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:39:54 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Thibaud Guillot --- (In reply to Amaury GAU from comment #15) > Hi, > > I can't reproduce the Test Plan. Everything seems correct before and after > applying the patch, in both the Staff interface and the OPAC. > > This might have been corrected throughout the updates. Probably needs some > checkup. Hi Amaury, I tried to reproduce it again, there are some behavior changes on the master, the button to highlight or not appears now but the terms are not properly highlighted (as in the test plan: "b) not all search terms are highlighted (e.g. "των" in the 2nd book)") and after applying this patch it seems to be fixed. However, for versions 21.11 and earlier, the behavior is as explained in this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:42:42 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #17 from Thibaud Guillot --- (In reply to Amaury GAU from comment #15) > Hi, > > I can't reproduce the Test Plan. Everything seems correct before and after > applying the patch, in both the Staff interface and the OPAC. > > This might have been corrected throughout the updates. Probably needs some > checkup. I forgot to answer you about sysprefs or others that must be activated.. On master now there is a syspref to activate Highlight on search terms, so it must be set on 'Highlight' of course => see "StaffHighlightedWords". Thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:49:50 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:49:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:49:55 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #8 from Jonathan Druart --- Created attachment 145923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145923&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:51:40 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29963 --- Comment #9 from Jonathan Druart --- I am really hesitant here, didn't we decide to not prefill it? See bug 29963. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:51:40 +0000 Subject: [Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:51:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:51:47 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 09:53:22 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > I am really hesitant here, didn't we decide to not prefill it? > > See bug 29963. Ok, got it. This is about the focus. Then I think the patch is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:01:16 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32406, 32409 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32406, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32409 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 [Bug 32406] Cannot search pending orders using non-latin-1 scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 [Bug 32409] Cannot search cashups using non-latin-1 scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:01:16 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32401 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:01:16 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32401 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32401 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:08:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:08:41 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #84 from Jonathan Druart --- Note that bug 32401 is removing header_filter from DT wrapper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:09:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:09:55 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:09:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:09:59 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144446|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 145924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145924&action=edit Bug 32406: Switch acq datatable from headers to query param This patch changes the pending orders datatable from using the x-koha-query header to the "q" query parameter, so that it is able to support UTF-8 encoded scripts rather than just Latin-1 scripts. Test plan: 1. Apply patch 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Change title from "Gairm" to "五" (alternatively use "cœur" or Arabic title) 4. Create a basket containing multiple records including bib 29 五 5. Close the basket 6. Receive shipment 7. You should be on a page like the following: http://localhost:8081/cgi-bin/koha/acqui/parcel.pl?invoiceid=3 8. In the search box, type in 五 9. Note that you see a "Processing..." box and then the results are filtered to just show the order for 五 Signed-off-by: Tomas Cohen Arazi tcohen amend: removed the line instead as we are probably phasing out that DT configuration option anyway. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:10:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:10:25 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:10:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:10:30 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144461|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 145925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145925&action=edit Bug 32409: Fix cashup searching with non latin-1 chars This patch fixes a problem with the way queries are passed to the API so cashups are searchable with non-laint1 chars. To test: 1. Have two superlibrarian users, one with non-latin1 chars on the name (e.g. خمسة) 2. Setup a debit type that can be sold. 3. Use the POS module to have some activity, using both your regular user and the other one. 4. Go to the register you used, and choose 'Transaction history' 5. Perform a couple cashups with each user ('Record cashup'). 6. Look at the 'Cashup history' table => SUCCESS: You see cashups for both users 7. Use the 'Search' filter with latin chars => SUCCESS: Your user with only latin1 chars is displayed on the table 8. Repeat, using some non-latin1 char found on the other user => FAIL: Table is not refreshed or filtered! 9. Apply this patch 10. Reload the page 11. Repeat 8 => SUCCESS: Filtering works now! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:10:51 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:10:55 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144462|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 145926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145926&action=edit Bug 32401: Remove x-koha-query support HTTP headers can only contain ASCII characters, and it is thus impractical to use a header for passing DB queries that could contain non-ascii characters. We don't need it, and should be removed. This patch removes traces from the datatables.js files and also from detail.tt, which had it set to false anyway. See bug 32406 and bug 32409 for the cases in which it was being used, and problematic. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:20:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:20:48 +0000 Subject: [Koha-bugs] [Bug 9893] Koha::DateUtils::output_pref should not use $dateonly parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9893 --- Comment #2 from Jonathan Druart --- Could be, but that's not going to bring us many benefits. And I actually think I prefer to have it separate, especially because timeformat is also a syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:20:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:20:59 +0000 Subject: [Koha-bugs] [Bug 9893] Koha::DateUtils::output_pref should not use $dateonly parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:24:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:24:38 +0000 Subject: [Koha-bugs] [Bug 8871] Many "subroutine redefined" warnings from C4 and Koha modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8871 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Many "subroutine redefined" |Many "subroutine redefined" |warnings from C4 modules |warnings from C4 and Koha | |modules --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > (In reply to Jonathan Druart from comment #4) > > This is not specific to C4/Reserves.pm. We have circular dependencies in all > > our C4 modules. > > How should we go about this? Is there a chance to fix those or is this more > a matter of moving more things to Koha: to clean up the code more? Not really... % perl -w C4/Circulation.pm 2>&1|wc -l 53 % perl -w C4/Reserves.pm 2>&1|wc -l 35 % perl -w Koha/Item.pm 2>&1|wc -l 56 % perl -w Koha/Patron.pm 2>&1|wc -l 83 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:27:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:27:00 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:27:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:27:04 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145917|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 145927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145927&action=edit Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:37:37 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 Hans Pålsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson at hkr.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:44:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:44:29 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:44:33 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145921|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 145928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145928&action=edit Bug 32770: Restore patron search on all emails and phone numbers Prior to bug 30063 we had "Email" and "Phone" in the search field list that allowed a search on all email or phone attributes. This patch restores that (in an a bit ugly way, but cannot do easier). Test plan: Confirm that "Email" and "Phone" are displayed in the search field list when searching for patrons. Note that "Phone" was there already, but was only searching on the first "phone" attribute. Confirm that the search works as expected. Note for QA: I was not expecting the REST API to handle search on attributes with the DB column names, I think this is a bug. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:46:29 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #7 from Martin Renvoize --- OK.. we all agreed Option 1 is likely the behaviour we want.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:54:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:54:05 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32637 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:58:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:58:21 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 --- Comment #2 from Jonathan Druart --- I am expecting this to be enough, but apparently the spec validation is not working here. diff --git a/api/v1/swagger/paths/patrons.yaml b/api/v1/swagger/paths/patrons.yaml index 1100a9fba96..493be03d507 100644 --- a/api/v1/swagger/paths/patrons.yaml +++ b/api/v1/swagger/paths/patrons.yaml @@ -6,6 +6,8 @@ tags: - patrons summary: List patrons + consumes: + - application/json produces: - application/json parameters: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 11:59:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 10:59:58 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 --- Comment #3 from Jonathan Druart --- (tried with GET instead of POST, but that's the same) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:06:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:06:53 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 --- Comment #4 from Jonathan Druart --- Is this https://github.com/jhthorsen/mojolicious-plugin-openapi/issues/209 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:08:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:08:13 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Is this https://github.com/jhthorsen/mojolicious-plugin-openapi/issues/209 ? Well, almost... """ Please ask on IRC or open an issue if you found a bug, as this issue if for v3. (Sorry, but I’m unsure what you try to point out in the last comment) """ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:18:30 +0000 Subject: [Koha-bugs] [Bug 32777] New: Unhandled exception not displaying stack trace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 Bug ID: 32777 Summary: Unhandled exception not displaying stack trace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com CC: tomascohen at gmail.com Depends on: 25032 It's painful to debug, we should display the stack trace to track down the root of the problem. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:18:30 +0000 Subject: [Koha-bugs] [Bug 25032] Generic unhandled exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 [Bug 32777] Unhandled exception not displaying stack trace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:20:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:20:46 +0000 Subject: [Koha-bugs] [Bug 32777] Unhandled exception not displaying stack trace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 --- Comment #1 from Jonathan Druart --- Created attachment 145929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145929&action=edit Bug 32777: Display stack trace for REST API unhandled exception -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:21:49 +0000 Subject: [Koha-bugs] [Bug 32777] Unhandled exception not displaying stack trace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |In Discussion --- Comment #2 from Jonathan Druart --- Do we need that in production as well? Do we actually have stack traces in production for other 500? If not, why? How do people debug crashes if they are not displayed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:22:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:22:10 +0000 Subject: [Koha-bugs] [Bug 32777] Unhandled exception not displaying stack trace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:45:02 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:45:06 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 --- Comment #1 from Owen Leonard --- Created attachment 145930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145930&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:48:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:48:47 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:54:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:54:05 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:54:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:54:09 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122648|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 145931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145931&action=edit Bug 28672: Pass itemnumber instead of item object The warn call here was passing the full item object which leads to HASH() in the logs.. this patch updates it to pass the itemnumber which is more helpful. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:54:19 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 --- Comment #4 from Kyle M Hall --- Created attachment 145932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145932&action=edit Bug 28672: (QA follow-up) Method calls cannot be interpolated directly Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:56:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:56:05 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145932|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 145933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145933&action=edit Bug 28672: (QA follow-up) Method calls cannot be interpolated directly Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:56:54 +0000 Subject: [Koha-bugs] [Bug 32768] Autocomplete suggestions container should always be on top of other UI elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 11:57:57 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Kyle M Hall --- (In reply to Olivier Hubert from comment #2) > The patch applies but I am unsure of how to proceed in order to confirm that > this works as intended. Can you provide a test plan? Testing this patch requires importing an EDI invoice with a partially received quantity. This is trivial and hard to test so I am passing qa directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:02:07 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 --- Comment #7 from Martin Renvoize --- Thanks for tackling this one Kyle, and thanks for the follow-up.. just reading it this morning I thought we probably needed that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:14:24 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145876|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim --- Created attachment 145934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145934&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:18:26 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:19:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:19:10 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 --- Comment #29 from Pedro Amorim --- Apply patches, on ktd, preparation: - Run dbic - Run reset_all - Enable ILLModule sys pref - At least one ILL batch status needs to exist, admin -> (bottom right) Interlibrary Loan batch statuses, add that (name:NEW status:NEW) - At least one ILL Backend with "provide_batch_requests" capability needs to exist, add ReprintsDesk backend from https://github.com/PTFS-Europe/koha-ill-reprintsdesk to kohadevbox/koha/Koha/Illbackends with name 'ReprintsDesk' - Update backend_directory in koha-conf.xml to /kohadevbox/koha/Koha/Illbackends - At least one metadata enrichment plugin needs to exist, admin -> Manage plugins add that (https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.0) - restart_all - Run yarn build to update CSS Test plan: - Go to ILL Requests admin area, click "New ILL batch request" and select ReprintsDesk - Create new batch (insert name, cardnumber and library) and press "continue" - Add PubMed ID, one per line (example: 23668524\n29710265) and press "Process identifiers" - After processing is complete, click "add items to batch" and then "finish and view batch" Verify that: - The items requested in the batch are now illrequests in Koha, and are part of the batch that was just created - Clicking on "Batch requests" lists all existing batches - From the previous step, clicking on a batch name lists only the requests from that batch - If a batch is deleted, whatever requests that were previously on that batch are not deleted (their batch_id is now NULL) - When editing a request that is part of a batch, it's possible to change which batch the request is part of, or none. (Optional) Test logging: - Before doing the above, enable illlog sys pref - Do some CRUD actions on batch requests - Check log viewer -> module "Interlibrary loans" - Verify that the actions performed have been logged (Optional) Test error messaging: - Try creating a batch with an already existing batch name, verify it doesn't create and error message shows appropriately - Try creating a batch with a non-existent borrower cardnumber, verifiy it doesn't create the batch and error message shows appropriately Run tests and ensure all are passing: prove -v t/db_dependent/Illbatches.t prove -v t/db_dependent/api/v1/illbatches.t prove -v t/db_dependent/IllbatchStatuses.t prove -v t/db_dependent/api/v1/illbatchstatuses.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:33:34 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:33:38 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 --- Comment #3 from Nick Clemens --- Created attachment 145935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145935&action=edit Bug 32770: [alternate] Restore patron search on all emails, phones, and addresses Prior to bug 30063 we had "Email", "Phone", and "Address" in the search field list that allowed a search on all email, phone, or address attributes. This patron restores these and makes sure the search box and the patron search filters use the same block to keep them consistent The fields are now labelled 'All emails', 'All phones', and 'Full address' to make it clear that they search multiple - including any single field in the DefaultPatronSearchFields will additionally add that to the dropdowns To test: 1 - define 'test at email.pro' as 'Secondary email' for a patron 2 - Search from 'Search patrons' address bar (visible at top of moremember.pl) 3 - Nothing is found using 'Standard' or 'Email fields' 4 - Apply patch 5 - Refresh page and repeat 6 - Nothing is found for standard, Patron is found for 'All emails' 7 - Define a unique value for patron in 'Address 2' 8 - Confirm 'Full address' search returns the patron 9 - Test with 'Secondary phone' and 'All phones' as well 10 - Repeat test from 'Patrons' module using the search on the left -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:34:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:34:33 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 --- Comment #4 from Nick Clemens --- The original patch did not include 'address' and did not address the search bar - I attached an alternate to cover these and make the combination of fields more clear to users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:35:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:35:57 +0000 Subject: [Koha-bugs] [Bug 32777] Unhandled exception not displaying stack trace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32777 --- Comment #3 from Marcel de Rooy --- I am all for those stack traces. Note that the stack trace in plack-error.log often contains only a few useful lines. All the internal Plack stuff is just waste of space.. Devel::Stacktrace allows you to filter? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:42:34 +0000 Subject: [Koha-bugs] [Bug 32778] New: Auto-unsuspended holds do do not trigger realtime holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32778 Bug ID: 32778 Summary: Auto-unsuspended holds do do not trigger realtime holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Auto-unsuspended holds, or future holds, do not trigger the RealTimeHolds queue updates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 12:52:33 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #40 from Martin Renvoize --- OK.. been testing running through the make process and this is looking great so far. Not a blocker, but do we need both compiled css/js and source scss/vue files in blib? I can't see a need for them and can't see a problem having them there.. but wondered if we wanted to clean that up whilst we're in here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:05:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:05:33 +0000 Subject: [Koha-bugs] [Bug 32779] New: Import from list is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Bug ID: 32779 Summary: Import from list is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:05:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:05:33 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:10:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:10:19 +0000 Subject: [Koha-bugs] [Bug 32780] New: t/db_dependent/Koha/BackgroundJobs must be moved to t/db_dependent/Koha/BackgroundJob Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32780 Bug ID: 32780 Summary: t/db_dependent/Koha/BackgroundJobs must be moved to t/db_dependent/Koha/BackgroundJob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org % ls t/db_dependent/Koha/BackgroundJob BatchCancelHold.t BatchDeleteBiblio.t BatchUpdateAuthority.t BatchUpdateBiblio.t CreateEHoldingsFromBiblios.t MARCImportRevertBatch.t UpdateElasticIndex.t BatchDeleteAuthority.t BatchDeleteItem.t BatchUpdateBiblioHoldsQueue.t BatchUpdateItem.t MARCImportCommitBatch.t StageMARCForImport.t % ls t/db_dependent/Koha/BackgroundJobs BatchDeleteBiblio.t BatchDeleteItem.t BatchUpdateBiblio.t StageMARCForImport.t That's not consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:10:44 +0000 Subject: [Koha-bugs] [Bug 32780] t/db_dependent/Koha/BackgroundJobs must be moved to t/db_dependent/Koha/BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:10:44 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32780 [Bug 32780] t/db_dependent/Koha/BackgroundJobs must be moved to t/db_dependent/Koha/BackgroundJob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:10:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:10:59 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145777|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 145936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145936&action=edit Bug 32741: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:11:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:11:05 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145778|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 145937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145937&action=edit Bug 32741: Fix {biblios|authorities}/bib1.att duplicate codes This patch fixes a duplicate attribute code for Author-in-order in the biblios definition. The picked code matches what was already in ccl.properties. Also Chronological-term for authorities gets fixed. To test: 1. Apply the regression tests 2. Run: k$ prove xt/verify_bib1.att.t => FAIL: Some failiures 3. Apply this patch 4. Repeat 1 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:11:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:11:43 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Nice to have regressions tests here now, all works as expected, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:16:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:16:40 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145481|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 145938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145938&action=edit Bug 28314: Spinning icon is not always going away for local covers in staff The spinner is always visible with images which are under 80-90 px high this patch remove the spinner when the image is loaded. To test: 1. Make sure the LocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set LocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 2.7. Click on the title of the record in the page heading to access the detailed record --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. Search for the previous record with the small image 6. Click on the title of the record in the page heading to access the detailed record --> Note that the spinner is no more displayed Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:17:07 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Nice little fix, no regressions. QA scripts happy, Passed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:22:37 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145374|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 145939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145939&action=edit Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:23:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:23:00 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- No regressions, cleanup works. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:23:06 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:33:24 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:36:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:36:59 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145783|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 145940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145940&action=edit Bug 32455: Use from_email_address for 'from' field for hold notices This patch updates two occurrences where the inbound library email is used as the from address To test: 1 - Set a unique 'Email' and 'Reply to' address for a library 2 - Find a patron of that library, ensure they have an email 3 - Ensure their messaging preference for holds is 'email' 4 - Set system preference ReservesMaxPickupDelay to -1 5 - Set system preference ExpireReservesMaxPickUpDelay to Allow 6 - Set system preference ExpireReservesAutoFill to Do 7 - Place and fill a hold for that patron at that library 8 - Check the patron's notification tab, confirm the from address is the 'Reply to' 9 - Place a hold for another patron on the same item 10 - Run the expired holds cronjob: perl misc/cronjobs/holds/cancel_expired_holds.pl --reason=whatever 11 - Check the message_queue - notice the from address is the 'reply to' 12 - Apply patch 13 - Repeat 1-11, confirm the from addresses are correct now Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:37:04 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145784|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 145941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145941&action=edit Bug 32455: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:37:09 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145785|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 145942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145942&action=edit Bug 32455: Cleanup and expand ExpireReservesAutoFill.t The tests here reused data, and deleted the tables before starting, with a little shifting we can use specific data and avoid mass deletion To test: prove -v t/db_dependent/Holds/ExpireReservesAutoFill.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:37:43 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- Trivial fix, great unit test improvements, no regressions and QA scripts are happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:38:39 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145928|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:43:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:43:57 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145370|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 145943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145943&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind Signed-off-by: Blou Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:46:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:46:22 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Damn, annoying that we missed this in the prior bug. Still, the quick fix here works around it.. we should certainly look into implementing bug 32557 though. Passing QA as this gets us out of a hole and all works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:46:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:46:28 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:49:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:49:37 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145591|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 145944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145944&action=edit Bug 32672: Incorrect CSS path to jquery-ui This patch removes links to jQueryUI assets which are not required in the self-checkout and self-checkin pages. The patch also adds missing JS to the self-checkin page related to internationalization. This prevents a JS error related to an undefined function, "__". To test, apply the patch and view the main pages in self-checkout and self-checkin, and the help page in self checkout. There should be no errors in the browser console related to missing files. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:50:03 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- All working now, nice bit of cleanup. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:50:11 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:54:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:54:35 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144895|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 145945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145945&action=edit Bug 32537: Add no-block option to SIP cli emulator This patch adds the option to pass a no-block option and use this in checkout/checkin/renew messages To test: 1 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 2 - Confirm out like: SEND: 09N20221227 20183920221227 201839APCPL|AOCPL|AB39999000010831|ACterm1|BIN| (Note the N after 09) 3 - Apply patch 4 - Restart SIP, repeat 1 5 - Confirm still an N 6 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n N 7 - Confirm still an N 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n Y 9 - Confirm the send has a Y after 09 Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:54:39 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144935|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 145946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145946&action=edit Bug 32537: (QA follow-up) Don't allow invalid no block values Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:54:44 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144936|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 145947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145947&action=edit Bug 32537: (QA follow-up): Tidy code Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:55:06 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Great addition for SIP testing.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:55:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 13:55:12 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:19:04 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:19:08 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 --- Comment #1 from Jonathan Druart --- Created attachment 145948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145948&action=edit Bug 32779: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:19:13 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 --- Comment #2 from Jonathan Druart --- Created attachment 145949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145949&action=edit Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:25:08 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- David is correct. Everything should go through Koha::Logger. This gives the most control over where the messages end up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:35:46 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145901|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 145950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145950&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl with parameter -m 3 or some other number of max processes 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:36:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:36:19 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #31 from Kyle M Hall --- (In reply to Emily Lamancusa from comment #29) > *-Step 5 should say parameter -m 3 instead of parameter -p 3 > > Apparently I can't type it correctly either! Thanks! I've updated the test plan in the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:43:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:43:43 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #452 from Tomás Cohen Arazi --- Created attachment 145951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145951&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:43:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:43:59 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #453 from Tomás Cohen Arazi --- Created attachment 145952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145952&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:44:16 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #454 from Tomás Cohen Arazi --- Created attachment 145953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145953&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:44:34 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #455 from Tomás Cohen Arazi --- Created attachment 145954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145954&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:44:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:44:49 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #456 from Tomás Cohen Arazi --- Created attachment 145955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145955&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:50:29 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:50:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:50:41 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:50:57 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:51:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:51:09 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 14:51:20 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:00:55 +0000 Subject: [Koha-bugs] [Bug 30581] Items should show on the Holds Queue and Holds to Pull even if they have requested transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30581 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #2 from Michael Adamyk --- Agreed... this causes a lot of problems since the item in question is really in limbo, similar to an orphaned hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:12:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:12:29 +0000 Subject: [Koha-bugs] [Bug 32781] New: CreateEHoldingsFromBiblios not dealing with non-existent package correcly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Bug ID: 32781 Summary: CreateEHoldingsFromBiblios not dealing with non-existent package correcly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:12:40 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32779, 30943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:12:40 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:12:40 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:15:11 +0000 Subject: [Koha-bugs] [Bug 32769] Standardize structure around action fieldsets in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:15:15 +0000 Subject: [Koha-bugs] [Bug 32769] Standardize structure around action fieldsets in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145904|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 145956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145956&action=edit Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:15:54 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #16 from Jonathan Druart --- Created attachment 145957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145957&action=edit Bug 30943: Adjust CreateEHoldingsFromBiblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:18:24 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 --- Comment #17 from Jonathan Druart --- Created attachment 145958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145958&action=edit Bug 30943: Fix test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:28 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32779 --- Comment #18 from Jonathan Druart --- Last patch is based on bug 32779. Adding the dependency here to avoid conflicts later. I assume 32779 is going to be pushed before this one as it's a bugfix that needs to be backported. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:28 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:34 +0000 Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down acqui/histsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:37 +0000 Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down acqui/histsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:39 +0000 Subject: [Koha-bugs] [Bug 32688] Convert recalls awaiting pickup tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32688 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:19:42 +0000 Subject: [Koha-bugs] [Bug 32688] Convert recalls awaiting pickup tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32688 --- Comment #7 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:20:01 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30943 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:20:01 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32781 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:25:29 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:25:33 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 --- Comment #1 from Jonathan Druart --- Created attachment 145959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145959&action=edit Bug 32781: Prevent import from list to fail if package does not exist This is theorical (caught when writting tests) but we need to deal with it. Can't call method "resources" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 94. Test plan: prove t/db_dependent/Koha/BackgroundJob/CreateEHoldingsFromBiblios.t must return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:27:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:27:49 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:31:04 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #3 from Felicity Brown --- Having the patron type included in customer suggestions would be super helpful for our Acquisitions staff. It would be great if this were it's own separate column, so that purchase suggestions could be sorted by customer type (I'm thinking about sorting out staff requests for collection redevelopment versus new title suggestions from customers). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:34:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:34:18 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Lucas Gass --- (In reply to Felicity Brown from comment #3) > Having the patron type included in customer suggestions would be super > helpful for our Acquisitions staff. It would be great if this were it's own > separate column, so that purchase suggestions could be sorted by customer > type (I'm thinking about sorting out staff requests for collection > redevelopment versus new title suggestions from customers). Failing this based on Felicity's comment. New patch incoming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:38:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:38:47 +0000 Subject: [Koha-bugs] [Bug 32656] Script delete_records_via_leader.pl no longer deletes items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32656 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #12 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:40:53 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145218|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 145960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145960&action=edit Bug 32612: Add worker-error to log4perl conf To test: 1 - Apply patch 2 - vim /etc/koha/sites/kohadev/log4perl.conf, Add lines below: log4perl.logger.worker = WARN, WORKER log4perl.appender.WORKER=Log::Log4perl::Appender::Screen log4perl.appender.WORKER.stderr=1 log4perl.appender.WORKER.mode=append log4perl.appender.WORKER.layout=PatternLayout log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n log4perl.appender.WORKER.utf8=1 3 - Restart all 4 - Edit misc/background_jobs_worker.pl - my $job = Koha::BackgroundJobs->find($args->{job_id}); + my $job;# = Koha::BackgroundJobs->find($args->{job_id}); 5 - In another terminal: tail -f /var/log/koha/kohadev/koha-worker-error.log 6 - Force enqueue a job (that won't be found because of #4 perl -e 'use Koha::BackgroundJob::BatchUpdateItem; my $bg = Koha::BackgroundJob::BatchUpdateItem->new(); $bg->enqueue({ record_ids=>['888888']});' 7 - Note error in log like: [2023/01/11 19:26:10] [WARN] No job found for id=2983 main:: /kohadevbox/koha/misc/background_jobs_worker.pl (111) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:41:33 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:41:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:41:36 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #123 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:41:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:41:44 +0000 Subject: [Koha-bugs] [Bug 32221] Password entry should be removed from placeholder list in notices editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32221 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #11 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:44:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:44:00 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:44:04 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #55 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:45:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:45:09 +0000 Subject: [Koha-bugs] [Bug 32782] New: UNIMARC support Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Bug ID: 32782 Summary: UNIMARC support Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 I need UNIMARC equivalence for the following values: my $publication_title = $biblio->title; my $print_identifier = $record->subfield( '020', 'a' ) || $record->subfield( '020', 'z' ) || $record->subfield( '022', 'a' ) || $record->subfield( '022', 'y' ); my $online_identifier = $print_identifier; my ( $date_first_issue_online, $date_last_issue_online ) = $fix_coverage->( $record->subfield( '866', 'a' ) ); my ( $num_first_vol_online, $num_last_vol_online ) = $fix_coverage->( $record->subfield( '863', 'a' ) ); my ( $num_first_issue_online, $num_last_issue_online ) = ( '', '' ); # FIXME ? my $title_url = $record->subfield( '856', 'u' ); my $first_author = $biblio->author; my $embargo_info = ''; # FIXME ? my $coverage_depth = $title_url ? 'fulltext' : 'print'; my $notes = $record->subfield( '852', 'z' ); my $publisher_name = $record->subfield( '260', 'b' ); my $publication_type = ''; # FIXME ? my $date_monograph_published_print = ''; # FIXME ? my $date_monograph_published_online = ''; # FIXME ? my $monograph_volume = ''; # FIXME ? my $monograph_edition = ''; # FIXME ? my $first_editor = ''; # FIXME ? my $parent_publication_title_id = ''; # FIXME ? my $preceeding_publication_title_id = ''; # FIXME ? my $access_type = ''; # FIXME ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:45:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:45:09 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 [Bug 32782] UNIMARC support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:45:31 +0000 Subject: [Koha-bugs] [Bug 32782] UNIMARC support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #1 from Jonathan Druart --- Paul, can you have a look at this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:49:35 +0000 Subject: [Koha-bugs] [Bug 32783] New: Add more mapping when creating eholding from biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Bug ID: 32783 Summary: Add more mapping when creating eholding from biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 There is a lot of FIXMEs here, we could do better and provide more mappings. my $publication_title = $biblio->title; my $print_identifier = $record->subfield( '020', 'a' ) || $record->subfield( '020', 'z' ) || $record->subfield( '022', 'a' ) || $record->subfield( '022', 'y' ); my $online_identifier = $print_identifier; my ( $date_first_issue_online, $date_last_issue_online ) = $fix_coverage->( $record->subfield( '866', 'a' ) ); my ( $num_first_vol_online, $num_last_vol_online ) = $fix_coverage->( $record->subfield( '863', 'a' ) ); my ( $num_first_issue_online, $num_last_issue_online ) = ( '', '' ); # FIXME ? my $title_url = $record->subfield( '856', 'u' ); my $first_author = $biblio->author; my $embargo_info = ''; # FIXME ? my $coverage_depth = $title_url ? 'fulltext' : 'print'; my $notes = $record->subfield( '852', 'z' ); my $publisher_name = $record->subfield( '260', 'b' ); my $publication_type = ''; # FIXME ? my $date_monograph_published_print = ''; # FIXME ? my $date_monograph_published_online = ''; # FIXME ? my $monograph_volume = ''; # FIXME ? my $monograph_edition = ''; # FIXME ? my $first_editor = ''; # FIXME ? my $parent_publication_title_id = ''; # FIXME ? my $preceeding_publication_title_id = ''; # FIXME ? my $access_type = ''; # FIXME ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:49:35 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 [Bug 32783] Add more mapping when creating eholding from biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:49:35 +0000 Subject: [Koha-bugs] [Bug 32782] UNIMARC support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32783 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:49:46 +0000 Subject: [Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:50:13 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Jonathan Druart --- Jonathan, can I get your help here please? Or Katrin maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:52:31 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #34 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:52:35 +0000 Subject: [Koha-bugs] [Bug 32782] UNIMARC support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 --- Comment #2 from Jonathan Druart --- Created attachment 145961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145961&action=edit Bug 32782: ERM UNIMARC support - Create the biblio record when a resource is created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:52:59 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Agreed, there's something off going on here.. looks like a mistake adding the XSML change in this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:55:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:55:02 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #50 from Lucas Gass --- If this needs to be backported for 22.05.x then I will need some help rebasing Bug 32394. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:55:09 +0000 Subject: [Koha-bugs] [Bug 31958] Save button when editing a vendor should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #1 from Matt Blenkinsop --- Created attachment 145962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145962&action=edit Button image -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:55:41 +0000 Subject: [Koha-bugs] [Bug 31958] Save button when editing a vendor should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 --- Comment #2 from Matt Blenkinsop --- Hi Katrin, just looking at this one and it appears the button is already yellow - am I looking in the wrong place? See image attached -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:55:54 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:58:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 15:58:45 +0000 Subject: [Koha-bugs] [Bug 32692] Terminology: MARC framework tag subfield editor uses intranet instead of staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32692 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:00:14 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144406|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 145963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145963&action=edit Bug 13976: Sort popularity numerically in Zebra To test: 1 - Create a new template at Tools->Marc modification template 2 - Add action: Copy 999$c to 942$0 3 - Create a report: SELECT biblionuber FROM biblios 4 - Run report, show all, do a batch modification to all records using template above 5 - Search for 'a' (make sure you are using Zebra) 6 - Sort by popularity 7 - Note records are sorted wrong 8 - Apply patch 9 - Restart all 10 - Reload search results 11 - Success! Sorted correctly Signed-off-by: Anke -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:04:21 +0000 Subject: [Koha-bugs] [Bug 32376] selenium/authentication_2fa.t produces artefact In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32376 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:04:56 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #16 from Nick Clemens --- (In reply to Martin Renvoize from comment #14) > Agreed, there's something off going on here.. looks like a mistake adding > the XSML change in this patch? Removed those -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:07:14 +0000 Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in Advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:10:16 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #17 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:13:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:13:04 +0000 Subject: [Koha-bugs] [Bug 32229] Typo: Items missing from bundle at checkin for %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32229 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass --- bundleMissingLabel does not exist in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:13:08 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #23 from Jonathan Druart --- Created attachment 145964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145964&action=edit Bug 32394: [22.05.x] Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:13:14 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #24 from Jonathan Druart --- Created attachment 145965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145965&action=edit Bug 32394: [22.05.x] Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:13:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:13:19 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #25 from Jonathan Druart --- Created attachment 145966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145966&action=edit Bug 32394: [22.05.x] Add tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:13:33 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #26 from Jonathan Druart --- I have not tested the rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:14:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:14:54 +0000 Subject: [Koha-bugs] [Bug 32718] Capitalization: Display Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32718 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- No EnableItemGroups in 22.05.x, no backport -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:25:32 +0000 Subject: [Koha-bugs] [Bug 32204] in-page anchor to edititem on additem.pl not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32204 --- Comment #12 from Lucas Gass --- This fix does not work with 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:35:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:35:34 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #27 from Lucas Gass --- (In reply to Jonathan Druart from comment #26) > I have not tested the rebase! Thanks Jonathan, it seems to work but I'd like one more sign-off besides my own before I push to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:55:09 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:55:14 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145927|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 145967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145967&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:58:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:58:23 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #41 from Martin Renvoize --- I tried to do an old-fashioned dev install to test this.. but alas, I failed miserably. I had to sort out all sorts of dependencies to get the 'perl Makefile.PL' step happy.. then upon running 'make' it complained about yarn not being found.. so I installed yarn but then it complained with yarn: error: no such option: --frozen-lockfile So I tried replacing --frozen-lockfile with --immutable and that complained too. In short.. I can run `build-resources.PL` perfectly from inside ktd.. though of course in that case we don't need the `yarn install` step at all as we have our our node_modules all there and waiting for us.. but trying to run it outside of ktd we end up stuck in dependancies hell. I'm not sure where that leaves us.. we're not really actually expecting people to be running dev installs now.. and we don't really document it anywhere anymore as far as I can see on googling.. So maybe this is OK as I believe this should all work for packaging as it stands. We need Mason to weight in really. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:58:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:58:39 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:58:44 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145948|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim --- Created attachment 145968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145968&action=edit Bug 32779: Add tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:58:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 16:58:48 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145949|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim --- Created attachment 145969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145969&action=edit Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:27:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:27:09 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:29:04 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:29:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:29:19 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145968|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 145970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145970&action=edit Bug 32779: Add tests Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:29:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:29:37 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145969|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 145971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145971&action=edit Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed Signed-off-by: Pedro Amorim Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:30:34 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #2 from Pedro Amorim --- This is not applying for me: Applying: Bug 32781: Prevent import from list to fail if package does not exist error: sha1 information is lacking or useless (Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:34:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:34:37 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 --- Comment #7 from Tomás Cohen Arazi --- Fixes the described issue. No QA script complaints. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:38:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:38:44 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145960|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 145972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145972&action=edit Bug 32612: Add worker-error to log4perl conf To test: 1 - Apply patch 2 - vim /etc/koha/sites/kohadev/log4perl.conf, Add lines below: log4perl.logger.worker = WARN, WORKER log4perl.appender.WORKER=Log::Log4perl::Appender::Screen log4perl.appender.WORKER.stderr=1 log4perl.appender.WORKER.mode=append log4perl.appender.WORKER.layout=PatternLayout log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n log4perl.appender.WORKER.utf8=1 3 - Restart all 4 - Edit misc/background_jobs_worker.pl - my $job = Koha::BackgroundJobs->find($args->{job_id}); + my $job;# = Koha::BackgroundJobs->find($args->{job_id}); 5 - In another terminal: tail -f /var/log/koha/kohadev/koha-worker-error.log 6 - Force enqueue a job (that won't be found because of #4 perl -e 'use Koha::BackgroundJob::BatchUpdateItem; my $bg = Koha::BackgroundJob::BatchUpdateItem->new(); $bg->enqueue({ record_ids=>['888888']});' 7 - Note error in log like: [2023/01/11 19:26:10] [WARN] No job found for id=2983 main:: /kohadevbox/koha/misc/background_jobs_worker.pl (111) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:38:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:38:58 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #12 from Kyle M Hall --- Created attachment 145973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145973&action=edit Bug 32612: (QA Follow-up) Remove superfluous line Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:39:58 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |pedro.amorim at ptfs-europe.co |.com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:43:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:43:10 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #13 from Kyle M Hall --- Created attachment 145974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145974&action=edit Bug 32612: (QA Follow-up) Append to worker-error.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:47:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:47:56 +0000 Subject: [Koha-bugs] [Bug 32555] Error when viewing serial in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #13 from David Nind --- (In reply to Isabel Pineda from comment #11) > Thank you very much. Just one question: Is there a workaround how I can > enable the serials view in the OPAC in the current version? You could manually make the change to the Koha code on your server - see the diff for the bug listed under the attachments section to see what was changed to fix it. It is a change to a single line of code. Once the next maintenance release of Koha 22.11 comes out (this would normally be near the end of February), you could reverse the change and then do the normal maintenance release upgrade. I realise that this isn't standard practice, but needs must and all that.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:53:41 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 17:53:46 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145967|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop --- Created attachment 145975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145975&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:05:01 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:05:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:05:06 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145473|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop --- Created attachment 145976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145976&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:10:58 +0000 Subject: [Koha-bugs] [Bug 32555] Error when viewing serial in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 --- Comment #14 from Isabel Pineda --- (In reply to David Nind from comment #13) > (In reply to Isabel Pineda from comment #11) > > Thank you very much. Just one question: Is there a workaround how I can > > enable the serials view in the OPAC in the current version? > > You could manually make the change to the Koha code on your server - see the > diff for the bug listed under the attachments section to see what was > changed to fix it. It is a change to a single line of code. > > Once the next maintenance release of Koha 22.11 comes out (this would > normally be near the end of February), you could reverse the change and then > do the normal maintenance release upgrade. > > I realise that this isn't standard practice, but needs must and all that.... Hi David. Thank you so much. I thought that the fix would come with the release of version 22.11 in November. I have just changed the line in the file, and now everything is working again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:16:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:16:14 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #28 from Lucas Gass --- (In reply to Jonathan Druart from comment #26) > I have not tested the rebase! Tomas and I tested the rebase together and everything is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:21:02 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #29 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:27:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:27:21 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:32:38 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #51 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:37:44 +0000 Subject: [Koha-bugs] [Bug 32416] arp - Accelerated reader point searches fail due to conflicting attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32416 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:46:11 +0000 Subject: [Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:50:54 +0000 Subject: [Koha-bugs] [Bug 32631] Error when previewing record during batch record modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32631 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass --- Not needed in 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:52:09 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 --- Comment #9 from Michael Hafen --- I will prepare another patch. I'll fix the name of the new method and move it to Koha/Patron.pm, I will fix the "Patron Lists" capitalization on the tab, I'll rephrase the list table headers as you suggested, I'll fix the copyright. The size of the lists could be a problem. I'll make sure that both tables on the lists tab are paged and searchable, that should help with the presentation at least. I like the convenience of having the other lists at hand to quickly add a patron to them. (In reply to Katrin Fischer from comment #8) > Hi Michael, > > some notes: > > 1) Naming of the new method > > Your patch adds a GetListsWithPatron to Koha/List/Patron.pm. > > This module is not really written to our coding standards, but the method > name should be snake case instead of camel case. > > PERL9: Subroutine naming conventions > Koha namespace [current] > subroutines in the Koha namespace should be snake case. > > 2) Location of the new method > > I also wonder if Koha/List/Patron is the right spot (some other devs might > want to weigh in), but I would have expected this in Koha/Patron. There we > also have other methods like get_club_enrollments or get_routing_lists that > serve similar purposes. > > 3) Missing unit tests > > PERL17: Unit tests are required (updated Apr 26, 2017) > Unit tests must be provided for *ALL* new routines in modules, as well as > for changes to existing routines > > 4) Capitalization > > + href="#pat_lists-tab" aria-controls="pat_lists-tab" role="tab" > data-toggle="tab"> > + Patron Lists ([% patron_lists_count > | html %]) > + > > This should be "Patron lists" (we have a rule to only capitalize the first > word) > > 5) Templates > > This is a little hard to understand/translate, wonder if we could rephrase a > little (but that might be on me, I needed a few takes to get it) > > +

Patron lists currently in

> > Patron lists without/with this patron > Lists this patron is/is not on > > ? > > 6) Copyright > > Is this correct for the new file? > > +++ b/patron_lists/patron-lists-tab.pl > @@ -0,0 +1,91 @@ > +#!/usr/bin/perl > + > +# Copyright 2013 ByWater Solutions > +# > > 7) I wonder about the use case of showing the lists the patron is not in and > if that could not get a little much in a big system. Not a blocker, just > wondering and wondering if a different presentation, like a 'patron list > search' could be interesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:58:53 +0000 Subject: [Koha-bugs] [Bug 31932] The basket summary page template needs a cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 18:58:54 +0000 Subject: [Koha-bugs] [Bug 32733] Add more page-sections to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32733 Bug 32733 depends on bug 31932, which changed state. Bug 31932 Summary: The basket summary page template needs a cleanup https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31932 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:00:33 +0000 Subject: [Koha-bugs] [Bug 32733] Add more page-sections to basket summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32733 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #11 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:07:27 +0000 Subject: [Koha-bugs] [Bug 30254] New overdue fine applied to incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30254 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #23 from Lucas Gass --- Tests won't apply to 22.05.x, if needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:10:57 +0000 Subject: [Koha-bugs] [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #8 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:15:08 +0000 Subject: [Koha-bugs] [Bug 32694] Keep current option for budgets in receiving broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32694 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:19:08 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #89 from Lucas Gass --- This patchset doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:19:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:19:10 +0000 Subject: [Koha-bugs] [Bug 32689] Host item entry (773) missing a space between label and content when $i is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32689 Bug 32689 depends on bug 16522, which changed state. Bug 16522 Summary: Add 773 (Host item entry) to the cart and list displays and e-mails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:28:40 +0000 Subject: [Koha-bugs] [Bug 32784] New: Reoccurring News Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32784 Bug ID: 32784 Summary: Reoccurring News Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be helpful if we could make certain news articles reoccurring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:32:15 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145768|0 |1 is obsolete| | --- Comment #10 from Michael Hafen --- Created attachment 145977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145977&action=edit Bug 32730: Add Patron Lists tab to patron details and circulation pages Fresh patch with updates as suggested by QA (this is my first time writing a unit test). Test plan: 1. Apply patch 2. create a patron list if there aren't any 3. search for a patron 4. observe the "Patron lists" tab showing the list that the patron is not in 5. try adding the patron to the list and removing them from the list to be sure the feature has full operation 6. click "Check Out" on the side bar menu to navigate to the circulation page for this patron 7. observe the "Patron lists" tab, and verify it operates as it did on the patron details page Bug 32730: (follow-up) Minor corrections by Owen Leonard This patch corrects an instance of an incorrect capital letter ("Patron Lists" -> "Patron lists") and makes minor tweaks to indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:32:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:32:26 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:35:41 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:57:00 +0000 Subject: [Koha-bugs] [Bug 32785] New: Typo: Maximum number of simultaneus pickups per interval (curbside pickups) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Bug ID: 32785 Summary: Typo: Maximum number of simultaneus pickups per interval (curbside pickups) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org In the curbside pickup configuration page, there is a small typo Maximum number of simultaneus pickups per interval should be "simultaneous" To get there: 1. Enable the CurbsidePickup system preferences 2. Go to Administration > Curbside pickup --> Next to Maximum patrons per interval, the tip is "Maximum number of simultaneus pickups per interval" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:57:31 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Depends on| |30650 Assignee|oleonard at myacpl.org |caroline.cyr-la-rose at inlibr | |o.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 19:57:31 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:01:25 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:01:29 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 145978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145978&action=edit Bug 32785 - Typo: Maximum number of simultaneus pickups per interval (curbside pickups) This patch corrects a small typo in the curbside pickup administration page. To test: 1. Apply patch 2. Enable the CurbsidePickup system preferences 3. Go to Administration > Curbside pickup --> Next to Maximum patrons per interval, the tip should be "Maximum number of simultaneous pickups per interval" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:06:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:06:34 +0000 Subject: [Koha-bugs] [Bug 32786] New: Curbside pickup admin page has cities search bar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Bug ID: 32786 Summary: Curbside pickup admin page has cities search bar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I noticed that when you're on the curbside pickup administration page, the search bar at the top is set to search cities and towns. To get there: 1. Enable the CurbsidePickup system preference 2. Go to Administration > Curbside pickup --> Notice the search bar at the top of the page, it is set by default on Search cities Most other administration pages (those that don't have specific searches) are set by default on system preferences search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:06:58 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:06:58 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 [Bug 32786] Curbside pickup admin page has cities search bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:10:33 +0000 Subject: [Koha-bugs] [Bug 32787] New: Patron restrictions admin page has patron categories search bar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Bug ID: 32787 Summary: Patron restrictions admin page has patron categories search bar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When you're on the Patron restrictions administration page, the search bar at the top of the page is set to search for patron categories. Not sure if this was intentional or not, but it doesn't make sense to me. Most other administration pages (those that don't have specific searches) are set by default on system preferences search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:10:46 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Severity|enhancement |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:10:46 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 [Bug 32787] Patron restrictions admin page has patron categories search bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:28:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:28:09 +0000 Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP checkin/checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 --- Comment #14 from Jonathan Druart --- + $message .= (" - You owe " . Koha::Number::Price->new( $balance )->format({ with_symbol => 1}) . "."); .= a list? those parenthesis are not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:31:18 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30943 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:31:18 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32779 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:31:30 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:31:30 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:32:44 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32779 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:32:44 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32781 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:32:54 +0000 Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 [Bug 32779] Import from list is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:32:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:32:54 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943 [Bug 30943] Make background job classes use helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:34:00 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 --- Comment #3 from Jonathan Druart --- (In reply to Pedro Amorim from comment #2) > This is not applying for me: > Applying: Bug 32781: Prevent import from list to fail if package does not > exist > error: sha1 information is lacking or useless > (Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm). > error: could not build fake ancestor I was missing dependency. It needs bug 32779 then bug 30943, and finally this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:42:27 +0000 Subject: [Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WONTFIX |--- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- I spend 1 hour searching for this. I reopen to add a warning message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:42:54 +0000 Subject: [Koha-bugs] [Bug 32788] New: Curbside pickups - Order curbside pickup slots chronologically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Bug ID: 32788 Summary: Curbside pickups - Order curbside pickup slots chronologically Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I noticed that if you don't enter the slots in a normal morning-to-evening order, they stay ordered however you entered them. I think they should appear in chronological order based on the hours. I entered them in random order because I started on Monday 10-12, 13-16, 18-20. When I changed the day to Tuesday, 18-20 was still entered in the boxes so I just clicked Add because I'm lazy and figured I'd save a few keys/click. Then added 10-12 and 13-16. So my Monday was ordered correctly (10-12, 13-16, 18-20) and my Tuesday was ordered 18-20, 10-12, 13-16. I continued with my lazy ways throughout the week, and it's very much out of order lol! I think if you enter 18-20 and then enter 10-12, the latter should appear before the former (10-12, 18-20). To reproduce: 1. Enable the CurbsidePickup system preference 2. Go to Administration > Curbside pickup 3. In the Curbside pickup hours, enter for example Sunday 13:00 16:00 4. Click Add 5. Add a slot before the previous one, for example Sunday 10:00 12:00 6. Click Add --> The slots are displayed 13-16, 10-12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:46:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 20:46:34 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 21:12:14 +0000 Subject: [Koha-bugs] [Bug 22842] Add an option to prevent local logins on the staff or opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22842 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |andrewfh at dubcolib.org Resolution|--- |DUPLICATE --- Comment #1 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 18506 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 21:12:14 +0000 Subject: [Koha-bugs] [Bug 18506] SSO - Shibboleth Only Mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 --- Comment #52 from Andrew Fuerste-Henry --- *** Bug 22842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 21:21:23 +0000 Subject: [Koha-bugs] [Bug 22842] Add an option to prevent local logins on the staff or opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- I'd say this is more a duplicate of bug 28093 than it is of the original shibOnly introduction. Now I understand the use cases around all this a bit better I wish I'd named that preference differently.. it's more of a shibboleth/saml auto forward.. yes the effect is the same but the approach could differ. With the option to hide local login one could allow for shib with a fallback to LDAP and prevent local.. for example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 21:21:39 +0000 Subject: [Koha-bugs] [Bug 22842] Add an option to prevent local logins on the staff or opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22842 --- Comment #3 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 28093 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 21:21:39 +0000 Subject: [Koha-bugs] [Bug 28093] Additional configuration option(s) for Shibboleth-only mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28093 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Martin Renvoize --- *** Bug 22842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:14:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:14:45 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #42 from David Cook --- (In reply to Martin Renvoize from comment #40) > Not a blocker, but do we need both compiled css/js and source scss/vue files > in blib? I can't see a need for them and can't see a problem having them > there.. but wondered if we wanted to clean that up whilst we're in here? Yeah, that thought crossed my mind as well. I don't know enough about scss/vue to know whether we should be putting them in a different source/build folder all together, or if we should update the Makefile.PL to just exclude them from being included. I think certainly a different ticket in any case though. But one worth thinking about just from a maintenance perspective I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:40:22 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:40:26 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145923|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 145979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145979&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:50:13 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #43 from David Cook --- (In reply to Martin Renvoize from comment #41) > I had to sort out all sorts of dependencies to get the 'perl Makefile.PL' > step happy.. then upon running 'make' it complained about yarn not being > found.. so I installed yarn but then it complained with > yarn: error: no such option: --frozen-lockfile > > So I tried replacing --frozen-lockfile with --immutable and that complained > too. Which kind of dependencies did you need to sort out? Was it stuff like "build-essential gcc gettext" or something else? Which OS and OS version were you using? Was this in or outside of Docker? Which version of yarn were you using? Was it Yarn v1, v2, or v3? What was the --immutable complaint? It looks like Debian/Ubuntu provide Yarn 1.x, and npm looks like it uses 1.x (although it provides 2.x too). > In short.. I can run `build-resources.PL` perfectly from inside ktd.. though > of course in that case we don't need the `yarn install` step at all as we > have our our node_modules all there and waiting for us.. but trying to run > it outside of ktd we end up stuck in dependancies hell. I needed the `yarn install` in my ktd as I didn't have node_modules already there. After a bit of reading, it sounds like running some type of `yarn install` invocation is a common step (although I suppose we could debate about when to run it). I used to run Koha in OpenSuse and getting the dependencies right was always a pain, which is why we switched over to Debian/Ubuntu (and ktd for dev/test). > I'm not sure where that leaves us.. we're not really actually expecting > people to be running dev installs now.. and we don't really document it > anywhere anymore as far as I can see on googling.. So maybe this is OK as I > believe this should all work for packaging as it stands. > > We need Mason to weight in really. Yeah, it would be good to hear from Mason. Perhaps I should have a go with my local package building as well and see if I bump into any gotchas... Both single and dev installs are a bit fraught because of dependencies (which is a big reason I stopped doing them heh). Overall, I don't think the community directly supports anything except Debian package installs on Debian/Ubuntu, although we could always document better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:52:52 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #44 from David Cook --- At the end of the day, I suppose the most important thing is that the Debian packages are built correctly for consumers of Koha, and then the second most important thing is that developers/testers are able to generate Koha installs without too much friction. __Packages__ If Mason can look into how this will work with the existing community package build workflow, that would be useful. I need to do some other work right now... but I'll make a note to look at building a package using these patches. __Dev/Test__ Maybe we should have a crack at testing this process. I was interested by Jonathan's comment about using "watch" for dev/test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 22:54:27 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 slmontesdeoca at orem.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slmontesdeoca at orem.org --- Comment #1 from slmontesdeoca at orem.org --- Being able to sort series by volume number would be extremely helpful. However, doing so shouldn't be confined to the 440 $v, but also 8XX $v. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 00:00:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 23:00:03 +0000 Subject: [Koha-bugs] [Bug 32789] New: Add diacritics box for easier addition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32789 Bug ID: 32789 Summary: Add diacritics box for easier addition Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: slmontesdeoca at orem.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 145980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145980&action=edit Diacritics Popup Box in OCLC Connexion It would be helpful to have a popup box (or something similar) for inserting diacritics and special characters, like OCLC Connexion has (pictured in attachment). This would make it easier and faster to add the most common diacritics than looking up the keyboard for any given language. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 00:01:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 23:01:05 +0000 Subject: [Koha-bugs] [Bug 31665] 952$d ( Date acquired ) no longer prefills with todays date when focused In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145979|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes --- Created attachment 145981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145981&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on Signed-off-by: Lucas Gass Signed-off-by: Michael Adamyk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 00:06:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2023 23:06:20 +0000 Subject: [Koha-bugs] [Bug 32790] New: Add "Genre" as a search option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32790 Bug ID: 32790 Summary: Add "Genre" as a search option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: slmontesdeoca at orem.org Currently, the options to search the catalog include "Subject" and "Subject as phrase", but they do not include "Genre" or "Genre as phrase". Is it possible to separate genre out as a separate search element? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:23:34 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:39:38 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #3 from Lucas Gass --- Created attachment 145982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145982&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:40:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:40:40 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:51:58 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145919|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:52:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:52:08 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145918|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:52:37 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #3 from Alex Buckley --- Created attachment 145983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145983&action=edit Bug 32775: Do not order language directories based on when they were created Sponsored-by: Kinder library, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:54:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 01:54:38 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #4 from Alex Buckley --- Created attachment 145984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145984&action=edit Bug 32775: Correctly display language order in sysprefs when you have multiple languages in a group Test plan: 1. Apply first patch 2. Install en-NZ and another language - e.g. mi-NZ - so you have three languages showing in your sysprefs en-NZ (selected), en (unselected) and mi-NZ (selected) 3. Tick en-NZ and mi-NZ in language and OPACLanguages sysprefs. Order en-NZ above mi-NZ and save 4. Refresh the syspref page and confirm mi-NZ is displaying above en-NZ, even though you ordered en-NZ first 5. Refresh the syspref page multiple times and observe the order of the languages changes 6. Apply this (second) patch 7. Restart plack 8. Refresh syspref page several times confirming that en-NZ is always ordered first - as expected. Sponsored-by: Kinder library, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:10:04 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from David Cook --- Thought about doing a follow-up but thought it might make more sense to fail QA. These patches are missing the update to /etc/koha/log4perl-site.conf.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:16:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:16:14 +0000 Subject: [Koha-bugs] [Bug 32791] New: Log4perl configuration files need a tool for updating on package upgrade Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 Bug ID: 32791 Summary: Log4perl configuration files need a tool for updating on package upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Typically, we update existing log4perl.conf files using debian/koha-common.postinst but it's making that file grow way too much and it's difficult to test. Instead, let's provide a CLI tool that we can more easily test and update without touching debian/koha-common.postinst directly. It should hopefully simplify maintenance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:16:57 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #15 from David Cook --- Tomas was mentioning in IRC how he doesn't like how we update log4perl config in koha-common.postinst and that's given me an idea for bug 32791 I'm not going to add it as a dependency as I think it's really out of scope for this change, but just flagging it here in the hopes that he sees it and it makes him happier :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:17:07 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32791 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:17:07 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32612 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:17:19 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 02:21:57 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #16 from David Cook --- Also, the stanza in debian/koha-common.postinst shouldn't be at the bottom. It should be up with the others (until bug 32791 can take over...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:16:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:16:11 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #1 from David Cook --- Created attachment 145985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145985&action=edit Bug 32791: Add Debian tool for adding missing config to log4perl files This change adds a tool for adding missing config to log4perl files for individual Koha instances created using Debian packages Test plan: 0. Apply patch 1. Comment out a component in /etc/koha/sites/kohadev/log4perl.conf or delete some of the configuration 2. Run the following: ./debian/scripts/koha-log4perl kohadev 3. Note warning saying config has been updated 4. Review config to see that it was updated correctly 5. Run the following: ./debian/scripts/koha-log4perl kohadev 6. Note that no config changes are made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:20:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:20:06 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #17 from David Cook --- Looks like debian/koha-core.postinst needs to be updated too... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:20:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:20:25 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #2 from David Cook --- Note that this will also make it so that debian/koha-core.postinst doesn't need manual updates as well... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:22:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:22:02 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:22:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:22:07 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #3 from David Cook --- Created attachment 145986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145986&action=edit Bug 32791: Update koha-common and koha-core packaging to include koha-log4perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:25:32 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #4 from David Cook --- This is a first draft so I'm happy to tweak the koha-log4perl tool. On one hand, it would be nice to have this code in a Koha Perl module so that it could be suitably unit tested. On the other hand, it's Debian-specific, so we'll need to be abstract the snippets more, and we'll need to make the koha-log4perl tool aware of paths in PERL5LIB. Probably parsing it, splitting it, and then using "use lib $path". I'm not opposed to that. But it's a consideration. It probably would be better to put it into a Perl module and unit test it, so that we can fully automate the testing of this one. -- Anyway, I mostly wanted to do these patches as a proof of concept and then get feedback. I think it's a big step forward from doing this all in debian/koha-common.postinst and debian/koha-core.postinst themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:25:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:25:49 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 03:26:57 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 --- Comment #5 from David Cook --- Note also that there is technically an XML configuration option available for Log4perl with /usr/share/perl5/Log/Log4perl/Config/DOMConfigurator.pm but it requires an additional dependency, and it's rather ugly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:15:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:15:25 +0000 Subject: [Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:15:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:15:30 +0000 Subject: [Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 --- Comment #1 from Aleisha Amohia --- Created attachment 145987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145987&action=edit Bug 32776: Add ConvertSelectedReservesToRecalls system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:15:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:15:35 +0000 Subject: [Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 --- Comment #2 from Aleisha Amohia --- Created attachment 145988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145988&action=edit Bug 32776: Select reserves to convert using new syspref This patchset enhances the convert_reserves_to_recalls.pl cronjob by allowing libraries to be more specific about which reserves should be converted to recalls. The new ConvertSelectedReservesToRecalls adds the flexibility to choose: - the oldest placed reserve to be converted to a recall - each reserve will be converted, one by one, until all recallable items are recalled When reserves are converted to recalls, they will be allocated a specific item and become an item-level recall. This is so recallable items can be allocated one by one. To test: 1. Apply Bug 31415 and configure recalls 2. Apply these patches and update database 3. Create a biblio with 3 items 4. Check out all 3 items to 3 different patrons 5. Place 4 biblio-level reserves for 4 different patrons 6. Set the ConvertSelectedReservesToRecalls system preference to 'oldest' 7. In your shell, run the script misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 8. Confirm there is now 1 recall and 3 biblio-level reserves on the record 9. Confirm the recall has been allocated to one item (there should be a barcode next to the title in the recalls table) 10. In your shell, run the script misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 11. Confirm there are now 2 recalls and 2 biblio-level reserves on the record 12. Confirm the second recall was allocated to the second item. NOT the same item as the first recall. 13. In your shell, run the script twice misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 14. Confirm there is still one reserve remaining that can't be converted because all recallable items are already recalled. 15. Set the ConvertSelectedReservesToRecalls system preference to 'recallable' 16. Select all of the recalls on the record and delete them 17. Place 4 biblio-level reserves for 4 different patrons 18. In your shell, run the script misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 19. Confirm all reserves have been converted to recalls and allocated an item. The fourth reserve will have been allocated as a second recall to the first item. 20. Select all of the recalls on the record and delete them. 21. Place 2 biblio-level recalls and 2 item-level recalls for 4 different patrons, in any order 22. In your shell, run the script misc/cronjobs/recalls/convert_reserves_to_recalls.pl -v --min 1 23. Confirm all reserves have been converted to recalls and allocated an item. The item-level reserves should have been allocated to their intended item. The biblio-level reserves should have been allocated to the other items. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:19:51 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 --- Comment #4 from Alex Buckley --- Created attachment 145989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145989&action=edit Bug 32560: (follow-up) Altered wording of output Sponsored-by: Dalton McCaughey Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:21:00 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 --- Comment #5 from Alex Buckley --- (In reply to David Nind from comment #3) > Just a minor suggestion - rather than the output being "1 borrowers to be > changed", maybe change it to "1 borrower(s) changed". > > The main reason is that when you run the script, the borrowers are changed. Hi David, Great suggestion, thank you, and thanks for testing too! I have attached a follow-up patch with that new wording. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:23:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:23:28 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Alex Buckley --- Just setting this back to 'Needs signoff' so you can hopefully test and signoff the additional patch. Thanks so much -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:33:38 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:33:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 04:33:42 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145393|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 145990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145990&action=edit Bug 32673: Remove misc/load_testing/ scripts see comment 0 for more info Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 06:10:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 05:10:30 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #45 from David Cook --- So I'm looking at building a package with these patches, and I notice that the "yarn" in ktd is provided by this source list: deb https://dl.yarnpkg.com/debian/ stable main -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 06:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 05:13:28 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #46 from David Cook --- (In reply to David Cook from comment #45) > So I'm looking at building a package with these patches, and I notice that > the "yarn" in ktd is provided by this source list: > > deb https://dl.yarnpkg.com/debian/ stable main After I set up the repo: sudo apt-get install yarn Reading package lists... Done Building dependency tree... Done Reading state information... Done The following additional packages will be installed: libc-ares2 libnode72 libuv1 nodejs nodejs-doc Suggested packages: npm The following NEW packages will be installed: libc-ares2 libnode72 libuv1 nodejs nodejs-doc yarn 0 upgraded, 6 newly installed, 0 to remove and 0 not upgraded. Need to get 12.2 MB of archives. After this operation, 54.1 MB of additional disk space will be used. Do you want to continue? [Y/n] y -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 06:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 05:24:04 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #47 from David Cook --- Package builder output on "make": make[1]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' "/usr/bin/perl" build-resources.PL yarn install v1.22.19 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning " > bootstrap at 4.6.2" has unmet peer dependency "jquery at 1.9.1 - 3". warning " > bootstrap at 4.6.2" has unmet peer dependency "popper.js@^1.16.1". [4/4] Building fresh packages... Done in 242.50s. yarn run v1.22.19 $ yarn css:build:prod && yarn js:build:prod $ gulp build && gulp css --view opac [05:19:53] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:19:54] Starting 'build'... [05:19:54] Finished 'build' after 10 ms [05:19:58] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:19:58] Starting 'css'... [05:19:58] Finished 'css' after 12 ms $ webpack --mode production asset main.js 1.44 MiB [emitted] [minimized] [big] (name: main) 1 related asset orphan modules 838 KiB [orphan] 277 modules runtime modules 1.17 KiB 6 modules cacheable modules 2.69 MiB modules by path ./node_modules/ 2.18 MiB 30 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/ 525 KiB modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/*.vue 35.6 KiB 20 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/*.js 3.52 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js 1.12 KiB [built] [code generated] + 2 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/*.js 484 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/routes.js + 232 modules 474 KiB [built] [code generated] + 2 modules ./koha-tmpl/intranet-tmpl/prog/js/vue/main-erm.ts 1.88 KiB [built] [code generated] WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: main.js (1.44 MiB) WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance. Entrypoints: main (1.44 MiB) main.js WARNING in webpack performance recommendations: You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application. For more info visit https://webpack.js.org/guides/code-splitting/ webpack 5.74.0 compiled with 3 warnings in 27212 ms Done in 72.50s. -- Package builder output on "make install": make[1]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' dh_auto_install dh_auto_install: warning: Compatibility levels before 10 are deprecated (level 9 in use) make -j1 install DESTDIR=/home/koha/build/koha-22.12\+test.bb175389/debian/tmp AM_UPDATE_INFO_DIR=no PREFIX=/usr make[2]: Entering directory '/home/koha/build/koha-22.12+test.bb175389' "/usr/bin/perl" build-resources.PL yarn install v1.22.19 [1/4] Resolving packages... success Already up-to-date. Done in 0.83s. yarn run v1.22.19 $ yarn css:build:prod && yarn js:build:prod $ gulp build && gulp css --view opac [05:22:18] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:22:18] Starting 'build'... [05:22:18] Finished 'build' after 10 ms [05:22:21] Using gulpfile ~/build/koha-22.12+test.bb175389/gulpfile.js [05:22:21] Starting 'css'... [05:22:21] Finished 'css' after 11 ms $ webpack --mode production asset main.js 1.44 MiB [compared for emit] [minimized] [big] (name: main) 1 related asset orphan modules 838 KiB [orphan] 277 modules runtime modules 1.17 KiB 6 modules cacheable modules 2.69 MiB modules by path ./node_modules/ 2.18 MiB 30 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/ 525 KiB modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/*.vue 35.6 KiB 20 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/*.js 3.52 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js 1.12 KiB [built] [code generated] + 2 modules modules by path ./koha-tmpl/intranet-tmpl/prog/js/vue/*.js 484 KiB ./koha-tmpl/intranet-tmpl/prog/js/vue/routes.js + 232 modules 474 KiB [built] [code generated] + 2 modules ./koha-tmpl/intranet-tmpl/prog/js/vue/main-erm.ts 1.88 KiB [built] [code generated] WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: main.js (1.44 MiB) WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance. Entrypoints: main (1.44 MiB) main.js WARNING in webpack performance recommendations: You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application. For more info visit https://webpack.js.org/guides/code-splitting/ webpack 5.74.0 compiled with 3 warnings in 20990 ms Done in 33.78s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 06:33:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 05:33:56 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #48 from David Cook --- Everything was looking good in my build until I hit the issue where debian/control is still incorrect in the master branch... xsltproc --output /home/koha/build/koha-22.12+test.bb175389/debian/tmp/debian/tmp_docbook/ \ /usr/share/xml/docbook/stylesheet/docbook-xsl-ns/manpages/docbook.xsl \ debian/docs/*.xml warning: failed to load external entity "/usr/share/xml/docbook/stylesheet/docbook-xsl-ns/manpages/docbook.xsl" cannot parse /usr/share/xml/docbook/stylesheet/docbook-xsl-ns/manpages/docbook.xsl make[1]: *** [debian/rules:39: override_dh_auto_install] Error 4 make[1]: Leaving directory '/home/koha/build/koha-22.12+test.bb175389' make: *** [debian/rules:9: binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 debuild: fatal error at line 1182: dpkg-buildpackage -us -uc -ui failed -- If the debian/control were correct, then I think the build would've succeeded. For example: Installing /home/koha/build/koha-22.12+test.bb175389/debian/tmp/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/main.js.LICENSE.txt Installing /home/koha/build/koha-22.12+test.bb175389/debian/tmp/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/main.js Installing /home/koha/build/koha-22.12+test.bb175389/debian/tmp/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/css/opac.css -- So... as long as the yarn is version 1.22.19... it's all looking good to me. I was building on a Debian Bullseye Docker image using https://gitlab.com/minusdavid/koha-deb-builder-docker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:34:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 07:34:05 +0000 Subject: [Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 07:34:11 +0000 Subject: [Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632 --- Comment #9 from Fridolin Somers --- Created attachment 145991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145991&action=edit Bug 20632: Alert when SCO or SCI user in OPAC login page Special patrons for self check-out/check-in are not allowed to login into OPAC. This patch adds an alter message in OPAC login page when authentification is tried with SCO/SCI user. Test plan : 1) SCO 1.1) Use koha-testing-docker that is configured with patron 'self_checkout' 1.2) Go to OPAC main page, not logged-in 1.3) Try to login with login 'self_checkout' and password 'self_checkout' => You see an alert 'You can not loggin with self check-out user' 2) SCI 2.1) Create a new patron with login 'self_checkin', password 'self_checkin' 2.2) Define on him the permission 'self_checkin_module' 2.3) Go to OPAC main page, not logged-in 2.4) Try to login with login 'self_checkin' and password 'self_checkin' => You see an alert 'You can not loggin with self check-in user' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:41:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 07:41:25 +0000 Subject: [Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |dcook at prosentient.com.au --- Comment #10 from Jonathan Druart --- I don't think this is valid, that could be considered a security issue to provide such info. C4::Auth changes without tests => FQA anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:05:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 08:05:55 +0000 Subject: [Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632 --- Comment #11 from Fridolin Somers --- In this case a less specific message ? Like "Login failed because of technical issue" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 08:11:01 +0000 Subject: [Koha-bugs] [Bug 23380] GuessAuthTypeCode should check authority type exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23380 --- Comment #6 from Fridolin Somers --- (In reply to Jonathan Druart from comment #5) > (In reply to Fridolin Somers from comment #4) > > Fixed for current master. > > > > Using Koha::Authority::Types->search->get_column('authtypecode') is better. > > Which means? Do we close this one? No I mean rebased on current master and patch slightly changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:21:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:21:35 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:21:39 +0000 Subject: [Koha-bugs] [Bug 32781] CreateEHoldingsFromBiblios not dealing with non-existent package correcly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32781 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145959|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim --- Created attachment 145992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145992&action=edit Bug 32781: Prevent import from list to fail if package does not exist This is theorical (caught when writting tests) but we need to deal with it. Can't call method "resources" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 94. Test plan: prove t/db_dependent/Koha/BackgroundJob/CreateEHoldingsFromBiblios.t must return green Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:31:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:31:04 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:31:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:31:09 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145978|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 145993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145993&action=edit Bug 32785 - Typo: Maximum number of simultaneus pickups per interval (curbside pickups) This patch corrects a small typo in the curbside pickup administration page. To test: 1. Apply patch 2. Enable the CurbsidePickup system preferences 3. Go to Administration > Curbside pickup --> Next to Maximum patrons per interval, the tip should be "Maximum number of simultaneous pickups per interval" Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:32:15 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:38:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:38:58 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:58:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:58:37 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #2 from Matt Blenkinsop --- I think there is another fieldset that has been missed as the sidebar on serials-search is still inside the main form fieldset - see lines 434-440 in serials-search.tt Does this need amending as well or is this not subject to the same standardized structure? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:58:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:58:56 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 --- Comment #13 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #10) > Created attachment 145847 [details] [review] > Bug 32712: (QA follow-up) Use Koha.Preference > > Signed-off-by: Tomas Cohen Arazi koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc is missing [% USE Koha %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:59:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 09:59:22 +0000 Subject: [Koha-bugs] [Bug 32793] New: import_patrons.pl typo in usage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Bug ID: 32793 Summary: import_patrons.pl typo in usage Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:01:08 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 --- Comment #1 from Pedro Amorim --- Created attachment 145994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145994&action=edit Bug 32793: import_patrons.pl typo in usage Typo fix to prevent confusion in CLI usage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:02:16 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:02:31 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:08:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:08:44 +0000 Subject: [Koha-bugs] [Bug 32180] ERM - Mandatory fields don't have the 'required' class on the label In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32180 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:33:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:33:44 +0000 Subject: [Koha-bugs] [Bug 29109] Delete ILL requests manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29109 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m Status|NEW |In Discussion --- Comment #2 from Pedro Amorim --- In order to be able to delete a request, that request's status needs to have 'KILL' as a next_action in the status_graph of its respective backend. In other words, it's the backend that will determine when the delete button/action is available. If you don't see a "delete request" button, it means the that request's backend does not allow for deletion of requests in that status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 10:59:49 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:26:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 11:26:23 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #13) > (In reply to Tomás Cohen Arazi from comment #10) > > Created attachment 145847 [details] [review] [review] > > Bug 32712: (QA follow-up) Use Koha.Preference > > > > Signed-off-by: Tomas Cohen Arazi > > koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc is missing [% USE > Koha %] That was on purpose. Do you think it needs to be added even if the callers already include it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 11:54:11 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 11:54:16 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #18 from Kyle M Hall --- Created attachment 145995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145995&action=edit Bug 32612: (QA Follow-up) Update package files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 11:55:57 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #19 from Kyle M Hall --- (In reply to David Cook from comment #14) > Thought about doing a follow-up but thought it might make more sense to fail > QA. As a developer and QA'er, my mantra is "Follow-up if you can, fail is you must" ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:25:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:25:28 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #457 from Tomás Cohen Arazi --- I tested the feature and after a rebase fix Kyle did it is working properly. The QA scripts are happy, things are covered by tests and they pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:31:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:31:09 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #49 from Martin Renvoize --- So I was installing on a fresh Ubuntu.. and trying initially to use ubuntu apt repos.. Yarn came in at a newer version that Koha expected.. that was the main stumbling block really. I've since managed to get it all working.. thanks for the tip about that yarn repo. We don't document a dev install anywhere now so it's become more difficult and I've become very rusty ;). My feeling at this point is that we should go with this as is now :). You can add my SO lines to the remote branch Jonathan.. I'm happy I got it all working for a standard install and a dev type install.. and it sounds like David was pretty happy with building a package, all be it he had expected issues due to upstream having a bad debian.control file at the minute (I fixed that in 22.11.x branch already.. not sure if he's got it building and applying to master regularly yet?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:33:53 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #8) > Bug 12225 changed the templates to correctly pass through the no-block flag, > however, we don't have a no-block routine for checkins ^^ any chance we can have a regression test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:50:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:50:18 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145983|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 145996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145996&action=edit Bug 32775: Do not order language directories based on when they were created Sponsored-by: Kinder library, New Zealand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:50:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:50:23 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145984|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 145997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145997&action=edit Bug 32775: Correctly display language order in sysprefs when you have multiple languages in a group Test plan: 1. Apply first patch 2. Install en-NZ and another language - e.g. mi-NZ - so you have three languages showing in your sysprefs en-NZ (selected), en (unselected) and mi-NZ (selected) 3. Tick en-NZ and mi-NZ in language and OPACLanguages sysprefs. Order en-NZ above mi-NZ and save 4. Refresh the syspref page and confirm mi-NZ is displaying above en-NZ, even though you ordered en-NZ first 5. Refresh the syspref page multiple times and observe the order of the languages changes 6. Apply this (second) patch 7. Restart plack 8. Refresh syspref page several times confirming that en-NZ is always ordered first - as expected. Sponsored-by: Kinder library, New Zealand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:50:27 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #7 from Martin Renvoize --- Created attachment 145998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145998&action=edit Bug 32775: (QA follow-up) Fix tab and indenting issues Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 12:51:11 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Working as described, signing off. I added a QA follow-up to fix the use of tabs and ran a perltidy over the changed code block for clarity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:18:37 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 --- Comment #15 from Jonathan Druart --- It should be included where used. We faced issues because of that in the past (w hen backported for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:19:44 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #510 from Jonathan Druart --- All that bundle JS code in detail.tt could have been moved to a dedicated js file to keep the template under 2k lines :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:29:00 +0000 Subject: [Koha-bugs] [Bug 32794] New: mailto links in 856 can be incorrectly formed by XSLT Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Bug ID: 32794 Summary: mailto links in 856 can be incorrectly formed by XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The current code checks for '://' in the 856, and adds http:// or ftp://, depending on first indicator, if it isn't present. The marc standard, however, lists more access methods that are not tested for or covered. mailto: won't meet the test for '://' and should be handled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:33:53 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:33:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:33:56 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 --- Comment #1 from Nick Clemens --- Created attachment 145999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145999&action=edit Bug 32794: Expand tests for access method in XLST files This patch expands the checks for 856u to check for mailto, and adds a few conditiona checks of the first indicator to cover more methods Reference: https://www.oclc.org/bibformats/en/8xx/856.html To test: 1 - Edit a record and add a few 856 fields: 856 0 0 $umailto:test at example.org 856 0 0 $utest at example.org 856 2 0 $utelnet://pucc.princeton.edu 856 2 0 $upucc.princeton.edu 856 3 0 $u8885555555 2 - View staff details and results and opac details and results 3 - Note all links have been prepended with http:// 4 - Apply patch 5 - Refresh all views, ensure links are correctly formed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:34:11 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:40:01 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145545|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 146000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146000&action=edit Bug 32546: Move ILL system preferences into their own tab in administration Without this patch the interlibrary loan related system preferences appeared on the circulation tab, that is already quite long. As ILL is a complete module, it deserves its own tab. To test: * Search for interlibrary loan related preferences in Admin, verify their number and location * Apply patch * Verfiy all the previously found preferences now appear on their own tab: Interlibrary loans Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:40:29 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com QA Contact| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Excellent improvement, thanks Katrin! Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:41:15 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:41:15 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32546 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 [Bug 32546] Move ILL system preferences to their own tab in administration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:42:19 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19605 | Blocks| |19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:42:19 +0000 Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19822 | Depends on| |19822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:43:36 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #511 from Martin Renvoize --- (In reply to Jonathan Druart from comment #510) > All that bundle JS code in detail.tt could have been moved to a dedicated js > file to keep the template under 2k lines :D True.. it grew and grew and grew. I'll create a follow-up bug and handle that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:49:54 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:50:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 13:50:09 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #50 from Jonathan Druart --- (In reply to Martin Renvoize from comment #49) > You can add my SO lines to the remote branch Jonathan Done, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:01:02 +0000 Subject: [Koha-bugs] [Bug 25512] Add support for LDAPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25512 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #1 from Frédéric Demians --- I'm encountering the same issue with Google Workspace LDAP server. It is necessary to explicitly specify Google cert/key files generated for each configured LDAP client from Google Workspace admin console. Something like that: clientcert => '..../etc/ldap/Google_xx_yy_zz_36497.crt', clientkey => '..../etc/ldap/Google_xx_yy_zz_36497.key', -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:03:31 +0000 Subject: [Koha-bugs] [Bug 30271] Allow distinct ILLHiddenRequestStatuses config for view from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30271 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:14:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:14:21 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #21 from Martin Renvoize --- Created attachment 146001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146001&action=edit Bug 25503: Make Koha::Exporter::Record tests pass with unimarc Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:14:26 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #22 from Martin Renvoize --- Created attachment 146002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146002&action=edit Bug 25503: Add failing test for _get_biblio_for_export Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:14:32 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #23 from Martin Renvoize --- Created attachment 146003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146003&action=edit Bug 25503: Make _get_biblio_for_export test pass Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:14:37 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 --- Comment #24 from Martin Renvoize --- Created attachment 146004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146004&action=edit Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce Signed-off-by: Katrin Fischer Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:16:51 +0000 Subject: [Koha-bugs] [Bug 32795] New: ILLHiddenRequestStatuses system preference description is wrong Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 Bug ID: 32795 Summary: ILLHiddenRequestStatuses system preference description is wrong Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: katrin.fischer at bsz-bw.de Depends on: 28641 Currently, the ILLHiddenRequestStatuses sys preference reads: "... The request codes can be found in the ILLSTATUS authorized value category." But, the request status codes actually come from status_graph of their respective backend, or alternatively from core Koha::Illrequest, not from ILLSTATUS. ILLSTATUS AV is only used for a request's status_alias, which is an alternate list of statuses that is only used to give the staff member the ability of adding their own statuses by editing a request. On top of that, bug 28641 refers to the fact that the code that is checking this system preference doesn't even consider the requests' status_alias, only the actual status coming status_graph in code. I think this label should be updated to reflect that it may use both the status codes from installed ILL backends and the values from ILLSTATUS, once 28641 is fixed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:16:51 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:18:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:18:15 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143165|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 146005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146005&action=edit Bug 25503: Make Koha::Exporter::Record tests pass with unimarc Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=25508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:18:21 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143166|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 146006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146006&action=edit Bug 25503: Add failing test for _get_biblio_for_export Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=25508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:18:26 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143167|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 146007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146007&action=edit Bug 25503: Make _get_biblio_for_export test pass Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=25508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:18:32 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143168|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 146008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146008&action=edit Bug 25503: Add option to export items bundle contents in checkouts table Test plan: 1. Enable system preference ExportCircHistory 2. Create an item bundle (see bug 28854 comment 458) 3. Check out the item bundle 4. In the checkouts table, check the box in column "Export", choose export format 'MARC with items', check "Export items bundle contents" and click on "Export" button The exported file should contain the biblio and item created at step 2, but also the biblio and items that are part of the bundle Signed-off-by: Marie-Luce Signed-off-by: Katrin Fischer Signed-off-by: Marie-Luce Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=25508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:20:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:20:16 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:20:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:20:27 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:20:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:20:38 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:20:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:20:49 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:21:57 +0000 Subject: [Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize --- All working as described.. QA scripts are happy and this adds some nice cleanup and improvements to the unit tests. Whilst I would have loved to see the bundle handling code in a module rather than at the controller, I understand why you did it this way in this case. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:26:24 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140898|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146009&action=edit Bug 29099: Add bundle support to inventory tool Test plan: 1. Create an item bundle (see bug 28854 comment 458) containing 2 items with barcodes B1 and B2 2. Go to the inventory tool 3. Enter B1 inside the barcode list 4. Select the item bundle in "Item location filters" fieldset 5. Submit the form In the result table you should see B2 with the problem "Missing (not scanned)" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:26:36 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:27:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:27:41 +0000 Subject: [Koha-bugs] [Bug 29099] Add support for item bundles in the inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 --- Comment #6 from Martin Renvoize --- I'd have loved to have seen a customer signoff here.. but I'm confident enough in the code and have tested it's working.. So I'm signing off myself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:37:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:37:17 +0000 Subject: [Koha-bugs] [Bug 32796] New: Marc modification template copying multiple subfields issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32796 Bug ID: 32796 Summary: Marc modification template copying multiple subfields issue Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org 1. Marc record contains a 264 field with multiple subfield $a. eg =264 \1$aAbingdon, Oxon ;$aNew York, NY :$bRoutledge,$c2020. 2. Marc modification template created to set to "Copy All" 264a to 260a 3. Stage record with template from #2 4. Note that 2 x 260 fields created =260 \1$aAbingdon, Oxon =260 \1$aNew York, NY 5. Expected outcome: =260 \1$aAbingdon, Oxon;$aNew York, NY Variation using "Copy 1st" doesn't work either. Result is =260 \1$aAbingdon, Oxon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:43:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:43:58 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:55:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:55:04 +0000 Subject: [Koha-bugs] [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 --- Comment #1 from Katrin Fischer --- That certainly makes sense. If we changed the description we could also update Bug 28641 - ILLHiddenRequestStatuses does not consider custom statuses to be an enhancement instead of a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:55:29 +0000 Subject: [Koha-bugs] [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28641 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:55:29 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32795 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:56:25 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:56:30 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 --- Comment #1 from Owen Leonard --- Created attachment 146010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146010&action=edit Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:56:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:56:50 +0000 Subject: [Koha-bugs] [Bug 32797] New: Cannot save OAI set mapping rule for subfield 0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Bug ID: 32797 Summary: Cannot save OAI set mapping rule for subfield 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The code checks the truth of the subfield, it should check if not empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:59:26 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:59:29 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 --- Comment #1 from Nick Clemens --- Created attachment 146011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146011&action=edit Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 14:59:42 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:42 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:46 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #458 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:50 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:54 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:57 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:01:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:01:59 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:02 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:05 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:08 +0000 Subject: [Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:11 +0000 Subject: [Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:14 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:16 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:18 +0000 Subject: [Koha-bugs] [Bug 32798] New: build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Bug ID: 32798 Summary: build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The code passes 'marc_record', it should be 'record' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:19 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:02:22 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:03:59 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:07:57 +0000 Subject: [Koha-bugs] [Bug 32799] New: ILLSTATUS authorized value category name is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Bug ID: 32799 Summary: ILLSTATUS authorized value category name is confusing Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com Bug 20581 introduced the ability to manually select custom ILL request statuses. These custom ILL request statuses are stored in the ILLSTATUS AV and are then stored in the status_alias column of illrequests. Staff members are lead to believe that ILL statuses are stored in the ILLSTATUS authorized values list when these are just aliases used for display purposes. The actual ILL statuses are fed from the backend or Koha::Illrequest. My suggestion would be rename this to ILL_STATUS_ALIAS or ILL_STATUS_ALIASES -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:07:57 +0000 Subject: [Koha-bugs] [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32799 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:07:57 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32799 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:08:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:08:37 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:08:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:08:42 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146010|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 146012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146012&action=edit Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:09:00 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 --- Comment #3 from Caroline Cyr La Rose --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:10:58 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:11:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:11:02 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 --- Comment #1 from Nick Clemens --- Created attachment 146013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146013&action=edit Bug 32798: Update parameter passed to Koha::Biblio::Metadata->record To test: 1 - Enable OAI sets, and define a set with mapping 952 y = BK 2 - perl misc/migration_tools/build_oai_sets.pl -v -i -r 3 - The script dies: Koha::Biblio::Metadata->record must be called on an instantiated object or like a class method with a record passed in parameter 4 - Apply patch 5 - Repeat 6 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:11:10 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:24:13 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |31223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 [Bug 31223] Batch edit items explodes if plugins disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:24:13 +0000 Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:24:31 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:24:31 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 [Bug 30889] Background jobs lead to wrong/missing info in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:24:31 +0000 Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:25:05 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:25:05 +0000 Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:25:29 +0000 Subject: [Koha-bugs] [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 [Bug 30360] Add helper methods to Koha::BackgroundJobs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:25:29 +0000 Subject: [Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31351 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31351 [Bug 31351] Worker dies on reindex job when operator last name/first name/branch name contains non-ASCII chars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:26:32 +0000 Subject: [Koha-bugs] [Bug 32795] ILLHiddenRequestStatuses system preference description is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32795 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:28:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:28:58 +0000 Subject: [Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:31:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:31:40 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 146014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146014&action=edit Bug 32712: (QA follow-up) Add missing include I assumed it wasn't needed because teh .tt files using this already includ teh Koha plugin. But we shuoldn't skip, just in case someone doesn't notice when reusing this, and debugging will be a pain. Sorry for that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:32:47 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:41:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:41:07 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #103 from Hammat wele --- Created attachment 146015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146015&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:57:57 +0000 Subject: [Koha-bugs] [Bug 32800] New: build_oai_sets.pl fails on deleted records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Bug ID: 32800 Summary: build_oai_sets.pl fails on deleted records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The code fetches metadata for biblios and deleted biblios, but we cannot embed items on deleted biblios: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. To recreate: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:59:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:59:09 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:59:13 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #1 from Nick Clemens --- Created attachment 146016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146016&action=edit Bug 32800: Don't embed items for deleted records To test: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. 4 - Apply patch 5 - Repeat 6 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 16:59:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 15:59:32 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:19:51 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143367|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 146017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146017&action=edit Bug 32121: Show an alert when adding a checked out item to an item bundle When trying to add a checked out item to an item bundle, an alert message will show up, giving the user a chance to return the item immediately before adding it to the bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and check out this item. 3. Try to add the checked out item to the bundle You should see a message saying that the item is checked out. Next to this message should be a button "Check in and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly returned and added to the bundle Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:19:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:19:56 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #3 from Martin Renvoize --- Created attachment 146018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146018&action=edit Bug 32121: (QA follow-up) Use error_code rather than key We semi-recently introduced error_code into our error object to allow for translation and code paths for different errors without having to rely on long description string matches. This QA follow-up converts the existing match and new 'key' fields introduced in this patchset to use the updated 'error_code' key. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:20:53 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:26:34 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 --- Comment #4 from Martin Renvoize --- Sorry I didn't spot this earlier.. great piece of functionality; Had to do a minor rebase to get it to apply clean, nothing too scary. I added a follow-up to convert from 'key' to 'error_code' as that's the direction we're headed I believe. I also far prefer your construction of the result alerts.. makes my code look very amateurish! Regarding choice of 409 vs 400 i'm never sure which to use.. perhaps 409 for 'resolvable conflicts' that trigger the option to resend with a condition and 400 for unresolvable one's where we show a harder error and no inline resolution option? Finally.. tests.. I think we perhaps need some API tests to prevent regressions from creeping in with your addition of a new param on the endpoint?.. I'll leave that one for the QA person. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:26:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:26:45 +0000 Subject: [Koha-bugs] [Bug 32801] New: /checkouts?checked_in=1 errors when itemnumber is null Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32801 Bug ID: 32801 Summary: /checkouts?checked_in=1 errors when itemnumber is null Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com CC: tomascohen at gmail.com When trying to fetch checked_in checkouts for a borrower, if the old_issues doesn't have an itemnumber (for example the item was deleted). It brings a 500 error. This is a message I got while querying this url : /api/v1/checkouts?patron_id=13662&checked_in=1 
{"errors":[{"message":"Expected integer - got
null.","path":"\/0\/item_id"},{"message":"Expected integer - got
null.","path":"\/1\/item_id"},{"message":"Expected integer - got
null.","path":"\/9\/item_id"},{"message":"Expected integer - got
null.","path":"\/12\/item_id"},{"message":"Expected integer - got
null.","path":"\/13\/item_id"},{"message":"Expected integer - got
null.","path":"\/14\/item_id"},{"message":"Expected integer - got
null.","path":"\/15\/item_id"}],"status":200}
Querying with itemnumber not null solves the issue : /api/v1/checkouts?patron_id=13662&checked_in=1&q={"item_id":{"-not_like":"null"}} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:28:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:28:20 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:37:41 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:41:37 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140883|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 146019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146019&action=edit Bug 31615: Allow checkin of items bundles without verifying their contents This patch adds a button in the "bundle verification" modal to skip this step and do the checkin anyway. Test plan: 1. Create an items bundle (see bug 28854 comment 458) 2. Check out this bundle, then return it. The "bundle verification" modal should appear 3. Leave the textarea empty and click on "Confirm checkin without verifying bundle contents" 4. Confirm that the bundle was correctly returned, and no items were marked as lost Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:43:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:43:58 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Signing off.. works as described. I think I'd like to see the display of this button tied to a pref though myself.. I know some site want to require verification at check-in, whilst others won’t and will happily use the inventory in their workflow instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:44:56 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele at inlibro.com --- Comment #104 from Hammat wele --- sub filterAutocomplete moved to a new module and now the filtering is done at the search time. (In reply to Katrin Fischer from comment #93) > 6) Updating installations: I believe you also need to reset mappings to make > this work? How can we ensure this works out of the box for people updating > without them having to "redo" their index configuration? (database update?) It's been wrote in the test plan by precaution but there is no need reset mappings to make this work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 32802] New: Bundle handling JS should be moved to an asset Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 Bug ID: 32802 Summary: Bundle handling JS should be moved to an asset Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 29560, 31080, 31615, 32121 The item bundling Javascript has come quiet extensive.. it should be tidied up somewhat and moved into it's own asset file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 [Bug 29560] Add option to create MARC links when adding items to bundles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080 [Bug 31080] Block adding the bundle item to its own bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 [Bug 31615] Allow checkin of items bundles without verifying their contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 [Bug 32121] Show an alert when adding a checked out item to an item bundle -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:34 +0000 Subject: [Koha-bugs] [Bug 32803] New: EnableItemGroups and EnableItemGroupHolds options are wrong Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Bug ID: 32803 Summary: EnableItemGroups and EnableItemGroupHolds options are wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I played around with item groups and now in my About page > System information, I have an error message System preference 'EnableItemGroups' must be '0' or '1', but is 'no'. System preference 'EnableItemGroupHolds' must be '0' or '1', but is 'no'. I think it may be the options in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref that are yes/no, but should be 1/0? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:49:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:49:55 +0000 Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #512 from Martin Renvoize --- Bug 32802 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:50:28 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145950|0 |1 is obsolete| | --- Comment #32 from Emily Lamancusa --- Created attachment 146020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146020&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl with parameter -m 3 or some other number of max processes 6) Note the multiple forked processes in the ps output Test notes - also tested the following on KTD: 1. Stop background_jobs_worker.pl 2. Edit /etc/koha/sites/kohadev/koha-conf.xml - set max_processes to 10 3. Generate some background jobs 4. Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5. Restart all 6. Confirm multiple forked processes in the ps output Both methods work as expected and generate multiple forked processes based on the value set for max processes. Signed-off-by: emlam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:51:07 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:51:38 +0000 Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 --- Comment #8 from Martin Renvoize --- Noone interested in this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:53:22 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #1 from Caroline Cyr La Rose --- The installer data (installer/data/mysql/mandatory/sysprefs.sql) and dbrevs (installer/data/mysql/db_revs/220600014.pl and installer/data/mysql/db_revs/220600078.pl) insert 0 for both by default. So I think that part is OK. It's only when you change them manually in the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:53:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:53:27 +0000 Subject: [Koha-bugs] [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 --- Comment #9 from Lucas Gass --- I should not have backported this, tests are failing because there is no 'Koha::Checkouts::Renewals' in 22.05. That looks like it was added by Bug 30275. I will revert this patchset from 22.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:56:27 +0000 Subject: [Koha-bugs] [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 [Bug 30275] Checkout renewals should be stored in their own table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:56:27 +0000 Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 17:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 16:57:07 +0000 Subject: [Koha-bugs] [Bug 29021] Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29021 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03 released in| | --- Comment #10 from Lucas Gass --- Patchset reverted from 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:04:40 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145905|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 146021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146021&action=edit Bug 32772: Make all autocomplete searches 'starts_with' To test: 1 - Add patrons with surname Fitzwilliams and Williams 2 - Enable 'PatronAutocomplete' syspref 3 - In checkout box type 'Will' 4 - You see fitwilliams first 5 - Apply patch 6 - Type 'Will' 7 - Autocomplete does not suggest Fitzwilliam, only Williams 8 - Type '%will' 9 - Fitzwilliams is suggested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:05:01 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:06:04 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Whilst the nerd/coder side of me prefers the alternative.. I think in real life people will all prefer the functionality of the first patch. As such, I tested that one and am signing off confident in the approach as agreed by the staff and a few customers here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:07:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:07:18 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- In fact.. as this patch is trivial and fixes a major regression I'll go straight for PQA.. Thanks Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:14:47 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Caroline Cyr La Rose --- I prefer Owen's buttons because they don't need translation ;) I was coming to say that I couldn't find the Expand/Unexpand strings in the po files after updating them, but this is better! Going through the patron account pages with the "Galaxy fold" setting in Chrome, which is the narrowest I found, there are some tables that are missing the expand option. - Summary - Checkouts: OK - Summary - Relatives' checkouts: OK - Summary - Overdue: OK - Summary - Clubs: Large table not collapsed - Summary - Charges: Narrow table OK - Summary - Relatives' charges: Narrow table OK - Summary - Holds: OK - Summary - Recalls: Large table not collapsed - Summary - Article requests: Large table not collapsed - Charges - (patron's own): OK (should we show another column rather than the date? Maybe a matter for another bug) - Charges - (relative's): Large table not collapsed - Tags: Narrow table OK - Search history - Catalog: OK (Should we show another column rather than the date? Maybe a matter for another bug) - Search history - Authority: Large table not collapsed - Checkout history - All: Large table not collapsed - Checkout history - Checkouts: Large table not collapsed - Checkout history - On-site: Large table not collapsed - Recalls history: Large table not collapsed - Purchase suggestions: OK (list view not table) - Messaging: Large table not collapsed - Lists: OK (list view not table) - ILL requests: To check, I have never been able to set up ILL on my installation - Curbside pickups: OK Other pages that have tables (not sure I found all of them) - Holdings: OK - Subscription (serial): Large table not collapsed - Course reserves - Courses: Large table not collapsed - Course reserves - Reserves: Large table not collapsed - Authority search results: Large table not collapsed Should we open another bug for these non-patron-account pages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:34:22 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:47:14 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:47:18 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 146022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146022&action=edit Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:48:14 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Depends on| |24857, 24860 Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 [Bug 24860] Add ability to place item group level holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:48:14 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:48:14 +0000 Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:55:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:55:56 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 17:56:02 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 --- Comment #2 from Pedro Amorim --- Created attachment 146023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146023&action=edit Bug 28641: ILLHiddenRequestStatuses does not consider custom statuses This patch adds the status_alias column to the ILLHiddenRequestStatuses sys pref check. Because requests will have status_alias NULL by default, we also check for that. Test plan: Create multiple ILL requests of different backends and place them in different status (NEW, COMP, REQ, etc) Create multiple ILLSTATUS entries Add and remove a mix of both status and status_alias codes in ILLHiddenRequestStatuses and refresh the ILL requests page to confirm the result is according to expectation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 18:02:32 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 --- Comment #7 from Lucas Gass --- Mason, this doesn't cleanly apply to 22.05.x. Can you check? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:19:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 18:19:34 +0000 Subject: [Koha-bugs] [Bug 24843] Allow batch change of framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24843 Enica Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 18:21:55 +0000 Subject: [Koha-bugs] [Bug 32784] Reoccurring News In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:57:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 18:57:04 +0000 Subject: [Koha-bugs] [Bug 32804] New: Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Bug ID: 32804 Summary: Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When 'Item processing' option during import is set to 'replace' itemnumber matches do not check any other data - so the item's biblionumber is set to the matched biblionumber, but the biblioitemnumber is not updated or checked This means that if you import a record containing an item with an itemnumber from another record you will end up with an item with mismatched biblio and biblioitem numbers This happens in consortia when multiple libraries have ordered the same biblio. Two biblios are created, later the final import with barcodes etc. is imported to replace items, and the more full bib is chosen for the biblio match, so items are half moved. To recreate: 1 - Be using the sample data in koha testing docker 2 - Stage the sample file on this report 3 - Match on KohaBiblio(999$c) / Item processing: replace 4 - Note the biblio match is "The complete novels / Austen, Jane" 5 - View the staged marc, note the barcode 39999000004090 in an item 6 - Search for that barcode 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert" 8 - Import the file 9 - Check the db: SELECT * FROM items WHERE biblionumber != biblioitemnumber; 10 - Note the mismatch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:07:09 +0000 Subject: [Koha-bugs] [Bug 32805] New: When recording localuse in the statistics table location is always NULL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Bug ID: 32805 Summary: When recording localuse in the statistics table location is always NULL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When UpdateStats records a localuse in the statistics table the location is always NULL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:07:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:07:18 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:09:36 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:10:45 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:10:48 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 --- Comment #1 from Lucas Gass --- Created attachment 146024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146024&action=edit Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:11:13 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:19:06 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:19:14 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145972|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 146025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146025&action=edit Bug 32612: Add worker-error to log4perl conf To test: 1 - Apply patch 2 - vim /etc/koha/sites/kohadev/log4perl.conf, Add lines below: log4perl.logger.worker = WARN, WORKER log4perl.appender.WORKER=Log::Log4perl::Appender::Screen log4perl.appender.WORKER.stderr=1 log4perl.appender.WORKER.mode=append log4perl.appender.WORKER.layout=PatternLayout log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n log4perl.appender.WORKER.utf8=1 3 - Restart all 4 - Edit misc/background_jobs_worker.pl - my $job = Koha::BackgroundJobs->find($args->{job_id}); + my $job;# = Koha::BackgroundJobs->find($args->{job_id}); 5 - In another terminal: tail -f /var/log/koha/kohadev/koha-worker-error.log 6 - Force enqueue a job (that won't be found because of #4 perl -e 'use Koha::BackgroundJob::BatchUpdateItem; my $bg = Koha::BackgroundJob::BatchUpdateItem->new(); $bg->enqueue({ record_ids=>['888888']});' 7 - Note error in log like: [2023/01/11 19:26:10] [WARN] No job found for id=2983 main:: /kohadevbox/koha/misc/background_jobs_worker.pl (111) Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:19:20 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145973|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 146026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146026&action=edit Bug 32612: (QA Follow-up) Remove superfluous line Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:19:26 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145995|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 146027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146027&action=edit Bug 32612: (QA Follow-up) Update package files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:24:24 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- Testing notes (using KTD): 1. Step 5: I don't have a /var/log/koha/kohadev/koha-worker-error.log, but do have a worker-error.log and worker-output.log 2. The error was logged in worker-output.log: [2023/02/02 19:15:09] [WARN] No job found for id=2 main:: /kohadevbox/koha/misc/background_jobs_worker.pl (114) 3. I think I had to do another restart_all after making the change to the file for the error to appear in the log. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:33:07 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:33:12 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145994|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 146028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146028&action=edit Bug 32793: import_patrons.pl typo in usage Typo fix to prevent confusion in CLI usage Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:37:40 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): 1. From the command line run: misc/import_patrons.pl --help 2. Note that in the usage section for the [--preserve_field ] option, there is an underscore used for --preserve_field. This should be a dash (see the full list under options). 3. Apply the patch. 4. Repeat step 1 - the usage section now has --preserve-field with a dash. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:43:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:43:26 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:52:59 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:53:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:53:05 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146011|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 146029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146029&action=edit Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:56:13 +0000 Subject: [Koha-bugs] [Bug 32806] New: Some Vue files need to be moved for better reusability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug ID: 32806 Summary: Some Vue files need to be moved for better reusability Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 32030 So far the Vue files are only used by the ERM module, but some needs to be move in a parent directory to make them reusable by another module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:56:13 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 [Bug 32806] Some Vue files need to be moved for better reusability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:57:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:57:43 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #1 from Jonathan Druart --- Created attachment 146030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146030&action=edit Bug 32806: Move Vue files for reusability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:59:29 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:59:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:59:34 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145782|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 146031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146031&action=edit Bug 32560: Cronjob to mark expired borrowers as lost their card Test plan: 1. Edit a borrower to have an expiration date in the past - also make sure they have 'Lost card' set to 'No' 2. Run the set_expired_lost.pl script: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl 3. Notice you get output saying the number of borrowers are to be changed 4. View the borrower account from #1 and notice they have a 'Lost card' value of 'Yes' 5. Run the set_expired_lost.pl script again and observe no output is printed to the terminal - this is because all expired borrowers have already been marked as lost. Sponsored-by: Dalton McCaughey Library, Australia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:59:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:59:39 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145989|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 146032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146032&action=edit Bug 32560: (follow-up) Altered wording of output Sponsored-by: Dalton McCaughey Library, Australia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:59:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 19:59:46 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustin.moyano at gmail.com, | |martin.renvoize at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:13:21 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #2 from Jonathan Druart --- Created attachment 146033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146033&action=edit Bug 32806: Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:16:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:16:31 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #1 from Nick Clemens --- Created attachment 146034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146034&action=edit Sample file for importing with item from another record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:17:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:17:33 +0000 Subject: [Koha-bugs] [Bug 25395] Enumchron needs to sort numerically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25395 Enica Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:17:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:17:35 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #3 from Jonathan Druart --- Created attachment 146035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146035&action=edit Bug 32806: Rename ERMHome and ERMMain to Home and Main We don't need to repeat "ERM" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:23:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:23:33 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #4 from Jonathan Druart --- Created attachment 146036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146036&action=edit Bug 32806: Move routes.js to routes/erm.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:24:24 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:29:06 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #20 from Emily Lamancusa --- I encountered an error while testing this patch with batch item updates, in which one bad bib blocked the ES indexing update for every item in the batch. To reproduce the error: 1. Apply patches and run ktd --es7 up 2. Set SearchEngine system preference to 'Elasticsearch' 3. perl misc/search_tools/es_indexer_daemon.pl (leave running in the terminal while performing subsequent steps) 4. Perform an item search for all items where Collection is Reference 5. Export the results to a barcode file (898 items) 6. Upload this file to the Batch Item Modification Tool 7. Make an edit to the Full Call Number* and click Save 8. Notice that es_indexer_daemon prints an error to the console 9. Perform a catalog search 10. Limit the results with the Collection - Reference facet 11. Note that none of the results display the updated Call Number value *Or, as far as I can tell, any edit that will produce a change in the record for biblionumber 369 Error message printed to the console: ^ at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 114. DEBUG - Update of elastic index failed with: Invalid data, cannot decode metadata object (biblio_metadata.id=368, biblionumber=369, format=marcxml, schema=MARC21, decoding_error=':8: parser error : PCDATA invalid Char value 31 00aD000015937 ^ :9: parser error : PCDATA invalid Char value 31 00satmrnu0 ^ :9: parser error : PCDATA invalid Char value 31 00satmrnu0 ^ :9: parser error : PCDATA invalid Char value 31 00satmrnu0 ^ :9: parser error : PCDATA invalid Char value 31 00satmrnu0 ^ :10: parser error : PCDATA invalid Char value 31 00ar19881981bdkldan ^ :10: parser error : PCDATA invalid Char value 31 00ar19881981bdkldan ^ :10: parser error : PCDATA invalid Char value 31 00ar19881981bdkldan ^') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:34:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:34:03 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:34:07 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #2 from Nick Clemens --- Created attachment 146037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146037&action=edit Bug 32804: Do not adjust biblionumber when replacing items during import This patch adjust the item matching at import to confirm that for a duplicate itemnumber or barcode matches an existing item in the DB and uses the original biblionumber when updating the item. When ordering in a consortium the items may be moved around, duplicate biblios added, and various matches found. We should not allow importing of items to move them from 1 biblio to another, but we should allow the imports to succeed and assume itemnumber or barcode matches are authoritative. The responsibility for correct matching of items to biblio should fall on the creator of the files To test: 1 - Be using the sample data in koha testing docker 2 - Stage the sample file on this report 3 - Match on KohaBiblio(999$c) / Item processing: replace 4 - Note the biblio match is "The complete novels / Austen, Jane" 5 - View the staged marc, note the barcode 39999000004090 in an item 6 - Search for that barcode 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert" 8 - Import the file 9 - Check the db: SELECT * FROM items WHERE biblionumber != biblioitemnumber; 10 - Note the mismatch 11 - Fix the item and set it as 'Music' type UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE biblionumber != biblioitemnumber; 12 - Apply patch, restart all 13 - Stage and import the file with the same settings 14 - Confirm the item is modified on its original biblio (99) and that item type is Book again 15 - Change itemnumber to avoid itemnumber match and reset type UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212; 16 - Stage and import with the same setttings 17 - Confirm the marcode match worked and item is updated to book on original record 18 - Delete the original item 19 - Stage and import the file with the same settings 20 - The item is successfully created 21 - Stage and import, but item processing option is 'add' 22 - Confirm 1 item ignored 23 - Check the db SELECT * FROM import_items WHERE barcode=39999000004090 24 - Confirm there is a line with 'error' and duplicate_barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:42:10 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145930|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 146038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146038&action=edit Bug 32771: Standardize structure around action fieldsets in serials This patch updates serials templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and rebuild the staff interface CSS. Go to serials and check the following pages to confirm that changes to form structure look correct: - Navigate directly to /cgi-bin/koha/serials/serials-search.pl - Check the form on this page. - Perform a subscription search. On the search results page, check the sidebar form. - Click "Manage numbering patterns" in the left-hand sidebar menu. - Click "New numbering pattern" and check the forms on that page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:42:10 +0000 Subject: [Koha-bugs] [Bug 32807] New: No need to fetch all if we need to know if one exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Bug ID: 32807 Summary: No need to fetch all if we need to know if one exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 In (at least) AgreementsList we are calling fetchAgreements which fetch all the agreements, to know if we display the table (that will fetch again the first X agreements). We need a fetchCountAgreements (similar to fetchCountLocalPackages) instead. I think we discussed that already somewhere else. Anyone willing to provide a patch to make their grip on Vue and the ERM module? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:42:10 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:48:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:48:41 +0000 Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:49:15 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145977|0 |1 is obsolete| | --- Comment #11 from Michael Hafen --- Created attachment 146039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146039&action=edit Bug 32730: Add Patron Lists tab to patron details and circulation pages (rebased 2023-02-02) Test Plan: 1. Apply patch 2. create a patron list if there aren't any 3. search for a patron 4. observe the "Patron lists" tab showing the list that the patron is not in 5. try adding the patron to the list and removing them from the list to be sure the feature has full operation 6. click "Check Out" on the side bar menu to navigate to the circulation page for this patron 7. observe the "Patron lists" tab, and verify it operates as it did on the patron details page Bug 32730: (follow-up) Minor corrections by Owen Leonard This patch corrects an instance of an incorrect capital letter ("Patron Lists" -> "Patron lists") and makes minor tweaks to indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:49:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:49:24 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:56:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:56:00 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:56:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:56:00 +0000 Subject: [Koha-bugs] [Bug 31645] flatpickr - update coding guidelines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31645 Bug 31645 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:56:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:56:01 +0000 Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an order in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Bug 23202 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 20:56:02 +0000 Subject: [Koha-bugs] [Bug 31741] Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 Bug 31741 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:19:41 +0000 Subject: [Koha-bugs] [Bug 31958] Save button when editing a vendor should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- There were some global fixes and a lot of patches overall, I believe this was fixed elsewhere. Thx for checking and the screenshot! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:19:41 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 31958, which changed state. Bug 31958 Summary: Save button when editing a vendor should be yellow https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31958 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:46:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:46:05 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #51 from Katrin Fischer --- When everything is set, could you add a little write-up to the wiki? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:47:45 +0000 Subject: [Koha-bugs] [Bug 32808] New: Logic in AgreementsList is flawed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 Bug ID: 32808 Summary: Logic in AgreementsList is flawed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32807
{{ $__("Loading") }}
[...]
{{ $__("There are no agreements defined") }}
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:47:45 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32808 [Bug 32808] Logic in AgreementsList is flawed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 21:56:51 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #2 from Katrin Fischer --- Hm, do we have maybe some example data for these? I'll also add Heather for a real MARC expert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:08:58 +0000 Subject: [Koha-bugs] [Bug 32726] Authority search result display and relator terms in 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Should there be two patches with similar titles and contents? Maybe this should be squashed - not sure of the protocol here... (Can confirm it works, so happy to sign off.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:20:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:20:37 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:20:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:20:41 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145881|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 146040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146040&action=edit Bug 32698: Use template wrapper for serials pages tabs This patch updates three serials templates to replace tab markup with the use of WRAPPERs. To test requires more data than will be found in the sample data. You need at least one subscription with issues spanning more than one year. I suggest creating a new subscription which starts in December, then receive one issue from December and one in January. Apply the patch and go to Serials. - Perform a subscription search. - On the search results page there should be two tabs: "Open" and "Closed." These tabs should work correctly. - Open the detail view of one of your subscriptions. - You should see at least four tabs: "Information," "Planning," "Issues," and "Summary." - In some cases an "Acquisition details" tab will also appear. To test this you must go to Acquisitions and add an order to a basket by choosing "From a subscription" option. - Click "Serial collection" in the left-hand sidebar. - There should be tabs for each year of subscription issues in your collection. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:32:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:32:42 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #52 from David Cook --- (In reply to Martin Renvoize from comment #49) > You can add my SO lines to the remote branch Jonathan.. I'm happy I got it > all working for a standard install and a dev type install.. and it sounds > like David was pretty happy with building a package, all be it he had > expected issues due to upstream having a bad debian.control file at the > minute (I fixed that in 22.11.x branch already.. not sure if he's got it > building and applying to master regularly yet?) Yeah I'm pretty happy :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:33:23 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:33:23 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32806 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:43:21 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- (In reply to Jonathan Druart from comment #0) > Anyone willing to provide a patch to make their grip on Vue and the ERM > module? I don't really know anything about the ERM, but one of these days I do plan to get to grips with Vue. Probably not this patch though 😅 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:45:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:45:21 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:48:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:48:47 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128634|0 |1 is obsolete| | --- Comment #14 from Lucas Gass --- Created attachment 146041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146041&action=edit Bug 27992: Call AddReturn when checking in localuse item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:52:37 +0000 Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:58:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 22:58:36 +0000 Subject: [Koha-bugs] [Bug 25512] Add support for LDAPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25512 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:25:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 23:25:57 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #15 from Lucas Gass --- > In marked my item lost using the 'claims returned' feature. With this change > the item will be returned and the claim remains unresolved. Is this an issue? In this case should we return the item and resolve the claim. Or block the return and leave the claim? > When you try to return an item that is lost with BlockReturnOfLostItems we > deny the return. But we allow checking it out to a statistical patron. > Should the latter also be blocked? If the item is LOST and BlockReturnOfLostItems is off, ask for confirmation but if the item is LOST and BlockReturnOfLostItems is on block the return? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:26:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2023 23:26:10 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:11:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 00:11:17 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #4 from Lucas Gass --- Created attachment 146042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146042&action=edit Bug 30928: Update Accounts.pm and Recalls.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 00:44:10 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145885|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 146043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146043&action=edit Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 00:44:14 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145886|0 |1 is obsolete| | --- Comment #7 from Lucas Gass --- Created attachment 146044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146044&action=edit Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:45:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 00:45:15 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 02:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 01:43:16 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #3 from quickfire28 at gmail.com --- Im not that good in MySQL, can i ask how can i locate the lines before and after the error? the KOHA version im going to update is 20.05( i already fix the first bug i found in my update using this (MariaDB [koha]> SELECT language_subtag,GROUP_CONCAT(script_subtag SEPARATOR ' | '),COUNT(*) AS nb\ -> FROM language_script_mapping GROUP BY language_subtag HAVING nb > 1; +-----------------+---------------------------------------------+----+ | language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb | +-----------------+---------------------------------------------+----+ | ar | Arab | Arab | 2 | | he | Hebr | Hebr | 2 | +-----------------+---------------------------------------------+----+ And fix with : DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ; DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ;) but after this one the next error bug appears. (ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739) Please help me in finding the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 02:44:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 01:44:00 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #4 from quickfire28 at gmail.com --- Im not that good in MySQL, can i ask how can i locate the lines before and after the error? the KOHA version im going to update is 20.05( i already fix the first bug i found in my update using this (MariaDB [koha]> SELECT language_subtag,GROUP_CONCAT(script_subtag SEPARATOR ' | '),COUNT(*) AS nb\ -> FROM language_script_mapping GROUP BY language_subtag HAVING nb > 1; +-----------------+---------------------------------------------+----+ | language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb | +-----------------+---------------------------------------------+----+ | ar | Arab | Arab | 2 | | he | Hebr | Hebr | 2 | +-----------------+---------------------------------------------+----+ And fix with : DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ; DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ;) but after this one the next error bug appears. (ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739) Please help me in finding the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:01:29 +0000 Subject: [Koha-bugs] [Bug 32809] New: Automatic debian/control updates (dev) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 Bug ID: 32809 Summary: Automatic debian/control updates (dev) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com this bug tracks automatic updates for debian/control, on 'master/main' branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:18:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:18:52 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 --- Comment #1 from Mason James --- Created attachment 146045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146045&action=edit Update debian/changelog file: 22.12.00-3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:18:56 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 --- Comment #2 from Mason James --- Created attachment 146046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146046&action=edit Update debian/control file: 22.12.00-3 on deb9 (1b6e9c7b) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:20:34 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:20:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:20:50 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:24:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:24:53 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145557|0 |1 is obsolete| | Attachment #145558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:24:55 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 --- Comment #8 from Mason James --- Created attachment 146047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146047&action=edit Update debian/changelog file: 22.05.09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:24:58 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 --- Comment #9 from Mason James --- Created attachment 146048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146048&action=edit Update debian/control file: 22.05.09 on deb9 (cb5f3095) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:25:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:25:11 +0000 Subject: [Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145561|0 |1 is obsolete| | Attachment #145562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:25:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:25:14 +0000 Subject: [Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 --- Comment #9 from Mason James --- Created attachment 146049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146049&action=edit Update debian/changelog file: 21.11.16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:25:17 +0000 Subject: [Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 --- Comment #10 from Mason James --- Created attachment 146050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146050&action=edit Update debian/control file: 21.11.16 on deb9 (09f26f0d) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:27:03 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing, please ignore) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:27:03 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30034 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:27:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:27:31 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing, please ignore) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED Resolution|FIXED |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:37:22 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 --- Comment #10 from Mason James --- (In reply to Lucas Gass from comment #7) > Mason, this doesn't cleanly apply to 22.05.x. Can you check? looks like its OK now... mason at xen1:~/koha$ git reset --hard v22.05.09 HEAD is now at cb5f3095c2 Update release notes for 22.05.09 release mason at xen1:~/g/k/m$ git bz apply 32667 Bug 32667 - Automatic debian/control updates (oldstable) 146047 - Update debian/changelog file: 22.05.09 146048 - Update debian/control file: 22.05.09 on deb9 (cb5f3095) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Update debian/changelog file: 22.05.09 Applying: Update debian/control file: 22.05.09 on deb9 (cb5f3095) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 03:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 02:42:54 +0000 Subject: [Koha-bugs] [Bug 32809] Automatic debian/control updates (dev/unstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (dev) |updates (dev/unstable) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 04:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 03:05:18 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Suzanne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra at yahoo.com --- Comment #3 from Suzanne --- This has caused a lot of problems at our library. Patrons end up trying to pay over and over and the fines won't go away (because they are fines from another account) and then they have a bunch of credit on their library account and we have to go find the other family member cards and resolve the fines manually. Would love to see this get fixed as soon as possible. Thank you for working on it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:42:30 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143765|0 |1 is obsolete| | --- Comment #69 from Emmi Takkinen --- Created attachment 146051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146051&action=edit Bug 16223: Add new columns to table restriction_types This patch adds two new columns, lift_after_payment and fee_limit, to table restriction_types. These colums are used to control lifting patrons restrictions after paying their fees. To test: 1. Apply this patch. 2. Update your database via updatedatabase.pl. => Confirm your table restriction_types has two new columns. Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:43:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:43:03 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143766|0 |1 is obsolete| | --- Comment #70 from Emmi Takkinen --- Created attachment 146052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146052&action=edit Bug 16223: DO NOT PUSH! Schema changes Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:43:37 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143767|0 |1 is obsolete| | --- Comment #71 from Emmi Takkinen --- Created attachment 146053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146053&action=edit Bug 16223: Add ability to define liftable restrictions Some libraries debar Patrons at the end of the year for having unpaid fines, like in Bug 15157. Currently librarians have to manually remove this type of debarments after Patron has paid his/her fines. This patch adds ability to create restrictions which are lifted after patron pays ceratain amount of fines. To test: 1. Apply this patch. 2. Restart your services if needed. 3. Navigate to page restrictions.pl. => Note that table has two new colums in it, "Lift after payment?" and "Fee limit". 4. Add new restriction which has "Lift after payment?" set as Yes and fee limit as 5. 5. Create fees for a patron so they exceed fee limit e.g. 10 6. Add restriction made in step 2. for the patron 7. Pay patrons fees partially so that they go under fee limit => Note that patrons restriction should now be lifted. Also prove t/db_dependent/Patron/Borrower_Debarments.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:44:04 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143768|0 |1 is obsolete| | --- Comment #72 from Emmi Takkinen --- Created attachment 146054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146054&action=edit Bug 16223: (QA follow-up) Fix kohastructure bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:44:38 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143769|0 |1 is obsolete| | --- Comment #73 from Emmi Takkinen --- Created attachment 146055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146055&action=edit Bug 16223: (QA follow-up) Remove GetDebarments We remove the GetDebarments routine in 31095. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:45:12 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143770|0 |1 is obsolete| | --- Comment #74 from Emmi Takkinen --- Created attachment 146056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146056&action=edit Bug 16223: (QA follow-up) Move trigger to apply This patch moves the del_restrictions_after_payment from before the actual credit application call inside Koha::Account::pay to after the application of credits to debits in Koha::Account::Line::apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 07:45:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 06:45:46 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143936|0 |1 is obsolete| | --- Comment #75 from Emmi Takkinen --- Created attachment 146057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146057&action=edit Bug 16223: Add correct value attributes to restriction options in select element Restrictions weren't lift after payment because value attributes for restrictions code were missing from restriction select element in patron-restrictions-tab.inc. Due this restrictions were always set as type "MANUAL". To test: 1. Add new restriction which has "Lift after payment?" set as Yes and fee limit as 5. 2. Create fees for a patron so they exceed fee limit e.g. 10 3. Add restriction made in step 1. for the patron 4. Pay patrons fees partially so that they go under fee limit => Note that patrons restriction should now be lifted. Also prove t/db_dependent/Patron/Borrower_Debarments.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:20:09 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:20:14 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146028|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 146058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146058&action=edit Bug 32793: import_patrons.pl typo in usage Typo fix to prevent confusion in CLI usage Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:20:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:20:37 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Pedro: Please fill the Assignee field ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:20:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:20:46 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:24:30 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:24:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:24:36 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146029|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 146059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146059&action=edit Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:24:58 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:26:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:26:17 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #24 from Marcel de Rooy --- * Commit title does not contain 'follow-up' correctly spelt - f8e52c1569 * Commit title does not contain '(QA follow-up)' correctly spelt - f8e52c1569 * Commit title does not contain 'follow-up' correctly spelt - 8df1eff282 * Commit title does not contain '(QA follow-up)' correctly spelt - 8df1eff282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:29:50 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #25 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:35:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:35:05 +0000 Subject: [Koha-bugs] [Bug 22872] payment_type handling is untested in Koha::Account->add_credit. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872 --- Comment #1 from Martin Renvoize --- I wonder if this is still the case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:35:41 +0000 Subject: [Koha-bugs] [Bug 22872] payment_type handling is untested in Koha::Account->add_credit. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22872 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:37:27 +0000 Subject: [Koha-bugs] [Bug 18496] Membership renewal fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18496 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Still planning to submit some code for this Amit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:41:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:41:11 +0000 Subject: [Koha-bugs] [Bug 20519] Credit amount in pay.pl should use the class="credit" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |martin.renvoize at ptfs-europe | |.com Component|Fines and fees |Staff interface --- Comment #1 from Martin Renvoize --- I feel like this may have been resolved now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:42:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:42:44 +0000 Subject: [Koha-bugs] [Bug 21916] Add ability to specify where credits are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:43:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:43:03 +0000 Subject: [Koha-bugs] [Bug 21916] Add ability to specify where credits are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Currently it is impossible to apply credits against debits in patron accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 08:43:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 07:43:03 +0000 Subject: [Koha-bugs] [Bug 18805] Currently it is impossible to apply credits against debits in patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 [Bug 21916] Add ability to specify where credits are used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:00:14 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:00:14 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:03:49 +0000 Subject: [Koha-bugs] [Bug 32810] New: Allow guarantor to pay guarantee's fines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 Bug ID: 32810 Summary: Allow guarantor to pay guarantee's fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: caroline.cyr-la-rose at inlibro.com, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 20849 We need to have the possibility to apply payments to guarantee's fines as a guarantor. - View guarantee's fees - Pay guarantee's fees - Use guarantors credit against guarantee's fees Like the checkouts and fines, this should be turned on in the guarantee's account. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20849 [Bug 20849] Add the ability on staff client to view all fines of a guarantee on the guarantor's account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:03:49 +0000 Subject: [Koha-bugs] [Bug 20849] Add the ability on staff client to view all fines of a guarantee on the guarantor's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20849 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 [Bug 32810] Allow guarantor to pay guarantee's fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:04:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:04:09 +0000 Subject: [Koha-bugs] [Bug 32810] Allow guarantor to pay guarantee's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 --- Comment #1 from Martin Renvoize --- We need this for both staff and opac interfaces I believe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:04:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:04:58 +0000 Subject: [Koha-bugs] [Bug 32810] Allow guarantor to pay guarantee's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 [Bug 21916] Add ability to specify where credits are used -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:04:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:04:58 +0000 Subject: [Koha-bugs] [Bug 21916] Add ability to specify where credits are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21916 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 [Bug 32810] Allow guarantor to pay guarantee's fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:10:53 +0000 Subject: [Koha-bugs] [Bug 32791] Log4perl configuration files need a tool for updating on package upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:16:30 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #5 from Katrin Fischer --- What I meant was the lines in the error output. The installer will usually tell you what updates were done and where the error occurred, the database update version, which is the third number, like i.e. 22.04.023, but may it differs when using the web installer and older versions. Without a table or anything as a clue, I have no idea what the duplicate key refers to. :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 09:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 08:42:46 +0000 Subject: [Koha-bugs] [Bug 27510] Download the report in HTML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #19 from Magnus Enger --- It looks like HTML::Table is packaged, at least in Debian 9.13: $ sudo apt-cache policy libhtml-table-perl libhtml-table-perl: Installert: (ingen) Kandidat: 2.08a-3 Versjonstabell: 2.08a-3 500 500 http://mirrors.linode.com/debian stretch/main amd64 Packages So what is needed here? - A test plan in the commit message - To add libhtml-table-perl to Koha's dpendencies Should adding the dep be part of the patch, or is that something the RM adds? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:18:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:18:00 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:51:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:51:02 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to the worker-error.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #26 from Marcel de Rooy --- Confirming that warns and Koha::Logger go to worker-output now. The start/stop statements end up in worker-error. Worker.log is not used. koha-worker does this: DAEMONOPTS="--name=${worker_name} \ --errlog=/var/log/koha/$name/worker-error.log \ --stdout=/var/log/koha/$name/worker.log \ --output=/var/log/koha/$name/worker-output.log \ Since --output includes stdout, it seems that the --stdout line is useless. The client stdout is formally included in --output. But it seems to be discarded anyway since we are running in the background. I tested print statements in background-worker and they go nowhere. Removed the worker.log line in a follow-up. Daemon docs says: -l spec, --errlog=spec Send daemon's standard output and error to the syslog destination or file specified by spec. If spec is of the form "facility.priority", then output is sent to syslog(3). Otherwise, output is appended to the file whose path is given in spec. By default, output is sent to daemon.err. -O spec, --stdout=spec Capture the client's standard output and send it to the syslog destination or file specified by spec. If spec is of the form "facility.priority", then output is sent to syslog(3). Otherwise, stdout is appended to the file whose path is given in spec. By default, stdout is discarded unless the --foreground option is present, in which case, the client's stdout is propagated to daemon's stdout. -o spec, --output=spec Capture the client's standard output and error and send it to the syslog destination or file specified by spec. If spec is of the form "facility.priority", then output is sent to syslog (3). Otherwise, output is appended to the file whose path is given in spec. By default, output is discarded unless the --foreground option is present. In this case, the client's stdout and stderr are propagated to daemon's stdout and stderr respectively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:51:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:51:35 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha background worker |Koha background worker |should log to the |should log to |worker-error.log |worker-error/output.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:54:51 +0000 Subject: [Koha-bugs] [Bug 32811] New: Remove unused indexer.log Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 Bug ID: 32811 Summary: Remove unused indexer.log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 32612. The daemon output option overrides here the stdout option. The indexer.log is not used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:56:53 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:56:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:56:57 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 --- Comment #1 from Marcel de Rooy --- Created attachment 146060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146060&action=edit Bug 32811: Remove useless lines for indexer.log See also bug 32612. The output option includes the stdout. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:58:35 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy --- Test plan: Restart koha-indexer. Or restart the container. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:58:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:58:52 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- Trivial. Self SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:07 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:07 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32811 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:45 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146025|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 146061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146061&action=edit Bug 32612: Add worker-error to log4perl conf To test: 1 - Apply patch 2 - vim /etc/koha/sites/kohadev/log4perl.conf, Add lines below: log4perl.logger.worker = WARN, WORKER log4perl.appender.WORKER=Log::Log4perl::Appender::Screen log4perl.appender.WORKER.stderr=1 log4perl.appender.WORKER.mode=append log4perl.appender.WORKER.layout=PatternLayout log4perl.appender.WORKER.layout.ConversionPattern=[%d] [%p] %m %l%n log4perl.appender.WORKER.utf8=1 3 - Restart all 4 - Edit misc/background_jobs_worker.pl - my $job = Koha::BackgroundJobs->find($args->{job_id}); + my $job;# = Koha::BackgroundJobs->find($args->{job_id}); 5 - In another terminal: tail -f /var/log/koha/kohadev/koha-worker-error.log 6 - Force enqueue a job (that won't be found because of #4 perl -e 'use Koha::BackgroundJob::BatchUpdateItem; my $bg = Koha::BackgroundJob::BatchUpdateItem->new(); $bg->enqueue({ record_ids=>['888888']});' 7 - Note error in log like: [2023/01/11 19:26:10] [WARN] No job found for id=2983 main:: /kohadevbox/koha/misc/background_jobs_worker.pl (111) Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:49 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #28 from Marcel de Rooy --- Created attachment 146062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146062&action=edit Bug 32612: (QA follow-up) Remove superfluous line Signed-off-by: Kyle M Hall Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:54 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #29 from Marcel de Rooy --- Created attachment 146063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146063&action=edit Bug 32612: (QA follow-up) Update package files Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 10:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 09:59:59 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #30 from Marcel de Rooy --- Created attachment 146064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146064&action=edit Bug 32612: (QA follow-up) Remove more unneeded appender lines To be more consistent ;) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:00:04 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #31 from Marcel de Rooy --- Created attachment 146065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146065&action=edit Bug 32612: (QA follow-up) Remove worker.log It is not used; overruled by daemon's --output option. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:00:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:00:10 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #32 from Marcel de Rooy --- Created attachment 146066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146066&action=edit Bug 32612: (QA follow-up) Add missing interface for Logger Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:00:40 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:00:43 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146027|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:01:01 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:10:01 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #33 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:20:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:20:26 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #34 from Marcel de Rooy --- +Max processes will be set from the command line option, the environment variable MAX_PROCESSES, or the koha-conf file, in that order of precedence. +By default the script will only run one job at a time. I think this is not needed. Confusing too. It is already simpler if we remove the koha-conf option here. I would opt for commandline option or default 1. Setting MAX_PROCESSES or --max_processes is the same amount of work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:21:30 +0000 Subject: [Koha-bugs] [Bug 32700] Action logs logging should be divided into smaller components to reduce table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32700 --- Comment #1 from Lari Strand --- At least we should only log the changes made to biblios and items when they have been modified. In 21.11 modifying a biblio only logged all the biblio data before the modification. On item modification only the whole item with new item data is logged. This should be fixed so that only the old value and the changed new value/values gets logged. This would reduce data that is logged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:28:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:28:10 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #35 from Marcel de Rooy --- Not sure (yet) but should the default not be zero? Just do not fork like we currently do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:31:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:31:40 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #36 from Marcel de Rooy --- Theoretical add a wait_all_children: diff --git a/misc/background_jobs_worker.pl b/misc/background_jobs_worker.pl index 1b2d6309d9..89f51042cf 100755 --- a/misc/background_jobs_worker.pl +++ b/misc/background_jobs_worker.pl @@ -156,6 +156,7 @@ while (1) { sleep 10; } } +$pm->wait_all_children; $conn->disconnect; sub process_job { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:32:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:32:09 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #37 from Marcel de Rooy --- Changing status to reflect need for feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:32:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:32:35 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #38 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #34) > +Max processes will be set from the command line option, the environment > variable MAX_PROCESSES, or the koha-conf file, in that order of precedence. > +By default the script will only run one job at a time. > > I think this is not needed. Confusing too. > It is already simpler if we remove the koha-conf option here. > I would opt for commandline option or default 1. Setting MAX_PROCESSES or > --max_processes is the same amount of work? default 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:41:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:41:11 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:41:15 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146012|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 146067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146067&action=edit Bug 32787: Patron restrictions admin page has patron categories search bar This patch updates the patron restriction administration page to correct the markup around the header and breadcrumbs: Using the header WRAPPER, using the sub-header WRAPPER, and switching to the system preferences search bar. The patch also corrects the page title to prevent a leading "rsaquo;" in some cases. Note: This patch contains indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Patron restrictions. The system preferences search should be preselected in the header search bar, and everything should look correct. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:41:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:41:31 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:43:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:43:48 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 873a0a1178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:44:30 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:44:34 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145993|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 146068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146068&action=edit Bug 32785: Typo: Maximum number of simultaneus pickups per interval (curbside pickups) This patch corrects a small typo in the curbside pickup administration page. To test: 1. Apply patch 2. Enable the CurbsidePickup system preferences 3. Go to Administration > Curbside pickup --> Next to Maximum patrons per interval, the tip should be "Maximum number of simultaneous pickups per interval" Signed-off-by: Matt Blenkinsop Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:44:56 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:48:13 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:48:17 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145990|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 146069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146069&action=edit Bug 32673: Remove misc/load_testing/ scripts see comment 0 for more info Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:48:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:48:49 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:53:25 +0000 Subject: [Koha-bugs] [Bug 32663] Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- `streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your patron/borrower''s primary address', Are we going the right direction here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 11:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 10:53:37 +0000 Subject: [Koha-bugs] [Bug 32663] Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:11:13 +0000 Subject: [Koha-bugs] [Bug 32812] New: Fix cataloguing/value_builder/barcode_manual.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 Bug ID: 32812 Summary: Fix cataloguing/value_builder/barcode_manual.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:11:13 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 [Bug 32812] Fix cataloguing/value_builder/barcode_manual.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:12:08 +0000 Subject: [Koha-bugs] [Bug 32812] Fix cataloguing/value_builder/barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 --- Comment #1 from Julian Maurice --- Created attachment 146070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146070&action=edit Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:12:23 +0000 Subject: [Koha-bugs] [Bug 32812] Fix cataloguing/value_builder/barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:13:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:13:43 +0000 Subject: [Koha-bugs] [Bug 32813] New: Fix cataloguing/value_builder/barcode.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 Bug ID: 32813 Summary: Fix cataloguing/value_builder/barcode.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:13:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:13:43 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 [Bug 32813] Fix cataloguing/value_builder/barcode.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:14:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:14:17 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 --- Comment #1 from Julian Maurice --- Created attachment 146071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146071&action=edit Bug 32813: Fix cataloguing/value_builder/barcode.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:14:28 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:15:53 +0000 Subject: [Koha-bugs] [Bug 32814] New: Fix cataloguing/value_builder/callnumber-KU.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 Bug ID: 32814 Summary: Fix cataloguing/value_builder/callnumber-KU.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:15:53 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:16:30 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 --- Comment #1 from Julian Maurice --- Created attachment 146072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146072&action=edit Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:16:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:16:41 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:17:32 +0000 Subject: [Koha-bugs] [Bug 32815] New: Fix cataloguing/value_builder/callnumber.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 Bug ID: 32815 Summary: Fix cataloguing/value_builder/callnumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:17:32 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 [Bug 32815] Fix cataloguing/value_builder/callnumber.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:18:06 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 --- Comment #1 from Julian Maurice --- Created attachment 146073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146073&action=edit Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:18:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:18:18 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:19:45 +0000 Subject: [Koha-bugs] [Bug 32816] New: Fix cataloguing/value_builder/cn_browser.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 Bug ID: 32816 Summary: Fix cataloguing/value_builder/cn_browser.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:19:45 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:20:17 +0000 Subject: [Koha-bugs] [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 --- Comment #1 from Julian Maurice --- Created attachment 146074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146074&action=edit Bug 32816: Fix cataloguing/value_builder/cn_browser.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:20:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:20:33 +0000 Subject: [Koha-bugs] [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:22:49 +0000 Subject: [Koha-bugs] [Bug 32817] New: Fix cataloguing/value_builder/dateaccessioned.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Bug ID: 32817 Summary: Fix cataloguing/value_builder/dateaccessioned.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:22:49 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:23:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:23:19 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #1 from Julian Maurice --- Created attachment 146075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146075&action=edit Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:23:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:23:30 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:26:37 +0000 Subject: [Koha-bugs] [Bug 32818] New: Fix cataloguing/value_builder/marc21_field_005.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Bug ID: 32818 Summary: Fix cataloguing/value_builder/marc21_field_005.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:26:37 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 [Bug 32818] Fix cataloguing/value_builder/marc21_field_005.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:27:14 +0000 Subject: [Koha-bugs] [Bug 32818] Fix cataloguing/value_builder/marc21_field_005.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 --- Comment #1 from Julian Maurice --- Created attachment 146076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146076&action=edit Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Remove unnecessary return statement This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:27:27 +0000 Subject: [Koha-bugs] [Bug 32818] Fix cataloguing/value_builder/marc21_field_005.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:41:00 +0000 Subject: [Koha-bugs] [Bug 32819] New: Fix cataloguing/value_builder/stocknumberam123.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 Bug ID: 32819 Summary: Fix cataloguing/value_builder/stocknumberam123.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:41:00 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 [Bug 32819] Fix cataloguing/value_builder/stocknumberam123.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:42:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:42:03 +0000 Subject: [Koha-bugs] [Bug 32819] Fix cataloguing/value_builder/stocknumberam123.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 --- Comment #1 from Julian Maurice --- Created attachment 146077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146077&action=edit Bug 32819: Fix cataloguing/value_builder/stocknumberam123.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:42:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:42:18 +0000 Subject: [Koha-bugs] [Bug 32819] Fix cataloguing/value_builder/stocknumberam123.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:43:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:43:06 +0000 Subject: [Koha-bugs] [Bug 32820] New: Fix cataloguing/value_builder/stocknumberAV.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 Bug ID: 32820 Summary: Fix cataloguing/value_builder/stocknumberAV.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:43:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:43:06 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 [Bug 32820] Fix cataloguing/value_builder/stocknumberAV.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:43:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:43:48 +0000 Subject: [Koha-bugs] [Bug 32820] Fix cataloguing/value_builder/stocknumberAV.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 --- Comment #1 from Julian Maurice --- Created attachment 146078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146078&action=edit Bug 32820: Fix cataloguing/value_builder/stocknumberAV.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:44:13 +0000 Subject: [Koha-bugs] [Bug 32820] Fix cataloguing/value_builder/stocknumberAV.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:45:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:45:08 +0000 Subject: [Koha-bugs] [Bug 32821] New: Fix cataloguing/value_builder/stocknumber.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 Bug ID: 32821 Summary: Fix cataloguing/value_builder/stocknumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:45:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:45:08 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:45:54 +0000 Subject: [Koha-bugs] [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 --- Comment #1 from Julian Maurice --- Created attachment 146079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146079&action=edit Bug 32821: Fix cataloguing/value_builder/stocknumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:46:04 +0000 Subject: [Koha-bugs] [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:47:06 +0000 Subject: [Koha-bugs] [Bug 32822] New: Fix cataloguing/value_builder/unimarc_field_010.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 Bug ID: 32822 Summary: Fix cataloguing/value_builder/unimarc_field_010.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:47:06 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 [Bug 32822] Fix cataloguing/value_builder/unimarc_field_010.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:47:38 +0000 Subject: [Koha-bugs] [Bug 32822] Fix cataloguing/value_builder/unimarc_field_010.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 --- Comment #1 from Julian Maurice --- Created attachment 146080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146080&action=edit Bug 32822: Fix cataloguing/value_builder/unimarc_field_010.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:47:49 +0000 Subject: [Koha-bugs] [Bug 32822] Fix cataloguing/value_builder/unimarc_field_010.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:48:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:48:43 +0000 Subject: [Koha-bugs] [Bug 32823] New: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 Bug ID: 32823 Summary: Fix cataloguing/value_builder/unimarc_field_100_authoritie s.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 12:48:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 11:48:43 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 [Bug 32823] Fix cataloguing/value_builder/unimarc_field_100_authorities.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:15:02 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:40:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:40:43 +0000 Subject: [Koha-bugs] [Bug 32823] Fix cataloguing/value_builder/unimarc_field_100_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 --- Comment #1 from Julian Maurice --- Created attachment 146081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146081&action=edit Bug 32823: Fix cataloguing/value_builder/unimarc_field_100_authorities.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:40:47 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #2 from Michaela Sieber --- (In reply to Jonathan Druart from comment #1) > > We could discuss the display of the prices here, I've decided to format > them but they are not accurate to the currency. We cannot do better for > now as we are not storing the format along with the currency. > We would prefer unitprice and currency code (not symbol) [% order.invoice_unitprice | currency => order.invoice_currency %] Exemplar: 52.33 EUR 876.42 USD 69.38 CAD ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:40:56 +0000 Subject: [Koha-bugs] [Bug 32823] Fix cataloguing/value_builder/unimarc_field_100_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:41:32 +0000 Subject: [Koha-bugs] [Bug 32824] New: Fix cataloguing/value_builder/unimarc_field_100.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32824 Bug ID: 32824 Summary: Fix cataloguing/value_builder/unimarc_field_100.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:41:32 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32824 [Bug 32824] Fix cataloguing/value_builder/unimarc_field_100.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:14 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145906|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 146082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146082&action=edit Bug 25655: DB changes Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:16 +0000 Subject: [Koha-bugs] [Bug 32824] Fix cataloguing/value_builder/unimarc_field_100.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32824 --- Comment #1 from Julian Maurice --- Created attachment 146083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146083&action=edit Bug 32824: Fix cataloguing/value_builder/unimarc_field_100.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:19 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145907|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 146084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146084&action=edit Bug 25655: DBIC changes Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:23 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145908|0 |1 is obsolete| | --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 146085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146085&action=edit Bug 25655: REST API specs Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:25 +0000 Subject: [Koha-bugs] [Bug 32824] Fix cataloguing/value_builder/unimarc_field_100.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32824 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:28 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145909|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 146086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146086&action=edit Bug 25655: Store actual cost in foreign currency and currency from the invoice Bug 24158 allows to calculate the actual cost on time of receive from a foreign currency. This new enhancement is storing the price and the currency in database, into two new columns invoice_unitprice an invoice_currency Test plan: Create a new order with several items to receive Receive one or more items, and tick "change currency" on the order receive page Select a currency and finish the receiving In DB notice that the price and the currency have been stored. Receive remaining items and confirm that the form is prefilled with previous price and currency Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:32 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145910|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes --- Created attachment 146087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146087&action=edit Bug 25655: Save values from ModOrderReceive Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:36 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145911|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes --- Created attachment 146088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146088&action=edit Bug 25655: Select currency and prefill unitprice with previous receipt In case of partial order we want to prefill the unit price and the currency with the value of the previous receipt. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:40 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145912|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes --- Created attachment 146089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146089&action=edit Bug 25655: Add tests And fix a bug they caught. We need to undef if a modification is made and invoice_currency is removed. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:42:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:42:44 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:43:24 +0000 Subject: [Koha-bugs] [Bug 32825] New: Fix cataloguing/value_builder/unimarc_field_105.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 Bug ID: 32825 Summary: Fix cataloguing/value_builder/unimarc_field_105.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:43:24 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 [Bug 32825] Fix cataloguing/value_builder/unimarc_field_105.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:43:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:43:55 +0000 Subject: [Koha-bugs] [Bug 32825] Fix cataloguing/value_builder/unimarc_field_105.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 --- Comment #1 from Julian Maurice --- Created attachment 146090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146090&action=edit Bug 32825: Fix cataloguing/value_builder/unimarc_field_105.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:44:04 +0000 Subject: [Koha-bugs] [Bug 32825] Fix cataloguing/value_builder/unimarc_field_105.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:44:58 +0000 Subject: [Koha-bugs] [Bug 32826] New: Fix cataloguing/value_builder/unimarc_field_106.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32826 Bug ID: 32826 Summary: Fix cataloguing/value_builder/unimarc_field_106.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:44:58 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32826 [Bug 32826] Fix cataloguing/value_builder/unimarc_field_106.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:45:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:45:40 +0000 Subject: [Koha-bugs] [Bug 32826] Fix cataloguing/value_builder/unimarc_field_106.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32826 --- Comment #1 from Julian Maurice --- Created attachment 146091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146091&action=edit Bug 32826: Fix cataloguing/value_builder/unimarc_field_106.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:45:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:45:50 +0000 Subject: [Koha-bugs] [Bug 32826] Fix cataloguing/value_builder/unimarc_field_106.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32826 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:46:35 +0000 Subject: [Koha-bugs] [Bug 32827] New: Fix cataloguing/value_builder/unimarc_field_110.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 Bug ID: 32827 Summary: Fix cataloguing/value_builder/unimarc_field_110.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:46:35 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 [Bug 32827] Fix cataloguing/value_builder/unimarc_field_110.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:47:09 +0000 Subject: [Koha-bugs] [Bug 32827] Fix cataloguing/value_builder/unimarc_field_110.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 --- Comment #1 from Julian Maurice --- Created attachment 146092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146092&action=edit Bug 32827: Fix cataloguing/value_builder/unimarc_field_110.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:47:20 +0000 Subject: [Koha-bugs] [Bug 32827] Fix cataloguing/value_builder/unimarc_field_110.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:48:24 +0000 Subject: [Koha-bugs] [Bug 32828] New: Fix cataloguing/value_builder/unimarc_field_115a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 Bug ID: 32828 Summary: Fix cataloguing/value_builder/unimarc_field_115a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:48:24 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 [Bug 32828] Fix cataloguing/value_builder/unimarc_field_115a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:48:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:48:56 +0000 Subject: [Koha-bugs] [Bug 32828] Fix cataloguing/value_builder/unimarc_field_115a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 --- Comment #1 from Julian Maurice --- Created attachment 146093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146093&action=edit Bug 32828: Fix cataloguing/value_builder/unimarc_field_115a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:49:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:49:23 +0000 Subject: [Koha-bugs] [Bug 32828] Fix cataloguing/value_builder/unimarc_field_115a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:50:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:50:07 +0000 Subject: [Koha-bugs] [Bug 32829] New: Fix cataloguing/value_builder/unimarc_field_115b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 Bug ID: 32829 Summary: Fix cataloguing/value_builder/unimarc_field_115b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:50:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:50:07 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 [Bug 32829] Fix cataloguing/value_builder/unimarc_field_115b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:50:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:50:55 +0000 Subject: [Koha-bugs] [Bug 32829] Fix cataloguing/value_builder/unimarc_field_115b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 --- Comment #1 from Julian Maurice --- Created attachment 146094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146094&action=edit Bug 32829: Fix cataloguing/value_builder/unimarc_field_115b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:51:07 +0000 Subject: [Koha-bugs] [Bug 32829] Fix cataloguing/value_builder/unimarc_field_115b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:51:44 +0000 Subject: [Koha-bugs] [Bug 32830] New: Fix cataloguing/value_builder/unimarc_field_116.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 Bug ID: 32830 Summary: Fix cataloguing/value_builder/unimarc_field_116.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:51:44 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:52:16 +0000 Subject: [Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 --- Comment #1 from Julian Maurice --- Created attachment 146095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146095&action=edit Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:52:26 +0000 Subject: [Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:53:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:53:36 +0000 Subject: [Koha-bugs] [Bug 32831] New: Fix cataloguing/value_builder/unimarc_field_117.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 Bug ID: 32831 Summary: Fix cataloguing/value_builder/unimarc_field_117.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:53:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:53:36 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:54:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:54:15 +0000 Subject: [Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 --- Comment #1 from Julian Maurice --- Created attachment 146096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146096&action=edit Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:54:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:54:24 +0000 Subject: [Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:54:48 +0000 Subject: [Koha-bugs] [Bug 32832] New: Fix cataloguing/value_builder/unimarc_field_120.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 Bug ID: 32832 Summary: Fix cataloguing/value_builder/unimarc_field_120.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:54:48 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:55:37 +0000 Subject: [Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 --- Comment #1 from Julian Maurice --- Created attachment 146097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146097&action=edit Bug 32832: Fix cataloguing/value_builder/unimarc_field_120.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:55:47 +0000 Subject: [Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:57:01 +0000 Subject: [Koha-bugs] [Bug 32833] New: Fix cataloguing/value_builder/unimarc_field_121a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 Bug ID: 32833 Summary: Fix cataloguing/value_builder/unimarc_field_121a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:57:01 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:57:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:57:36 +0000 Subject: [Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 --- Comment #1 from Julian Maurice --- Created attachment 146098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146098&action=edit Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:57:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:57:46 +0000 Subject: [Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:58:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:58:32 +0000 Subject: [Koha-bugs] [Bug 32834] New: Fix cataloguing/value_builder/unimarc_field_121b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 Bug ID: 32834 Summary: Fix cataloguing/value_builder/unimarc_field_121b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:58:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:58:32 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:59:07 +0000 Subject: [Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 --- Comment #1 from Julian Maurice --- Created attachment 146099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146099&action=edit Bug 32834: Fix cataloguing/value_builder/unimarc_field_121b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 13:59:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 12:59:19 +0000 Subject: [Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:00:13 +0000 Subject: [Koha-bugs] [Bug 32835] New: Fix cataloguing/value_builder/unimarc_field_122.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 Bug ID: 32835 Summary: Fix cataloguing/value_builder/unimarc_field_122.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:00:13 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 [Bug 32835] Fix cataloguing/value_builder/unimarc_field_122.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:00:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:00:44 +0000 Subject: [Koha-bugs] [Bug 32835] Fix cataloguing/value_builder/unimarc_field_122.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 --- Comment #1 from Julian Maurice --- Created attachment 146100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146100&action=edit Bug 32835: Fix cataloguing/value_builder/unimarc_field_122.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:00:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:00:54 +0000 Subject: [Koha-bugs] [Bug 32835] Fix cataloguing/value_builder/unimarc_field_122.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:01:26 +0000 Subject: [Koha-bugs] [Bug 32836] New: Fix cataloguing/value_builder/unimarc_field_123a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 Bug ID: 32836 Summary: Fix cataloguing/value_builder/unimarc_field_123a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:01:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:01:26 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:03:10 +0000 Subject: [Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 --- Comment #1 from Julian Maurice --- Created attachment 146101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146101&action=edit Bug 32836: Fix cataloguing/value_builder/unimarc_field_123a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:03:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:03:19 +0000 Subject: [Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:03:43 +0000 Subject: [Koha-bugs] [Bug 32837] New: Fix cataloguing/value_builder/unimarc_field_123d.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 Bug ID: 32837 Summary: Fix cataloguing/value_builder/unimarc_field_123d.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:03:43 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:04:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:04:11 +0000 Subject: [Koha-bugs] [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 --- Comment #1 from Julian Maurice --- Created attachment 146102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146102&action=edit Bug 32837: Fix cataloguing/value_builder/unimarc_field_123d.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:04:20 +0000 Subject: [Koha-bugs] [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:05:11 +0000 Subject: [Koha-bugs] [Bug 32838] New: Fix cataloguing/value_builder/unimarc_field_123e.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 Bug ID: 32838 Summary: Fix cataloguing/value_builder/unimarc_field_123e.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:05:11 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 [Bug 32838] Fix cataloguing/value_builder/unimarc_field_123e.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:05:42 +0000 Subject: [Koha-bugs] [Bug 32838] Fix cataloguing/value_builder/unimarc_field_123e.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 --- Comment #1 from Julian Maurice --- Created attachment 146103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146103&action=edit Bug 32838: Fix cataloguing/value_builder/unimarc_field_123e.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:05:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:05:52 +0000 Subject: [Koha-bugs] [Bug 32838] Fix cataloguing/value_builder/unimarc_field_123e.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:06:12 +0000 Subject: [Koha-bugs] [Bug 32839] New: Fix cataloguing/value_builder/unimarc_field_123f.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 Bug ID: 32839 Summary: Fix cataloguing/value_builder/unimarc_field_123f.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:06:12 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:06:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:06:50 +0000 Subject: [Koha-bugs] [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 --- Comment #1 from Julian Maurice --- Created attachment 146104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146104&action=edit Bug 32839: Fix cataloguing/value_builder/unimarc_field_123f.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:07:05 +0000 Subject: [Koha-bugs] [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:07:44 +0000 Subject: [Koha-bugs] [Bug 32840] New: Fix cataloguing/value_builder/unimarc_field_123g.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 Bug ID: 32840 Summary: Fix cataloguing/value_builder/unimarc_field_123g.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:07:44 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 [Bug 32840] Fix cataloguing/value_builder/unimarc_field_123g.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:08:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:08:16 +0000 Subject: [Koha-bugs] [Bug 32840] Fix cataloguing/value_builder/unimarc_field_123g.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 --- Comment #1 from Julian Maurice --- Created attachment 146105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146105&action=edit Bug 32840: Fix cataloguing/value_builder/unimarc_field_123g.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:08:28 +0000 Subject: [Koha-bugs] [Bug 32840] Fix cataloguing/value_builder/unimarc_field_123g.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:08:52 +0000 Subject: [Koha-bugs] [Bug 32841] New: Fix cataloguing/value_builder/unimarc_field_123i.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 Bug ID: 32841 Summary: Fix cataloguing/value_builder/unimarc_field_123i.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:08:52 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:09:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:09:25 +0000 Subject: [Koha-bugs] [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 --- Comment #1 from Julian Maurice --- Created attachment 146106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146106&action=edit Bug 32841: Fix cataloguing/value_builder/unimarc_field_123i.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:09:34 +0000 Subject: [Koha-bugs] [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:10:04 +0000 Subject: [Koha-bugs] [Bug 32842] New: Fix cataloguing/value_builder/unimarc_field_123j.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 Bug ID: 32842 Summary: Fix cataloguing/value_builder/unimarc_field_123j.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:10:04 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 [Bug 32842] Fix cataloguing/value_builder/unimarc_field_123j.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:10:49 +0000 Subject: [Koha-bugs] [Bug 32842] Fix cataloguing/value_builder/unimarc_field_123j.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 --- Comment #1 from Julian Maurice --- Created attachment 146107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146107&action=edit Bug 32842: Fix cataloguing/value_builder/unimarc_field_123j.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:11:13 +0000 Subject: [Koha-bugs] [Bug 32842] Fix cataloguing/value_builder/unimarc_field_123j.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:11:34 +0000 Subject: [Koha-bugs] [Bug 32843] New: Fix cataloguing/value_builder/unimarc_field_124a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 Bug ID: 32843 Summary: Fix cataloguing/value_builder/unimarc_field_124a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:11:34 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:12:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:12:06 +0000 Subject: [Koha-bugs] [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 --- Comment #1 from Julian Maurice --- Created attachment 146108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146108&action=edit Bug 32843: Fix cataloguing/value_builder/unimarc_field_124a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:12:17 +0000 Subject: [Koha-bugs] [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:13:01 +0000 Subject: [Koha-bugs] [Bug 32844] New: Fix cataloguing/value_builder/unimarc_field_124b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 Bug ID: 32844 Summary: Fix cataloguing/value_builder/unimarc_field_124b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:13:01 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 [Bug 32844] Fix cataloguing/value_builder/unimarc_field_124b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:13:39 +0000 Subject: [Koha-bugs] [Bug 32844] Fix cataloguing/value_builder/unimarc_field_124b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 --- Comment #1 from Julian Maurice --- Created attachment 146109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146109&action=edit Bug 32844: Fix cataloguing/value_builder/unimarc_field_124b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:13:50 +0000 Subject: [Koha-bugs] [Bug 32844] Fix cataloguing/value_builder/unimarc_field_124b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:14:27 +0000 Subject: [Koha-bugs] [Bug 32845] New: Fix cataloguing/value_builder/unimarc_field_124c.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 Bug ID: 32845 Summary: Fix cataloguing/value_builder/unimarc_field_124c.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:14:27 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:14:56 +0000 Subject: [Koha-bugs] [Bug 32676] EDI message status uses varying case, breaking EDI status block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32676 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #6 from Tomás Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:15:14 +0000 Subject: [Koha-bugs] [Bug 32700] Action logs logging should be divided into smaller components to reduce table size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32700 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:15:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:15:56 +0000 Subject: [Koha-bugs] [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 --- Comment #1 from Julian Maurice --- Created attachment 146110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146110&action=edit Bug 32845: Fix cataloguing/value_builder/unimarc_field_124c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:16:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:16:12 +0000 Subject: [Koha-bugs] [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:16:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:16:54 +0000 Subject: [Koha-bugs] [Bug 32846] New: Fix cataloguing/value_builder/unimarc_field_124d.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 Bug ID: 32846 Summary: Fix cataloguing/value_builder/unimarc_field_124d.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:16:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:16:54 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 [Bug 32846] Fix cataloguing/value_builder/unimarc_field_124d.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:17:25 +0000 Subject: [Koha-bugs] [Bug 32846] Fix cataloguing/value_builder/unimarc_field_124d.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 --- Comment #1 from Julian Maurice --- Created attachment 146111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146111&action=edit Bug 32846: Fix cataloguing/value_builder/unimarc_field_124d.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:17:25 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- LOL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:17:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:17:35 +0000 Subject: [Koha-bugs] [Bug 32846] Fix cataloguing/value_builder/unimarc_field_124d.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:17:55 +0000 Subject: [Koha-bugs] [Bug 32847] New: Fix cataloguing/value_builder/unimarc_field_124e.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 Bug ID: 32847 Summary: Fix cataloguing/value_builder/unimarc_field_124e.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:17:55 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:18:36 +0000 Subject: [Koha-bugs] [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 --- Comment #1 from Julian Maurice --- Created attachment 146112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146112&action=edit Bug 32847: Fix cataloguing/value_builder/unimarc_field_124e.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:18:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:18:44 +0000 Subject: [Koha-bugs] [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:19:46 +0000 Subject: [Koha-bugs] [Bug 32848] New: Fix cataloguing/value_builder/unimarc_field_124f.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 Bug ID: 32848 Summary: Fix cataloguing/value_builder/unimarc_field_124f.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:19:46 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 [Bug 32848] Fix cataloguing/value_builder/unimarc_field_124f.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:20:21 +0000 Subject: [Koha-bugs] [Bug 32848] Fix cataloguing/value_builder/unimarc_field_124f.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 --- Comment #1 from Julian Maurice --- Created attachment 146113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146113&action=edit Bug 32848: Fix cataloguing/value_builder/unimarc_field_124f.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:20:30 +0000 Subject: [Koha-bugs] [Bug 32848] Fix cataloguing/value_builder/unimarc_field_124f.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:22:49 +0000 Subject: [Koha-bugs] [Bug 32849] New: Fix cataloguing/value_builder/unimarc_field_124g.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 Bug ID: 32849 Summary: Fix cataloguing/value_builder/unimarc_field_124g.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:22:49 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:23:27 +0000 Subject: [Koha-bugs] [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 --- Comment #1 from Julian Maurice --- Created attachment 146114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146114&action=edit Bug 32849: Fix cataloguing/value_builder/unimarc_field_124g.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:23:40 +0000 Subject: [Koha-bugs] [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:24:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:24:06 +0000 Subject: [Koha-bugs] [Bug 32850] New: Fix cataloguing/value_builder/unimarc_field_124.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Bug ID: 32850 Summary: Fix cataloguing/value_builder/unimarc_field_124.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:24:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:24:06 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:24:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:24:44 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 --- Comment #1 from Julian Maurice --- Created attachment 146115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146115&action=edit Bug 32850: Fix cataloguing/value_builder/unimarc_field_124.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:24:55 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:25:15 +0000 Subject: [Koha-bugs] [Bug 32851] New: Fix cataloguing/value_builder/unimarc_field_125a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 Bug ID: 32851 Summary: Fix cataloguing/value_builder/unimarc_field_125a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:25:15 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:25:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:25:45 +0000 Subject: [Koha-bugs] [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 --- Comment #1 from Julian Maurice --- Created attachment 146116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146116&action=edit Bug 32851: Fix cataloguing/value_builder/unimarc_field_125a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:25:58 +0000 Subject: [Koha-bugs] [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:26:24 +0000 Subject: [Koha-bugs] [Bug 32852] New: Fix cataloguing/value_builder/unimarc_field_125b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 Bug ID: 32852 Summary: Fix cataloguing/value_builder/unimarc_field_125b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:26:24 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 [Bug 32852] Fix cataloguing/value_builder/unimarc_field_125b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:26:48 +0000 Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Pablo AB from comment #14) > Upgrade to 21.11.15.001 [12:03:24]: Bug 32330 - Add indexes to > background_jobs table > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Key column > 'queue' doesn't exist in table at /usr/share/koha/lib/C4/Installer.pm line > 739 > > queue is not present on background_jobs on 21.11: > https://schema.koha-community.org/21_11/tables/background_jobs.html > > There is a workaround? We just released a hot-fix 21.11.17. Thanks for reporting it. > This reveals a QA flaw? This patch was intended for 22.11 and 22.05, probably a communication problem. Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:26:58 +0000 Subject: [Koha-bugs] [Bug 32852] Fix cataloguing/value_builder/unimarc_field_125b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 --- Comment #1 from Julian Maurice --- Created attachment 146117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146117&action=edit Bug 32852: Fix cataloguing/value_builder/unimarc_field_125b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:27:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:27:10 +0000 Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330 --- Comment #17 from Tomás Cohen Arazi --- Reverted the 'queue' portion of this dev, on 21.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:27:11 +0000 Subject: [Koha-bugs] [Bug 32852] Fix cataloguing/value_builder/unimarc_field_125b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:27:29 +0000 Subject: [Koha-bugs] [Bug 32853] New: Fix cataloguing/value_builder/unimarc_field_125.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Bug ID: 32853 Summary: Fix cataloguing/value_builder/unimarc_field_125.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:27:29 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:28:04 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 --- Comment #1 from Julian Maurice --- Created attachment 146118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146118&action=edit Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:28:22 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:28:53 +0000 Subject: [Koha-bugs] [Bug 32854] New: Fix cataloguing/value_builder/unimarc_field_126a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 Bug ID: 32854 Summary: Fix cataloguing/value_builder/unimarc_field_126a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:28:53 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 [Bug 32854] Fix cataloguing/value_builder/unimarc_field_126a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:29:25 +0000 Subject: [Koha-bugs] [Bug 32854] Fix cataloguing/value_builder/unimarc_field_126a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 --- Comment #1 from Julian Maurice --- Created attachment 146119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146119&action=edit Bug 32854: Fix cataloguing/value_builder/unimarc_field_126a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:29:36 +0000 Subject: [Koha-bugs] [Bug 32854] Fix cataloguing/value_builder/unimarc_field_126a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:29:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:29:38 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #15 from Tomás Cohen Arazi --- What y'all think about moving the column into an ENUM type? I can do it, and willing to push this ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:31:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:31:23 +0000 Subject: [Koha-bugs] [Bug 32855] New: Fix cataloguing/value_builder/unimarc_field_126b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 Bug ID: 32855 Summary: Fix cataloguing/value_builder/unimarc_field_126b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:31:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:31:23 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:31:56 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:00 +0000 Subject: [Koha-bugs] [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 --- Comment #1 from Julian Maurice --- Created attachment 146120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146120&action=edit Bug 32855: Fix cataloguing/value_builder/unimarc_field_126b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:17 +0000 Subject: [Koha-bugs] [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:31 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:34 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:36 +0000 Subject: [Koha-bugs] [Bug 32856] New: Fix cataloguing/value_builder/unimarc_field_126.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Bug ID: 32856 Summary: Fix cataloguing/value_builder/unimarc_field_126.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:36 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:37 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:40 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #34 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:43 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:46 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:50 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:53 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:55 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:32:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:32:58 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #33 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:01 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:05 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:08 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:12 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:15 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:18 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:21 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:24 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:26 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:29 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:32 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:35 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:46 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 --- Comment #1 from Julian Maurice --- Created attachment 146121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146121&action=edit Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:33:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:33:56 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:34:23 +0000 Subject: [Koha-bugs] [Bug 32857] New: Fix cataloguing/value_builder/unimarc_field_127.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 Bug ID: 32857 Summary: Fix cataloguing/value_builder/unimarc_field_127.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:34:23 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:34:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:34:55 +0000 Subject: [Koha-bugs] [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 --- Comment #1 from Julian Maurice --- Created attachment 146122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146122&action=edit Bug 32857: Fix cataloguing/value_builder/unimarc_field_127.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:35:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:35:06 +0000 Subject: [Koha-bugs] [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:35:31 +0000 Subject: [Koha-bugs] [Bug 32858] New: Fix cataloguing/value_builder/unimarc_field_128a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 Bug ID: 32858 Summary: Fix cataloguing/value_builder/unimarc_field_128a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:35:31 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 [Bug 32858] Fix cataloguing/value_builder/unimarc_field_128a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:36:05 +0000 Subject: [Koha-bugs] [Bug 32858] Fix cataloguing/value_builder/unimarc_field_128a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 --- Comment #1 from Julian Maurice --- Created attachment 146123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146123&action=edit Bug 32858: Fix cataloguing/value_builder/unimarc_field_128a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:36:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:36:17 +0000 Subject: [Koha-bugs] [Bug 32858] Fix cataloguing/value_builder/unimarc_field_128a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:36:39 +0000 Subject: [Koha-bugs] [Bug 32859] New: Fix cataloguing/value_builder/unimarc_field_128b.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 Bug ID: 32859 Summary: Fix cataloguing/value_builder/unimarc_field_128b.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:36:39 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:37:14 +0000 Subject: [Koha-bugs] [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 --- Comment #1 from Julian Maurice --- Created attachment 146124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146124&action=edit Bug 32859: Fix cataloguing/value_builder/unimarc_field_128b.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:37:26 +0000 Subject: [Koha-bugs] [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:37:48 +0000 Subject: [Koha-bugs] [Bug 32860] New: Fix cataloguing/value_builder/unimarc_field_128c.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 Bug ID: 32860 Summary: Fix cataloguing/value_builder/unimarc_field_128c.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:37:48 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 [Bug 32860] Fix cataloguing/value_builder/unimarc_field_128c.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:38:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:38:19 +0000 Subject: [Koha-bugs] [Bug 32860] Fix cataloguing/value_builder/unimarc_field_128c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 --- Comment #1 from Julian Maurice --- Created attachment 146125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146125&action=edit Bug 32860: Fix cataloguing/value_builder/unimarc_field_128c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:38:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:38:28 +0000 Subject: [Koha-bugs] [Bug 32860] Fix cataloguing/value_builder/unimarc_field_128c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:39:13 +0000 Subject: [Koha-bugs] [Bug 32861] New: Fix cataloguing/value_builder/unimarc_field_130.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 Bug ID: 32861 Summary: Fix cataloguing/value_builder/unimarc_field_130.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:39:13 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:42:58 +0000 Subject: [Koha-bugs] [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 --- Comment #1 from Julian Maurice --- Created attachment 146126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146126&action=edit Bug 32861: Fix cataloguing/value_builder/unimarc_field_130.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:43:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:43:08 +0000 Subject: [Koha-bugs] [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:43:38 +0000 Subject: [Koha-bugs] [Bug 32862] New: Fix cataloguing/value_builder/unimarc_field_135a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 Bug ID: 32862 Summary: Fix cataloguing/value_builder/unimarc_field_135a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:43:38 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32862 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 [Bug 32862] Fix cataloguing/value_builder/unimarc_field_135a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:44:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:44:05 +0000 Subject: [Koha-bugs] [Bug 32862] Fix cataloguing/value_builder/unimarc_field_135a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 --- Comment #1 from Julian Maurice --- Created attachment 146127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146127&action=edit Bug 32862: Fix cataloguing/value_builder/unimarc_field_135a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:47:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:47:54 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #459 from Katrin Fischer --- (In reply to Katrin Fischer from comment #440) > Hi Kyle, > > does the last patch set fix the error Michaela noted on comment 430? > > Michaela also told that in her testing it showed the behavior as you > described it - so I need to do my homework and retest. I aim to have another > go at this patch set on Friday. Fingers crossed. It's Friday, but I am no longer needed here :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:49:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:49:53 +0000 Subject: [Koha-bugs] [Bug 32862] Fix cataloguing/value_builder/unimarc_field_135a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:50:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:50:31 +0000 Subject: [Koha-bugs] [Bug 32863] New: Fix cataloguing/value_builder/unimarc_field_140.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 Bug ID: 32863 Summary: Fix cataloguing/value_builder/unimarc_field_140.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:50:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:50:31 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:51:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:51:12 +0000 Subject: [Koha-bugs] [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 --- Comment #1 from Julian Maurice --- Created attachment 146128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146128&action=edit Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:51:30 +0000 Subject: [Koha-bugs] [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:51:58 +0000 Subject: [Koha-bugs] [Bug 32864] New: Fix cataloguing/value_builder/unimarc_field_141.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 Bug ID: 32864 Summary: Fix cataloguing/value_builder/unimarc_field_141.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:51:58 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 [Bug 32864] Fix cataloguing/value_builder/unimarc_field_141.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:52:52 +0000 Subject: [Koha-bugs] [Bug 32864] Fix cataloguing/value_builder/unimarc_field_141.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 --- Comment #1 from Julian Maurice --- Created attachment 146129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146129&action=edit Bug 32864: Fix cataloguing/value_builder/unimarc_field_141.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:53:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:53:00 +0000 Subject: [Koha-bugs] [Bug 32864] Fix cataloguing/value_builder/unimarc_field_141.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:54:01 +0000 Subject: [Koha-bugs] [Bug 32865] New: Fix cataloguing/value_builder/unimarc_field_146a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Bug ID: 32865 Summary: Fix cataloguing/value_builder/unimarc_field_146a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:54:01 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:54:40 +0000 Subject: [Koha-bugs] [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #1 from Julian Maurice --- Created attachment 146130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146130&action=edit Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:54:47 +0000 Subject: [Koha-bugs] [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:55:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:55:43 +0000 Subject: [Koha-bugs] [Bug 32866] New: Fix cataloguing/value_builder/unimarc_field_146h.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Bug ID: 32866 Summary: Fix cataloguing/value_builder/unimarc_field_146h.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:55:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:55:43 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 [Bug 32866] Fix cataloguing/value_builder/unimarc_field_146h.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:56:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:56:38 +0000 Subject: [Koha-bugs] [Bug 32866] Fix cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 --- Comment #1 from Julian Maurice --- Created attachment 146131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146131&action=edit Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:56:46 +0000 Subject: [Koha-bugs] [Bug 32866] Fix cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:57:37 +0000 Subject: [Koha-bugs] [Bug 32867] New: Fix cataloguing/value_builder/unimarc_field_146i.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Bug ID: 32867 Summary: Fix cataloguing/value_builder/unimarc_field_146i.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:57:37 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 [Bug 32867] Fix cataloguing/value_builder/unimarc_field_146i.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:58:06 +0000 Subject: [Koha-bugs] [Bug 32867] Fix cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 --- Comment #1 from Julian Maurice --- Created attachment 146132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146132&action=edit Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:58:15 +0000 Subject: [Koha-bugs] [Bug 32867] Fix cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:58:44 +0000 Subject: [Koha-bugs] [Bug 32868] New: Fix cataloguing/value_builder/unimarc_field_210c_bis.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Bug ID: 32868 Summary: Fix cataloguing/value_builder/unimarc_field_210c_bis.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:58:44 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:59:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:59:20 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 --- Comment #1 from Julian Maurice --- Created attachment 146133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146133&action=edit Bug 32868: Fix cataloguing/value_builder/unimarc_field_210c_bis.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:59:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:59:31 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:59:55 +0000 Subject: [Koha-bugs] [Bug 32869] New: Fix cataloguing/value_builder/unimarc_field_210c.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Bug ID: 32869 Summary: Fix cataloguing/value_builder/unimarc_field_210c.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 14:59:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 13:59:55 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:00:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:00:28 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 --- Comment #1 from Julian Maurice --- Created attachment 146134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146134&action=edit Bug 32869: Fix cataloguing/value_builder/unimarc_field_210c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:00:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:00:37 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:00:58 +0000 Subject: [Koha-bugs] [Bug 32870] New: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Bug ID: 32870 Summary: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:00:58 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:01:09 +0000 Subject: [Koha-bugs] [Bug 27510] Download the report in HTML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:01:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:01:15 +0000 Subject: [Koha-bugs] [Bug 27510] Download the report in HTML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116850|0 |1 is obsolete| | --- Comment #20 from Magnus Enger --- Created attachment 146135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146135&action=edit Bug 27510: Download the report in HTML format TEST PLAN: 1. Apply this patch 2. Update database ./updatedatabase.pl Now we have new preference 'ReportUserCSS' where we can add style for our HTML report. 3. Go on the page - /reports/guided_reports.pl 4. Download -> Document HTML Signed-off-by: Magnus Enger I have fixed some conflicts and put in the test plan that was on Bugzilla. Feature works as advertised. HTML file can be downloaded and is a full HTML document. Formatting can be done with the syspref. Links generated in SQL carry over to the document (but links need to be absolute to work, of course.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:01:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:01:24 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 --- Comment #1 from Julian Maurice --- Created attachment 146136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146136&action=edit Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:01:51 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:02:18 +0000 Subject: [Koha-bugs] [Bug 32871] New: Fix cataloguing/value_builder/unimarc_field_225a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Bug ID: 32871 Summary: Fix cataloguing/value_builder/unimarc_field_225a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:02:18 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:02:55 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 --- Comment #16 from Martin Renvoize --- No issue at all with it being an ENUM.. makes sense to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:03:11 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 --- Comment #1 from Julian Maurice --- Created attachment 146137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146137&action=edit Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:03:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:03:20 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:03:38 +0000 Subject: [Koha-bugs] [Bug 32872] New: Fix cataloguing/value_builder/unimarc_field_4XX.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Bug ID: 32872 Summary: Fix cataloguing/value_builder/unimarc_field_4XX.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:03:38 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:03:43 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #141 from Katrin Fischer --- Hi Aleisha, with bug 16522 now pushed, this no longer applies. Could you pleas rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-3150-Move-emails-for-sending-cart-and-list-con-7TAJ75.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:04:13 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 --- Comment #1 from Julian Maurice --- Created attachment 146138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146138&action=edit Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:04:27 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:05:24 +0000 Subject: [Koha-bugs] [Bug 32873] New: Fix cataloguing/value_builder/unimarc_field_686a.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Bug ID: 32873 Summary: Fix cataloguing/value_builder/unimarc_field_686a.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:05:24 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:06:12 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 --- Comment #1 from Julian Maurice --- Created attachment 146139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146139&action=edit Bug 32873: Fix cataloguing/value_builder/unimarc_field_686a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:06:22 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:07:09 +0000 Subject: [Koha-bugs] [Bug 32874] New: Fix cataloguing/value_builder/unimarc_field_700-4.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Bug ID: 32874 Summary: Fix cataloguing/value_builder/unimarc_field_700-4.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:07:09 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:07:35 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 --- Comment #1 from Julian Maurice --- Created attachment 146140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146140&action=edit Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:07:44 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:08:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:08:17 +0000 Subject: [Koha-bugs] [Bug 32875] New: Fix cataloguing/value_builder/unimarc_leader_authorities.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Bug ID: 32875 Summary: Fix cataloguing/value_builder/unimarc_leader_authorities.p l Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:08:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:08:17 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:08:52 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 --- Comment #1 from Julian Maurice --- Created attachment 146141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146141&action=edit Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:11:20 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:11:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:11:48 +0000 Subject: [Koha-bugs] [Bug 32876] New: Fix cataloguing/value_builder/unimarc_leader.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 Bug ID: 32876 Summary: Fix cataloguing/value_builder/unimarc_leader.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:11:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:11:48 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:12:08 +0000 Subject: [Koha-bugs] [Bug 27510] Download the report in HTML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #21 from Magnus Enger --- Created attachment 146142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146142&action=edit Bug 27510: Followup - Change "Document HTML" to "HTML file" as requested by Owen - Add HTML::Table to cpanfile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:12:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:12:25 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 --- Comment #1 from Julian Maurice --- Created attachment 146143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146143&action=edit Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:12:43 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:13:20 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:13:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:13:31 +0000 Subject: [Koha-bugs] [Bug 32877] New: Fix cataloguing/value_builder/upload.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Bug ID: 32877 Summary: Fix cataloguing/value_builder/upload.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Blocks: 30975 This is part of the refactoring happening in bug 30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:13:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:13:31 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 [Bug 32877] Fix cataloguing/value_builder/upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:14:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:14:05 +0000 Subject: [Koha-bugs] [Bug 32877] Fix cataloguing/value_builder/upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 --- Comment #1 from Julian Maurice --- Created attachment 146144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146144&action=edit Bug 32877: Fix cataloguing/value_builder/upload.pl Remove unnecessary call to event.preventDefault This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:14:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:14:38 +0000 Subject: [Koha-bugs] [Bug 32877] Fix cataloguing/value_builder/upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:15:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:15:43 +0000 Subject: [Koha-bugs] [Bug 27510] Download the report in HTML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #22 from Magnus Enger --- Not sure if my followup should be one or two patches? I am also taking a chance on leaving this at "signed off". Please reset to "needs signoff" if that is thought necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:22:15 +0000 Subject: [Koha-bugs] [Bug 32878] New: Make it impossible to renew the item if it has active item level hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Bug ID: 32878 Summary: Make it impossible to renew the item if it has active item level hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: stalkernoid at gmail.com Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:25:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:25:22 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:25:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:25:26 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #1 from Peter Vashchuk --- Created attachment 146145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146145&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:28:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:28:01 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138318|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 146146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146146&action=edit Bug 30975: Fix framework plugins not working on cloned fields/subfields Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not work on a cloned field/subfield. That is because we rely on jQuery's `.data('events')` to clone event handlers to the cloned elements, and that was removed in jQuery 1.8.0 (I did not confirm but it's possible it continued to work after that thanks to jQuery Migrate) It is apparently still possible to access these event handlers by using `jQuery._data(element, "events")` but here's what jQuery 1.8.0 release notes says about it: "this is not a supported public interface; the actual data structures may change incompatibly from version to version." So we should not rely on it. Instead, what this patch does is use event delegation [1]. Events are bound to a parent container, so when elements are added dynamically inside that container, we don't need to re-attach event handlers manually This patch also comes with a bit of cleanup, and introduce "breaking changes" (they are breaking changes only if you happen to have custom framework plugins): 1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to 'mouseover' and 'mousemove' are not used and would trigger too much events. 'keypress' is also not used, and is deprecated 2) Event handlers now takes a single parameter that is an Event object It just makes the code a lot less complicated. 3) Event handlers do not pollute the global scope anymore [1] https://learn.jquery.com/events/event-delegation/ Test plan: - Go to every page that has a MARC editor and verify that plugins still work. This includes addbiblio.pl, additem.pl, authorities.pl, neworderempty.pl, orderreceive.pl - Test plugins that use 'focus' event (for instance barcode.pl), 'blur' event (callnumber.pl) and 'click' event (almost all the others) - Test that plugins work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:28:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:28:45 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:29:29 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140810|Bug-30975-Fix-framework-plu |[22.05] filename|gins-on-cloned-fieldssu.pat |Bug-30975-Fix-framework-plu |ch |gins-on-cloned-fieldssu.pat | |ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:32:15 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #17 from Julian Maurice --- I split the patch into smaller ones (one patch per plugin, see "Depends on"). That should be easier to test and push. Leaving this one as BLOCKED until all other patches are pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:33:53 +0000 Subject: [Koha-bugs] [Bug 32879] New: Item search: Display additional 245 subfields in CSV export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32879 Bug ID: 32879 Summary: Item search: Display additional 245 subfields in CSV export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 14911 fixes this for the result list of the item search. It would be grat if the CSV export file could also include the additional information. It's not as simple as using the biblio-title include there too, as that adds spans that you don't want in the CSV file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:34:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:34:28 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #18 from Julian Maurice --- I also reintroduced some events ('change', 'mousedown', 'mouseup', 'keydown', 'keyup') just in case someone uses a custom plugin that use one of those events. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:34:51 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 --- Comment #12 from Katrin Fischer --- This works for the result list, but not for the CSV export. I've filed Bug 32879 - Item search: Display additional 245 subfields in CSV export I tried to provide a follow-up, but: The include used for the result lists adds spans, so we cannot use the same solution for the CSV export easily. I think this is still worthwhile as a first step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:36:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:36:55 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:37:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:37:00 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144529|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 146147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146147&action=edit Bug 14911: Add 245 fields to itemsearch title column via biblio-title.inc To test: 1. Have some records that have these 245 fields: -Title 245$a -Subtitle 245$b -Medium 245$h -Part number 245$n -Part name 245$p Note: IN KTD I have to run batchRebuildBiblioTables.pl -c 2. Apply patch and do an item search that will turn up items with the 245 fields lists above 3. Notice that those subfields are now included in the title column. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:39:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:39:03 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:40:39 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This introduces a breaking release notes| |change for users that have | |custom framework plugins: | |the first parameter of | |javascript functions is now | |always an Event object. | |Before that it was possible | |to receive a string | |containing an HTML ID. This | |ID is available in | |`event.data.id` (assuming | |the first parameter is | |named `event`) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:50:22 +0000 Subject: [Koha-bugs] [Bug 32880] New: Show library's name instead of branchcode in dialog when overwriting an existing notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32880 Bug ID: 32880 Summary: Show library's name instead of branchcode in dialog when overwriting an existing notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When you copy a notice to a branch, that already has the notice and then save, you'll get a warning that the notice already exists. This message uses the branchcode instead of the library name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:52:35 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:52:40 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142672|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 146148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146148&action=edit Bug 24616: Allow copying notice to a branch even if it exists in that branch If you try to copy notice or slip to a branch which already has that notice or slip Koha won't let you save it. Instead pop-up saying branch already has that notice is displayed. This patch allows users to copy and override already existing notice or slip. To test: 1. Find notice which exists e.g. in all branches and branch A. 2. Copy that notice, add notice screen is displayed. 3. Press save. => Pop-up informing that notice already exists in branch A is displayed. 4. Apply this patch. 5. Repeat steps 2. and 3. 6. Pop-up to confirm overwrite of notice is displayed. => Confirm that if you press OK, notice is saved succesfully. => Otherwise, changes to notice should not be saved. Also try to save the notice you tested with as a new (same code) to branch A. Confirm that pop-up is displayed as it should be. Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:52:44 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145238|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 146149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146149&action=edit Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy Signed-off-by: ml-inlibro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:52:49 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #18 from Katrin Fischer --- Created attachment 146150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146150&action=edit Bug 24616: (QA follow-up) Remove "This has bug" comment ... hopefully because there is no more bug now! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:56:27 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #19 from Katrin Fischer --- 1) Removed this comment (hopefully rightfully) in a follow-up: +//This has bug 2) return confirm(__("A letter with the code '%s' already exists for '%s'. Overwrite this letter?").format(new_lettercode, new_branchcode)); We get the branchcode in the message instead of the library's name. But: This is already the case for the old error that doesn't allow you to overwrite. So I filed: Bug 32880 - Show library's name instead of branchcode in dialog when overwriting an existing notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 15:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 14:56:30 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #128 from Magnus Enger --- Great to see this is being kept alive after so many years! :-) I had the same initial error as David and Solene. I was able to make it go away by doing this: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt index 931079996c..f8b57c0db7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt @@ -373,7 +373,7 @@ - [% FOREACH s IN signs %] + [% FOREACH s IN signs.next %] [% s.name | html %] [% IF ( s.webapp ) %]Yes[% ELSE %]No[% END %] @@ -413,7 +413,7 @@ - [% FOREACH s IN streams %] + [% FOREACH s IN streams.next %] [% s.name | html %] [% s.saved_sql.report_name | html %] But I have problems getting the one sign I added to display, so that change might be just nonsense. I was also getting a JS error when viewing the table of signs. It seems to be am invalid value for sPaginationType, so this made the error go away: @@ -451,13 +451,13 @@ "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); $("#table_streams").dataTable($.extend(true, {}, dataTablesDefaults, { "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); Not sure if "full" is the pagination we want, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:01:08 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:03:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:03:21 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:05:04 +0000 Subject: [Koha-bugs] [Bug 32667] Automatic debian/control updates (oldstable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable --- Comment #11 from Lucas Gass --- Thanks Mason, those patches are now pushed to 22.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:06:16 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:06:23 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145039|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 146151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146151&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:07:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:07:30 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #19 from Katrin Fischer --- Jan, congrats on your first patch for Koha! Sorry it took a while to get around to this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:09:32 +0000 Subject: [Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145934|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim --- Created attachment 146152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146152&action=edit Bug 30719: (QA Follow-up): - Fix wrong link 'Create a new batch status message' in case there are no existing batch statuses - Detail of batch update - View status of any request within a batch - Fix typo to correctly display status code on batch statuses list page - Fixed an issue with illrequest api definition that prevented the listing of any ILL requests if any request had a status_alias - Updated "Add items to batch" css class to match new 22.11 style - Fixed conflict issue where it prevented the creation of a single request in a backend that is using JS field validation utilizing the #cardnumber selector - Added a check for metadata enrichment plugins and bail batches JS code if none are found, this prevents a console error - Remove ysearch from patron auto complete in batch creation and use patron_autocomplete instead - 'New batch' and 'list batches' buttons no longer show if no metadata plugin is installed - Fixed tests, all passing now - Improved error messaging for non-existent cardnumber input in patron in ill batch creation - Improved error messaging for duplicate batch name creation error - Fix sidemenu filters and search not working after new batch_id column Sponsored-by: UKHSA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:12:05 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #3 from Heather --- Interesting! First, I'm blushing--I'd say I'm a MARC Conversationalist and not a MARC Expert--I dream of MARC Fluency! That said, the MARC bits are the clearest to me! I'm not sure what I'm looking at--if someone can fill me in, I'm happy to help. Initial reactions, looking at the FIXME lines: The 260 is obsolete but still used. If it's a digitized, older resource (think HathiTrust or JSTOR resource available only via the paid licenses) the biblio for the print version may use 260. A newly published item's biblios will use 264s. I don't know what "embargo_info" is. Help? Looking at the other FIXMEs, it looks like you might be looking at Linking Entry Fields. A Preceeding Entry will be a 780, with suitable subfields. "Parent publication" is vague--if this is for a supplement, the "parent" is in a 772. If this is a Host/Analytic relationship, the Host is in a 773. But if this is all for an electronic/print relationship, those relationships are in 776s. The "first issue online...last issue online" stuff tends to not actually appear in cataloging records because it changes so much. A serial MARC record will have the dates published/sequential designations (if known) in 362 fields (there can be more than one in a record). Published dates should also be in the 008 positions 007-014 (two dates). But in the digitized/published online version, the dates could be different, so they are actually seldom tracked in the cataloging records--they're usually mentioned in the discovery/search interface entry for the resource. Tell me more! Tell me where I'm wrong so I can learn! And when I understand more what this "my $publication_title..." text is and what it's doing, I can come up with sample MARC records for y'all. We don't use ERM, but I've worked where it is used, so know what it's supposed to do. I also use it as a patron!:) Fun!! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:12:38 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:14:35 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #129 from Magnus Enger --- This made the sign display in the main table: diff --git a/tools/signs.pl b/tools/signs.pl index e243b59b97..5b317925d0 100755 --- a/tools/signs.pl +++ b/tools/signs.pl @@ -302,12 +302,12 @@ if ( $op eq 'add_stream' ) { } else { - my @streams = Koha::SignStreams->search(); - my @signs = Koha::Signs->search(); + my $streams = Koha::SignStreams->search(); + my $signs = Koha::Signs->search(); $template->param( - streams => \@streams, - signs => \@signs, + streams => $streams, + signs => $signs, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:17:25 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #4 from Heather --- Brainstorm! OCLC does something similar brilliantly--I just realized what this probably is--like a macro to derive the electronic version from the print, microformat, etc., version record. Hold on--I'll post more today. Back soon. --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:17:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:17:50 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bibliwho at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:23:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:23:00 +0000 Subject: [Koha-bugs] [Bug 32778] Auto-unsuspended holds do do not trigger realtime holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32778 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:27:56 +0000 Subject: [Koha-bugs] [Bug 29109] Delete ILL requests manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29109 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Tomás Cohen Arazi --- This is already implemented and up to the backend developers to make the KILL status reachable were appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 16:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 15:46:09 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry --- At step 20 in the test plan I'm not getting an item created as described. I have deleted the item with barcode 39999000004090, but when I stage the batch set to match on biblionumber and replace items I don't get a new item created on import. The import_items table gives the error "duplicate item barcode" even though that barcode is in deleteditems and doesn't bring anything up in searches. Also, the behavior at steps 16/17 seems wrong to me. The incoming MARC has this item on one bib, Koha has it on another. To my mind, that suggests there's some fundamental confusion that should be sorted out manually. With this patch as written, the import and overlay edits an item on a bib that's not indicated in any way when looking at the batch, which seems like a good way miss errors in your import batch and to introduce unexpected item edits to your catalog. The item action choice is "Replace items when a matching bib is found." This is replacing an item on a non-matching bib. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:09:10 +0000 Subject: [Koha-bugs] [Bug 32881] New: System preferences sub menu text is hard to read Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Bug ID: 32881 Summary: System preferences sub menu text is hard to read Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 Created attachment 146153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146153&action=edit syspref before and after Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:09:10 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 [Bug 32881] System preferences sub menu text is hard to read -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:11:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:11:29 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 --- Comment #1 from Pedro Amorim --- Created attachment 146154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146154&action=edit Bug 32881: System preferences sub menu text is hard to read This patch makes the font-size slightly larger and applies a background color to the selected submenu. To test: Go to system preferences Click on any side menu item and check the items in the sub menu under it Apply patch run yarn build Go to system preferences again and check the changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:29:50 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #5 from Heather --- So I created a video showing what the OCLC Connexion Client's macro, "GenerateERecord" does, but it was too large to attach to this bug, so I uploaded it to my YouTube account: https://youtu.be/orzMYemsY5I I'll attach a copy of the source (print) MARC record to this bug. I tried to attach the OCLC macro file to this bug, so the developers could look at it, but it's too large--let me know if I can somehow provide that info! The functionality that I'd love to see in Koha: In the Advanced Bibliographic Editor, I'd like a new Macro that's called, "Generate e-record," because I usually have to edit/upgrade a bib record before generating the e-record. In addition, when displaying a bib record in the staff client, I'd like to select the "Edit" button, and have a new option that's called, "Generate e-record," that does this resulting in the record displayed in the editor that my login uses (eitehr the Basic or the Advanced). The generated e-record should be in a framework that's chosen via a syspref; I'd like the choice to be either generate the new e-record using the *same* framework of the source record, or a designated framework. E.g., we and many Koha libraries don't use different frameworks at all--they're unnecessary--so all our bibs are int he Default framework and we would want the generated record to also be in the Default framework. However libraries that do use frameworks might want, e.g., the generated bib to be in something like an ERecord framework. This is such an exciting development! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:31:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:31:53 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #6 from Heather --- Created attachment 146157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146157&action=edit MARC print serial record This is the MARC record exported from OCLC (via the OCLC Connexion Client software) for the print, serial title used in my video to show the functionality of this software's "Generate e-record" macro. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:54:31 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30650 --- Comment #1 from Caroline Cyr La Rose --- I noticed that the order also affects the way the slots are displayed when scheduling a pickup. If your day looks like 13-16, 10-12 in the configuration, the slots will be in that order too in the Schedule pickup tab in Circulation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:54:31 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 17:58:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 16:58:33 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:01:27 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #394 from Martin Renvoize --- Nearly there here.. I've rolled the QA fixes into the various commits and added tests for all the new object methods and api's introduced. However.. writing those tests has made me want to do a tiny bit of refactoring.. I'm going to move the notice generation that currently happens inside the API controller into the Koha::Ticket::Update object to match what I did for similar message generation in the Koha::Ticket store method. Once I've done that, I'll also want to enhance/add some additional unit tests to cover those notices and ticket triggers. Hopefully I'll get all that done on Monday and have a fresh patchset to upload... thanks for taking a look already Kyle.. I'll poke again once we're ready for a final review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:07:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:07:49 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:07:53 +0000 Subject: [Koha-bugs] [Bug 32805] When recording localuse in the statistics table location is always NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32805 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146024|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 146158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146158&action=edit Bug 32805: Update location when recording a localuse in statistics table To test: 1. Create a statistical patron and checkout, checkin to them. 2. Notice in the statistics table that the location is NULL 3. Apply patch 4. Try steps 1-2 again 5. The location should be correctly recorded in statistics.location Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:05 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:10 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145731|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 146159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146159&action=edit Bug 32721: Add branch specific userjs and usercss This patch allows for branch specific userJS and userCSS to be added through the libraries table. This works in conjunction with the global UserJS and UserCSS functionality and allows for multiple OPACs with different css and js options. Test plan: 1) Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "FFL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT FFL" 2) In the container, run restart_all 3) Navigate to the OPACUserJS and OPACUserCSS system preferences and add the following: OPACUserJS - console.log('Hello from global sysprefs');, OPACUserCSS - 'body { background-color: black; }' 4) Refresh the OPAC and the background should be black and the message should be logged to the console in developer tools 5) Navigate to Administration > Libraries 6) On the Fairfield branch (if this does not exist you will need to create a branch with a code matching the code that you added to the apache conf file), click edit 7) At the bottom there should be two fields to add userjs and usercss, complete with Codemirror syntax checking 8) In userjs add console.log('Hello from branch level'); and in usercss add 'body { background-color: blue; } then save 9) Return to the OPAC and refresh 10) If you are logged out of the OPAC it should now be logging both the message from global and from the branch level and the background should be blue (if not you will need to log out) 11) Log back into the OPAC using a user that DOES NOT have a default branch matching the branch you added to the Apache conf 12) The OPAC should now revert to only showing the global message in the console with a black background Sponsored-by: PTFS Europe Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:14 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145732|0 |1 is obsolete| | --- Comment #12 from Lucas Gass --- Created attachment 146160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146160&action=edit Bug 32721: Database update to add userjs and usercss to branches table This patch adds the columns for userjs and usercss to the branches table Test plan as per previous commit Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:19 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145733|0 |1 is obsolete| | --- Comment #13 from Lucas Gass --- Created attachment 146161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146161&action=edit Bug 32721: DBIC Schema This commit adds the DBIC Schema for the database change Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:24 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145734|0 |1 is obsolete| | --- Comment #14 from Lucas Gass --- Created attachment 146162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146162&action=edit Bug 32721: Add unit tests Unit tests to test two new functions: GetBranchSpecificJS and GetBranchSpecificCSS Test plan: 1) In the shell run prove -t t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:28 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145735|0 |1 is obsolete| | --- Comment #15 from Lucas Gass --- Created attachment 146163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146163&action=edit Bug 32721: Tidy up - duplicate fetching of userjs and css Currently UserJS and UserCSS is injected into the template as a parameter through Auth.pm but is then fetched using Koha.Preference() in the template. This patch tidies this up by removing the parameters from Auth.pm Test plan as per first commit Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:32 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145759|0 |1 is obsolete| | --- Comment #16 from Lucas Gass --- Created attachment 146164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146164&action=edit Bug 32721: (QA follow up) - fix QA issues This patches addresses issues raised by the QA tests. It also adds a missed import of the Branches file in the document head Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:33:43 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #19 from Esther Melander --- I agree with Heather. I recently tried merging a 155 (genre) with a 150 (topical). I wanted the corresponding 655 to survive and the 650's changed to 655 with the correct link. The merge appeared to fail as both merge candidates disappeared - meaning I can't find them in the database. >From a workflow perspective this kind of a merge, with warning, is an ideal way to clean up authorities. As a workaround, which I have not tested, I would need to do a batch bib change to the authority records linked with the incorrect 650 to the correct 655 and then go back and delete the 150 authority. This is much more work, in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:34:38 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:34:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:34:43 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 146165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146165&action=edit Bug 32761: Correct typos in CircControl syspref To test: 1: look up the CircControl syspref, see that it says "wether" and "libray" 2: apply patch 3: reload, see it says "whether" and "library" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:35:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:35:00 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Assignee|koha-bugs at lists.koha-commun |andrewfh at dubcolib.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:35:40 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:39:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:39:26 +0000 Subject: [Koha-bugs] [Bug 26540] Server error when attempting to issue cash credit with UseCashRegisters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- no longer applies cleanly to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:47:42 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #2 from Andrew Fuerste-Henry --- Fleshing this out a little: To reproduce: 1: have AllowRenewalIfOtherItemsAvailable set to Allow 2: have a bib with multiple items 3: 3: Checkout an item, and make another item level hold on that specific item. 4: Renew it using the "Renew" checkbox, it should get renewed without any problems. 5: Apply the patch. 6: Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 7: "Renew all" button should not work either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:51:20 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:51:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:51:23 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146145|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 146166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146166&action=edit Bug 32878: Make it impossible to renew the item if it has active item level hold introduced in: 73c3c5d2f10751c23156372300239d42e5957c66 Bug 31112: (QA follow-up) Reduce database queries started from: 8ba1a9a5345310c54d9225049d470544b56eeb11 Bug 31112: Remove unnecessary if-clause Currently, you can renew the item even if someone already made an item level hold on that item. This patch changes that, making it not possible to do so. To reproduce: 1. Checkout an item, and make another item level hold on that specific item. 2. Renew it using the "Renew" checkbox, it should get renewed without any problems. 3. Apply the patch. 4. Checkbox should be gone and replaced with "On Hold" link that leads to the hold that doesn't allow you to renew the item again. 5. "Renew all" button should not work either. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:59:17 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:59:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:59:21 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146154|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 146167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146167&action=edit Bug 32881: System preferences sub menu text is hard to read This patch makes the font-size slightly larger and applies a background color to the selected submenu. To test: Go to system preferences Click on any side menu item and check the items in the sub menu under it Apply patch run yarn build Go to system preferences again and check the changes Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 18:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 17:59:51 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:00:14 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:01:22 +0000 Subject: [Koha-bugs] [Bug 32879] Item search: Display additional 245 subfields in CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32879 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:21:20 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:21:24 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:21:28 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:21:32 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:24:09 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 146168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146168&action=edit Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <>

Discharge confirmation

<> certifies that the following borrower:
<> <> (cardnumber: <>)
has returned all items.

3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:24:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:24:16 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 146169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146169&action=edit Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 19:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 18:24:24 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 146170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146170&action=edit Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 20:13:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 19:13:51 +0000 Subject: [Koha-bugs] [Bug 32883] New: Curbside pickups - Order "To be staged" by date and time of scheduled pickup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Bug ID: 32883 Summary: Curbside pickups - Order "To be staged" by date and time of scheduled pickup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The entries in the "To be staged" tab in the curbside pickup module should be ordered by date and time of the scheduled pickup so that we can address the most pressing/the soonest first. Right now, I'm not sure how they are ordered... Maybe in the order they were scheduled? To test: 1. Enable the CurbsidePickup system preference 2. Set up curbside pickup for a library (e.g. Centerville) 2.1. Go to Administration > Curbside pickup 2.2. Click the tab for the library 2.3. Fill out the form: - Enable: Check - Pickup interval: 10 (or other) - Maximum patrons per interval: 3 (or other) - Patron-scheduled pickup: leave unchecked - Enable for waiting holds only: leave unchecked 2.4. Enter a couple of time periods (e.g. - Day: Sunday - From: 10:00 - To: 12:00 2.5. Click 'Add' 2.6. Click 'Save configuration' 3. Schedule a pickup 3.1. Go to Circulation > Curbside pickups 3.2. Click 'Schedule pickup' 3.3. Search for a patron name (e.g. Henry) 3.4. Pick a date 3.5. Pick a time (not the first one, e.g. 10:50) 3.6. Click 'Submit' 4. Schedule a second pickup, in a time slot before the other one 4.1. Search for a patron name (e.g. Edna) 4.2. Pick the same date 4.3. Pick a time before the time selected in step 3.5 (e.g. 10:10) 4.4. Submit 5. Check the "To be staged" tab --> Pickups are not ordered from soonest to latest pickup time I think the table should maybe be a datatable with column configuration, search boxes and the arrows to order a column, to match all other tables in Koha, with the default order on the 'Pickup date/time' column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 20:14:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 19:14:01 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 20:14:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 19:14:01 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 20:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 19:23:06 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |fridolin.somers at biblibre.co | |m Text to go in the| |When creating an authority release notes| |record there is the | |possibility to reorder the | |subfields. | |However this | |order was not sent back to | |the bibliographic | |records | |when creating a link to the | |authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:43:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:43:57 +0000 Subject: [Koha-bugs] [Bug 32555] Error when viewing serial in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Lucas Gass --- Missing dependencies for 22.05, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:44:41 +0000 Subject: [Koha-bugs] [Bug 32712] OPACShowCheckoutName makes OPAC explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32712 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #17 from Lucas Gass --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:45:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:45:24 +0000 Subject: [Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:46:04 +0000 Subject: [Koha-bugs] [Bug 32618] Add 'page-section' to various administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:46:04 +0000 Subject: [Koha-bugs] [Bug 31757] [Omnibus] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug 31757 depends on bug 32618, which changed state. Bug 32618 Summary: Add 'page-section' to various administration pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:48:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:48:12 +0000 Subject: [Koha-bugs] [Bug 32738] Correct upload local cover image title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Doesn't apply clean to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:48:58 +0000 Subject: [Koha-bugs] [Bug 32600] Housebound module needs page-section treatment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:48:59 +0000 Subject: [Koha-bugs] [Bug 31757] [Omnibus] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug 31757 depends on bug 32600, which changed state. Bug 32600 Summary: Housebound module needs page-section treatment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:51:30 +0000 Subject: [Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/617/ CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:51:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:51:55 +0000 Subject: [Koha-bugs] [Bug 32644] Terminology: staff/intranet and biblio in plugins home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32644 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:52:48 +0000 Subject: [Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:54:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:54:10 +0000 Subject: [Koha-bugs] [Bug 32690] Reindent the serial collection template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32690 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #9 from Lucas Gass --- Doesn't apply cleanly to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:54:32 +0000 Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/617/ Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:54:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:54:56 +0000 Subject: [Koha-bugs] [Bug 32442] Invalid Template Toolkit in notices can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32442 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #18 from Lucas Gass --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:56:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:56:29 +0000 Subject: [Koha-bugs] [Bug 32482] Reindent holds awaiting pickup template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32482 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Lucas Gass --- These fixes have been great but they don't apply well in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:45 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:54 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/617 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:56 +0000 Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963 Bug 30963 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:56 +0000 Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove slots in the past In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261 Bug 31261 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:57 +0000 Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without slots In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262 Bug 31262 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:57 +0000 Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be able to alert even if not staged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263 Bug 31263 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:57 +0000 Subject: [Koha-bugs] [Bug 31266] Curbside pickups - New messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266 Bug 31266 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:58 +0000 Subject: [Koha-bugs] [Bug 32108] Change "x" icon to replace patron when scheduling a pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32108 Bug 32108 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:58 +0000 Subject: [Koha-bugs] [Bug 32111] Cannot schedule a pickup at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32111 Bug 32111 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:58 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Bug 32785 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:59 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Bug 32786 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:59 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Bug 32788 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:59 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Bug 32883 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:58:59 +0000 Subject: [Koha-bugs] [Bug 30964] Add information about overdues and restrictions on the curbside pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964 Bug 30964 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:59:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:59:00 +0000 Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Bug 30965 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:59:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:59:00 +0000 Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Bug 31264 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 22:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 21:59:01 +0000 Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Bug 31265 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:02:29 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: Fine blocking checkout is missing currency symbol In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #21 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:04:26 +0000 Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/618 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:07:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:07:47 +0000 Subject: [Koha-bugs] [Bug 32292] Update and add database column descriptions used in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #24 from Lucas Gass --- Doesn't apply cleanly to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:07:48 +0000 Subject: [Koha-bugs] [Bug 32312] Complete database column descriptions for circulation module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Bug 32312 depends on bug 32292, which changed state. Bug 32292 Summary: Update and add database column descriptions used in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:07:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:07:49 +0000 Subject: [Koha-bugs] [Bug 32313] Complete database column descriptions for cataloguing module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32313 Bug 32313 depends on bug 32292, which changed state. Bug 32292 Summary: Update and add database column descriptions used in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:07:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:07:49 +0000 Subject: [Koha-bugs] [Bug 32314] Complete database column descriptions for accounts module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32314 Bug 32314 depends on bug 32292, which changed state. Bug 32292 Summary: Update and add database column descriptions used in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:07:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:07:49 +0000 Subject: [Koha-bugs] [Bug 32315] Complete database column descriptions for serials module in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32315 Bug 32315 depends on bug 32292, which changed state. Bug 32292 Summary: Update and add database column descriptions used in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:08:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:08:30 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Doesn't apply cleanly to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:08:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:08:30 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Bug 32587 depends on bug 32586, which changed state. Bug 32586 Summary: Reindent items with no checkouts reports template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:09:28 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:09:28 +0000 Subject: [Koha-bugs] [Bug 31757] [Omnibus] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug 31757 depends on bug 32587, which changed state. Bug 32587 Summary: Add page-section to items with no checkouts report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:09:28 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Bug 32589 depends on bug 32587, which changed state. Bug 32587 Summary: Add page-section to items with no checkouts report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:10:16 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:10:16 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Bug 32588 depends on bug 32589, which changed state. Bug 32589 Summary: Improve headings on result tables for 'checkouts with no items' report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:12:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:12:54 +0000 Subject: [Koha-bugs] [Bug 26628] Clubs permissions should grant access to Tools page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:13:47 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:16:10 +0000 Subject: [Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #13 from Lucas Gass --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:18:24 +0000 Subject: [Koha-bugs] [Bug 32239] Report options for adding groups/sub groups are misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32239 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:21:33 +0000 Subject: [Koha-bugs] [Bug 32688] Convert recalls awaiting pickup tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32688 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #8 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:26:15 +0000 Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down acqui/histsearch.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | --- Comment #6 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:27:30 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #124 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:27:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:27:31 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Bug 16223 depends on bug 31095, which changed state. Bug 31095 Summary: Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:27:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:27:32 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Bug 31458 depends on bug 31095, which changed state. Bug 31095 Summary: Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:29:26 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #56 from Lucas Gass --- 22.05.x has the dependencies but I am not sure about backporting this at this point in the 22.05.x lifecycle. Won't backport unless convinced otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:57:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:57:04 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 23:57:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 22:57:08 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145982|0 |1 is obsolete| | Attachment #146042|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 146171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146171&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats To test: Apply patch, updatedatabase, and restart_all Do each of the following actions and check the statistics table making sure the interface is properly being recorded: RENEWALS: -Renewal from staff client -Renew from OPAC -Renew from API. You could add something like this to IntranetUSerJS: $.ajax({ url: '/api/v1/checkouts/338/renewal', method: 'POST', contentType: 'application/json', success: function(result) { console.log('renewed') }, }); -Renewal from automatic_renewals -Renewal from SIP ( can use sip_cli_emulator.pl ) CHECKOUTS: -Checkout from staff client -Checkout from SCO -Checkout from API -Checkout from SIP ( can use sip_cli_emulator.pl ) CHECKIN: -Checkin from staff client -Check in from batch -Check in from API -Check in from SCI -Check in from SIP ( can use sip_cli_emulator.pl ) RECALLS: -OPAC recall -Staff client recall ACCOUNTING: -Make a payment -Make a payemnt from SIP ( can use sip_cli_emulator.pl ) prove -v /kohadevbox/koha/t/db_dependent/Circulation.t Tests should all pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 00:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 23:25:41 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #6 from Lucas Gass --- Created attachment 146172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146172&action=edit Bug 30928: Add tests prove -v t/db_dependent/Koha/Statistics.t prove -v t/db_dependent/Stats.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 00:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 23:33:36 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 00:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 23:33:40 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146165|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 146173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146173&action=edit Bug 32761: Correct typos in CircControl syspref To test: 1: look up the CircControl syspref, see that it says "wether" and "libray" 2: apply patch 3: reload, see it says "whether" and "library" Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 00:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2023 23:34:24 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- Good fix, trivial, straight PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 01:01:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 00:01:34 +0000 Subject: [Koha-bugs] [Bug 32877] Fix cataloguing/value_builder/upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 01:01:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 00:01:38 +0000 Subject: [Koha-bugs] [Bug 32877] Fix cataloguing/value_builder/upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146144|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 146174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146174&action=edit Bug 32877: Fix cataloguing/value_builder/upload.pl Remove unnecessary call to event.preventDefault This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 01:11:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 00:11:24 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- When I add the plugin to a 952 field like 'Date acquired' and then go to an item record, when I like on the '...' the page jumps back to the top. This doesn't happen without the patch. This appears to happen for me in both Chrome and Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 01:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 00:20:18 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #3 from Lucas Gass --- We can stop the links for jumping by using "#/" instead of "#" as the href. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 01:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 00:21:41 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #4 from Lucas Gass --- Created attachment 146175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146175&action=edit Bug 32817: Stop links from jumping to top of page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 12:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 11:37:15 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 15:04:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 14:04:17 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_32884=5D_New=3A_Advanced_Editor_=28?= =?utf-8?q?rancor=29_don=C2=B4t_work_after_21=2E11=2E17_upgrade?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32884 Bug ID: 32884 Summary: Advanced Editor (rancor) don´t work after 21.11.17 upgrade Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: paliotti at mdp.edu.ar QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 15:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 14:16:00 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_32884=5D_Advanced_Editor_=28rancor?= =?utf-8?q?=29_don=C2=B4t_work_after_21=2E11=2E17_upgrade?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32884 --- Comment #1 from Pablo López Liotti --- hi, how bug title say, after 21.11.17 upgrade, advanced editor don't work. When I go to Cataloging-> Advanced editor, system remain frezze with "Loading, please wait..." message. If you select "New record option" get same answer. I have to change Advance editor syspref parameter to off for be able to work editing records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 19:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 18:00:56 +0000 Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 --- Comment #17 from Katrin Fischer --- (In reply to quickfire28 from comment #15) > (In reply to victor from comment #3) > > (In reply to Fridolin Somers from comment #2) > > > Hi, > > > > > > We have seen this one only once, on a very old database (started at 3.2). > > > > > > We detect it with : > > > MariaDB [koha]> SELECT language_subtag,GROUP_CONCAT(script_subtag SEPARATOR > > > ' | '),COUNT(*) AS nb\ > > > -> FROM language_script_mapping GROUP BY language_subtag HAVING nb > > > > 1; > > > +-----------------+---------------------------------------------+----+ > > > | language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb | > > > +-----------------+---------------------------------------------+----+ > > > | ar | Arab | Arab | 2 | > > > | he | Hebr | Hebr | 2 | > > > +-----------------+---------------------------------------------+----+ > > > > > > And fix with : > > > DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ; > > > DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ; > > > > Thank you very much! > > The issue was resolved with your guidance. > > Good day! > > I tried to use this fix on my KOHA, and the update works. but when i use > patron seach on koha web and try to open the patron list it gives an error > 500. > > or when type name of patron on search bar and hit enter it also gives error > 500. > > Thank you! I believe these are unrelated - the error you see is unlikely to be linked to the change to languages. Please try the mailing list with a description of your issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 19:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 18:02:47 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #19 from Katrin Fischer --- (In reply to Julian Maurice from comment #18) > I also reintroduced some events ('change', 'mousedown', 'mouseup', > 'keydown', 'keyup') just in case someone uses a custom plugin that use one > of those events. Thx Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 19:03:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 18:03:23 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #24 from David Nind --- Two things from testing: 1. The CSS changes are only reflected in the PDF if they are made in the Email section of the notice. If you add them to the Print section, then the inline CSS is ignored. 2. The tests fail for me after removing weasyprint (step 9 of the test plan): prove -v t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_Discharge.t .. 1..23 ok 1 - A patron with issues cannot be discharged ok 2 - No request done if patron has issues ok 3 - No discharge done if patron has issues ok 4 - There is no pending discharge request ok 5 - There is no validated discharge ok 6 - A patron without issues can be discharged ok 7 - Confirm failure when lacking borrower number ok 8 - The patron has been discharged ok 9 - The patron has been debarred after discharge ok 10 - There are 3 validated discharges ok 11 - There is 1 validated discharge for a given patron ok 12 - There is 2 validated discharges for a given branchcode ok 13 - The debarment has been lifted ok 14 - The patron is not discharged after the restriction has been lifted ok 15 - There is a pending discharge request (second time) ok 16 - There is no pending discharge request (second time) ok 17 # skip Skipping because weasyprint is not installed not ok 18 - Failed call to run() prints the generated error ok 19 - undef returned if failed run # Failed test 'Failed call to run() prints the generated error' # at t/db_dependent/Patron/Borrower_Discharge.t line 141. # found warning: weasyprint not found! at /kohadevbox/koha/Koha/Patron/Discharge.pm line 151. # expected to find warning: Some error ok 20 - Expected failure because of missing weasyprint ok 21 - undef returned if missing weasyprint ok 22 - Discharge request sent # Subtest: search_limited 1..4 ok 1 - With permission, all discharges are visible ok 2 - With permission, all discharges are visible ok 3 - Without permission, only discharge from our group are visible ok 4 - Without permission, only discharge from our group are visible ok 23 - search_limited # Looks like you failed 1 test of 23. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/23 subtests (less 1 skipped subtest: 21 okay) Test Summary Report ------------------- t/db_dependent/Patron/Borrower_Discharge.t (Wstat: 256 Tests: 23 Failed: 1) Failed test: 18 Non-zero exit status: 1 Files=1, Tests=23, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.55 cusr 0.28 csys = 1.85 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 23:53:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 22:53:27 +0000 Subject: [Koha-bugs] [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 Bug 27382 depends on bug 28431, which changed state. Bug 28431 Summary: [DOCS] Spelling error in the manual (tools): exsit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 23:53:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 22:53:26 +0000 Subject: [Koha-bugs] [Bug 28431] [DOCS] Spelling error in the manual (tools): exsit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- This appears to be fixed now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 4 23:55:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 22:55:39 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:09:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:09:42 +0000 Subject: [Koha-bugs] [Bug 32225] Capitalization: Display Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32718 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:09:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:09:42 +0000 Subject: [Koha-bugs] [Bug 32718] Capitalization: Display Order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32718 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- *** Bug 32225 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:21:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:21:50 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:21:54 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 --- Comment #1 from Katrin Fischer --- Created attachment 146176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146176&action=edit Bug 28674: Fix typo 'hlpd' in schema comments Fixes the lines for old_reserves.item_level_hold and reserves.item_level_hold comments to read 'hold' instead of 'hpld' To test: * The easiest way to verify this change is by looking at the patch itself -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:29:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:29:11 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:56:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:56:03 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:56:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:56:08 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #1 from Katrin Fischer --- Created attachment 146177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146177&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 00:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Feb 2023 23:58:16 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|isobel.graham09 at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:00:00 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:00:07 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 --- Comment #1 from Katrin Fischer --- Created attachment 146178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146178&action=edit Bug 31407: Set focus for cursor to Currency when adding a new currency This makes sure that the focus is on the first field of the form when adding a new currency. To test: * Go to administration > currencies * Add a new currency * Verify the focus is not on the form * Apply patch * Repeat, verify the focus is now on the first input "currency" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:03:47 +0000 Subject: [Koha-bugs] [Bug 31408] Set focus for cursor to Start date when adding a new budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- Hm, using the focus class on a date input field with flatpickr breaks the date widget. Owen, do you have a tip/suggestion maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:08:34 +0000 Subject: [Koha-bugs] [Bug 32885] New: Checkbox "Update all sub funds with this owner" in the fund add/edit form is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32885 Bug ID: 32885 Summary: Checkbox "Update all sub funds with this owner" in the fund add/edit form is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When adding a new fund or editing an existing one the checkbox and label for "Update all sub funds with this owner" are misaligned in the form. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:08:34 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32885 [Bug 32885] Checkbox "Update all sub funds with this owner" in the fund add/edit form is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:10:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:10:54 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:10:58 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 --- Comment #1 from Katrin Fischer --- Created attachment 146179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146179&action=edit Bug 31409: Set focus for cursor to Fund code when adding a new fund This makes sure that the focus is on the first input field of the form when adding or editing a fund. To test: * Go to administration > funds * Add a new fund to the budget * Verify the focus is not inside the form * Apply patch * Verify the focus is now in the first form field "Fund code" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:11:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:11:09 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|isobel.graham09 at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:16:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:16:41 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:19:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:19:02 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:19:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:19:07 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 --- Comment #1 from Katrin Fischer --- Created attachment 146180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146180&action=edit Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:20:39 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:25:00 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Assignee|katrin.fischer at bsz-bw.de |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- The focus class on the input field has no effect here. Owen, maybe you could take a look and make a suggestion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:26:32 +0000 Subject: [Koha-bugs] [Bug 32886] New: Set focus for cursor to Code when adding a new restriction Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Bug ID: 32886 Summary: Set focus for cursor to Code when adding a new restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 31411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:26:32 +0000 Subject: [Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 [Bug 32886] Set focus for cursor to Code when adding a new restriction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:34:58 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Katrin Fischer --- focus class is not working in this case - hints appreciated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:40:03 +0000 Subject: [Koha-bugs] [Bug 26737] Focus for cursor is in cataloging search input box on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26737 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set focus for cursor to |Focus for cursor is in |cataloging search input box |cataloging search input box |on additem.pl |on additem.pl Keywords| |regression --- Comment #6 from Katrin Fischer --- I am rephrasing this bug a little since this has now been identified as a regression of Bug 11905. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:44:59 +0000 Subject: [Koha-bugs] [Bug 32215] Capitalization: %s You Searched for %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 --- Comment #1 from Katrin Fischer --- Hm, it's easy to fix, but I am failing to see it in the GUI. This should appear on administration > restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:51:44 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:53:37 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 01:53:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 00:53:42 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 --- Comment #1 from Katrin Fischer --- Created attachment 146181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146181&action=edit Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:02:32 +0000 Subject: [Koha-bugs] [Bug 32887] New: OpacLibraryInfo needs to be pre-selected when OPAC info is added for a library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32887 Bug ID: 32887 Summary: OpacLibraryInfo needs to be pre-selected when OPAC info is added for a library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To test: * Go to administration > libraries * Edit a library * Verify there is a link "Add HTML content" * Click it * On the HTML customizations form, verify that the location pull down is not correctly set to OpacLibraryInfo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:03:38 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:03:42 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 --- Comment #1 from Katrin Fischer --- Created attachment 146182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146182&action=edit Bug 32226: Fix capitalization of "Add/Edit html content" HTML is an abbreviation and as such should always be capitalized. To test: * Go to administration > libraries * Edit any existing branch * The hint for OPAC info reads 'Add html content' * Add some content, verify the link changes to 'Edit html content' * Apply patch * Verify both cases now read 'HTML' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:03:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:03:54 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:09:37 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:09:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:09:41 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 --- Comment #1 from Katrin Fischer --- Created attachment 146183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146183&action=edit Bug 32230: Fix capitalization of "Manage Domains" To test: * Go to administration > Identity providers * Add a new identity provider and fill out all required form fields Hint: you can use the buttons to add example JSON to the input fields * Save * Verify the entry in the table now shows a "Manage Domains" button * Apply patch * Verify the button now reads correctly: "Manage domains" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:09:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:09:48 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:20:55 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:21:00 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 --- Comment #1 from Katrin Fischer --- Created attachment 146184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146184&action=edit Bug 32264: Fix capitalization and terminology: Show in Staff client? This fixes several occurences of Staff client to read staff interface. To test: * Activate the search filter feature via the SavedSearchFilters system preference * Do a search in the staff catalogue * Use the link "save as search filter" on top of the results list * Verify it reads "Show in Staff client?" in the form * Go to administration > search filters * Verify the table has a heading "staff client" * Edit the filter * Verify there is the "Show in staff client" again * Apply patch * All those spots should now read 'staff interface' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:21:05 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:25:32 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:28:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:28:09 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:28:13 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 --- Comment #1 from Katrin Fischer --- Created attachment 146185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146185&action=edit Bug 32294: Fix capitalization for user ID in self checkout Fixes capitalization of "user ID" on the self checkout help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify there is a User ID within a sentence and a User id in the heading * Apply patch * Both should be corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:34:14 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:40:21 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:40:25 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 --- Comment #1 from Katrin Fischer --- Created attachment 146186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146186&action=edit Bug 32295: Fix punctuation for "Filters :" on serials claims page To test: * Add a subscription * Generate next issue, to have a late one * Go to serials > claims * Select your vendor * Verify one of the sections is labelled "Filters :" * Apply patch * Verify the section is now labelled "Filters:" https://bugs.koha-community.org/show_bug.cgi?id=28428 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:46:50 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:46:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:46:54 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 --- Comment #1 from Katrin Fischer --- Created attachment 146187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146187&action=edit Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:47:14 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:57:01 +0000 Subject: [Koha-bugs] [Bug 32888] New: Ordering from staged records will use first fund from list when none was set Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32888 Bug ID: 32888 Summary: Ordering from staged records will use first fund from list when none was set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com There used to be a warning when you tried to add orders without setting either an individual fund for the order or a default fund. Now if both fields are unset, it will just use the first fund in the list on saving :( (found while fixing bug 32293) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:58:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:58:21 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:58:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:58:25 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 --- Comment #1 from Katrin Fischer --- Created attachment 146188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146188&action=edit Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:59:16 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32888 --- Comment #2 from Katrin Fischer --- There is currently an issue in bug 32888 that means we can no longer trigger that warning/message as it just uses the first fund found. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32888 [Bug 32888] Ordering from staged records will use first fund from list when none was set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:59:16 +0000 Subject: [Koha-bugs] [Bug 32888] Ordering from staged records will use first fund from list when none was set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 [Bug 32293] Terminology: Some budgets are not defined in item records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 02:59:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 01:59:38 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 03:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 02:17:25 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: 'You must |Ill requests uses some |choose a branch' in |wrong terminology |ill-requests.tt | Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 03:22:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 02:22:09 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 03:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 02:22:13 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 --- Comment #2 from Katrin Fischer --- Created attachment 146189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146189&action=edit Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checkout out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 03:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 02:30:18 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 --- Comment #3 from Katrin Fischer --- Created attachment 146190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146190&action=edit Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checkout out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 03:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 02:49:03 +0000 Subject: [Koha-bugs] [Bug 20519] Credit amount in pay.pl should use the class="credit" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I can confirm that this has been fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:00:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:00:08 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:00:14 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146167|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 146191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146191&action=edit Bug 32881: System preferences sub menu text is hard to read This patch makes the font-size slightly larger and applies a background color to the selected submenu. To test: Go to system preferences Click on any side menu item and check the items in the sub menu under it Apply patch run yarn build Go to system preferences again and check the changes Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:00:42 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:03:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:03:20 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:03:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:03:25 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146043|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 146192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146192&action=edit Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:03:31 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146044|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 146193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146193&action=edit Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:13:39 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:13:44 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145996|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 146194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146194&action=edit Bug 32775: Do not order language directories based on when they were created Sponsored-by: Kinder library, New Zealand Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:13:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:13:48 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145997|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 146195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146195&action=edit Bug 32775: Correctly display language order in sysprefs when you have multiple languages in a group Test plan: 1. Apply first patch 2. Install en-NZ and another language - e.g. mi-NZ - so you have three languages showing in your sysprefs en-NZ (selected), en (unselected) and mi-NZ (selected) 3. Tick en-NZ and mi-NZ in language and OPACLanguages sysprefs. Order en-NZ above mi-NZ and save 4. Refresh the syspref page and confirm mi-NZ is displaying above en-NZ, even though you ordered en-NZ first 5. Refresh the syspref page multiple times and observe the order of the languages changes 6. Apply this (second) patch 7. Restart plack 8. Refresh syspref page several times confirming that en-NZ is always ordered first - as expected. Sponsored-by: Kinder library, New Zealand Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:13:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:13:54 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145998|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 146196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146196&action=edit Bug 32775: (QA follow-up) Fix tab and indenting issues Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:15:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:15:34 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- There are some bigger changes to a method in C4 here - we should have some unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:26:12 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #7 from Katrin Fischer --- I believe that Felicity meant the patron category by 'customer's type'. So instead of 'Staff (S)', we should display the usual 'Staff' without the added type. I'll provide a patch to remove the patron category's type from display for consistency and because those single letters don't work well with translations and have been causing a lot of confusion in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:28:37 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:28:42 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145975|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 146197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146197&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:28:46 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #9 from Katrin Fischer --- Created attachment 146198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146198&action=edit Bug 32774: (QA follow-up) Remove patron category type from display This is for consistency and because those single letters don't translate well and are more prone to cause confusion than being helpful. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:36:37 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:38:39 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:38:45 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145529|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 146199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146199&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:38:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:38:49 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145530|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 146200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146200&action=edit Bug 32571: (follow-up) Implement abstracted tabs on About page This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:38:54 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145533|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 146201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146201&action=edit Bug 32571: (follow-up) Use more unique variable name to avoid collisions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:39:34 +0000 Subject: [Koha-bugs] [Bug 32649] Use template wrapper for library transfer limits tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:39:39 +0000 Subject: [Koha-bugs] [Bug 32649] Use template wrapper for library transfer limits tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32649 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145365|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 146202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146202&action=edit Bug 32649: Use template wrapper for library transfer limits tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the library transfer limits page. To test, apply the patch and go to Administration -> Library transfer limits. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:43:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:43:32 +0000 Subject: [Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:43:36 +0000 Subject: [Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145789|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 146203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146203&action=edit Bug 32662: Use template wrapper for item circulation alerts page This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the item circulation alerts page. To test, apply the patch and go to Administration -> Item circulation alerts. There should be two tabs, "Checkout" and "Check-in" which work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:46:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:46:03 +0000 Subject: [Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:46:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:46:07 +0000 Subject: [Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145790|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 146204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146204&action=edit Bug 32660: Use template wrapper for basket groups tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the basket groups page. To test you must have at least one active vendor, one or more closed baskets under that vendor, and at least one basket group containing a closed basket. Apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should see two tabs, "Open" and "Closed." The tabs should look correct and work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:46:11 +0000 Subject: [Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145791|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 146205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146205&action=edit Bug 32660: (follow-up) Use more unique variable name to avoid collisions Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:48:59 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:49:03 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145792|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 146206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146206&action=edit Bug 32661: Use template wrapper for invoices page tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the invoices page. To test you must have at least one open invoice and one closed invoice. - Go to Acquisitions -> Invoices. - You should see two tabs, "Open invoices" and "Closed invoices." - The tabs should look correct and work correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:49:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:49:07 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145793|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 146207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146207&action=edit Bug 32661: (follow-up) Use more unique variable name to avoid collisions Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:49:16 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:51:24 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:51:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:51:28 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146040|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 146208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146208&action=edit Bug 32698: Use template wrapper for serials pages tabs This patch updates three serials templates to replace tab markup with the use of WRAPPERs. To test requires more data than will be found in the sample data. You need at least one subscription with issues spanning more than one year. I suggest creating a new subscription which starts in December, then receive one issue from December and one in January. Apply the patch and go to Serials. - Perform a subscription search. - On the search results page there should be two tabs: "Open" and "Closed." These tabs should work correctly. - Open the detail view of one of your subscriptions. - You should see at least four tabs: "Information," "Planning," "Issues," and "Summary." - In some cases an "Acquisition details" tab will also appear. To test this you must go to Acquisitions and add an order to a basket by choosing "From a subscription" option. - Click "Serial collection" in the left-hand sidebar. - There should be tabs for each year of subscription issues in your collection. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 13:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 12:51:36 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:07:34 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:07:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:07:38 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145065|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 146209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146209&action=edit Bug 32567: Update unimarc_field_110.pl with some values 'Script of title' values => e - b/c/d/e/f/g/h i - d/e j - f/g l - f n - b/c o - a p - a 'Translitteral code' values => 'g' and 'h' Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:07:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:07:42 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 --- Comment #5 from Katrin Fischer --- Created attachment 146210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146210&action=edit Bug 32567: (QA follow-up) Fix some labelling inconsistencies This makes sure that the descriptions in the pull-downs always match for selected/unselected. This is not only for consistency, but will also ease translations as simple things like an additional space will create a new string to translate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:07:52 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:11:03 +0000 Subject: [Koha-bugs] [Bug 32658] Use template wrapper in order from staged file template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer --- Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32658: Use template wrapper in order from staged file template Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32658: Use template wrapper in order from staged file template hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32658-Use-template-wrapper-in-order-from-stage-3QNVu8.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:15:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:15:04 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:15:15 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:15:19 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145206|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 146211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146211&action=edit Bug 32606: Revert Flatpickr style changes made in Bug 31943 This patch removes the CSS controlling the width of a Flatpickr date input. The side-effects of this change are worse than the problem the change was intended to fix. To test, apply the patch and rebuild the staff interface CSS. Check pages which are referenced in bugs caused by Bug 31943: - The holds page (Bug 32259) - Checking out when specifying a date due in the past (Bug 32210) - Circulation -> Renew (Bug 32157) Flatpickr inputs should look correct. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:13 +0000 Subject: [Koha-bugs] [Bug 32210] When checking out with a date in the past, the due date input is too wide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32606 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:13 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- *** Bug 32210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:30 +0000 Subject: [Koha-bugs] [Bug 32157] Renewal due date input field width - adjusts to the width of the screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32606 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:30 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from Katrin Fischer --- *** Bug 32157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:51 +0000 Subject: [Koha-bugs] [Bug 32259] Date inputs too small in tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32606 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:16:51 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Katrin Fischer --- *** Bug 32259 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:23:13 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:23:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:23:37 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:23:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:23:41 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145772|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 146212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146212&action=edit Bug 26765: Make author span a clickable link on OPAC results list This patch follows the markup of the staff interface catalog results XSLT to make authors in OPAC search results clickable. The patch also makes some minor CSS changes so that title and author links are not too crowded together. To test, apply the patch and rebuild the OPAC CSS. - Perform a catalog search in the OPAC which will return multiple results. - In the search results, each author in each search result should be a separate clickable link. - The margins around the result title and authors should be comfortable. - Confirm that each link takes you to the correct author search. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:29:25 +0000 Subject: [Koha-bugs] [Bug 32769] Standardize structure around action fieldsets in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 --- Comment #3 from Katrin Fischer --- This does what it says on the tin, but we still have some display inconsistencies, as sometimes the button is outside the page-section (shortcuts) and other times it's within (aqplan). Is this something we should look at now or better for later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:31:56 +0000 Subject: [Koha-bugs] [Bug 32769] Standardize structure around action fieldsets in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 14:32:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 13:32:01 +0000 Subject: [Koha-bugs] [Bug 32769] Standardize structure around action fieldsets in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145956|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 146213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146213&action=edit Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 23:13:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 22:13:22 +0000 Subject: [Koha-bugs] [Bug 32663] Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #5 from David Cook --- (In reply to Marcel de Rooy from comment #4) > `streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your > patron/borrower''s primary address', > > Are we going the right direction here? Perhaps not. Looks like borrower_modifications is out of sync with borrowers and deletedborrowers. Looks like many fields in borrower_modifications have the wrong type: streetnumber, streettype, zipcode, mobile, B_streetnumber, B_streettype, B_address, B_zipcode, password, altcontactfirstname, altcontactsurname, altcontactaddress1, altcontactaddress2, altcontactaddress3, altcontactzipcode, altcontactphone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 23:13:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 22:13:48 +0000 Subject: [Koha-bugs] [Bug 32663] Error updating personal details in OPAC when > 10 text characters entered: Main address > Street number input field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > (In reply to Marcel de Rooy from comment #4) > > `streetnumber` tinytext DEFAULT NULL COMMENT 'the house number for your > > patron/borrower''s primary address', > > > > Are we going the right direction here? > > Perhaps not. > > Looks like borrower_modifications is out of sync with borrowers and > deletedborrowers. > > Looks like many fields in borrower_modifications have the wrong type: > streetnumber, streettype, zipcode, mobile, B_streetnumber, B_streettype, > B_address, B_zipcode, password, altcontactfirstname, altcontactsurname, > altcontactaddress1, altcontactaddress2, altcontactaddress3, > altcontactzipcode, altcontactphone At least that's in kohastructure.sql. I am not sure about an upgraded database. Yikes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 23:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 22:17:54 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #39 from David Cook --- (In reply to Marcel de Rooy from comment #34) > +Max processes will be set from the command line option, the environment > variable MAX_PROCESSES, or the koha-conf file, in that order of precedence. > +By default the script will only run one job at a time. > > I think this is not needed. Confusing too. > It is already simpler if we remove the koha-conf option here. > I would opt for commandline option or default 1. Setting MAX_PROCESSES or > --max_processes is the same amount of work? If you wanted to set different options for different instances, koha-conf would be the only option that would work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 5 23:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Feb 2023 22:19:21 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #40 from David Cook --- (In reply to Marcel de Rooy from comment #35) > Not sure (yet) but should the default not be zero? Just do not fork like we > currently do? The job needs to run in a forked process. The memory used by the job can be reclaimed when the child process ends - whereas the memory will never be reclaimed by the OS if the process doesn't fork. (The memory can be re-used if it's internally freed within Perl but can't be reclaimed by the OS.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 07:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 06:34:40 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #41 from Marcel de Rooy --- (In reply to David Cook from comment #40) > (In reply to Marcel de Rooy from comment #35) > > Not sure (yet) but should the default not be zero? Just do not fork like we > > currently do? > > The job needs to run in a forked process. The memory used by the job can be > reclaimed when the child process ends - whereas the memory will never be > reclaimed by the OS if the process doesn't fork. (The memory can be re-used > if it's internally freed within Perl but can't be reclaimed by the OS.) Probably you misread my comment ;) My formulations are compact. Note that this patch leaves the original fork in the process_job sub. To keep current behavior (parent process, 1 fork in process_job) the default should be zero. Not one. "Just do not fork" refers to the extra fork that we introduce here around calling process_job. And that actually introduces a double fork that we might want to get rid of too.. So the default could be 1 IF we remove the fork in the sub. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 07:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 06:42:28 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #42 from Marcel de Rooy --- (In reply to David Cook from comment #39) > (In reply to Marcel de Rooy from comment #34) > > +Max processes will be set from the command line option, the environment > > variable MAX_PROCESSES, or the koha-conf file, in that order of precedence. > > +By default the script will only run one job at a time. > > > > I think this is not needed. Confusing too. > > It is already simpler if we remove the koha-conf option here. > > I would opt for commandline option or default 1. Setting MAX_PROCESSES or > > --max_processes is the same amount of work? > > If you wanted to set different options for different instances, koha-conf > would be the only option that would work. Okay. That would be an easier solution for that scenario. (We could even add a pref, haha.) If it will be really used like that, is still a question for me though. So, lets keep all options then, no blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 08:02:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 07:02:05 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #5 from Julian Maurice --- Ah, sorry... The call to preventDefault should be removed after bug 30975 is pushed. I'll fix the dependency order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 08:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 07:02:13 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30975 Blocks|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 08:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 07:02:13 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32817 Depends on|32817 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 08:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 07:02:31 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 09:26:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 08:26:51 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 --- Comment #6 from Thibaud Guillot --- (In reply to Katrin Fischer from comment #5) > Created attachment 146210 [details] [review] > Bug 32567: (QA follow-up) Fix some labelling inconsistencies > > This makes sure that the descriptions in the pull-downs always > match for selected/unselected. > This is not only for consistency, but will also ease translations > as simple things like an additional space will create a new > string to translate. > > Signed-off-by: Katrin Fischer Thanks Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:36:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:36:08 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #108 from Ere Maijala --- Is there a bug about adding support for this functionality to the REST API? As far as I can see, the holds endpoint doesn't currently support x-koha-embed for including information about cancel requests (for filtering the holds) or provide any way for checking if a waiting hold can be cancelled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:48:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144647|0 |1 is obsolete| | --- Comment #395 from Martin Renvoize --- Created attachment 146214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146214&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:48:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:48:30 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144648|0 |1 is obsolete| | --- Comment #396 from Martin Renvoize --- Created attachment 146215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146215&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:48:38 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144649|0 |1 is obsolete| | --- Comment #397 from Martin Renvoize --- Created attachment 146216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146216&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:48:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:48:46 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144650|0 |1 is obsolete| | --- Comment #398 from Martin Renvoize --- Created attachment 146217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146217&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:48:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:48:53 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144651|0 |1 is obsolete| | --- Comment #399 from Martin Renvoize --- Created attachment 146218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146218&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:01 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144652|0 |1 is obsolete| | --- Comment #400 from Martin Renvoize --- Created attachment 146219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146219&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:09 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144653|0 |1 is obsolete| | --- Comment #401 from Martin Renvoize --- Created attachment 146220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146220&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:17 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144654|0 |1 is obsolete| | --- Comment #402 from Martin Renvoize --- Created attachment 146221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146221&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:26 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144655|0 |1 is obsolete| | --- Comment #403 from Martin Renvoize --- Created attachment 146222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146222&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:34 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144656|0 |1 is obsolete| | --- Comment #404 from Martin Renvoize --- Created attachment 146223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146223&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:43 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144657|0 |1 is obsolete| | --- Comment #405 from Martin Renvoize --- Created attachment 146224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146224&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:51 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144658|0 |1 is obsolete| | --- Comment #406 from Martin Renvoize --- Created attachment 146225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146225&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:49:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:49:59 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144659|0 |1 is obsolete| | --- Comment #407 from Martin Renvoize --- Created attachment 146226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146226&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:08 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144660|0 |1 is obsolete| | --- Comment #408 from Martin Renvoize --- Created attachment 146227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146227&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:17 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144661|0 |1 is obsolete| | --- Comment #409 from Martin Renvoize --- Created attachment 146228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146228&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:25 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144662|0 |1 is obsolete| | --- Comment #410 from Martin Renvoize --- Created attachment 146229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146229&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:33 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144663|0 |1 is obsolete| | --- Comment #411 from Martin Renvoize --- Created attachment 146230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146230&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:41 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144664|0 |1 is obsolete| | --- Comment #412 from Martin Renvoize --- Created attachment 146231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146231&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:48 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144665|0 |1 is obsolete| | --- Comment #413 from Martin Renvoize --- Created attachment 146232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146232&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:50:57 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144666|0 |1 is obsolete| | --- Comment #414 from Martin Renvoize --- Created attachment 146233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146233&action=edit Bug 31028: (follow-up) Add
to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:51:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:51:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144667|0 |1 is obsolete| | --- Comment #415 from Martin Renvoize --- Created attachment 146234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146234&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:51:14 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144668|0 |1 is obsolete| | --- Comment #416 from Martin Renvoize --- Created attachment 146235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146235&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:51:22 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #417 from Martin Renvoize --- Created attachment 146236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146236&action=edit Bug 31028: Unit tests for ticket create notice triggers This patch adds unit tests for the two notices that can be triggered upon ticket creation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:51:30 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #418 from Martin Renvoize --- Created attachment 146237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146237&action=edit Bug 31028: Unit tests for ticket update api's This patch adds the missing unit tests for the ticket updates api endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:52:37 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 10:56:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 09:56:10 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #419 from Martin Renvoize --- Back to you Kyle.. I metric tonne of unit tests added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 11:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 10:44:07 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 --- Comment #17 from Matt Blenkinsop --- Is it not already an ENUM? Martin raised it in his feedback and it was changed in the "(follow-up) Change sql and adapt for translations" patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 11:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 10:56:23 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Matt Blenkinsop from comment #17) > Is it not already an ENUM? Martin raised it in his feedback and it was > changed in the "(follow-up) Change sql and adapt for translations" patch It is and ENUM on the DB. What's missing is reflecting that on the API. It is currently defined as a nullable string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 11:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 10:59:29 +0000 Subject: [Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642 --- Comment #19 from Matt Blenkinsop --- Ah yes I see what you mean, missed that first time round! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:12:12 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146214|0 |1 is obsolete| | --- Comment #420 from Martin Renvoize --- Created attachment 146238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146238&action=edit Bug 31028: Add `tickets` and `ticket_updates` tables This patch adds the new `tickets` and `ticket_updates` tables for tracking catalog concern tickets. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:12:23 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146215|0 |1 is obsolete| | --- Comment #421 from Martin Renvoize --- Created attachment 146239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146239&action=edit Bug 31028: DBIC Schema update Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:12:33 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146216|0 |1 is obsolete| | --- Comment #422 from Martin Renvoize --- Created attachment 146240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146240&action=edit Bug 31028: Add new Koha::Object(s) classes This patch adds new Koha::Object(s) for the newly introduced tables, including updateing existing Koha::Objects adding new relations as required. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:12:43 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146217|0 |1 is obsolete| | --- Comment #423 from Martin Renvoize --- Created attachment 146241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146241&action=edit Bug 31028: Add API's for tickets This patch adds basic CRUD API's for the ticket endpoints. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:12:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:12:57 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146218|0 |1 is obsolete| | --- Comment #424 from Martin Renvoize --- Created attachment 146242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146242&action=edit Bug 31028: Add `OpacCatalogConcerns` preference Enabling this preference should allow catalog concerns to be added by logged in patrons on the opac. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:10 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146219|0 |1 is obsolete| | --- Comment #425 from Martin Renvoize --- Created attachment 146243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146243&action=edit Bug 31028: Add ability to report catalog concerns from the OPAC This patch adds the ability for patrons to report catalog concerns via the opac. Test plan 1) Enable the new `OpacCatalogConcerns` system preference 2) Navigate to the record details page of a biblio record on the OPAC 3) You should see a new 'Report a concern' option in the right side actions box 4) If not logged in you should have the login modal displayed and upon a successful login you should be redirected back to the details page with a new model displayed for entering concern details 5) Submit your concern with a title and details. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:22 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146220|0 |1 is obsolete| | --- Comment #426 from Martin Renvoize --- Created attachment 146244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146244&action=edit Bug 31028: Add configurable help text and templates This patch adds configurable help text and a template option to the catalog concern report modal in the OPAC. Test plan 1) Enable `OpacCatalogConcerns` preference 2) Build the CSS for the OPAC 3) Check that there is a 'CatalogConcernHelp' block listed in the HTML Customisations page. 4) On the OPAC navigate to a record and click the 'Report a concern' button. 5) Confirm that the content of 'CatalogConcernHelp' displays beneath the detail entry box and that it displays as expected. 6) Check that there is a 'CatalogConcernTemplate' block listed in the HTML customisations page. 7) On the OPAC 'Report a concern' modal, you should see the content of the 'CatalogConcernTemplate' block pre-filled in the details textarea. Note: There is a caveat to the template.. as textarea can only be used to submit plaintext with this patch and as such the template needs to not utilise the WYSIWYG editor else you will be faced with raw HTML inside your textarea. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:32 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146221|0 |1 is obsolete| | --- Comment #427 from Martin Renvoize --- Created attachment 146245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146245&action=edit Bug 31028: Add acknowledgement notice This patch adds an acknowledgement notice that will be sent to the opac user upon submission of a catalog concern report. Test plan 1) Confirm that a new notice template is added to the notices management page. 2) If using a sandbox, check the 'email log' from the management UI to see the resultant notice has been 'sent' Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:42 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146222|0 |1 is obsolete| | --- Comment #428 from Martin Renvoize --- Created attachment 146246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146246&action=edit Bug 31028: Add catalog concern management page to staff This patch adds a catalog concern management page to the staff client accessible via the cataloging home page and a new 'Pending catalog concerns' link on the front page. This includes added the requisit ticket_updates api endpoints and notice triggers and templates for notifying patrons of changes to their reported concerns. Test plan 1) Enable the `OpacCatalogConcerns` system preference 2) Catalog concern management is tied to your users ability to edit the catalog, `editcatalogue`. 3) Confirm that you can see 'Catalog concerns' listed on the cataloging home page if you have the `editcatalogue` permission and not if you do not. 4) Add a new concern as an opac user. 5) Confirm that once a concern is present in the system you see a count of 'catalog concerns pending' on the intranet main page if you have the `editcatalogue` permission. 6) Click through either the cataloging home page or pending concerns link on the main page to view the new concerns management page. 7) Confirm the table displays as one would expect. 8) Confirm clicking on details or the concern title exposes a 'details' modal with the option to add an update or resolve the concern. 9) Verify that if selecting 'notify' when updateing or resolving a concern triggers a notice to be sent to the opac user who first reported the issue. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:51 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146223|0 |1 is obsolete| | --- Comment #429 from Martin Renvoize --- Created attachment 146247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146247&action=edit Bug 31028: Add email notification of cataloguers on submissions This patch adds an optional cataloger notification to email the cataloging team whenever a new catalog concern is reported. Test plan 1) Enable `OpacCatalogConcerns` 2) Add at least one email address to the new `CatalogerEmails` prefernce (a comma delimited list is also allowed). 3) Confirm that a default template has been added to the Notices management, `TICKET_NOTIFY`. 4) Submit a new concern using the OPAC 5) Confirm that an email is sent to those email addresses listed in CatalogerEmails. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:13:59 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146224|0 |1 is obsolete| | --- Comment #430 from Martin Renvoize --- Created attachment 146248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146248&action=edit Bug 31028: Add ability to report concerns from the staff interface This patch brings the CatalogConcerns feature to the staff client allowing non-cataloguers to report issues with catalog records from the record details page. Test plan 1) Enable the new `CatalogConcerns` system preference 2) Confirm that without the `edit_catalogue` permission your user can submit a catalog concern via `New -> New catalog concern` from the toolbar on a records detail display. 3) Confirm that the right user was recorded as the reporter on the catalog concern management page (You must have logged in again as a user with the `edit_catalogue` permission to see this page. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:10 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146225|0 |1 is obsolete| | --- Comment #431 from Martin Renvoize --- Created attachment 146249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146249&action=edit Bug 31028: Add display to details page This patch adds the display of biblio specific concerns to the biblio detail display page. Test plan 1) Enable the feature as in prior patch test plans 2) Add a concern as per prior patch test plans 3) Confirm that a new tab appears at the bottom of the catalog record details display and all functionality from the concern management page is precent. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:21 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146226|0 |1 is obsolete| | --- Comment #432 from Martin Renvoize --- Created attachment 146250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146250&action=edit Bug 31028: (follow-up) System preference terminology Capitalise NOTE and swap 'client' for 'interface'. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:30 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146227|0 |1 is obsolete| | --- Comment #433 from Martin Renvoize --- Created attachment 146251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146251&action=edit Bug 31028: Only show pending concerns if there are some This patch adds logic to catch when pending_biblio_tickets equals zero. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:39 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146228|0 |1 is obsolete| | --- Comment #434 from Martin Renvoize --- Created attachment 146252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146252&action=edit Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop the 'MENT' to ensure it fits. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:47 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146229|0 |1 is obsolete| | --- Comment #435 from Martin Renvoize --- Created attachment 146253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146253&action=edit Bug 31028: (follow-up) Update notice module codes This patch updates the notice codes from 'catalog' to 'catalogue' to be consistent with the existing codebase. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:14:56 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146230|0 |1 is obsolete| | --- Comment #436 from Martin Renvoize --- Created attachment 146254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146254&action=edit Bug 31028: (follow-up) Consistently style help-block This patch updates the opac and staff modals to set the help-block inside a div instead of a paragraph element allowing for the wysiwyg edited content to display as prescribed. We move the scss inside the fieldset definition to ensure we are specific enough to catch only the intended elements. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:04 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146231|0 |1 is obsolete| | --- Comment #437 from Martin Renvoize --- Created attachment 146255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146255&action=edit Bug 31028: Add feedback to the patron on submission This patch adds a success alert box when a patron submits a concern sucessfully. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:14 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146232|0 |1 is obsolete| | --- Comment #438 from Martin Renvoize --- Created attachment 146256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146256&action=edit Bug 31028: (follow-up) Fix permissions names Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:23 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146233|0 |1 is obsolete| | --- Comment #439 from Martin Renvoize --- Created attachment 146257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146257&action=edit Bug 31028: (follow-up) Add
to notices This should resolve the lack of linebreaks in resulting emails Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:32 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146234|0 |1 is obsolete| | --- Comment #440 from Martin Renvoize --- Created attachment 146258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146258&action=edit Bug 31028: (follow-up) Fix notices whitespace We we're using [% %] rather than [%- -%] in our the notice template introduced with this patchset. This leads to some interesting rendering results in some email clients. Using the proper whitespace ignoring template markup fixes the situation. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:41 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146235|0 |1 is obsolete| | --- Comment #441 from Martin Renvoize --- Created attachment 146259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146259&action=edit Bug 31028: Update patron and biblio includes to remove whitespace These includes used lots of [% %] blocks instead of [%- -%] and as such the produced markup contains superflous spacing. This is OK in the browser, but for some reason does affect rendering in HTML email. Signed-off-by: David Nind Signed-off-by: Helen Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:15:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:15:51 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146236|0 |1 is obsolete| | --- Comment #442 from Martin Renvoize --- Created attachment 146260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146260&action=edit Bug 31028: Unit tests for ticket create notice triggers This patch adds unit tests for the two notices that can be triggered upon ticket creation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:16:00 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146237|0 |1 is obsolete| | --- Comment #443 from Martin Renvoize --- Created attachment 146261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146261&action=edit Bug 31028: Unit tests for ticket update api's This patch adds the missing unit tests for the ticket updates api endpoints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:16:10 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #444 from Martin Renvoize --- Created attachment 146262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146262&action=edit Bug 31028: (follow-up) Mark public as boolean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:34:00 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 12:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 11:34:06 +0000 Subject: [Koha-bugs] [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146022|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop --- Created attachment 146263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146263&action=edit Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 13:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 12:24:25 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #7 from Jonathan Field --- So, if I understand this correctly, what we are trying to do here is take a MARC record (not necessarily print serial, could be an ebook or eaudio MARC record for example) and upload it into Koha in ERM as an eresource title? In the database structure this is essentially KBART2 format so the mappings are MARC21 -> KBART. Right now, I think we only take the most basic information. I hope I've understood that correctly? There are a few people who have already trod this path I believe, for example: https://github.com/zbw/marc2kbart/blob/master/imf/marc2kbart.fix and https://github.com/adambuttrick/marc_to_kbart/blob/master/convert.py These mappings make sense to me. We will never get a perfect match as some KBART fields are simply not described in MARC. For example, embargo_info means "you can't use this material until this date". That would never exist in MARC. I think it's possible that quite a lot of the fields you listed would not naturally be found in MARC. What do you think Heather/Katrin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 13:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 12:52:19 +0000 Subject: [Koha-bugs] [Bug 32728] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145897|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 146264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146264&action=edit Bug 32728: ERM - Update search header depending on navigation Search header should change to match the section you are in. Default is "agreement". If you are in "local titles" or "local packages", the header will be positionned on the relevant tab. Signed-off-by: Jonathan Field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 13:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 12:52:23 +0000 Subject: [Koha-bugs] [Bug 32728] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:00:56 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:00:59 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146180|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146265&action=edit Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:10:09 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:14:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:14:53 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:14:56 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 --- Comment #2 from Owen Leonard --- Created attachment 146266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146266&action=edit Bug 31413: Set focus for cursor to Selector when adding a new audio alert This patch adds a step to the process of displaying the new audio alert form so that focus will be set to the first field when the form has finished appearing. The typical "focus" class only works on elements which are present in the initial DOM when the page is displayed. To test, apply the patch and go to Administration -> Audio alerts. Click the "New alert" button. When the form appears cursor focus should be on the "Selector" field. Also test the edit process: When editing an existing alert there should not be automatic cursor focus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:28:38 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:28:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:28:41 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146177|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146267&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:36:11 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:36:15 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146176|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146268&action=edit Bug 28674: Fix typo 'hlpd' in schema comments Fixes the lines for old_reserves.item_level_hold and reserves.item_level_hold comments to read 'hold' instead of 'hpld' To test: * The easiest way to verify this change is by looking at the patch itself Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:39:13 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:39:17 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146178|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146269&action=edit Bug 31407: Set focus for cursor to Currency when adding a new currency This makes sure that the focus is on the first field of the form when adding a new currency. To test: * Go to administration > currencies * Add a new currency * Verify the focus is not on the form * Apply patch * Repeat, verify the focus is now on the first input "currency" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:42:54 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:43:13 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:43:14 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146179|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146270&action=edit Bug 31409: Set focus for cursor to Fund code when adding a new fund This makes sure that the focus is on the first input field of the form when adding or editing a fund. To test: * Go to administration > funds * Add a new fund to the budget * Verify the focus is not inside the form * Apply patch * Verify the focus is now in the first form field "Fund code" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:46:26 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:46:30 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146181|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146271&action=edit Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:51:50 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:51:53 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146182|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146272&action=edit Bug 32226: Fix capitalization of "Add/Edit html content" HTML is an abbreviation and as such should always be capitalized. To test: * Go to administration > libraries * Edit any existing branch * The hint for OPAC info reads 'Add html content' * Add some content, verify the link changes to 'Edit html content' * Apply patch * Verify both cases now read 'HTML' Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:53:44 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:53:47 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146183|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146273&action=edit Bug 32230: Fix capitalization of "Manage Domains" To test: * Go to administration > Identity providers * Add a new identity provider and fill out all required form fields Hint: you can use the buttons to add example JSON to the input fields * Save * Verify the entry in the table now shows a "Manage Domains" button * Apply patch * Verify the button now reads correctly: "Manage domains" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:58:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:58:55 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 14:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 13:58:58 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146184|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146274&action=edit Bug 32264: Fix capitalization and terminology: Show in Staff client? This fixes several occurences of Staff client to read staff interface. To test: * Activate the search filter feature via the SavedSearchFilters system preference * Do a search in the staff catalogue * Use the link "save as search filter" on top of the results list * Verify it reads "Show in Staff client?" in the form * Go to administration > search filters * Verify the table has a heading "staff client" * Edit the filter * Verify there is the "Show in staff client" again * Apply patch * All those spots should now read 'staff interface' Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:01:29 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:01:33 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146185|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146275&action=edit Bug 32294: Fix capitalization for user ID in self checkout Fixes capitalization of "user ID" on the self checkout help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify there is a User ID within a sentence and a User id in the heading * Apply patch * Both should be corrected Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:04:26 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:04:30 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146186|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146276&action=edit Bug 32295: Fix punctuation for "Filters :" on serials claims page To test: * Add a subscription * Generate next issue, to have a late one * Go to serials > claims * Select your vendor * Verify one of the sections is labelled "Filters :" * Apply patch * Verify the section is now labelled "Filters:" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:07:04 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:09:37 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:09:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:09:41 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146187|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146277&action=edit Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:12:48 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #10 from Felicity Brown --- Correct. The full word "Staff" is much more helpful than the abbreviation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:17:06 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:22:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:22:53 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:22:57 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146190|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 146278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146278&action=edit Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checked out out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 15:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 14:36:05 +0000 Subject: [Koha-bugs] [Bug 19587] "Place request with partners" button must be hidden if no partners defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #1 from Pedro Amorim --- This button only shows if the request's backend has the GENREQ status configured in the status_graph, on the current request's status "next_actions" array. Additionally, currently if there are partners but none of the partners have an e-mail address, the drop-down selection for partners shows empty, i.e. the page is accessible but not functional. This should also be taken into account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:30:23 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #6 from Lucas Gass --- (In reply to Julian Maurice from comment #5) > Ah, sorry... > The call to preventDefault should be removed after bug 30975 is pushed. I'll > fix the dependency order Ah I see, thanks! It looks like the dependency order for most the bugs linked to Bug 30975 need changed as well, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:36:12 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:36:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:36:16 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146266|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146279&action=edit Bug 31413: Set focus for cursor to Selector when adding a new audio alert This patch adds a step to the process of displaying the new audio alert form so that focus will be set to the first field when the form has finished appearing. The typical "focus" class only works on elements which are present in the initial DOM when the page is displayed. To test, apply the patch and go to Administration -> Audio alerts. Click the "New alert" button. When the form appears cursor focus should be on the "Selector" field. Also test the edit process: When editing an existing alert there should not be automatic cursor focus. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:40:21 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:40:26 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 --- Comment #1 from Jonathan Druart --- Created attachment 146280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146280&action=edit Bug 32786: Display admin header on curbside pickup admin Most other administration pages (those that don't have specific searches) are set by default on system preferences search. Test plan: Go to admin > Curbside pickup Confirm that the syspref search is displayed in the header -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:40:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:40:43 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:40:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:40:49 +0000 Subject: [Koha-bugs] [Bug 32817] Fix cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #7 from Julian Maurice --- (In reply to Lucas Gass from comment #6) > Ah I see, thanks! It looks like the dependency order for most the bugs > linked to Bug 30975 need changed as well, right? No, most of them are really required for bug 30975. This one was only an unnecessary cleanup (bug 30975 adds the call to event.preventDefault outside of the plugin code). There might be others, i will check them all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:43:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:43:53 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30975 | Summary|Fix |Clean up |cataloguing/value_builder/m |cataloguing/value_builder/m |arc21_field_005.pl |arc21_field_005.pl --- Comment #2 from Julian Maurice --- This one is actually only a cleanup patch that is not needed for bug 30975. Removing the dependency link Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:43:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:43:53 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32818 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:43:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:43:57 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:45:55 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:45:59 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146277|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146281&action=edit Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:48:36 +0000 Subject: [Koha-bugs] [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30975 | Depends on| |30975 --- Comment #2 from Julian Maurice --- This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:48:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:48:36 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32865 Depends on|32865 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Fix cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:48:51 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:48:51 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:49:31 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Clean up |cataloguing/value_builder/u |cataloguing/value_builder/u |nimarc_field_146h.pl |nimarc_field_146h.pl Depends on| |30975 Blocks|30975 | --- Comment #2 from Julian Maurice --- This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:49:31 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32866 Depends on|32866 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:50:28 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30975 Blocks|30975 | Summary|Fix |Clean up |cataloguing/value_builder/u |cataloguing/value_builder/u |nimarc_field_146i.pl |nimarc_field_146i.pl --- Comment #2 from Julian Maurice --- This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:50:28 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32867 Depends on|32867 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:50:37 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:50:40 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146275|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146282&action=edit Bug 32294: Fix capitalization for user ID in self checkout Fixes capitalization of "user ID" on the self checkout help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify there is a User ID within a sentence and a User id in the heading * Apply patch * Both should be corrected Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:50:58 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com QA Contact| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:51:33 +0000 Subject: [Koha-bugs] [Bug 32877] Clean up cataloguing/value_builder/upload.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Clean up |cataloguing/value_builder/u |cataloguing/value_builder/u |pload.pl |pload.pl Depends on| |30975 Blocks|30975 | --- Comment #3 from Julian Maurice --- This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:51:33 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32877 Depends on|32877 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 [Bug 32877] Clean up cataloguing/value_builder/upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:53:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:53:16 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:53:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:53:21 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #1 from Jonathan Druart --- Created attachment 146283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146283&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by staged (mark as staged) date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:53:46 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:54:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:54:41 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #2 from Jonathan Druart --- We could add DataTables to those tables, but this one line patch is fixing the default sort. It should be done on a separate bug in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:55:11 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Clean up |cataloguing/value_builder/d |cataloguing/value_builder/d |ateaccessioned.pl |ateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:55:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:55:18 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Clean up |cataloguing/value_builder/u |cataloguing/value_builder/u |nimarc_field_146a.pl |nimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:55:23 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:56:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:56:47 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:56:51 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146274|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146284&action=edit Bug 32264: Fix capitalization and terminology: Show in Staff client? This fixes several occurences of Staff client to read staff interface. To test: * Activate the search filter feature via the SavedSearchFilters system preference * Do a search in the staff catalogue * Use the link "save as search filter" on top of the results list * Verify it reads "Show in Staff client?" in the form * Go to administration > search filters * Verify the table has a heading "staff client" * Edit the filter * Verify there is the "Show in staff client" again * Apply patch * All those spots should now read 'staff interface' Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:03 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:06 +0000 Subject: [Koha-bugs] [Bug 32401] x-koha-query cannot contain non-ISO-8859-1 values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32401 --- Comment #14 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:09 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:12 +0000 Subject: [Koha-bugs] [Bug 32406] Cannot search pending orders using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32406 --- Comment #10 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:14 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:17 +0000 Subject: [Koha-bugs] [Bug 32409] Cannot search cashups using non-latin-1 scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32409 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:20 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:23 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #34 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:26 +0000 Subject: [Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:29 +0000 Subject: [Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #10 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:32 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:35 +0000 Subject: [Koha-bugs] [Bug 32673] Remove misc/load_testing/ scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32673 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:38 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:41 +0000 Subject: [Koha-bugs] [Bug 32741] Attribute codes should not be repeated in bib1.att In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32741 --- Comment #12 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:44 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:47 +0000 Subject: [Koha-bugs] [Bug 32779] Import from list is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32779 --- Comment #9 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:49 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 16:58:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 15:58:52 +0000 Subject: [Koha-bugs] [Bug 32797] Cannot save OAI set mapping rule for subfield 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32797 --- Comment #5 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:06:18 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:06:23 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 --- Comment #2 from Jonathan Druart --- Created attachment 146285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146285&action=edit Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:07:05 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:10:53 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:10:57 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146273|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146286&action=edit Bug 32230: Fix capitalization of "Manage Domains" To test: * Go to administration > Identity providers * Add a new identity provider and fill out all required form fields Hint: you can use the buttons to add example JSON to the input fields * Save * Verify the entry in the table now shows a "Manage Domains" button * Apply patch * Verify the button now reads correctly: "Manage domains" Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:14:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:14:07 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #43 from Jonathan Druart --- Could you remind me why we need this? Why don't you just run another worker? This area has not been very stable in the last releases and I am not sure we should play with more forking and introduce possible regressions when an alternative (run more workers) is already available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:14:11 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:14:15 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146280|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 146287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146287&action=edit Bug 32786: Display admin header on curbside pickup admin Most other administration pages (those that don't have specific searches) are set by default on system preferences search. Test plan: Go to admin > Curbside pickup Confirm that the syspref search is displayed in the header Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:14:30 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:14:34 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146269|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 146288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146288&action=edit Bug 31407: Set focus for cursor to Currency when adding a new currency This makes sure that the focus is on the first field of the form when adding a new currency. To test: * Go to administration > currencies * Add a new currency * Verify the focus is not on the form * Apply patch * Repeat, verify the focus is now on the first input "currency" Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:23:25 +0000 Subject: [Koha-bugs] [Bug 32658] Use template wrapper in order from staged file template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32658 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:23:29 +0000 Subject: [Koha-bugs] [Bug 32658] Use template wrapper in order from staged file template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32658 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145568|0 |1 is obsolete| | Attachment #145569|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 146289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146289&action=edit Bug 32658: Use template wrapper in order from staged file template This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the page for adding to a basket from a staged file. To test you need an active vendor, at least one basket for that vendor, and a staged MARC file. Apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add to orders" on one of your staged files. - On the "Add orders from..." page you should see three tabs, the first one active. - Tabs should look correct and work correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:23:34 +0000 Subject: [Koha-bugs] [Bug 32658] Use template wrapper in order from staged file template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32658 --- Comment #7 from Owen Leonard --- Created attachment 146290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146290&action=edit Bug 32658: (follow-up) Use more unique variable name to avoid collisions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:25:07 +0000 Subject: [Koha-bugs] [Bug 32889] New: Improve audio alert page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32889 Bug ID: 32889 Summary: Improve audio alert page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A couple things I noticed on audio_alerts.tt that could be better: Add/edit an alert: The breadcrumbs don't change. When adding an alert the breadcrumbs should be something like: Administration > Audio alerts > New alert When editing they should be something like: Administration > Audio alerts > Modify audio alert 'X' Also when adding/editing: If you use your browsers back button you are taken back to the Administration main page when you should go back to the Audio alerts main page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:27:47 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:27:50 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 --- Comment #10 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:27:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:27:53 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:27:57 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #35 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:00 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:03 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #11 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:05 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:08 +0000 Subject: [Koha-bugs] [Bug 32546] Move ILL system preferences to their own tab in administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:11 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:13 +0000 Subject: [Koha-bugs] [Bug 32655] Variables showing in patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32655 --- Comment #9 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:16 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:19 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 --- Comment #10 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:22 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:24 +0000 Subject: [Koha-bugs] [Bug 32785] Typo: Maximum number of simultaneus pickups per interval (curbside pickups) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32785 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:26 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:28:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:28:29 +0000 Subject: [Koha-bugs] [Bug 32793] import_patrons.pl typo in usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32793 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:47:09 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #3 from Caroline Cyr La Rose --- The patch works as advertised. I'm not sure about the "Staged and ready" order... Shouldn't it still be by scheduled pickup time? I've never used this IRL, so I'm not sure of the workflow, but I feel like I could prepare the pickups in any order (as I come to them on my holds shelf for example, or I picked them up on my holds shelf, put them on a cart and went to my desk to scan them), but I'd still want to see the most "pressing" at the top, so I can check if the patron is there... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:51:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:51:13 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:51:17 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146285|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose --- Created attachment 146291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146291&action=edit Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 17:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 16:51:33 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 --- Comment #4 from Caroline Cyr La Rose --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:00:30 +0000 Subject: [Koha-bugs] [Bug 32890] New: Add DataTables to curbside pickups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Bug ID: 32890 Summary: Add DataTables to curbside pickups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org This comes from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883#c2 I'm creating a new bug report as it was outside the scope of the other one. I suggested adding Datatables to the curbside pickup module, to be able to manage the ordering and the columns in table settings. - "To be staged" tab - "Staged & ready" tab - "Patron is outside" tab - "Delivered today" tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:01:01 +0000 Subject: [Koha-bugs] [Bug 32890] Add DataTables to curbside pickups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32883 Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:01:01 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 [Bug 32890] Add DataTables to curbside pickups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:01:01 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:02:04 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #4 from Caroline Cyr La Rose --- I created bug 32890 for the datatables thing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:10:33 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146037|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 146292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146292&action=edit Bug 32804: Add unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:10:45 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #5 from Kyle M Hall --- Created attachment 146293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146293&action=edit Bug 32804: Do not adjust biblionumber when replacing items during import This patch adjust the item matching at import to confirm that for a duplicate itemnumber or barcode matches an existing item in the DB and uses the original biblionumber when updating the item. When ordering in a consortium the items may be moved around, duplicate biblios added, and various matches found. We should not allow importing of items to move them from 1 biblio to another, but we should allow the imports to succeed and assume itemnumber or barcode matches are authoritative. The responsibility for correct matching of items to biblio should fall on the creator of the files To test: 1 - Be using the sample data in koha testing docker 2 - Stage the sample file on this report 3 - Match on KohaBiblio(999$c) / Item processing: replace 4 - Note the biblio match is "The complete novels / Austen, Jane" 5 - View the staged marc, note the barcode 39999000004090 in an item 6 - Search for that barcode 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert" 8 - Import the file 9 - Check the db: SELECT * FROM items WHERE biblionumber != biblioitemnumber; 10 - Note the mismatch 11 - Fix the item and set it as 'Music' type UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE biblionumber != biblioitemnumber; 12 - Apply patch, restart all 13 - Stage and import the file with the same settings 14 - Confirm the item is modified on its original biblio (99) and that item type is Book again 15 - Change itemnumber to avoid itemnumber match and reset type UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212; 16 - Stage and import with the same setttings 17 - Confirm the marcode match worked and item is updated to book on original record 18 - Delete the original item 19 - Stage and import the file with the same settings 20 - The item is successfully created 21 - Stage and import, but item processing option is 'add' 22 - Confirm 1 item ignored 23 - Check the db SELECT * FROM import_items WHERE barcode=39999000004090 24 - Confirm there is a line with 'error' and duplicate_barcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 18:59:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 17:59:15 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 --- Comment #3 from Katrin Fischer --- Thanks Owen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:00:55 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #11 from Katrin Fischer --- (In reply to Felicity Brown from comment #10) > Correct. The full word "Staff" is much more helpful than the abbreviation. Thx Felicity! The full description will display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:07:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:07:39 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #12 from Hammat wele --- Created attachment 146294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146294&action=edit Bug 32341: (follow-up) Making the remains OPAC tables responsive Apply the patch and check for the responsivity of the following tables 1- Go to the OPAC 2- Open mobile mode 3- The following tables are not responsive - Summary - Clubs - Summary - Recalls - Summary - Article requests - Charges - (relative's) - Search history - Authority - Checkout history - All - Checkout history - Checkouts - Checkout history - On-site - Recalls history - Messaging - Subscription (serial) - Course reserves - Courses - Course reserves - Reserves - Authority search results 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform previous step (1-3) 8- Confirm that the tables are now displayed correctly and is now responsive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:11:32 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 --- Comment #8 from Heather --- If this bug is for mapping MARC21 --> KBARTx, then disregard my comments! (I have no experience with this and can't imagine my library being interested in it.) However, I do have experience with mapping MARC21, so could chime in about that if helpful. If this bug is for creating a way (macro?) to create a MARC21 eResource record from a MARC21 non-eResource record, then I'm interested in that & my comments might be helpful. (I wish I spoke Developer better!!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:13:09 +0000 Subject: [Koha-bugs] [Bug 32891] New: Curbside pickups - Wrong slot selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Bug ID: 32891 Summary: Curbside pickups - Wrong slot selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Sometimes, I get an error message "Wrong slot selected". I'm hoping someone will understand why this happens. I think it's a bug since the selected slot exists, is displayed and the maximum number of patrons hasn't been reached. Here is my curbside pickup config https://snipboard.io/o6sqi1.jpg I selected 19:40 for today, Monday, Feb 6 https://snipboard.io/r1HdBz.jpg (I did this a bit before 11:30 (screenshot was taken at 11:23:49), if that changes something) The slot has no patrons, and when clicked it becomes green Wrong slot selected https://snipboard.io/w7WzTm.jpg This completely stops the scheduling process. I have to search for the patron again and select another slot to try again. There's no way to know which slot is "wrong" so it's trial and error until I get one that is ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:13:39 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Wrong slot selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:20:20 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:20:40 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146168|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:20:55 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:21:11 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:23:54 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 146295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146295&action=edit Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <>

Discharge confirmation

<> certifies that the following borrower:
<> <> (cardnumber: <>)
has returned all items.

3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:24:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:24:27 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 146296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146296&action=edit Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:24:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:24:56 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 146297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146297&action=edit Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:27:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:27:19 +0000 Subject: [Koha-bugs] [Bug 32892] New: Email template used when generating DISCHARGE PDF Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32892 Bug ID: 32892 Summary: Email template used when generating DISCHARGE PDF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The generated PDF discharge letter always picks the 'email' transport by default. This means users expecting to define a 'print' version of the discharge notice get confgused and/or wrong results. This was highlighted by bug 14251, which fixed styling the PDF with CSS, which is only picked if the 'email' transport letter is used. It is trivial to see this doesn't work as no transport is passed to GetPreparedLetter, which then defaults to 'email'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:27:50 +0000 Subject: [Koha-bugs] [Bug 32892] Email template used when generating DISCHARGE PDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32892 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |14251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 [Bug 14251] Allow use of CSS in discharge letter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:27:50 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32892 [Bug 32892] Email template used when generating DISCHARGE PDF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 19:40:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 18:40:11 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Wrong slot selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |david at davidnind.com --- Comment #1 from David Nind --- I tested Caroline's setup and I get the same message as well: 1. I don't think it is the order of the time slots, as it happened to me for a day when they were in order (Monday) (see bug 32788). 2. I changed Henry's home library to Centerville, but the message still occurred. 3. I couldn't see any errors in the browser console or error logs. 4. I also tried days a week or two in the future, but it still occurred. 5. There are tests (in t/db_dependent/Koha/CurbsidePickups.t) that generate the "Wrong slot selected" message - they seem logical, but shouldn't be something that you can replicate in the staff interface as you can only select from the date and times configured and displayed: #Day is not ok Cannot create a pickup on a day without opening slots defined #Day ok but datetime not ok Cannot create a pickup on a time without opening slots defined #Day ok, datetime inside the opening slot, but wrong (15:15 for instance) Cannot create a pickup on a time that is not matching the start of an interval IRC log discussion links: * 2023-02-03: https://irc.koha-community.org/koha/2023-02-03#i_2470945 * 2023-02-06: https://irc.koha-community.org/koha/2023-02-06#i_2471054 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:18:29 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin Somers --- > Circulation statistics show error 500 when the tables 'items' and 'deleteditems' do not have the same number of columns. How can this be ? On item deletion we move datas from items to deleteditems via Koha::Items move_to_deleted() : https://git.koha-community.org/Koha-community/Koha/src/commit/1b6e9c7bd1c6e50ab610c6d15fe2e46af2f666ec/Koha/Item.pm#L332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:26:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:26:52 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 --- Comment #14 from Fridolin Somers --- Maybe linked to Bug 30392 ? But I dont se how it can go wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:34:17 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:34:17 +0000 Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32511 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:34:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:34:28 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 --- Comment #15 from Fridolin Somers --- See also Bug 21982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:25 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:29 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:32 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 --- Comment #16 from Fridolin Somers --- On current master, I have a different error message : CGI::Compile::ROOT::kohadevbox_koha_reports_issues_stats_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.statistics.datetime' isn't in GROUP BY at /kohadevbox/koha/reports/issues_stats.pl line 92 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:35 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:40 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:44 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:48 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:51 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:35:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:35:56 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:03 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:06 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:10 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:13 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:16 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:20 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:23 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:28 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:32 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:36 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:40 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:36:43 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:43:11 +0000 Subject: [Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:43:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:43:53 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io --- Comment #5 from Agustín Moyano --- Hi Jonathan, to reuse stuff I like your idea to create folders by type (routes, stores, components, ..). Maybe we can add another folder named "modules" where we place all "main.ts" files, renaming them as "erm.ts" or "import_sources.ts". Or, instead of creating a "modules" folder, we could have a single "main.ts" and make all modules in routes to lazy load ( https://router.vuejs.org/guide/advanced/lazy-loading.html ) About the components folder, in my implementation, I added a "shared" subfolder for all shared components, but I don't mind keeping them in the components folder directly. I loved the idea of generating the breadcrumbs from the router specification, but the definition of it was kind of confusing, and hard to follow, so I took your idea and changed it a little bit. I added a couple more shared components, one of them being the implementation of Datatables in Vue (called KohaTables). I see that you have here the "composable" folder where you call functions of Datatables, but I saw that the creators of Datatables had an implementation for Vue, so I thought it best to use that. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:44:16 +0000 Subject: [Koha-bugs] [Bug 32023] Remove hr in opac-page.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:46:18 +0000 Subject: [Koha-bugs] [Bug 32023] Remove hr in opac-page.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:46:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:46:22 +0000 Subject: [Koha-bugs] [Bug 32023] Remove hr in opac-page.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #1 from Katrin Fischer --- Created attachment 146298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146298&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a
above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:46:50 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove hr in opac-page.tt |Remove horizontal line from | |OPAC navigation for CMS | |pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:50:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:50:46 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:56:44 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 22:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 21:56:48 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 --- Comment #1 from Katrin Fischer --- Created attachment 146299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146299&action=edit Bug 32027: Fix 'librarian interface' to use 'staff interface' in Pages/HTML customizations/News This changes all occurences of "librarian interface" to the correct term "staff interface" To test: * Create a new Page * Verify that the pull down for location has "librarian interface" * Save your page * Verify that the list of existing pages has "Librarian interface" as label for the link * Verify that when you hover over on those links the titles read "librarian interface" as well * Apply patch * All those should read correctly now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:02:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:02:17 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:02:22 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146298|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 146300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146300&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a
above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:02:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:02:48 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:04:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:04:46 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #3 from Caroline Cyr La Rose --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:08:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:08:26 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:08:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:08:30 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 --- Comment #2 from Katrin Fischer --- Created attachment 146301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146301&action=edit Bug 31768: Add tools toolbar to tags page The tags tool was missing the toolbar on the left side. With the filters, this patch adds the toolbar below, like we do on other pages like HTML customizations. To test: * Go to Tools > Tags * Verify no toolbar * Apply patch * Verify toolbar is now present * Compare to other tool pages * Sign off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:09:02 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:09:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:09:06 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146299|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 146302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146302&action=edit Bug 32027: Fix 'librarian interface' to use 'staff interface' in Pages/HTML customizations/News This changes all occurences of "librarian interface" to the correct term "staff interface" To test: * Create a new Page * Verify that the pull down for location has "librarian interface" * Save your page * Verify that the list of existing pages has "Librarian interface" as label for the link * Verify that when you hover over on those links the titles read "librarian interface" as well * Apply patch * All those should read correctly now. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:09:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:09:23 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 --- Comment #3 from Caroline Cyr La Rose --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:17:13 +0000 Subject: [Koha-bugs] [Bug 32893] New: ILL item flag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32893 Bug ID: 32893 Summary: ILL item flag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It might be worth considering having an ILL flag on item records that one could define certain actions for. I know that bug 22939 was recently signed off, but I was thinking, if one could flag an item as ILL, then perhaps in settings you could define how due dates are set. Maybe it is a hard due date as defined in that bug. Some libraries put the ILL on hold. Maybe the due date is calculated from the day day it went on hold minus the number of days it sat waiting before the item was checked out? Maybe there are other things you need it to do based on the flag. Maybe a redirection to a staff member when checked in? I'm spit-balling here because I don't know a lot about the current ILL module. Documentation is scarce, and it is fairly new, and there are several things that still need to be worked out there that we can do outside of the module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:17:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:17:55 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descrpitions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|952$h - Serial enumeration |Standardize capitalization |/ chronology: use sentence |for item subfield |case for label |descrpitions (UNIMARC | |995/MARC21 952) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:19:08 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Standardize capitalization |Standardize capitalization |for item subfield |for item subfield |descrpitions (UNIMARC |descriptions (UNIMARC |995/MARC21 952) |995/MARC21 952) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:21:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:21:50 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #44 from David Cook --- (In reply to Jonathan Druart from comment #43) > Could you remind me why we need this? Why don't you just run another worker? > This area has not been very stable in the last releases and I am not sure we > should play with more forking and introduce possible regressions when an > alternative (run more workers) is already available. I could be wrong but I think the premise of this change is that it would be more difficult to update koha-worker and koha-common.init to allow for a configurable number of workers than it would be to add more forks. However, I agree that it would be preferable to just run more workers. Even if it's easier to fork, I don't think this patch goes about it quite the right way... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:25:41 +0000 Subject: [Koha-bugs] [Bug 32893] ILL item flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32893 --- Comment #1 from Katrin Fischer --- We usually know the records linked to an ILL request and also knows the items that are ILL from this. I don't think a specific flag would be a technical requirement. Our backend uses a due date that the library sets/stores when the ILL item arrives at the library. When the item is checked out in the circulation module, it uses it, or when left empty, the circulation conditions are used. We use specific item types for ILL items and a message can be set for these to be displayed on return. Or you could include an option to set $3 in your ILL backend if you need the note to be more specific. The CirculateILL feature lets you add a due date when/before checking the item out. I have to admit, we don't use it as we diddn't want to check the items out in the ILL omdule, but in Circulation. Backends can implement workflows quite differently at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:29:40 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 --- Comment #3 from Katrin Fischer --- Created attachment 146303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146303&action=edit Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:31:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:31:35 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:31:51 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:31:56 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 --- Comment #1 from Katrin Fischer --- Created attachment 146304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146304&action=edit Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors https://bugs.koha-community.org/show_bug.cgi?id=31768 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:32:38 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:35:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:35:49 +0000 Subject: [Koha-bugs] [Bug 31476] Add tool tips to the buttons on the cataloguing start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add tool tips to the |Add tool tips to the |buttons on the circulation |buttons on the cataloguing |start page |start page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:39:19 +0000 Subject: [Koha-bugs] [Bug 32032] Cannot hide "Main contact method" field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I verified the field is now available as 'Primary contact method (primary_contact_method)' and hiding it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:41:08 +0000 Subject: [Koha-bugs] [Bug 32265] Terminology: Staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32264 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:41:08 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 --- Comment #4 from Katrin Fischer --- *** Bug 32265 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:48:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:48:31 +0000 Subject: [Koha-bugs] [Bug 32893] ILL item flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32893 --- Comment #2 from Christopher Brannon --- Maybe I should explain our workflow a bit. Several of our libraries place an ILL request with an outside source, like through WorldCat. When the request is made, we use a framework that creates an ILL bib and item. The framework uses a specific not for loan status that allows only staff to place a hold on it for the patron. It is also given an ILL shelving location and an ILL item type that gives it a general loan period (which is not ideal). If we have the barcode at that time, we enter it as well. When the item gets to us, we check it in to trigger the hold. We have some template toolkit logic to change the subject line and the wording in the hold notice to make its own ILL notice. The patron is notified. Since the hold time counts against the ILL loan period, we automatically check it out to the patron. This is not ideal, because the system won't know if it is picked up yet or not. What would be more ideal is if when the patron picked it up and checked it out, is if it would calculate the due date by deducting how long it waited for the patron to pick it up. We can do almost everything we need without an ILL module, but this part would make it completely work. Maybe we don't need a flag on the item. But maybe a circ rule that would look for a specific item type or status and that could trigger the special due date? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 6 23:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 22:49:21 +0000 Subject: [Koha-bugs] [Bug 30765] Terminology: ... at least one reservation ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Appears to be fixed already :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 00:14:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Feb 2023 23:14:41 +0000 Subject: [Koha-bugs] [Bug 32810] Allow guarantor to pay guarantee's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 Suzanne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra at yahoo.com --- Comment #2 from Suzanne --- I would add that it would also be nice to have work on self checks through SIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 02:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 01:35:21 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Aleisha Amohia --- Thanks Emily, please mark bug reports as Failed QA if they don't pass the test plan :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 05:03:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 04:03:36 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #6 from quickfire28 at gmail.com --- Added new system preference 'UseOCLCEncodingLevels' Upgrade to 22.06.00.056 [12:00:42]: Bug 30571 - Table z3950servers: three cols NOT NULL Upgrade to 22.06.00.057 [12:00:42]: Bug 29071 - Set HoldsQueueSplitNumbering wh ere not set Added new system preference 'HoldsSplitQueueNumbering' Upgrade to 22.06.00.058 [12:00:42]: Bug 30944 - Replace branchtransfers.cancell ation_reason CancelRecall with RecallCancellation Upgrade to 22.06.00.059 [12:00:42]: Bug 25936 - A password change notification feature Added new letter 'PASSWORD_CHANGE' (email) Added new system preference 'NotifyPasswordChange' Upgrade to 22.06.00.060 [12:00:42]: Bug 10950 - Add preferred pronoun field to patron record Added column 'borrowers.pronouns' Added column 'deletedborrowers.pronouns' Added column 'borrower_modifications.pronouns' Upgrade to 22.06.00.061 [12:00:42]: Bug 31333 - Add the ability to limit purcha se suggestions by patron category Added new system preference 'suggestionPatronCategoryExceptions' Upgrade to 22.06.00.062 [12:00:42]: Bug 27136 - Add missing languages: Cree, Af rikaans and Multiple languages, Undetermined and No linguistic content Added missing languages Upgrade to 22.06.00.063 [12:00:43]: Bug 31569 - Add primary key for import_bibl ios ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry '104 34' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 Enabling plugins on node rabbit at lrc: rabbitmq_stomp The following plugins have been configured: rabbitmq_stomp Applying plugin configuration to rabbit at lrc... The following plugins have been enabled: rabbitmq_stomp started 1 plugins. Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service is transient or generated. Here is the result of upgrade and the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:26:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:26:30 +0000 Subject: [Koha-bugs] [Bug 32894] New: Objects cache methods' result without invalidation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, tomascohen at gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:29:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:29:27 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #35 from Jonathan Druart --- prove t/db_dependent/SIP/SIPServer.t t/db_dependent/SIP/SIPServer.t .. Can't locate object method "BINMODE" via package "C4::SIP::Trapper" at /usr/share/perl5/Log/Log4perl/Appender/Screen.pm line 22. Compilation failed in require at t/db_dependent/SIP/SIPServer.t line 40. BEGIN failed--compilation aborted at t/db_dependent/SIP/SIPServer.t line 40. # Looks like your test exited with 255 before it could output anything. t/db_dependent/SIP/SIPServer.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:42:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:42:23 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146283|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 146305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146305&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:42:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:42:55 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #6 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #3) > I'm not sure about the "Staged and ready" order... Shouldn't it still be by > scheduled pickup time? Yes, I think you are right. I modified the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:45:23 +0000 Subject: [Koha-bugs] [Bug 32810] Allow guarantor to pay guarantee's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 --- Comment #3 from Martin Renvoize --- Agreed.. I'm working on some dependencies right know you wrap my head around the challenge.. I think the SIP side of this may well end up as a distinct bug and be one in if the first areas I tackle. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 07:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 06:48:04 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 --- Comment #4 from Martin Renvoize --- My initial reaction to this is that really we aught to be allowing payment of guarantees fines via SIP as apposed to overruling the blocking rules the way we are here. But, I need to dig through the code a bit here before I block it, I've not done that yet and this may be a decent intermediate work around whilst we work on a wider problem of guarantees fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:11:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:11:07 +0000 Subject: [Koha-bugs] [Bug 32895] New: Allow users to pay guarantees fines via SIP Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32895 Bug ID: 32895 Summary: Allow users to pay guarantees fines via SIP Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We need to have the possibility to apply payments to guarantee's fines as a guarantor via SIP when payment via SIP is enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:11:33 +0000 Subject: [Koha-bugs] [Bug 32895] Allow users to pay guarantees fines via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32895 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 [Bug 32810] Allow guarantor to pay guarantee's fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:11:33 +0000 Subject: [Koha-bugs] [Bug 32810] Allow guarantor to pay guarantee's fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32895 [Bug 32895] Allow users to pay guarantees fines via SIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:11:54 +0000 Subject: [Koha-bugs] [Bug 32895] Allow users to pay guarantees fines via SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32895 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32624 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:11:54 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:48:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:48:54 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Summary|Curbside pickups - Wrong |Curbside pickups - Cannot |slot selected |select slot in the last | |hour -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:52:48 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:52:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:52:53 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 --- Comment #2 from Jonathan Druart --- Created attachment 146306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146306&action=edit Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:53:31 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:53:45 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:53:45 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 [Bug 32891] Curbside pickups - Cannot select slot in the last hour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 08:56:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 07:56:18 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:08:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:08:19 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- I don't think you are supposed to check the uniqueness of the barcode, it's at the DBMS level already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:14:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:14:42 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #7 from Jonathan Druart --- PUT is expecting a full resource, if you want to partially modify a resource you need PATCH. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:16:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:16:06 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #5 from Martin Renvoize --- OK.. looked at the code now.. seems reasonable. Will work through QA today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:20:09 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145913|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 146307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146307&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:49:26 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #6 from Jonathan Druart --- (In reply to Agustín Moyano from comment #5) > Hi Jonathan, to reuse stuff I like your idea to create folders by type > (routes, stores, components, ..). > > Maybe we can add another folder named "modules" where we place all "main.ts" > files, renaming them as "erm.ts" or "import_sources.ts". Or, instead of > creating a "modules" folder, we could have a single "main.ts" and make all > modules in routes to lazy load ( > https://router.vuejs.org/guide/advanced/lazy-loading.html ) I think I quite like the idea to have them visible at the root instead of hiding in the sub directory, but I am not strongly attached to it. > About the components folder, in my implementation, I added a "shared" > subfolder for all shared components, but I don't mind keeping them in the > components folder directly. Same as above, it was to make them more visible, but that one could consider it messy. > I loved the idea of generating the breadcrumbs from the router > specification, but the definition of it was kind of confusing, and hard to > follow, so I took your idea and changed it a little bit. The breadcrumb for the ERM module is quite complex, hence the complexity of the file :) About your implementation, there is something weird, you don't define the routes, and "Add import source" leads to admin/import-sources.pl/add. Is that expected? On erm I've decided to rewrite the url and have something following the REST routes (/cgi-bin/koha/erm/eholdings/local/packages/add for instance) > I added a couple more shared components, one of them being the > implementation of Datatables in Vue (called KohaTables). I see that you have > here the "composable" folder where you call functions of Datatables, but I > saw that the creators of Datatables had an implementation for Vue, so I > thought it best to use that. Yes but then you will need to reimplement all what we have in datatables.js, and I don't think that's something worthwhile (at least I would not consider it a priority for now). In your implementation there is problem with the pagination (NaN), the order by does not work, there is no column filtering, etc. I think we need to be consistent between the modules that are going to use Vue. We should apply the changes to the existing modules, then use them for the new ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:49:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:49:49 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #7 from Jonathan Druart --- Putting in discussion, but we need to move forward quickly here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 09:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 08:50:04 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:02:29 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a system |This patch adds a system release notes|preference, |preference, |SearchLimitLibrary, to be |SearchLimitLibrary, to be |used in the advanced search |used in the advanced search |on the staff client and |on the staff interface and |OPAC, and the OPAC masthead |OPAC, and the OPAC masthead |search. When limiting |search. When limiting |search results with a |search results with a |library or library group, |library or library group, |the SearchLimitLibrary |the SearchLimitLibrary |system preference can be |system preference can be |set to limit using the |set to limit using the |item's holding branch, home |item's holding branch, home |branch, or both. |branch, or both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:25:33 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:25:36 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146304|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 146308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146308&action=edit Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:29:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:29:03 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #14 from paxed --- (In reply to AspenCat Team from comment #13) > Is this a particularly difficult enhancement? It would be super helpful. Bug > initially created in 2018. Does it need to be a paid-for development? It wouldn't be that hard... except the simplest change would not be accepted, as all new stuff must use Koha Objects. So, you'd have to convert C4/MarcModificationTemplates.pm to Koha/MarcModificationTemplate.pm, Koha/MarcModificationTemplates.pm, Koha/MarcModificationTemplateAction.pm, Koha/MarcModificationTemplateActions.pm (or something along those lines), change all the scripts that use the marc modification templates to use those new objects, rewrite tests, ... Too much of a hassle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:32:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:32:27 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 --- Comment #3 from David Nind --- Thanks Katrin for spotting the other occurrences that needed updating! The only one I wasn't sure about was URI, and whether it should be capitalised when spelt in full. The dictionaries and other resources I looked up were inconclusive... Also, I amended the commit message to remove the Bugzilla link after the test plan to bug 31768. Testing notes (using KTD): 1. After applying the patch, I did a reset_all - this loaded the updated text for the descriptions. 2. To test the UNIMARC changes (955) I amended the KTD .env file to change KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:35:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:35:30 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:35:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:35:34 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146301|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 146309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146309&action=edit Bug 31768: Add tools toolbar to tags page The tags tool was missing the toolbar on the left side. With the filters, this patch adds the toolbar below, like we do on other pages like HTML customizations. To test: * Go to Tools > Tags * Verify no toolbar * Apply patch * Verify toolbar is now present * Compare to other tool pages * Sign off :) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:51:14 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:51:20 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146295|0 |1 is obsolete| | --- Comment #28 from David Nind --- Created attachment 146310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146310&action=edit Bug 14251: Allow use of CSS in discharge letter The discharge feature relies PDF::FromHTML which explicitly doesn't handle CSS [1]. This patch makes it use the `weasyprint` command-line tool to generate the PDF. This tool handles CSS correctly. To test: 1. Install weasyprint: $ apt install weasyprint 2. Add some style to your DISCHARGE letter. I used: <>

Discharge confirmation

<> certifies that the following borrower:
<> <> (cardnumber: <>)
has returned all items.

3. Have some non-latin chars on the patron name. I picked 'Henry Acevedo' and added 'Δοκιμή' as picked from bug 23589. Only to check no regressions. 4. Enable the 'UseDischarge' syspref 5. Go to Henry's detail page 6. Choose More > Discharge and Generate the discharge => SUCCESS: - Style is applied to the PDF - Greek characters are displayed correctly 7. Run the tests: $ kshell k$ prove -v t/db_dependent/Patron/Borrower_Discharge.t => SUCCESS: The rewritten tests pass! 8. Remove weasyprint: $ apt remove weasyprint 9. Repeat 7 => SUCCESS: Tests pass, relevant test is skipped because of missing weasyprint 10. Sign off :-D [1] https://metacpan.org/pod/PDF::FromHTML#CAVEATS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:51:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:51:26 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146296|0 |1 is obsolete| | --- Comment #29 from David Nind --- Created attachment 146311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146311&action=edit Bug 14251: Add warning in about.pl for missing weasyprint To test: 1. Have weasyprint installed 2. Go to the About > System information page => SUCCESS: No warning about weasyprint 3. Uninstall weasyprint 4. Repeat 2 => SUCCESS: A warning is displayed and makes sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 10:51:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 09:51:32 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146297|0 |1 is obsolete| | --- Comment #30 from David Nind --- Created attachment 146312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146312&action=edit Bug 14251: Add weasyprint dependency Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:01:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:01:55 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146309|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146313&action=edit Bug 31768: Add tools toolbar to tags page The tags tool was missing the toolbar on the left side. With the filters, this patch adds the toolbar below, like we do on other pages like HTML customizations. To test: * Go to Tools > Tags * Verify no toolbar * Apply patch * Verify toolbar is now present * Compare to other tool pages * Sign off :) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:02:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:02:17 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Yeay, thanks Katrin Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:02:46 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:02:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:02:54 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:06:39 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:06:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:06:43 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146306|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 146314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146314&action=edit Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:07:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:07:37 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 --- Comment #4 from David Nind --- Thanks Jonathan for figuring out the cause of the issue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 11:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 10:14:28 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 --- Comment #4 from Katrin Fischer --- > The only one I wasn't sure about was URI, and whether it should be > capitalised when spelt in full. The dictionaries and other resources I > looked up were inconclusive... I was not completely sure either. Can't we just update the label to URI or URL? :) > > Also, I amended the commit message to remove the Bugzilla link after the > test plan to bug 31768. Thanks, that was due to me having a bug typo first. > Testing notes (using KTD): > > 1. After applying the patch, I did a reset_all - this loaded the updated > text for the descriptions. > > 2. To test the UNIMARC changes (955) I amended the KTD .env file to change > KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 12:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 11:31:44 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #8 from Pedro Amorim --- This looks really good. Had a look at Agustin's implementation, also looks really good. For discussion sake, here: https://gitlab.com/thekesolutions/Koha/-/tree/import_source_vue/koha-tmpl/intranet-tmpl/prog/js/vue I agree with everything and don't have much to add really, some thoughts at a glance: - Personally, I like Agustin's "modules" folder idea. - Not a huge fan of "fetch" folder, mostly the name, but don't have a great alternative for it either. - What about t/cypress? Should we prefix all module related tests with modulename and leave all tests inside integration folder where they currently live? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 12:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 11:36:15 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #15 from Martin Renvoize --- Offers of sponsorship always help a bug move forward, else a developer is either trying to justify time working on a bug to their boss for no obvious financial reward or working on the bug in their spare time. As for paxed comment regarding difficulty and C4 vs Koha.. I would say this is an area where you could happily continue in C4 space. It's not a hard requirement to rewrite the whole of Koha to refine an existing feature.. QA would push for Unit tests however, even for a C4 change.. but that's just standard good practice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 12:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 11:54:29 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 [Bug 21548] ILLLIBS patron category / partner_code seems extraneous -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 12:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 11:54:29 +0000 Subject: [Koha-bugs] [Bug 21548] ILLLIBS patron category / partner_code seems extraneous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 12:56:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 11:56:19 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 --- Comment #10 from Pedro Amorim --- Adding 21548 as a dependency as partner_code in koha-conf.xml is ILLLIBS but sample data is using IL. This would cause a future test plan to be more work than it has to be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:05:04 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #36 from Kyle M Hall --- Created attachment 146315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146315&action=edit Bug 32612: (QA follow-up) Add BINMODE method to C4::SIP::Trapper The module Log::Log4perl::Appender::Screen is attempting to change binmode during unit tests for SIPServer and is failing because of our tie in SIPServer.pm for reasons unknown. This patch implements the perltie method TIEHANDLE which allows the binmode to be handled in the C4::SIP::Trapper package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:09:44 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #37 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #35) > prove t/db_dependent/SIP/SIPServer.t > t/db_dependent/SIP/SIPServer.t .. Can't locate object method "BINMODE" via > package "C4::SIP::Trapper" at > /usr/share/perl5/Log/Log4perl/Appender/Screen.pm line 22. > Compilation failed in require at t/db_dependent/SIP/SIPServer.t line 40. > BEGIN failed--compilation aborted at t/db_dependent/SIP/SIPServer.t line 40. > # Looks like your test exited with 255 before it could output anything. > t/db_dependent/SIP/SIPServer.t .. Dubious, test returned 255 (wstat 65280, > 0xff00) > Failed 1/1 subtests Whats the relation with worker? log4perl.logger.sip = DEBUG, SIP log4perl.appender.SIP=Log::Log4perl::Appender::File log4perl.appender.SIP.filename=/var/log/koha/myclone/sip.log log4perl.appender.SIP.mode=append log4perl.appender.SIP.layout=PatternLayout log4perl.appender.SIP.layout.ConversionPattern=[%d] [%P] [%p] %X{accountid}@%X{peeraddr}: %m %l%n log4perl.appender.SIP.utf8=1 Please check the configuration for sip ? Note that the SIP configuration always goes to Appender::File too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:26:35 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143962|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes --- Created attachment 146316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146316&action=edit Bug 21699: Allow circulation messages to be editable During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page. It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Browser to a patron record 4) Create a new patron message 5) Note the patron message now has an "edit" button 6) Edit the existing message using the edit button and form 7) Check the action logs for that message, note there is a modification logged to that message if BorrowersLog is enabled Signed-off-by: Barbara Johnson Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:46:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:46:25 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146308|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146317&action=edit Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:47:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:47:32 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Looks good to me.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:48:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:48:07 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 13:57:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 12:57:59 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145204|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 146318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146318&action=edit Bug 32580: Fix typo in cancel link on background jobs page One way to test: * Make sure you are using Elasticsearch * Edit a record in your catalog * Go to: /cgi-bin/koha/admin/background_jobs.pl * Uncheck 'Current jobs only' * Cancel the job, you'll see a 404 error * Apply patch * Repeat, now the redirect should work right Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:00:14 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Trivial fix, working well.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:04:30 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146302|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 146319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146319&action=edit Bug 32027: Fix 'librarian interface' to use 'staff interface' in Pages/HTML customizations/News This changes all occurences of "librarian interface" to the correct term "staff interface" To test: * Create a new Page * Verify that the pull down for location has "librarian interface" * Save your page * Verify that the list of existing pages has "Librarian interface" as label for the link * Verify that when you hover over on those links the titles read "librarian interface" as well * Apply patch * All those should read correctly now. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:04:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:04:50 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #5 from Martin Renvoize --- Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:06:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:06:15 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146272|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 146320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146320&action=edit Bug 32226: Fix capitalization of "Add/Edit html content" HTML is an abbreviation and as such should always be capitalized. To test: * Go to administration > libraries * Edit any existing branch * The hint for OPAC info reads 'Add html content' * Add some content, verify the link changes to 'Edit html content' * Apply patch * Verify both cases now read 'HTML' Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:06:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:06:41 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- All working, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:08:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:08:37 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146300|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 146321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146321&action=edit Bug 32023: Remove hr in OpacNav for CMS pages In a page created with the new Pages tool, there is a
above the OpacNav block. This hr is not present on other OPAC pages and is removed by this patch. To test: 1. Go to Tools > Pages > New entry 2. Create a page and save 3. Copy the OPAC link 4. Go to Tools > HTML customizations > New entry 5. Create an OpacNav entry with the link to the page 6. Go to the OPAC main page --> Notice how the left navigation section looks 7. Click on the link on the left to go to the page --> an horizontal line appears above OpacNav 8. Apply patch 9. Repeat test - the horizontal line should be gone now Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:09:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:09:12 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- That HR was weird.. nice fix. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:12:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:12:27 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146271|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 146322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146322&action=edit Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:13:44 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Good catch.. Passing QA on this one.. However, there are more cases of 'id' littered around the templates.. not all that easy to find but there.. a number in syspref descriptions I believe (rg " id " helped me spot a few)... maybe a follow-up bug could be done for the rest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:15:15 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146278|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146323&action=edit Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checked out out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:15:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:15:39 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Nice consistency improvements, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:16:57 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146276|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 146324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146324&action=edit Bug 32295: Fix punctuation for "Filters :" on serials claims page To test: * Add a subscription * Generate next issue, to have a late one * Go to serials > claims * Select your vendor * Verify one of the sections is labelled "Filters :" * Apply patch * Verify the section is now labelled "Filters:" Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:17:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:17:35 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #4 from Martin Renvoize --- PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:18:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:18:46 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146268|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 146325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146325&action=edit Bug 28674: Fix typo 'hlpd' in schema comments Fixes the lines for old_reserves.item_level_hold and reserves.item_level_hold comments to read 'hold' instead of 'hpld' To test: * The easiest way to verify this change is by looking at the patch itself Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:19:00 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:21:01 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146287|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 146326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146326&action=edit Bug 32786: Display admin header on curbside pickup admin Most other administration pages (those that don't have specific searches) are set by default on system preferences search. Test plan: Go to admin > Curbside pickup Confirm that the syspref search is displayed in the header Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:21:21 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Nice consistency improvement, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:22:45 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146291|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146327&action=edit Bug 32788: Order curbside pickup slots chronologically We need to order the slots chronologically, not depending on when they have been added. Test plan: Create a slot 13 to 17 the another one 8 to 12 We want to display 8 to 12 before 13 to 17. Confirm that this patch fixes that on the 3 following views: Curbside pickups admin Curbside pickups staff side Curbside pickups at the OPAC Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:23:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:23:22 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Nice improvement, no regressions found. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:27:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:27:24 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145746|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 146328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146328&action=edit Bug 32603: Suggester category in Suggestions management In Suggestions management, in the table displaying all suggestions, add a column to display suggester category. This way, it is possible for example for the librarian managing suggestions rather to prioritize suggestions coming from teachers than those coming from students. TEST : 1. Apply the patch. 2. Acquisition > Suggestions. 3. There is a new column 'Suggester category'. It can be displayed/hidden. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:27:43 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Working nicely, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:31:25 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145345|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 146329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146329&action=edit Bug 32624: Don't include guarantee or guarantor fines in BV (fines amount) in SIP messages This patch chanegs the code to report only the patron's personal fines, and to report a block from other fines in the screen message This is to prevent overpayment on accounts from SIP machines To test: 1 - prove t/db_dependent/SIP/Patron.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:31:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:31:54 +0000 Subject: [Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Works as described, fixes a real issue and is well covered by tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:36:49 +0000 Subject: [Koha-bugs] [Bug 32215] Capitalization: %s You Searched for %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 --- Comment #2 from Owen Leonard --- I think this is some copy-paste from another template that isn't relevant here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:36:57 +0000 Subject: [Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:43:18 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:43:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:43:22 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 --- Comment #2 from Owen Leonard --- Created attachment 146330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146330&action=edit Bug 32886: Set focus for cursor to Code when adding a new restriction This patch adds the "focus" class to the form for defining a new patron restriction so that the cursor focus is automatically added. To test, apply the patch and go to Administration -> Patron restrictions -> New restriction. The cursor should automatically move to the "Code" input field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:44:10 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:28 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:33 +0000 Subject: [Koha-bugs] [Bug 32770] Patron search field groups no longer exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32770 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145935|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop --- Created attachment 146331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146331&action=edit Bug 32770: [alternate] Restore patron search on all emails, phones, and addresses Prior to bug 30063 we had "Email", "Phone", and "Address" in the search field list that allowed a search on all email, phone, or address attributes. This patron restores these and makes sure the search box and the patron search filters use the same block to keep them consistent The fields are now labelled 'All emails', 'All phones', and 'Full address' to make it clear that they search multiple - including any single field in the DefaultPatronSearchFields will additionally add that to the dropdowns To test: 1 - define 'test at email.pro' as 'Secondary email' for a patron 2 - Search from 'Search patrons' address bar (visible at top of moremember.pl) 3 - Nothing is found using 'Standard' or 'Email fields' 4 - Apply patch 5 - Refresh page and repeat 6 - Nothing is found for standard, Patron is found for 'All emails' 7 - Define a unique value for patron in 'Address 2' 8 - Confirm 'Full address' search returns the patron 9 - Test with 'Secondary phone' and 'All phones' as well 10 - Repeat test from 'Patrons' module using the search on the left Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:41 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:44 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:47 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:51 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:49:56 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:05 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:09 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:13 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:17 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:45 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:50 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:55 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:50:58 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:03 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:08 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:11 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:15 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:19 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:22 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:24 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:27 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:30 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:32 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:35 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:38 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:41 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:45 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:50 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:53 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:56 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:51:59 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:52:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:52:02 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:52:06 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:52:10 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:59:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:59:28 +0000 Subject: [Koha-bugs] [Bug 32544] borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 14:59:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 13:59:32 +0000 Subject: [Koha-bugs] [Bug 32544] borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32544 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:25:25 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #8 from Martin Renvoize --- Aren't we being a bit nieve here in terms of autoBarcode? I'm wondering: 1) Can we move the autoBarcode handling into Koha::Item->store() instead? 2) Even if we don't move the autoBarcode handling, don't we need to account for the other options it supports? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:25:43 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:28:04 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146314|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose --- Created attachment 146332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146332&action=edit Bug 32891: Fix slot selection in last hour If the curbside pickup module is configured with slot not on the hour (minutes=00), the slots in the last (not complete) hour won't be selectable. Test plan: Create the following configuration: pickup interval: 10 Opening hours: 08:00 to 11:30 Create a pickup and select 11:10 or 11:20 => Without this patch the pickup is not created and the UI displays "Wrong slot selected" => With this patch you are able to create the pickup Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:28:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:28:25 +0000 Subject: [Koha-bugs] [Bug 32891] Curbside pickups - Cannot select slot in the last hour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32891 --- Comment #6 from Caroline Cyr La Rose --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:33:40 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- I'd also argue that this is perhaps misplaced endpoint wise.. we already have a few `/items` endpoints.. whilst I understand the logic being `POST /biblios/{biblio_id}/items` I'm not so sure that logic holds here.. Shouldn't this be `PUT /items/{item_id}` or indeed if we want partial update `PATCH /items/{item_id}`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:36:06 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #9 from Martin Renvoize --- (In reply to Jonathan Druart from comment #6) > I don't think you are supposed to check the uniqueness of the barcode, it's > at the DBMS level already. He already fixed this in a followup above ;P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:40:05 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #10 from Martin Renvoize --- Also.. should we allow moving an item between biblios on this endpoint.. or should biblio_id really be a readOnly here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:45:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:45:45 +0000 Subject: [Koha-bugs] [Bug 32896] New: Can we move autoBarcode handling into Koha::Item->store() ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896 Bug ID: 32896 Summary: Can we move autoBarcode handling into Koha::Item->store() ? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Currently, the codebase is somewhat littered with calls to check the autoBarcode pref and then generate a barcode.. could we remove these calls from the various controllers and move it to one call in Koha::Item->store() instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:45:59 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:45:59 +0000 Subject: [Koha-bugs] [Bug 32896] Can we move autoBarcode handling into Koha::Item->store() ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31798 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:48:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:48:32 +0000 Subject: [Koha-bugs] [Bug 21548] ILLLIBS patron category / partner_code seems extraneous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #5 from Pedro Amorim --- Created attachment 146333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146333&action=edit 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:49:09 +0000 Subject: [Koha-bugs] [Bug 21548] ILLLIBS patron category / partner_code seems extraneous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:56:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:56:09 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:56:13 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146305|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose --- Created attachment 146334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146334&action=edit Bug 32883: Correct cubside pickups ordering They are displayed by date of creation, it's not what we want for "to be staged" for instance, where it needs to be ordered by date/time of scheduled pickup. Test plan: Create several curbside pickups, to have some in the different tabs Confirm that the order is the one you expect. => to be staged ordered by pickup date/time => stage and ready ordered by pickup date/time => patron is outside ordered by arrival date/time => delivered today ordered by *desc* delivered date/time Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:56:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:56:19 +0000 Subject: [Koha-bugs] [Bug 32812] Fix cataloguing/value_builder/barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:56:23 +0000 Subject: [Koha-bugs] [Bug 32812] Fix cataloguing/value_builder/barcode_manual.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146070|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146335&action=edit Bug 32812: Fix cataloguing/value_builder/barcode_manual.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:56:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:56:47 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #8 from Caroline Cyr La Rose --- Cool, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 15:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 14:58:44 +0000 Subject: [Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #39 from Blou --- Hello Katrin, I noticed you made some slight turn around on this bug. Is there anything else that could be done? Although Nick sided with Jonathan, I don't think anyone refuted Caroline's arguments ont comment 23. This needs to be stored. So if we're talking transition, we're all ear! Here, and at Collecto (so about 100 large institutions total), we just apply the patch. As it was mostly (and wrongly) shown in English beforehand, it still is. At least until the user can now edit it as needed. I have a hard time imagining an atomic update that could fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:10:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:10:02 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:13:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:13:58 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #9 from Pedro Amorim --- Patch no longer applies, HTTPD::Bench::ApacheBench was removed by bug 32673. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:14:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:14:22 +0000 Subject: [Koha-bugs] [Bug 31865] Hide display of 'dev/testing' packages on production installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31865 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:15:57 +0000 Subject: [Koha-bugs] [Bug 21548] ILLLIBS patron category / partner_code seems extraneous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:14 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:16 +0000 Subject: [Koha-bugs] [Bug 32289] Punctuation: Delete desk "...?" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32289 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:18 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:20 +0000 Subject: [Koha-bugs] [Bug 32294] Capitalization: Enter your User ID... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32294 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:23 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:25 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #12 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:28 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:30 +0000 Subject: [Koha-bugs] [Bug 32606] Revert Flatpickr style changes made in Bug 31943 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32606 --- Comment #8 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:32 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:35 +0000 Subject: [Koha-bugs] [Bug 32761] Typos in description of CircControlReturnsBranch system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32761 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:37 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:18:39 +0000 Subject: [Koha-bugs] [Bug 32787] Patron restrictions admin page has patron categories search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32787 --- Comment #6 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:23:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:23:52 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:23:54 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 --- Comment #21 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:23:57 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:23:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:23:59 +0000 Subject: [Koha-bugs] [Bug 32230] Capitalization: Manage Domains In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32230 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:24:01 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:24:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:24:03 +0000 Subject: [Koha-bugs] [Bug 32772] Patron autocomplete should not use contains on all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32772 --- Comment #12 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:24:05 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:24:08 +0000 Subject: [Koha-bugs] [Bug 32881] System preferences sub menu text is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:46:52 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:46:56 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146330|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop --- Created attachment 146336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146336&action=edit Bug 32886: Set focus for cursor to Code when adding a new restriction This patch adds the "focus" class to the form for defining a new patron restriction so that the cursor focus is automatically added. To test, apply the patch and go to Administration -> Patron restrictions -> New restriction. The cursor should automatically move to the "Code" input field. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:52:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:52:51 +0000 Subject: [Koha-bugs] [Bug 32897] New: Add sort fields to item records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32897 Bug ID: 32897 Summary: Add sort fields to item records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Requests have been made to have some generic fields added to item records to make searching/filtering items easier. Similar to Sort1 and Sort2 in the patron record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:54:27 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 [Bug 32609] Remove compiled files from src -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:54:27 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 [Bug 32806] Some Vue files need to be moved for better reusability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 16:55:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 15:55:55 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #9 from Jonathan Druart --- Created attachment 146337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146337&action=edit Bug 32806: (follow-up) Rename main.js to erm.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:02:24 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144484|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim --- Created attachment 146338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146338&action=edit Bug 31794: Add REST endpoint to get an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get the id of an authority 4. Make a GET request to /api/v1/authorities/{authid} with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc - text/plain 5. Check that you get the authority in the corresponding format 6. Sign off Signed-off-by: David Nind Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:02:29 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144485|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim --- Created attachment 146339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146339&action=edit Bug 31794: (follow-up) Add description to authorities tag Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:05:32 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #10 from Pedro Amorim --- Works as described, tests pass, wondering if we should DRY this in Authority.pm, or not worth: 152 C4::Context->preference('marcflavour') eq 'UNIMARC' 153 ? 'UNIMARCAUTH' 154 : 'MARC21'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:10:04 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:10:06 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146071|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146340&action=edit Bug 32813: Fix cataloguing/value_builder/barcode.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:28:48 +0000 Subject: [Koha-bugs] [Bug 32898] New: Cypress tests are failing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Bug ID: 32898 Summary: Cypress tests are failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We are not running them (yet) on jenkins and some cypress tests (for erm) are failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:32:39 +0000 Subject: [Koha-bugs] [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:32:41 +0000 Subject: [Koha-bugs] [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146074|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146341&action=edit Bug 32816: Fix cataloguing/value_builder/cn_browser.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:38:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:38:03 +0000 Subject: [Koha-bugs] [Bug 32899] New: Unused ILL configs in koha-conf.xml should be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32899 Bug ID: 32899 Summary: Unused ILL configs in koha-conf.xml should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com CC: katrin.fischer at bsz-bw.de, magnus at libriotech.no, martin.renvoize at ptfs-europe.com, tomascohen at gmail.com Depends on: 19822 staff_request_comments and reply_date in koha-conf.xml are only used in _censor method in Koha::Illrequest but this _censor method is not used anywhere else in Koha. Bug 19822 aims to move ILL config from koha-conf.xml into system preferences, but would it make sense to move configs that are not being used anywhere? Some ILL backends may use these, but all that I have checked so far do not. Backends maintained by PTFS-Europe do not use these. Tomas has confirmed the backends he maintains do not use these. Asking others in the community for confirmation and opinion on this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:38:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:38:03 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32899 [Bug 32899] Unused ILL configs in koha-conf.xml should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:44:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:44:00 +0000 Subject: [Koha-bugs] [Bug 32900] New: Curbside pickups - "Please fill in this field" tip is untranslatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32900 Bug ID: 32900 Summary: Curbside pickups - "Please fill in this field" tip is untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When scheduling a pickup, there is a tip when you hover the cursor on the date field that says "Please fill in this field". I could not find this string anywhere in the .po files, even after an update. To get this string: 1. Enable the CurbsidePickup system preference 2. Set up curbside pickup for a library (e.g. Centerville) 2.1. Go to Administration > Curbside pickup 2.2. Click the tab for the library 2.3. Fill out the form: - Enable: Check - Pickup interval: 10 (or other) - Maximum patrons per interval: 3 (or other) - Patron-scheduled pickup: leave unchecked - Enable for waiting holds only: leave unchecked 2.4. Enter a couple of time periods (e.g. - Day: Sunday - From: 10:00 - To: 12:00 2.5. Click 'Add' 2.6. Click 'Save configuration' 3. Schedule a pickup, hover over the date field 3.1. Go to Circulation > Curbside pickups 3.2. Click 'Schedule pickup' 3.3. Search for a patron name (e.g. Henry) 3.4. Hover the cursor on the date field --> The tip says "Please fill in this field." To translate : cd misc/translator ./translate update xx-XX git grep "Please fill in this field" --> No result -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:44:21 +0000 Subject: [Koha-bugs] [Bug 32900] Curbside pickups - "Please fill in this field" tip is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32900 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Add a curbside pickup module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:44:21 +0000 Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32900 [Bug 32900] Curbside pickups - "Please fill in this field" tip is untranslatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:49:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:49:06 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:49:08 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146072|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146342&action=edit Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:54:36 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 --- Comment #1 from Jonathan Druart --- Created attachment 146343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146343&action=edit Bug 32898: Fix Cypress tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:55:45 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #2 from Jonathan Druart --- There is still Titles_spec.ts that is failing. It's caused by: await fetch(apiUrl + "?" + new URLSearchParams(params)) //.then(checkError) .then( (response) => (count_local_titles = response.headers.get("X-Total-Count")) ); The error is not displayed if a 500 is encountered. However I didn't manage to fix it correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:56:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:56:33 +0000 Subject: [Koha-bugs] [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 17:56:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 16:56:36 +0000 Subject: [Koha-bugs] [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146079|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 146344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146344&action=edit Bug 32821: Fix cataloguing/value_builder/stocknumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:07:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:07:24 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #6 from Kyle M Hall --- (In reply to Andrew Fuerste-Henry from comment #3) > At step 20 in the test plan I'm not getting an item created as described. I > have deleted the item with barcode 39999000004090, but when I stage the > batch set to match on biblionumber and replace items I don't get a new item > created on import. The import_items table gives the error "duplicate item > barcode" even though that barcode is in deleteditems and doesn't bring > anything up in searches. I did not have this experience when I attempted to reproduce the issue from your description. Everything worked as Nick described. > Also, the behavior at steps 16/17 seems wrong to me. The incoming MARC has > this item on one bib, Koha has it on another. To my mind, that suggests > there's some fundamental confusion that should be sorted out manually. With > this patch as written, the import and overlay edits an item on a bib that's > not indicated in any way when looking at the batch, which seems like a good > way miss errors in your import batch and to introduce unexpected item edits > to your catalog. The item action choice is "Replace items when a matching > bib is found." This is replacing an item on a non-matching bib. I can understand your pov, but I also think catalogers care less about which bib the item is attached to and much more about having the item overlay correctly. My experience is that they overlay the records and items, then merge all duplicate records. We may want to adjust the wording of that message to clarify that it overlays items if *any* record matches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:11:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:11:09 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:11:11 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146292|0 |1 is obsolete| | Attachment #146293|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 146345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146345&action=edit Bug 32804: Add unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:11:19 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #8 from Kyle M Hall --- Created attachment 146346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146346&action=edit Bug 32804: Do not adjust biblionumber when replacing items during import This patch adjust the item matching at import to confirm that for a duplicate itemnumber or barcode matches an existing item in the DB and uses the original biblionumber when updating the item. When ordering in a consortium the items may be moved around, duplicate biblios added, and various matches found. We should not allow importing of items to move them from 1 biblio to another, but we should allow the imports to succeed and assume itemnumber or barcode matches are authoritative. The responsibility for correct matching of items to biblio should fall on the creator of the files To test: 1 - Be using the sample data in koha testing docker 2 - Stage the sample file on this report 3 - Match on KohaBiblio(999$c) / Item processing: replace 4 - Note the biblio match is "The complete novels / Austen, Jane" 5 - View the staged marc, note the barcode 39999000004090 in an item 6 - Search for that barcode 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert" 8 - Import the file 9 - Check the db: SELECT * FROM items WHERE biblionumber != biblioitemnumber; 10 - Note the mismatch 11 - Fix the item and set it as 'Music' type UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE biblionumber != biblioitemnumber; 12 - Apply patch, restart all 13 - Stage and import the file with the same settings 14 - Confirm the item is modified on its original biblio (99) and that item type is Book again 15 - Change itemnumber to avoid itemnumber match and reset type UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212; 16 - Stage and import with the same setttings 17 - Confirm the marcode match worked and item is updated to book on original record 18 - Delete the original item 19 - Stage and import the file with the same settings 20 - The item is successfully created 21 - Stage and import, but item processing option is 'add' 22 - Confirm 1 item ignored 23 - Check the db SELECT * FROM import_items WHERE barcode=39999000004090 24 - Confirm there is a line with 'error' and duplicate_barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:20:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:20:13 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- It looks like I was testing this one at the same time as Owen! I added this plugin to 952$o for the BKS framework (MARC21). If I enter a value, such as AAA 0, when I click on the ... it jumps to the top of the screen (it does generate the value though - AAA 0001). It didn't do this before the patch was applied (and after a flush_memcached and restart_all). Description of plugin ~~~~~~~~~~~~~~~~~~~~~ Is used for callnumber computation. User must supply a letter prefix (unspecified length) followed by an empty space followed by a "number". "Number" is 4 character long, and is either a number sequence which is 01 padded. If input does not conform with this format any processing is omitted. Some examples of legal values that trigger auto allocation: AAA 0 - returns first unused number AAA 0xxx starting with AAA 0001 BBB 12 - returns first unused number BBB 12xx starting with BBB 1201 CCC QW - returns first unused number CCC QWxx starting with CCC QW01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:20:44 +0000 Subject: [Koha-bugs] [Bug 32901] New: Replace use of the slang term "bib" with the term "record" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Bug ID: 32901 Summary: Replace use of the slang term "bib" with the term "record" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The "Item processing" pulldown on manage-marc-import.pl uses the slang term "bib" while the rest of the form uses the correct term "record". This field should be updated with the correct terminology. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:21:55 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:23:35 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:23:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:23:37 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 --- Comment #1 from Kyle M Hall --- Created attachment 146347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146347&action=edit Bug 32901: Replace use of the slang term "bib" with the term "record" The "Item processing" pulldown on manage-marc-import.pl uses the slang term "bib" while the rest of the form uses the correct term "record". This field should be updated with the correct terminology. Test Plan: 1) Find or stage a marc record batch 2) Note the "Item processing" pulldown uses the term "bib" 3) Apply this patch 4) Reload that page 5) Note the "Item proccessing" pulldown now uses the term "record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:24:02 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #38 from Tomás Cohen Arazi --- Follow-up pushed to master, thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:25:48 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:32:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:32:21 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32468 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:32:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:32:21 +0000 Subject: [Koha-bugs] [Bug 32468] Vendors select only allows selecting from first 20 vendors by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32468 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:36:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:36:36 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145201|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 146348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146348&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:36:39 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #8 from Owen Leonard --- Created attachment 146349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146349&action=edit Bug 32605: (follow-up) Additional fixes This patch makes some further changes to form CSS in order to improve consistency. Some templates have also been modified to improve layout. - Acquisitions -> New vendor - Staff interface home -> Patrons requesting modifications - Reports -> Saved SQL reports - Serials -> New subscription - Tools -> Import patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:44:23 +0000 Subject: [Koha-bugs] [Bug 32902] New: Add ability to choose if items overlay if any record matches or only if the item is on the matched record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Bug ID: 32902 Summary: Add ability to choose if items overlay if any record matches or only if the item is on the matched record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 32804 resolves an bug where an overlaid item could have its' biblionumber changed. Fixing this has the effect of enabling items to be updated even if the item is on a different record. This can be wanted or unwanted behavior depending on the situation. It would be good if the cataloger could choose which behavior is preferred on a per-batch bases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:44:44 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 [Bug 32901] Replace use of the slang term "bib" with the term "record" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:44:44 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:45:30 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:45:30 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 [Bug 32901] Replace use of the slang term "bib" with the term "record" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 18:56:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 17:56:47 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #9 from Owen Leonard --- (In reply to David Nind from comment #6) > 5. Label alignment when wrapped: previously input fields were centered on > the label, now aligned to the top of the label This is intentional. > - primary phone, secondary phone, secondary email fields, ZIP/Postal code: > these labels are wrapped now, previously they were on one line This is to be expected. > - "Allow auto-renewal of items": label indented - starts where other input > fields are > - Patron identity: raido buttons start where otehr input fields are This is the intended layout. > Patron category: > Edit patron card layout > Import patrons These pages should be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:00:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:00:11 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146347|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 146350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146350&action=edit Bug 32901: Replace use of the slang term "bib" with the term "record" The "Item processing" pulldown on manage-marc-import.pl uses the slang term "bib" while the rest of the form uses the correct term "record". This field should be updated with the correct terminology. Test Plan: 1) Find or stage a marc record batch 2) Note the "Item processing" pulldown uses the term "bib" 3) Apply this patch 4) Reload that page 5) Note the "Item proccessing" pulldown now uses the term "record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:02:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:02:01 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146350|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 146351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146351&action=edit Bug 32901: Replace use of the slang term "bib" with the term "record" The "Item processing" pulldown on manage-marc-import.pl uses the slang term "bib" while the rest of the form uses the correct term "record". This field should be updated with the correct terminology. Test Plan: 1) Find or stage a marc record batch 2) Note the "Item processing" pulldown uses the term "bib" 3) Apply this patch 4) Reload that page 5) Note the "Item proccessing" pulldown now uses the term "record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:06:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:06:37 +0000 Subject: [Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145666|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 146352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146352&action=edit Bug 32683: Convert header search tabs to Bootstrap This patch updates all search header include files so that they have Bootstrap tab markup instead of jQueryUI. jQueryUI-related JavaScript is updated to work with Bootstrap. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. Test that keyboard shortcuts work correctly: Alt-U for circulation, Alt-R for returns, Alt-W for renewals, and Alt-Q for search. Each shortcut should either activate the correct search tab (if present on the page) or redirect you to that page. Cursor focus should be automatically placed in expanded header search form, whether it be on page load or when switching tabs. Test search header forms with additional search options work correctly: Clicking the "settings" icon should expand the panel with additional fields. Test at least one page which uses each include file: - acquisitions-search.inc - Acquisitions and related pages - adv-search.inc - Advanced catalog search - authorities-search.inc - Authorities and related pages - Check that the right tab is preselected after each kind of search, e.g. a search by "Main heading" should return a search results page where the "Main heading" tab is preselected. - budgets-admin-search.inc - Administration -> Budgets - cat-search.inc - Catalog search results, bibliographic details, etc. - cataloging-search.inc - Cataloging home page and cataloging search results - checkin-search.inc - Circulation -> Check in - circ-search.inc - Circulation -> Check out - cities-admin-search.inc - Administration -> Cities and towns - contracts-admin-search.inc - Acquisitions -> Vendor -> Contracts - currencies-admin-search.inc - Administration -> Currencies - desks-admin-search.inc - Administration -> Desks (must have UseCirculationDesks enabled) - erm-search.inc - ERM (must have ERMModule enabled) - home-search.inc - Staff interface home page - letters-search.inc - Tools -> Notices - patron-search-header.inc - Patron details, patron accounting, etc. - patrons-admin-search.inc - Administratoin -> Patron categories - prefs-admin-search.inc - Administration home page and system preferences - serials-search.inc - Serials and related pages - suggestions-add-search.inc - Not used - z3950-admin-search.inc - Administration -> Z39.50 servers Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:11:50 +0000 Subject: [Koha-bugs] [Bug 32903] New: callnumber.pl plugin - leading 0s are not added when using a prefix Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32903 Bug ID: 32903 Summary: callnumber.pl plugin - leading 0s are not added when using a prefix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The description in the script for the cataloguing/value_builder/callnumber.pl says that if a prefix is used, then leading zeros are added when needed. Example: If this call number exists for an item "PREFIX 0009678570", then adding PREFIX to another item should generate "PREFIX 0009678571". However, it generates it as "PREFIX 9678571". To replicate (using KTD): 1. In a MARC21 instance, add the callnumber.pl plugin to 952$o for the BKS framework. 2. Edit an item for a record and add "PREFIX 0009678570" as the call number and save. 3. Edit another item for another record. 4. For the call number, enter "PREFIX" and then click on the three dots. 5. Note that it generates the call number as "PREFIX 9678571" instead of "PREFIX 0009678571" with the leading 0s. [1] Full description from the script: Is used for callnumber computation. If the user send an empty string, we return a simple incremented callnumber. If a prefix is submited, we look for the highest callnumber with this prefix, and return it incremented. In this case, a callnumber has this form : "PREFIX 0009678570". - PREFIX is an upercase word - a space separator - 10 digits, with leading 0s if needed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:12:17 +0000 Subject: [Koha-bugs] [Bug 32903] callnumber.pl plugin - leading 0s are not added when using a prefix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32903 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32815 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:12:17 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:21:04 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 146353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146353&action=edit Bug 32612: (QA follow-up) Add POD and fix typo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:26:08 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- Happy to push a patch from you again, Frederic :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:13 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:16 +0000 Subject: [Koha-bugs] [Bug 31407] Set focus for cursor to Currency when adding a new currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31407 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:20 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:22 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:25 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:27 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:29 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:33 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:36 +0000 Subject: [Koha-bugs] [Bug 32649] Use template wrapper for library transfer limits tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32649 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:39 +0000 Subject: [Koha-bugs] [Bug 32649] Use template wrapper for library transfer limits tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32649 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:43 +0000 Subject: [Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:45 +0000 Subject: [Koha-bugs] [Bug 32660] Use template wrapper for basket groups tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32660 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:48 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:52 +0000 Subject: [Koha-bugs] [Bug 32661] Use template wrapper for invoices page tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32661 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:54 +0000 Subject: [Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:29:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:29:58 +0000 Subject: [Koha-bugs] [Bug 32662] Use template wrapper for item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32662 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:30:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:30:02 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:30:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:30:04 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:30:06 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:30:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:30:09 +0000 Subject: [Koha-bugs] [Bug 32743] Reindent the invoice details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:35:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:35:13 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #12 from Tomás Cohen Arazi --- Please rebase. It colllides with bug 32603 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:38:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:38:14 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #7 from Tomás Cohen Arazi --- Conflict, please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:50:54 +0000 Subject: [Koha-bugs] [Bug 32774] Add patron category to suggestion management tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #13 from Lucas Gass --- This is a duplicate of 32603. *** This bug has been marked as a duplicate of bug 32603 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:50:54 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass --- *** Bug 32774 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:52:12 +0000 Subject: [Koha-bugs] [Bug 32408] If a fine can be overridden on checkout in Koha, what should the SIP client do? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #13 from Tomás Cohen Arazi --- Cool, let's allow setting this things at the account level. That would be valuable in the long run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 19:56:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 18:56:07 +0000 Subject: [Koha-bugs] [Bug 16791] [DOCS] Explanation of callnumber.pl plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16791 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Documentation| |David Nind contact| | Summary|Explanation of |[DOCS] Explanation of |callnumber.pl plugin |callnumber.pl plugin Status|NEW |Needs documenting Assignee|chris at bigballofwax.co.nz |david at davidnind.com --- Comment #2 from David Nind --- There is now a cataloguing (value builder) section in the manual (https://koha-community.org/manual/23.05/en/html/valuebuilder.html). My plan is to add a table/list of the plugins with a short description, then to add the details for each one. I'll start with this one, and go from there. Some already have a good description in the actual script, and many of the UNIMARC ones are helpers used to populate the fields with the required values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:31:17 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 --- Comment #3 from David Nind --- Created attachment 146354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146354&action=edit Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:32:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:32:10 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:32:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:32:13 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146073|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 146355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146355&action=edit Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=32813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:33:05 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146355|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 146356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146356&action=edit Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:36:23 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I mucked up the sign off, and have done again! Testing notes (using KTD): 1. In a MARC21 instance, add the callnumber.pl plugin to 952$o for the BKS framework. 2. Edit an item for a record and add "PREFIX 0009678570" as the call number and save. 3. Edit another item for another record. 4. For the call number, enter "PREFIX" and then click on the three dots. 5. Note that it generates the call number as "PREFIX 9678572". Note the description in the script says it should add leading zeros, but it doesn't. I have added bug 32903 for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:36:39 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:37:24 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #146354|0 |1 is obsolete| | --- Comment #4 from David Nind --- Comment on attachment 146354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146354 Bug 32815: Fix cataloguing/value_builder/callnumber.pl Accidentally attached a sign-off for another bug, obsoleting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:55:37 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 --- Comment #10 from Jonathan Druart --- Created attachment 146357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146357&action=edit Bug 32806: Move main-erm.ts to modules/erm.ts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 20:58:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 19:58:10 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #20 from David Nind --- Does cataloguing/value_builder/EXAMPLE.pl need updating to reflect the changes made in the refactoring? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 21:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 20:27:46 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 21:27:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 20:27:49 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146188|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 146358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146358&action=edit Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 21:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 20:28:48 +0000 Subject: [Koha-bugs] [Bug 32293] Terminology: Some budgets are not defined in item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- As the warning can't be triggered until there is a patch for bug 32888, I tested by reviewing the diff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:15:54 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:15:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:15:58 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146348|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 146359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146359&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:16:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:16:01 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146349|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 146360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146360&action=edit Bug 32605: (follow-up) Additional fixes This patch makes some further changes to form CSS in order to improve consistency. Some templates have also been modified to improve layout. - Acquisitions -> New vendor - Staff interface home -> Patrons requesting modifications - Reports -> Saved SQL reports - Serials -> New subscription - Tools -> Import patrons Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:18:21 +0000 Subject: [Koha-bugs] [Bug 32605] Restore some form styling from before the redesign In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #12 from David Nind --- Thanks Owen for the additional information and fixing the issues identified. I've signed off, even though I haven't checked every form. I'm making a big assumption that follow-up bugs will be created for any identified issues once this passes QA and gets pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:24:32 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:24:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:24:36 +0000 Subject: [Koha-bugs] [Bug 32901] Replace use of the slang term "bib" with the term "record" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32901 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146351|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 146361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146361&action=edit Bug 32901: Replace use of the slang term "bib" with the term "record" The "Item processing" pulldown on manage-marc-import.pl uses the slang term "bib" while the rest of the form uses the correct term "record". This field should be updated with the correct terminology. Test Plan: 1) Find or stage a marc record batch 2) Note the "Item processing" pulldown uses the term "bib" 3) Apply this patch 4) Reload that page 5) Note the "Item proccessing" pulldown now uses the term "record" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:46:35 +0000 Subject: [Koha-bugs] [Bug 31498] Allow for custom primary contact method values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:47:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:47:16 +0000 Subject: [Koha-bugs] [Bug 31659] Add SMSAlertNumber to options in borrowers.primary_contact_method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31659 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 22:58:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 21:58:14 +0000 Subject: [Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- The patch no longer applies - I'm getting a sha1 error: git bz apply 32746 Bug 32746 - Standardize structure around action fieldsets in acquisitions 145902 - Bug 32746: Standardize structure around action fieldsets in acquisitions Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32746: Standardize structure around action fieldsets in acquisitions error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt). error: could not build fake ancestor Patch failed at 0001 Bug 32746: Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:01:01 +0000 Subject: [Koha-bugs] [Bug 32904] New: Patrons table processing eternally and not loading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904 Bug ID: 32904 Summary: Patrons table processing eternally and not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Error in console: Uncaught TypeError: settings.jqXHR.responseJSON is undefined -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:02:52 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139701|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:05 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:14 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:22 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:30 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139697|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:38 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:44 +0000 Subject: [Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:46 +0000 Subject: [Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904 --- Comment #1 from Aleisha Amohia --- Created attachment 146362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146362&action=edit Bug 32904: Check if responseJSON is defined for dataTable error This patch checks if responseJSON is defined before checking if responseJSON.errors is defined. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:03:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:03:57 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #11 from Alex Buckley --- Created attachment 146363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146363&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:04:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:04:24 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #12 from Alex Buckley --- Created attachment 146364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146364&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:04:45 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #13 from Alex Buckley --- Created attachment 146365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146365&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:05:07 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #14 from Alex Buckley --- Created attachment 146366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146366&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:05:11 +0000 Subject: [Koha-bugs] [Bug 32904] Patrons table processing eternally and not loading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32030 Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- I'm not sure how to reproduce this or if this is the 'right' fix but it doesn't seem harmful. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:05:11 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32904 [Bug 32904] Patrons table processing eternally and not loading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:05:23 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #15 from Alex Buckley --- Created attachment 146367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146367&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:05:44 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 --- Comment #16 from Alex Buckley --- Created attachment 146368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146368&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:06:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:06:07 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Alex Buckley --- Rebased against master. Ready for testing again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:08:03 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:14:14 +0000 Subject: [Koha-bugs] [Bug 32899] Unused ILL configs in koha-conf.xml should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32899 --- Comment #1 from Katrin Fischer --- I guess Tomas' check included ours, but I can confirm we don't use it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:17:25 +0000 Subject: [Koha-bugs] [Bug 21860] MARC modification templates cannot check or change indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Marc modification templates |MARC modification templates |cannot check or change |cannot check or change |indicators |indicators -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:17:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:17:43 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 7 23:53:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 22:53:10 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 myoon at carnegiestout.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |myoon at carnegiestout.org --- Comment #14 from myoon at carnegiestout.org --- Works like a charm! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:17:19 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142286|0 |1 is obsolete| | --- Comment #23 from Lucas Gass --- Created attachment 146369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146369&action=edit Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:17:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:17:22 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142287|0 |1 is obsolete| | --- Comment #24 from Lucas Gass --- Created attachment 146370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146370&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:17:24 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142288|0 |1 is obsolete| | --- Comment #25 from Lucas Gass --- Created attachment 146371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146371&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:17:27 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143595|0 |1 is obsolete| | --- Comment #26 from Lucas Gass --- Created attachment 146372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146372&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:43:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:43:39 +0000 Subject: [Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168 --- Comment #2 from Lucas Gass --- Created attachment 146373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146373&action=edit Bug 32168: Add dateaccessioned.pl to 952 (datelastseen) for new installs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:48:51 +0000 Subject: [Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168 --- Comment #3 from Lucas Gass --- > Just wondering, if that could cause problems with bug 31212 Yes, I am running into this problem while working on 31212. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:50:00 +0000 Subject: [Koha-bugs] [Bug 32168] Editing date/datetime fields without the dateaccessioned.pl plugin can cause errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168 --- Comment #4 from Lucas Gass --- My patch enables dateaccessioned.pl by default with 952$r but should we also do the same for other date fields? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 00:51:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Feb 2023 23:51:05 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Lucas Gass --- This patchset is again ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:03:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:03:33 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|michalurban177 at gmail.com |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:22:51 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass --- Works as describe and tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:05 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:07 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146363|0 |1 is obsolete| | --- Comment #19 from Lucas Gass --- Created attachment 146374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146374&action=edit Bug 30418: Database changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:10 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146364|0 |1 is obsolete| | --- Comment #20 from Lucas Gass --- Created attachment 146375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146375&action=edit Bug 30418: Updated schema file Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:12 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146365|0 |1 is obsolete| | --- Comment #21 from Lucas Gass --- Created attachment 146376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146376&action=edit Bug 30418: Template and JavaScript changes Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:15 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146366|0 |1 is obsolete| | --- Comment #22 from Lucas Gass --- Created attachment 146377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146377&action=edit Bug 30418: Add ability for permitted staff to edit list contents Public lists with 'Allow changes to contents from' = 'Permitted staff only' can have their contents managed by Koha patrons with either of the permissions below: - superlibrarian permission - catalogue permission + 'edit_public_list_contents' sub-permission Test plan: 1. Apply patches, update database, restart services 2. In the staff client go to: Lists > New List 3. Create a list, choose 'Allow changes to contents from' => 'Permitted staff only' 4. Log into the OPAC as a patron with no permissions. 5. Confirm you CANNOT add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 6. Log into the OPAC as a patron with only the 'catalogue' permissions enabled 7. Confirm you CANNOT add a biblio to the list from OPAC search result or biblio detail pages 8. Log into the OPAC as a patron with the 'catalogue' and 'edit_public_list_contents' permissions enabled 9. Confirm you CAN add/remove biblios from the OPAC search result and biblio detail pages 10. Log into the OPAC as a patron with superlibrarian permissions 11. Confirm you CAN add a biblio to the list from the OPAC search result page and OPAC biblio detail pages 12. Log into the staff client as a patron with only the 'catalogue' permission and confirm you CANNOT add/remove records from the list 13. Log into the staff client as a patron with the 'catalogue' and 'edit_public_list_contents' sub-permission (found under 'Lists' parent permission) 14. Confirm you CAN add/remove records from the list 15. Login into thestaff client as a patron with 'superlibrarian' permissions and confirm you CAN add/remove records from the list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:18 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146367|0 |1 is obsolete| | --- Comment #23 from Lucas Gass --- Created attachment 146378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146378&action=edit Bug 30418: Unit tests Test plan: 1. Run unit tests sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:24:21 +0000 Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146368|0 |1 is obsolete| | --- Comment #24 from Lucas Gass --- Created attachment 146379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146379&action=edit Bug 30418: Re-order options of who can edit list contents The 'Allow changes to contents from' dropdown when creating/edit lists should be most locked down to least locked down: 1. Nobody 2. Owner only 3. Permitted staff only 4. Staff only 5. Anyone seeing this list Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:32:47 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:32:50 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:32:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:32:56 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 01:33:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 00:33:52 +0000 Subject: [Koha-bugs] [Bug 27730] Innocent changes to framework silently delete bibliographic data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 03:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 02:44:07 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #21 from Aleisha Amohia --- Can this fix please be backported to 22.11? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 04:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 03:00:56 +0000 Subject: [Koha-bugs] [Bug 27730] Innocent changes to framework silently delete bibliographic data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 04:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 03:22:28 +0000 Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 Danyon Sewell changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 04:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 03:42:14 +0000 Subject: [Koha-bugs] [Bug 32905] New: Fine calculation issue in 22.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32905 Bug ID: 32905 Summary: Fine calculation issue in 22.05 Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org Hello I noticed fine calculation issue in Koha version 22.05 onward and same has been reported byany in 22.11 also. Test plan 1. Configure circulation and fine rules 2. Issue book with backdate 3. Run the cronjob fines.pl 4. Check fine is not calculated 5. Under circulation and fine rules remove default value 0.00 from "overdue fines caps (amount) and give some value to like 100 6. Now run the cronjob fines.pl 7. Check the fine is calculated Now the issue is in earlier versions by default value was nothing under "overdue fines cap (amount)" option so the default value 0.00 in above versions asume fine cap is zero so system does not calculate though everything is configured well. Thanking you -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 05:42:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 04:42:21 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #7 from quickfire28 at gmail.com --- (In reply to quickfire28 from comment #6) > > > Added new system preference 'UseOCLCEncodingLevels' > Upgrade to 22.06.00.056 [12:00:42]: Bug 30571 - Table z3950servers: three > cols > NOT NULL > Upgrade to 22.06.00.057 [12:00:42]: Bug 29071 - Set > HoldsQueueSplitNumbering wh > ere not set > Added new system preference 'HoldsSplitQueueNumbering' > Upgrade to 22.06.00.058 [12:00:42]: Bug 30944 - Replace > branchtransfers.cancell > ation_reason CancelRecall with RecallCancellation > Upgrade to 22.06.00.059 [12:00:42]: Bug 25936 - A password change > notification > feature > Added new letter 'PASSWORD_CHANGE' (email) > Added new system preference 'NotifyPasswordChange' > Upgrade to 22.06.00.060 [12:00:42]: Bug 10950 - Add preferred pronoun field > to > patron record > Added column 'borrowers.pronouns' > Added column 'deletedborrowers.pronouns' > Added column 'borrower_modifications.pronouns' > Upgrade to 22.06.00.061 [12:00:42]: Bug 31333 - Add the ability to limit > purcha > se suggestions by patron category > Added new system preference 'suggestionPatronCategoryExceptions' > Upgrade to 22.06.00.062 [12:00:42]: Bug 27136 - Add missing languages: > Cree, Af > rikaans and Multiple languages, Undetermined and No linguistic content > Added missing languages > Upgrade to 22.06.00.063 [12:00:43]: Bug 31569 - Add primary key for > import_bibl > ios > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry > '104 > 34' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 > > Enabling plugins on node rabbit at lrc: > rabbitmq_stomp > The following plugins have been configured: > rabbitmq_stomp > Applying plugin configuration to rabbit at lrc... > The following plugins have been enabled: > rabbitmq_stomp > > started 1 plugins. > Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service > is transient or generated. > > > Here is the result of upgrade and the error. I dont know how to check which table is affected with that error in upgrade. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 07:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 06:57:53 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144983|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 146380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146380&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3)After go to "Edit"-> "Edit record" -> "Replace record via..." or choose "Replace Record.." directly 4) See that form is also prefilled with data now Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 07:57:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 06:57:56 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #44 from Martin Renvoize --- Created attachment 146381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146381&action=edit Bug 29173: (QA follow-up) Match pop-over sizes As suggested by David Nind, this patch updates the call to z3950 search on the authority edit page to match the sizing of the one from the details page. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:01:50 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #45 from Martin Renvoize --- This all works well and the QA script is happy. I would have loved to see some consistency in the implementation between the two buttons however.. At first I thought this approach made the most logical sense, at the controller level, but as I worked through the code to understand how it works on the edit page I concluded that I think that's the cleaner approach pre-populating the search fields using the data already on display in the page rather than having to query for it again in the search controller. Anyway.. I don't think that should hold this up.. but it might be nice to clean up as a follow-up bug. Passing QA, thanks Thibaud, and welcome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:05:51 +0000 Subject: [Koha-bugs] [Bug 32906] New: Make 'Replace record via Z3950/SRU' buttons in authorities work consistently Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906 Bug ID: 32906 Summary: Make 'Replace record via Z3950/SRU' buttons in authorities work consistently Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 29173 Bug 29173 implemented search pre-fill for the Replace via Z3950 search form from the authority detail page, but it did so in a very different, and MARC21 specific, way from the same button on the 'Edit authority' page. On the edit authority page we extract the pre-fill terms from the current page and pass them as URI parameters to the search pop-over form. I think we could take a similar approach on the detail display page and perhaps even make the feature work for both MARC21 and UNIMARC in this way? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:05:51 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906 [Bug 32906] Make 'Replace record via Z3950/SRU' buttons in authorities work consistently -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:06:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:06:15 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:38:39 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146307|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 146382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146382&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:38:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:38:42 +0000 Subject: [Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:38:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:38:55 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- This patch does not seem to be the correct fix. The columns in items and deleteditems are supposed to be the same, if you have a mismatch then you must fix the DB structure. Did you compare both table structures? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:48:23 +0000 Subject: [Koha-bugs] [Bug 32511] Circulation statistics result Error 500 where select Collection, Shelving location, Home library or Holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32511 --- Comment #18 from Mohd Hafiz Yusoff --- (In reply to Jonathan Druart from comment #17) > This patch does not seem to be the correct fix. The columns in items and > deleteditems are supposed to be the same, if you have a mismatch then you > must fix the DB structure. > > Did you compare both table structures? Patch working at me, but this discussion Failed QA. How to fix DB structures or compare table structures. Tq -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:49:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:49:45 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20395 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:49:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:49:45 +0000 Subject: [Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:50:57 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 --- Comment #7 from Jonathan Druart --- There is also recall_overdue_fine, but it should not be a problem as it's not a max. However, shouldn't we revert the changes made to bug 20395 and restore the formatting instead of completely removing it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:57:37 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:57:39 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146013|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 146383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146383&action=edit Bug 32798: Update parameter passed to Koha::Biblio::Metadata->record To test: 1 - Enable OAI sets, and define a set with mapping 952 y = BK 2 - perl misc/migration_tools/build_oai_sets.pl -v -i -r 3 - The script dies: Koha::Biblio::Metadata->record must be called on an instantiated object or like a class method with a record passed in parameter 4 - Apply patch 5 - Repeat 6 - Success! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 08:57:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 07:57:51 +0000 Subject: [Koha-bugs] [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_22_11_candidate Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:08:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:08:50 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #40 from Martin Renvoize --- Follow-up pushed to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:11:31 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #46 from Thibaud Guillot --- (In reply to Martin Renvoize from comment #45) > This all works well and the QA script is happy. > > I would have loved to see some consistency in the implementation between the > two buttons however.. At first I thought this approach made the most > logical sense, at the controller level, but as I worked through the code to > understand how it works on the edit page I concluded that I think that's the > cleaner approach pre-populating the search fields using the data already on > display in the page rather than having to query for it again in the search > controller. > > Anyway.. I don't think that should hold this up.. but it might be nice to > clean up as a follow-up bug. > > Passing QA, thanks Thibaud, and welcome! Thanks to you Martin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:24:18 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Jonathan Druart --- (In reply to Emily Lamancusa from comment #20) > I encountered an error while testing this patch with batch item updates, in > which one bad bib blocked the ES indexing update for every item in the batch. Hello Emily, I confirm the problem, but that's not directly linked with this patch. I am pretty sure this issue exists without this patch. When you create a new batch, 2 new jobs are created, the first one is modifying the items in database, the second one is updating elastic's index. If you look at the job list you will see that the second one has in error (still not clear, the status is "finished", but there is an error in the detail: " / records have successfully been reindexed. Some errors occurred.") That's not ideal but we should deal with that on a separate bug report in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:26:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:26:01 +0000 Subject: [Koha-bugs] [Bug 32792] new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Component|Koha |About Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:26:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:26:25 +0000 Subject: [Koha-bugs] [Bug 32907] New: Add a field for personal ID Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32907 Bug ID: 32907 Summary: Add a field for personal ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I know storing social security numbers are a big no-no in some countries, but in others it is perfectly fine and legal. At least libraries in Norway and Sweden expect an ILS to store and handle these numbers. They are not considered "top secret", but are used "everywhere" to identify people. In these countries it looks like a strange omission that "personal IDs" are not handled properly by the system, but have to be shoe-horned in as an extended patron attribute. This also makes it harder than necessary to write reports, sync data from external sources etc. I propose that we - add a database column like borrowers.personalid - add a syspref called something like UsePersonalID - set UsePersonalID to false as the default - make all display and handling of personalid dependent on UsePersonalID This way handling personal IDs will be opt-in only, and something that can be a choice for libraries that want/need to use it. Personal IDs could not only be social security numbers either, in an academic library it could be used for e.g. ORCIDs: https://orcid.org/ A further enhancement to this would be to use personalid for logins, as a third alternative to cardnumber and userid. This could also be governed by a syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 09:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 08:28:38 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #53 from Jonathan Druart --- (In reply to David Cook from comment #52) > (In reply to Martin Renvoize from comment #49) > > You can add my SO lines to the remote branch Jonathan.. I'm happy I got it > > all working for a standard install and a dev type install.. and it sounds > > like David was pretty happy with building a package, all be it he had > > expected issues due to upstream having a bad debian.control file at the > > minute (I fixed that in 22.11.x branch already.. not sure if he's got it > > building and applying to master regularly yet?) > > Yeah I'm pretty happy :) PQA then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 10:37:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 09:37:11 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 10:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 09:42:25 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 12:08:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 11:08:16 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 --- Comment #3 from Jonathan Druart --- Created attachment 146384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146384&action=edit Bug 32898: ERM - Improve fetch ... and fix cypress tests The main problem was that there were no more checkError call for fetchLocalTitleCount and the error was not displayed on the UI. This commit is doing several things: - Refactor fetch.js to call the same fetch method (myFetch) in order to deal with the error in a single place - Have a new myFetchTotal JS function to get the X-Total-Count header from the response and get the benefit of the previous refactoring - Rename fetchCountLocalPackages with fetchLocalPackagesCount to match fetchLocalTitleCount - Use fetchLocalPackagesCount on the Package list view - Use checkError from components using fetch directly. Ideally the could should be moved to fetch.js and myFetch should be used. - checkError get a new flag in parameter to ask for the response instead of the result (ie. the JSON of the response). That's useful when we need the response status or the headers - Make checkError throw a proper exception to stop propation. This modify the error we display on the UI, it's why we have the following changes in cypress tests: - "Something went wrong: Internal Server Error" + "Something went wrong: Error: Internal Server Error" That's not ideal, we should have our own JS exception to avoid that "Error" (coming from the toString call on the error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 12:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 11:10:44 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |martin.renvoize at ptfs-europe | |.com, | |paul.derscheid at lmscloud.de, | |tomascohen at gmail.com Status|ASSIGNED |Needs Signoff --- Comment #4 from Jonathan Druart --- Several tiny but important changes on the second patch. Could I get your opinion on it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 12:15:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 11:15:15 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146384|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 146385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146385&action=edit Bug 32898: ERM - Improve fetch ... and fix cypress tests The main problem was that there were no more checkError call for fetchLocalTitleCount and the error was not displayed on the UI. This commit is doing several things: - Refactor fetch.js to call the same fetch method (myFetch) in order to deal with the error in a single place - Have a new myFetchTotal JS function to get the X-Total-Count header from the response and get the benefit of the previous refactoring - Rename fetchCountLocalPackages with fetchLocalPackagesCount to match fetchLocalTitleCount - Use fetchLocalPackagesCount on the Package list view - Use checkError from components using fetch directly. Ideally the could should be moved to fetch.js and myFetch should be used. - checkError get a new flag in parameter to ask for the response instead of the result (ie. the JSON of the response). That's useful when we need the response status or the headers - Make checkError throw a proper exception to stop propation. This modify the error we display on the UI, it's why we have the following changes in cypress tests: - "Something went wrong: Internal Server Error" + "Something went wrong: Error: Internal Server Error" That's not ideal, we should have our own JS exception to avoid that "Error" (coming from the toString call on the error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 12:30:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 11:30:30 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #54 from Jonathan Druart --- There is a merge request in misc4dev to support both build_js and build, see https://gitlab.com/koha-community/koha-misc4dev It must be merged before this is pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 12:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 11:37:57 +0000 Subject: [Koha-bugs] [Bug 32657] neworderempty.pl should use RDA tag 264 not tag 260 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32657 Angela changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.oconnordesmond at staff | |.ittralee.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:05:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:05:52 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:05:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:05:55 +0000 Subject: [Koha-bugs] [Bug 28672] Improve EDI debug logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28672 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:05:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:05:57 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:05:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:05:59 +0000 Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:06:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:06:02 +0000 Subject: [Koha-bugs] [Bug 32408] If a fine can be overridden on checkout in Koha, what should the SIP client do? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:06:04 +0000 Subject: [Koha-bugs] [Bug 32408] If a fine can be overridden on checkout in Koha, what should the SIP client do? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32408 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:06:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:06:06 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:06:10 +0000 Subject: [Koha-bugs] [Bug 32788] Curbside pickups - Order curbside pickup slots chronologically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32788 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:09:33 +0000 Subject: [Koha-bugs] [Bug 32908] New: Item type icons broken in the bibliographic record details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Bug ID: 32908 Summary: Item type icons broken in the bibliographic record details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at dataly.gr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 146386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146386&action=edit Staff_Interface-Bibliographic_record_details-Item_type_icon_BROKEN In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 and is still broken [*] in the current master (539efac9aa), as the tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is b686bd65e19a6688ebda109a156ea31576559e4f from Bug 31321. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the and settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:12:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:12:47 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #1 from George Veranis --- Created attachment 146387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146387&action=edit Staff_Interface-Bibliographic_record_details-Item_type_icon_OK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:13:11 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #2 from George Veranis --- Steps to reproduce: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon Then, visit the bibliographic record's details page in the Staff interface. In the 'Item type' column of the 'Holdings' tab, notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser. [If you try the above in a Dockerised Koha instance the icon will -most likely- be displayed just fine. However, you can still verify that it's being loaded from the wrong path by right-clicking on the icon and selecting 'Inspect'.] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:17:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:17:44 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #41 from Marcel de Rooy --- Nobody willing to comment on questions in comment37 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:23:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:23:24 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gveranis at dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:25:46 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:25:48 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #3 from George Veranis --- Created attachment 146388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146388&action=edit Bug 32908: Load item type icons from the correct path In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Mentored by : Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:59:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:59:30 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24121 URL| |catalogue/detail.pl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 13:59:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 12:59:30 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32908 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:05:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:05:55 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #42 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #37) > (In reply to Jonathan Druart from comment #35) > > prove t/db_dependent/SIP/SIPServer.t > > t/db_dependent/SIP/SIPServer.t .. Can't locate object method "BINMODE" via > > package "C4::SIP::Trapper" at > > /usr/share/perl5/Log/Log4perl/Appender/Screen.pm line 22. > > Compilation failed in require at t/db_dependent/SIP/SIPServer.t line 40. > > BEGIN failed--compilation aborted at t/db_dependent/SIP/SIPServer.t line 40. > > # Looks like your test exited with 255 before it could output anything. > > t/db_dependent/SIP/SIPServer.t .. Dubious, test returned 255 (wstat 65280, > > 0xff00) > > Failed 1/1 subtests > > Whats the relation with worker? > I have no idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:07:35 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Laura changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #46 from Laura --- The test plan still works but OPACFineNoRenewals is still showing as OPACFineNoRenewals and not FineNoRenewals. (In reply to Emmi Takkinen from comment #45) > Created attachment 139674 [details] [review] > Bug 23415: Rename OPACFineNoRenewals > > OPACFineNoRenewals no longer applies just to OPAC. > To avoid confusion rename it as FineNoRenewals and > also rename all occurences in code. > > To test, confirm everything works as described in > previous test plans. > > Also prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:10:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:10:47 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:16:16 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 --- Comment #8 from Katrin Fischer --- I think the problem is not fixed in the right spot. Displaying the fine with comma is one thing, but the problem appears on editing. When the rule values are copied to the inputs for editing, they need to be "unformatted". Does that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:20:07 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #9 from Agustín Moyano --- (In reply to Martin Renvoize from comment #8) > Aren't we being a bit nieve here in terms of autoBarcode? > > I'm wondering: > 1) Can we move the autoBarcode handling into Koha::Item->store() instead? > 2) Even if we don't move the autoBarcode handling, don't we need to account > for the other options it supports? Hi Martin, If I remove all about autoBarcode and link this to bug 32896, would it pass QA? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:35:04 +0000 Subject: [Koha-bugs] [Bug 32907] Add a field for personal ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32907 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #1 from Donna --- Hi Magnus! We are seeing this with academic libraries more often now - they issue a card number but also need to record the student number. I would love if this field could be added to the standard patron search fields, and it sounds like it would be! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:47:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:47:39 +0000 Subject: [Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 Laura changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #9 from Laura --- (In reply to Emmi Takkinen from comment #7) > Created attachment 144570 [details] [review] > Bug 31470: Add id "relationship" to memberentrygen.tt, change id > "relationship" in auth-finder-search.inc > > In members.js line 112 variable guarantor_relationship is selected > with id "relationship". However id "relationship" is used in > auth-finder-search.inc, not in memberentrygen.tt. > > One way to see what kind of effect incorrect selector has (and how I > originally stumbled into this), is to add into "IntranetUserJS" a line > which changes non-patron guarantors relationship default selected value as > other than empty. Script has to change "relationship" instead of > "new_guarantor_relationship" because selector input for patron guarantors > relationship actually uses default selected value from non-patron guarantors > relationship. > > This patch changes two things. Firstly it adds id "relationship" to > memberentrygen.tt so that member.js can fetch correct value > to variable guarantor_relatioship. Secondly it changes id "relationship" > in auth-finder-search.tt as "special_relationship" to avoid confusion. > > To test memberentrygen.tt: > 1. Make sure you have some value(s) in syspref "borrowerRelationship" e.g. > "guarantor". > 2. Add following line to "IntranetUseJS": $('.relationship > option:eq(1)').attr('selected', 'selected'); > 3. Add guarantee patron and note that non-patron guarantors relationship is > now "guarantor". > 4. Add patron guarantor and note that relationship value is empty. > 5. Apply this patch and refresh page. > 6. Repeat step 4. > => Note that now relationship value is "guarantor". > > To test auth-finder-search.inc: > 1. Add authority e.g. Chronological Term > 2. Modify field 551$a, click "Tag editor" icon from right > 3. Searc pop-up is opened. > => Make sure that field "Special relationship" is highlighted > when you hover mouse over label. > => Make sure that after performing a search, search value in > "Special relationship" field persists. > > Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:48:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:48:28 +0000 Subject: [Koha-bugs] [Bug 32783] Add more mapping when creating eholding from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32783 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:54:39 +0000 Subject: [Koha-bugs] [Bug 31669] Make cost editable on edit request form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31669 Niamh Walker-Headon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon at hse.ie --- Comment #2 from Niamh Walker-Headon --- Has anyone thought about integration with acquisitions, and whether cost or price would be mapped? This might have implications for this bug. In addition, perhaps cost and price need to be relabelled? Patron Charge Vendor Price -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 14:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 13:58:16 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:00:45 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 [Bug 32898] Cypress tests are failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:00:45 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 [Bug 32807] No need to fetch all if we need to know if one exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:01:35 +0000 Subject: [Koha-bugs] [Bug 32909] New: Item type icons broken when placing an item-level hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Bug ID: 32909 Summary: Item type icons broken when placing an item-level hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item. This feature broke in v22.05.00 and is still broken [*] in the current master (ac1e80400d), as the tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is d4855131e3b8e5852f221182ed9588f4ddc67368 from Bug 29660. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the and settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:02:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:02:28 +0000 Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 --- Comment #3 from Niamh Walker-Headon --- I agree with Hugo's comment about being able to select the z39.50 targets, that makes sense. Currently, since our last upgrade the availability plugin shows in the staff client when creating a request https://koha.hselibrary.ie/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm but a staff member can't launch a search from the illview screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:03:14 +0000 Subject: [Koha-bugs] [Bug 22384] Make the title of an ILL clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22384 --- Comment #1 from Niamh Walker-Headon --- I agree, it would be more in line with what users are expecting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:04:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:04:09 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #1 from Andreas Roussos --- Created attachment 146389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146389&action=edit When trying to place a hold, no item type icon is displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:05:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:05:20 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #2 from Andreas Roussos --- Created attachment 146390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146390&action=edit When trying to place a hold, the item type icon is displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:05:34 +0000 Subject: [Koha-bugs] [Bug 22320] Make ILL comments visible to all staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22320 --- Comment #3 from Niamh Walker-Headon --- We have had to give all staff access to the ILL module. There is no way to limit their access to view, as a way to resolve this at the moment. I think allowing the viewing of ILL requests via the patron record, including notes as a granular permission would be our preferred solution to this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:06:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:06:43 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24121, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32908 URL| |reserve/request.pl --- Comment #3 from Andreas Roussos --- Steps to reproduce: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon Then, visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser. [If you try the above in a Dockerised Koha instance the icon will -most likely- be displayed just fine. However, you can still verify that it's being loaded from the wrong path by right-clicking on the icon and selecting 'Inspect'.] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:06:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:06:43 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:06:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:06:43 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:07:11 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:10:03 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:12:32 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:12:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:12:34 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #4 from Andreas Roussos --- Created attachment 146391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146391&action=edit Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:16:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:16:08 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #5 from Andreas Roussos --- I just wanted to point out that this bug is similar to the one George reported in Bug 32908, but actually has a different scope as it occurs when trying to place a hold. It also affects a wider range of Koha versions (v22.05.00 onwards) and has a test plan that's slightly different. Which is why I decided to submit a separate bug report and not a follow-up patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:14 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:16 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 --- Comment #1 from Kyle M Hall --- Created attachment 146392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146392&action=edit Bug 32902: Update Schema File [DO NOT PUSH] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:21 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:23 +0000 Subject: [Koha-bugs] [Bug 32908] Item type icons broken in the bibliographic record details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146388|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians --- Created attachment 146393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146393&action=edit Bug 32908: Load item type icons from the correct path In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:48 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146392|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 146394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146394&action=edit Bug 32902: Update Schema File [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:37:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:37:56 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 --- Comment #3 from Kyle M Hall --- Created attachment 146395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146395&action=edit Bug 32902: Add option to only overlay if matched item is on matched record Bug 32084 resolves an bug where an overlaid item could have its' biblionumber changed. Fixing this has the effect of enabling items to be updated even if the item is on a different record. This can be wanted or unwanted behavior depending on the situation. It would be good if the cataloger could choose which behavior is preferred on a per-batch bases. Test Plan: 1) Grab the sample marc record file from bug 32804 2) Upload this file, chose to match on biblionumber and replace matching item if any matching record was found 3) Import the batch 4) Note the item was replaced 5) Revert the import 6) Change the rule to replace matching items if matching item is on matching record 7) Apply different matching rules 8) Import the batch into the catalog 9) Note the item was not replaced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:40:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:40:13 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:40:27 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:56:51 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #43 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #41) > Nobody willing to comment on questions in comment37 ? I missed the context of your question there, as the error you commented had no relation to a worker or smth. I guess you meant the third patch, in which Nick silently added some missing log4perl entries for worker in the different debian/*.postinst files. It felt out of place, but as it had your QA stamp I didn't worry. It is good in my opinion should've happened on a separate bug. Thanks for raising it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:56:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:56:58 +0000 Subject: [Koha-bugs] [Bug 32910] New: Upgrade fontawesome icons to V6 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Bug ID: 32910 Summary: Upgrade fontawesome icons to V6 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 15:59:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 14:59:03 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #1 from Jonathan Druart --- Created attachment 146396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146396&action=edit Bug 32910: Adjust fontawesome icons ref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 16:02:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 15:02:30 +0000 Subject: [Koha-bugs] [Bug 32612] Koha background worker should log to worker-error/output.log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32612 --- Comment #44 from Marcel de Rooy --- Hmm. Thx Joubu and Tomas for responding. But these SIP::Trapper patches here still feel completely out of scope. Never mind ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 16:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 15:04:48 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146396|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 16:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 15:04:56 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #2 from Jonathan Druart --- I had a quick try at upgrading to V6, but it needs more attention. Especially a better focus on those 2 pages: https://fontawesome.com/v5/docs/web/setup/upgrade-from-v4 https://fontawesome.com/docs/web/setup/upgrade/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 16:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 15:05:19 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #3 from Jonathan Druart --- I didn't manage to attach the patches here, see https://gitlab.com/joubu/Koha/-/commits/bug_32910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 16:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 15:05:42 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:14:11 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Marius changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:14:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:14:13 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Marius changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135214|0 |1 is obsolete| | --- Comment #6 from Marius --- Created attachment 146397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146397&action=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <>
Or add another guarantor. in the textbox from the select list. f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Repeat steps a) to d) f) Notice that you can see the guarantor's informations. This also works if you decide to add a non-patron guarantor instead of a patron guarantor at step 3. NOTE: If you want to delete the letters, go in your database and run: - delete from message_queue; Signed-off-by: Marius Mandrescu Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:15:46 +0000 Subject: [Koha-bugs] [Bug 32902] Add ability to choose if items overlay if any record matches or only if the item is on the matched record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32902 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:20:10 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Marius changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146397|0 |1 is obsolete| | --- Comment #7 from Marius --- Created attachment 146398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146398&action=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <>
Or add another guarantor. in the textbox from the select list. f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Repeat steps a) to d) f) Notice that you can see the guarantor's informations. This also works if you decide to add a non-patron guarantor instead of a patron guarantor at step 3. NOTE: If you want to delete the letters, go in your database and run: - delete from message_queue; Signed-off-by: Marius Mandrescu Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:24:01 +0000 Subject: [Koha-bugs] [Bug 32898] Cypress tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146385|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 146399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146399&action=edit Bug 32898: ERM - Improve fetch ... and fix cypress tests The main problem was that there were no more checkError call for fetchLocalTitleCount and the error was not displayed on the UI. This commit is doing several things: - Refactor fetch.js to call the same fetch method (myFetch) in order to deal with the error in a single place - Have a new myFetchTotal JS function to get the X-Total-Count header from the response and get the benefit of the previous refactoring - Rename fetchCountLocalPackages with fetchLocalPackagesCount to match fetchLocalTitleCount - Use fetchLocalPackagesCount on the Package list view - Use checkError from components using fetch directly. Ideally the could should be moved to fetch.js and myFetch should be used. - checkError get a new flag in parameter to ask for the response instead of the result (ie. the JSON of the response). That's useful when we need the response status or the headers - Make checkError throw a proper exception to stop propation. This modify the error we display on the UI, it's why we have the following changes in cypress tests: - "Something went wrong: Internal Server Error" + "Something went wrong: Error: Internal Server Error" That's not ideal, we should have our own JS exception to avoid that "Error" (coming from the toString call on the error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:31:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:31:58 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 --- Comment #22 from Emily Lamancusa --- (In reply to Jonathan Druart from comment #21) > (In reply to Emily Lamancusa from comment #20) > > I encountered an error while testing this patch with batch item updates, in > > which one bad bib blocked the ES indexing update for every item in the batch. > > Hello Emily, I confirm the problem, but that's not directly linked with this > patch. I am pretty sure this issue exists without this patch. > > When you create a new batch, 2 new jobs are created, the first one is > modifying the items in database, the second one is updating elastic's index. > If you look at the job list you will see that the second one has in error > (still not clear, the status is "finished", but there is an error in the > detail: " / records have successfully been reindexed. Some errors occurred.") > > That's not ideal but we should deal with that on a separate bug report in my > opinion. Good to know - I didn't think to check whether the error was present without the patch (though it seems obvious in retrospect). Everything worked as intended on edits that didn't touch the broken bib, so I'll sign off here and open a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:18 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:21 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #22 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:23 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:25 +0000 Subject: [Koha-bugs] [Bug 26765] Make author span a clickable link on OPAC results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26765 --- Comment #10 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:26 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:28 +0000 Subject: [Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 --- Comment #5 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:30 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:31 +0000 Subject: [Koha-bugs] [Bug 31768] Tags is a 'Tool' but doesn't include the tools nav sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31768 --- Comment #8 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:33 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:35 +0000 Subject: [Koha-bugs] [Bug 31860] Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31860 --- Comment #8 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:37 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:38 +0000 Subject: [Koha-bugs] [Bug 32023] Remove horizontal line from OPAC navigation for CMS pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32023 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:40 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:41 +0000 Subject: [Koha-bugs] [Bug 32027] Terminology: change "librarian interface" to "staff interface" in additional contents tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32027 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:43 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:45 +0000 Subject: [Koha-bugs] [Bug 32222] Capitalization: id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:46 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:48 +0000 Subject: [Koha-bugs] [Bug 32226] Capitalization: Edit html content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32226 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:49 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:51 +0000 Subject: [Koha-bugs] [Bug 32264] Capitalization/Terminology: Show in Staff client? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32264 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:52 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:54 +0000 Subject: [Koha-bugs] [Bug 32290] Ill requests uses some wrong terminology In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32290 --- Comment #8 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:56 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:57 +0000 Subject: [Koha-bugs] [Bug 32295] Punctuation: Filters : In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32295 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:37:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:37:59 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:01 +0000 Subject: [Koha-bugs] [Bug 32455] Don't send hold notices from the library's inbound email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32455 --- Comment #14 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:02 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:04 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #22 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:06 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:08 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 --- Comment #7 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:10 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:38:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:38:11 +0000 Subject: [Koha-bugs] [Bug 32786] Curbside pickup admin page has cities search bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32786 --- Comment #6 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:44:04 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #6 from Laura Escamilla --- (In reply to Andreas Roussos from comment #4) > Created attachment 146391 [details] [review] > Bug 32909: Load item type icons from the correct path > > When placing an item-level hold in the Staff interface, > the table at the bottom of the screen (under the "Place > a hold on a specific item" heading) should display the > icon associated with the item type of each item in the > 'Item type' column. > > This feature broke in v22.05.00 (for Debian package installs): > instead of the item type icon you get the default 'broken > image URL' image of your web browser. > > This patch fixes that. > > Test plan: > > 1) (if needed) Configure the following System preferences: > - item-level_itypes => 'specific item' > - noItemTypeImages => 'Show' > > 2) (if needed) In Koha Administration > Item types, create > an item type and associate it with an icon > > 3) (if needed) Create a test bibliographic record, and add > an item to it that has an item type with an icon > > 4) Visit the bibliographic record's details page in the > Staff interface. Select 'Holds' on the left hand side, > then pick a patron. The "Place a hold on ..." page should > load. In the 'Item type' column of the table at the bottom > of the screen notice that instead of seeing the icon > associated with the item type of each item you get the > default 'broken image URL' image of your web browser [*] > > [*] In non-Debian package installs, the 'href' property > of the item type icon's tag should start with > '/opac-tmpl/bootstrap/itemtypeimg' > > 5) Apply this patch, restart Plack and refresh the page. > The item type icon should now be displayed correctly. > > KTD and Koha Sandboxes users: To verify the patch has > worked, you should right-click on the item type icon and > click 'Inspect': the 'href' property of the tag > should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:48:15 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 8 17:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Feb 2023 16:48:18 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145147|0 |1 is obsolete| | Attachment #145148|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 146400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146400&action=edit Bug 32507: Use template wrapper to build breadcrumb navigation This patch lays the groundwork for updating the way we build breadcrumb navigation on each page, and implements it on the cities administration page as a proof of concept. The page creates two blocks, 'breadcrumbs' and 'breadcrumb_item' 'breadcrumbs' builds the outer structure of the menu, currently: