[Koha-bugs] [Bug 30943] Make background job classes use helpers

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 1 10:03:50 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am all for this change, but I don't think it should be pushed before we
stabilize this area a bit. There are bug fixes with higher priority.

I would like to note 2 things here:
1. the tidy in Koha/BackgroundJob/BatchUpdateItem.pm goes against my config, so
we have a problem here if people go after others to tidy differently their
code..

2. I was intrigued by the removal of
-    $self->discard_changes;
and it seems safe.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list