[Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry I didn't spot this earlier.. great piece of functionality; Had to do a
minor rebase to get it to apply clean, nothing too scary.

I added a follow-up to convert from 'key' to 'error_code' as that's the
direction we're headed I believe.

I also far prefer your construction of the result alerts.. makes my code look
very amateurish!

Regarding choice of 409 vs 400 i'm never sure which to use.. perhaps 409 for
'resolvable conflicts' that trigger the option to resend with a condition and
400 for unresolvable one's where we show a harder error and no inline
resolution option?

Finally.. tests.. I think we perhaps need some API tests to prevent regressions
from creeping in with your addition of a new param on the endpoint?.. I'll
leave that one for the QA person.

-- 
You are receiving this mail because:
You are watching all bug changes.