[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

--- Comment #128 from Magnus Enger <magnus at libriotech.no> ---
Great to see this is being kept alive after so many years! :-) 

I had the same initial error as David and Solene. I was able to make it go away
by doing this: 

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
index 931079996c..f8b57c0db7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt
@@ -373,7 +373,7 @@
             </tr>
             </thead>
             <tbody>
-                [% FOREACH s IN signs %]
+                [% FOREACH s IN signs.next %]
                 <tr>
                     <td><a
href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id | uri
%]">[% s.name | html %]</a></td>
                     <td>[% IF ( s.webapp ) %]Yes[% ELSE %]No[% END %]</td>
@@ -413,7 +413,7 @@
             </tr>
             </thead>
             <tbody>
-                [% FOREACH s IN streams %]
+                [% FOREACH s IN streams.next %]
                 <tr>
                     <td><a
href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[%
s.sign_stream_id | uri %]">[% s.name | html %]</a></td>
                     <td title="ID: [% s.saved_sql_id | html %]">[%
s.saved_sql.report_name | html %]</td>

But I have problems getting the one sign I added to display, so that change
might be just nonsense. 

I was also getting a JS error when viewing the table of signs. It seems to be
am invalid value for sPaginationType, so this made the error go away: 

@@ -451,13 +451,13 @@
             "aoColumnDefs": [
                 { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false
},
             ],
-            "sPaginationType": "four_button"
+            "sPaginationType": "full"
         }));
         $("#table_streams").dataTable($.extend(true, {}, dataTablesDefaults, {
             "aoColumnDefs": [
                 { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false
},
             ],
-            "sPaginationType": "four_button"
+            "sPaginationType": "full"
         }));

Not sure if "full" is the pagination we want, though.

-- 
You are receiving this mail because:
You are watching all bug changes.