[Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #24 from David Nind <david at davidnind.com> ---
Two things from testing:

1. The CSS changes are only reflected in the PDF if they are made in the Email
section of the notice. If you add them to the Print section, then the inline
CSS is ignored.

2. The tests fail for me after removing weasyprint (step 9 of the test plan):

prove -v t/db_dependent/Patron/Borrower_Discharge.t
t/db_dependent/Patron/Borrower_Discharge.t .. 
1..23
ok 1 - A patron with issues cannot be discharged
ok 2 - No request done if patron has issues
ok 3 - No discharge done if patron has issues
ok 4 - There is no pending discharge request
ok 5 - There is no validated discharge
ok 6 - A patron without issues can be discharged
ok 7 - Confirm failure when lacking borrower number
ok 8 - The patron has been discharged
ok 9 - The patron has been debarred after discharge
ok 10 - There are 3 validated discharges
ok 11 - There is 1 validated discharge for a given patron
ok 12 - There is 2 validated discharges for a given branchcode
ok 13 - The debarment has been lifted
ok 14 - The patron is not discharged after the restriction has been lifted
ok 15 - There is a pending discharge request (second time)
ok 16 - There is no pending discharge request (second time)
ok 17 # skip Skipping because weasyprint is not installed
not ok 18 - Failed call to run() prints the generated error
ok 19 - undef returned if failed run

#   Failed test 'Failed call to run() prints the generated error'
#   at t/db_dependent/Patron/Borrower_Discharge.t line 141.
# found warning: weasyprint not found! at
/kohadevbox/koha/Koha/Patron/Discharge.pm line 151.
# expected to find warning: Some error
ok 20 - Expected failure because of missing weasyprint
ok 21 - undef returned if missing weasyprint
ok 22 - Discharge request sent
# Subtest: search_limited
    1..4
    ok 1 - With permission, all discharges are visible
    ok 2 - With permission, all discharges are visible
    ok 3 - Without permission, only discharge from our group are visible
    ok 4 - Without permission, only discharge from our group are visible
ok 23 - search_limited
# Looks like you failed 1 test of 23.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/23 subtests 
        (less 1 skipped subtest: 21 okay)

Test Summary Report
-------------------
t/db_dependent/Patron/Borrower_Discharge.t (Wstat: 256 Tests: 23 Failed: 1)
  Failed test:  18
  Non-zero exit status: 1
Files=1, Tests=23,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.55 cusr  0.28
csys =  1.85 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.