[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
Hi Jonathan, to reuse stuff I like your idea to create folders by type (routes,
stores, components, ..). 

Maybe we can add another folder named "modules" where we place all "main.ts"
files, renaming them as "erm.ts" or "import_sources.ts". Or, instead of
creating a "modules" folder, we could have a single "main.ts" and make all
modules in routes to lazy load (
https://router.vuejs.org/guide/advanced/lazy-loading.html )

About the components folder, in my implementation, I added a "shared" subfolder
for all shared components, but I don't mind keeping them in the components
folder directly.

I loved the idea of generating the breadcrumbs from the router specification,
but the definition of it was kind of confusing, and hard to follow, so I took
your idea and changed it a little bit.

I added a couple more shared components, one of them being the implementation
of Datatables in Vue (called KohaTables). I see that you have here the
"composable" folder where you call functions of Datatables, but I saw that the
creators of Datatables had an implementation for Vue, so I thought it best to
use that.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.