[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 8 21:01:47 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Agustín Moyano from comment #11)
> (In reply to Jonathan Druart from comment #6)
> > The breadcrumb for the ERM module is quite complex, hence the complexity of
> > the file :)
> > About your implementation, there is something weird, you don't define the
> > routes, and "Add import source" leads to admin/import-sources.pl/add. Is
> > that expected?
> > On erm I've decided to rewrite the url and have something following the REST
> > routes (/cgi-bin/koha/erm/eholdings/local/packages/add for instance)
> 
> I defined my routes in import-source/tree.js
> 
> That definition gets imported to stores/menu.js, and when that happens the
> tree gets analyzed, and some attributes are added.
> 
> from there, the menu store has actions that allow you to get the routes,
> left-hand submenu and breadcrums
> 
> About the url, if I don't make admin/import-sources.pl the root of my
> routes, when users enter, they would see an empty page... I really don't
> want users to click on something to see the table.. the other routes depend
> on this one, so the /add and /:id gets appended

You need the RewriteRule in apache's config.
Another thing is the translations, did you try if that works with your
implementation?

I don't mind replacing the breadcrumbs system we have for ERM, but to be honest
I spent a lot of time to reach this point, and my I am not sure what you have
now is ready to replace it. Feel free to provide an implementation for the ERM
module to see if there is feature parity.

https://snipboard.io/9f6qPL.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list