[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #7)
> 
> 1) I believe the list is now too limited. This is also likely to cause
> issues for libraries that have added fields not in your list. I think we
> should offer the full list, like BorrowerUnwantedField does - it would also
> simplify your patch :)

Honestly, I'm a bit surprised you want every field listed and I think it
increases the code burden personally.

> 2) I believe we had discussed not changing this one, because of something
> with the extended patron attributes, but I cannot remember the exact issue
> now :(

I can definitively say we do not support patron attributes as options here:

* The code limits the options to an allow list that can be seen in
koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc for the field
selection in various patron search forms.
* The autocomplete javascript does NOT limit the fields in the same way, but is
hard coded to use `me.` as a table identifier.. adding
`extended_attributes.field_name` is very unlikely to work, but I have not
tested.. what I have found though is that if you add a random "field" name,
then autocomplete just completely breaks.

-- 
You are receiving this mail because:
You are watching all bug changes.