[Koha-bugs] [Bug 30642] We should record the renewal type (automatic/manual)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 146472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146472&action=edit
Bug 30642: (follow-up) Change sql and adapt for translations

New column has now been changed to an enum in line with comments and the
strings have been amended to be picked up for translation. The file
koha-tmpl/intranet-tmpl/prog/en/includes/str/checkout_renewals.inc has been
removed as the variables can be included within the javascript file.

Test plan:
1) In the database shell run "show columns from checkout_renewals;" and observe
that there is currently no column for recording the type of renewal
2) Apply patch
3) In the shell run "dbic" and "perl installer/data/mysql/updatedatabase.pl" to
update the database schema with the new column.
4) Create some checkouts
5) Renew some checkouts manually and observe in the database that there is now
a column called "renewal_type" that will have recorded these as "Manual"
6) Create some checkouts that can be automatically renewed
7) Run the cron script in automatic_renewals.pl and observe that there are now
also entries with a renewal_type of "Automatic"
8) Send a GET request to http://localhost:8081/api/v1/checkouts/1/renewals and
observe that the renewal_type is now returned in the response
9) In the Item Details tab for a record, there is the "Current renewals" option
which has a button to view renewals. Click on this and observe that the modal
now displays the new information.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.