[Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works well overall, unit tests and QA script pass. 

What I notice is an inconsistency:

* listprice and currency are used for the original price on ordering.
* invoice_unitprice and invoice_currency are used for the original price on
receive.

But: 
* listprice and currency are always set, even if the currency is the active
currency.
* invoice_unitprice and invoice_currency are NULL, when the currency matches
the active currency.

I see some merit in making the invoice_unitprice behave like the listprice:
* It could make it easier to use these columns in reporting.
* It could make the transition easier if the active currency changes (just had
that happen for a library in Croatia)

But maybe there are downsides as well or a reason to keep it like that.

Michaela and Joubu, what do you think?

Note:
* 'Bug 24971 - Pre-select invoice currency from vendor on receive' is not fixed
by this patch. The pre-selected currency is the active one.

-- 
You are receiving this mail because:
You are watching all bug changes.