[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #112152|0                           |1
        is obsolete|                            |

--- Comment #127 from Lari Taskula <lari.taskula at hypernova.fi> ---
Created attachment 146546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146546&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreference

This patch moves C4::Members::Messaging::SetMessagingPreference to
Koha::Patron::MessagePreference
The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "SetMessagingPreference"
       (grep -r 'SetMessagingPreference').
3. Observe no results in source code.

---- UNIT TESTS ----
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t
4. prove t/db_dependent/api/v1/patrons.t

Works as expected. QA tools fails with:
FAIL    C4/Members/Messaging.pm pod empty section in previous paragraph
Can be fixed in a followup.
Signed-off-by: Marc Véron <veron at veron.ch>

QA tools pass now OK
Signed-off-by: Marc Véron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Rebased-by: Emmi Takkinen <emmi.takkinen at outlook.com>

-- 
You are receiving this mail because:
You are watching all bug changes.