[Koha-bugs] [Bug 11844] Additional fields for order lines

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Feb 12 09:53:15 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This generally looks great.. but there's a few last unit tests missing.

Could we have some tests for the new
Koha::AdditionalField::effective_authorised_value_category method please.

I'm afraid I'm also not seeing any additions for the
C4::Acquisition::TransferOrder changes either.

Finally, the changes in Koha/Object/Mixin/AdditionalFields.pm don't appear to
be tested either.

Sorry Julian, this is great work and I wouldn't want it accidentally undone in
a future change. Failing QA for now.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list