[Koha-bugs] [Bug 32949] Smart-rules prefils junk date on page load

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 13 16:51:34 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32949

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146584|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 146587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146587&action=edit
Bug 32949: Do not fill form with wrong shadow value to avoid data loss in
smart-rules.tt

When you edit the rule without initializing flatpickr plugin, if you
press the save button it will overwrite the date with an empty value,
making you lose the dates. This happens because flatpickr plugin's
shadow value is not loaded if it's not initialized with a click on that
date field. This patch fixes it.

1st Code commit text: To reproduce:
1. Head over to the smart rules admin page and create/use existing rule
   for certain item type/category.
2. Set "hard due date" and "No automatic renewal after (hard limit)" of
   that rule to a certain date and save.
3. Edit that same rule again, but this time just save it without any
   changes. The data for hard due date and hard limit will get lost and
   will be set as "None defined".
4. Apply the patch.
5. Repeat steps 2 and 3. Ensure that the data loss is not happening
   anymore.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list