[Koha-bugs] [Bug 32933] Use val() instead of attr("value") when getting field values with jQuery

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32933

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Decided to not hold this one up, as it has nice test plans and all that. Owen,
could you please verify if we should have a 'part 2' type of bug to fix the
other occurences?
>  
> > I think other instances of this code aren't buggy in the same way, but I
> > think it's worth updating all of them for consistency.
> 
> Should these (or some of these) be fixed as well?
> 
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:        
> .attr('value', op)
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:        
> .attr('value', id)
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:        
> doSubmit('doedit', $("#doedit").attr('value'));
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt:          
> tr.find('input[type="text"]').attr("value","");
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt:         
> $('#preftype').attr("value",$(this).attr("id"));
> koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt:       
> $("#confirm_not_duplicate").attr("value","1");
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:               
> opt.attr("value", filter.search_filter_id);
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt:        
> .attr('value', $(this).attr('value'));
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:       
> $("#redirect").attr("value",dest);
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:       
> $("#confirm_not_duplicate").attr("value","1");
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt:       
> $("#redirect").attr("value",redirect);
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt:              
> let amount_outstanding = parseFloat( $('#amountoutstanding').attr('value') );
> koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt:              
> let amount_writeoff = parseFloat( $('#amountwrittenoff').attr('value') );
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:           
> .attr('value', action)
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt:         
> opt.attr("value", profile.profile_id);
> koha-tmpl/intranet-tmpl/prog/js/members.js:    $("input#patron_attr_" +
> newId, clone).attr('value','');
> koha-tmpl/intranet-tmpl/prog/js/members.js:    $("select#patron_attr_" +
> newId, clone).attr('value','');
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:               
> .find('textarea').attr('value', '').end()
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:               
> .find('select').attr('value', '').end();
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:               
> $('input[type!="hidden"],select,textarea', clone).attr('id', 'patron-attr-'
> + newId).attr('value', '');
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:               
> $("label", clone).attr('for', 'patron-attr-' + newId).attr('value', '');
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:               
> $("#hold_form_biblios").attr("value", numList);
> 
> I used: git grep "\.attr(.v"

-- 
You are receiving this mail because:
You are watching all bug changes.