[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Public and tertiary
      release notes|                            |libraries in New Zealand
                   |                            |can claim tax back on
                   |                            |purchases.
                   |                            |
                   |                            |This
                   |                            |enhancement adds a new
                   |                            |system preference
                   |                            |'CalculateFundValuesIncludi
                   |                            |ngTax'.
                   |                            |
                   |                            |When set to
                   |                            |'Exclude' these libraries
                   |                            |can input order prices with
                   |                            |tax included (so vendor
                   |                            |invoice prices - which do
                   |                            |contain tax - can be
                   |                            |entered directly into
                   |                            |Koha).
                   |                            |
                   |                            |However, the order
                   |                            |prices removed from the
                   |                            |Koha funds are the tax
                   |                            |exclusive values (NZ
                   |                            |libraries claim tax back so
                   |                            |it should not be removed
                   |                            |from their funds).
             Status|Failed QA                   |Signed Off

--- Comment #26 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Setting this back to 'Signed off'. I have done the following:

1. Corrected the test plan on the second patch so that it reflects the point
David raised in comment #6

2. Submitted a fifth patch fixing QA test tool failures. I am still getting one
failure for the template on ordered.tt, but I think that might just be my qa
test tools. 

3. Fixed the unit tests and expanded the unit test coverage - we now test both
when vendors have listincgst/invoiceincgst set to 0 and 1.

The unit tests now consistently pass:

"
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in addition (+)
at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495.
t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in
multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line
520.
Use of uninitialized value in numeric eq (==) at
/home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531.
t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+)
at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495.
t/db_dependent/Budgets.t .. ok       
All tests successful.
Files=1, Tests=156, 12 wallclock secs ( 0.05 usr  0.01 sys +  9.22 cusr  2.01
csys = 11.29 CPU)
Result: PASS
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in
multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line
520.
Use of uninitialized value in numeric eq (==) at
/home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531.
t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in
multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line
520.
Use of uninitialized value in numeric eq (==) at
/home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531.
t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+)
at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495.
t/db_dependent/Budgets.t .. ok       
All tests successful.
Files=1, Tests=156, 11 wallclock secs ( 0.04 usr  0.02 sys +  9.10 cusr  1.50
csys = 10.66 CPU)
Result: PASS
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/156 Use of uninitialized value in
multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line
520.
Use of uninitialized value in numeric eq (==) at
/home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531.
t/db_dependent/Budgets.t .. 154/156 Use of uninitialized value in
multiplication (*) at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line
520.
Use of uninitialized value in numeric eq (==) at
/home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 531.
t/db_dependent/Budgets.t .. 155/156 Use of uninitialized value in addition (+)
at /home/vagrant/kohaclone/Koha/Acquisition/Order.pm line 495.
t/db_dependent/Budgets.t .. ok       
All tests successful.
Files=1, Tests=156, 10 wallclock secs ( 0.02 usr  0.02 sys +  7.34 cusr  1.27
csys =  8.65 CPU)
Result: PASS
"

-- 
You are receiving this mail because:
You are watching all bug changes.