[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #68 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Kyle M Hall from comment #62)
> Getting one unit test failure:
> 
> root at kohadevbox:koha(bug31735-qa)$ prove
> t/db_dependent/Koha/CirculationRules.t
> t/db_dependent/Koha/CirculationRules.t .. 1/7
>     #   Failed test 'No rule for branch, no default rule, fallback default
> (refund)'
>     #   at t/db_dependent/Koha/CirculationRules.t line 856.
>     #     Structures begin differing at:
>     #          $got->{lostreturn} = '0'
>     #     $expected->{lostreturn} = 'refund'
>     # Looks like you failed 1 test of 7.
> 
> #   Failed test 'get_lostreturn_policy() tests'
> #   at t/db_dependent/Koha/CirculationRules.t line 865.
> # Looks like you failed 1 test of 7.
> t/db_dependent/Koha/CirculationRules.t .. Dubious, test returned 1 (wstat
> 256, 0x100)
> Failed 1/7 subtests
> 
> Test Summary Report
> -------------------
> t/db_dependent/Koha/CirculationRules.t (Wstat: 256 Tests: 7 Failed: 1)
>   Failed test:  7
>   Non-zero exit status: 1
> Files=1, Tests=7,  3 wallclock secs ( 0.01 usr  0.00 sys +  1.90 cusr  0.13
> csys =  2.04 CPU)
> Result: FAIL

Ok! This should now be fixed. Was actually a bug in the test (not clearing
cache after changing rule ) exposed by fixing caching of falsy values. That fix
however should not be in this bug but in Bug 32092, so removed the change and
the test should now pass.

-- 
You are receiving this mail because:
You are watching all bug changes.