[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #23)
> Created attachment 147191 [details] [review]
> Bug 32353: Fix erm_agreements.t
> 
> Agreement.vendor_id has a default value defined in TestBuilder, but here
> we were assuming there was one.
> We should then generate it and pass the value when building the
> agreement objects.
> 
> The failure was:
> koha_1       |     #   Failed test '200 OK'
> koha_1       |     #   at t/db_dependent/api/v1/erm_agreements.t line 95.
> koha_1       |     #          got: '400'
> koha_1       |     #     expected: '200'
> koha_1       |
> koha_1       |     #   Failed test 'exact match for JSON Pointer ""'
> koha_1       |     #   at t/db_dependent/api/v1/erm_agreements.t line 95.
> koha_1       |     #     Structures begin differing at:
> koha_1       |     #          $got = HASH(0x55cde781a480)
> koha_1       |     #     $expected = ARRAY(0x55cde75af9c8)
> koha_1       |     # Looks like you failed 2 tests of 32.
> 
> 400 because we were calling
> http://localhost:8081/api/v1/erm/agreements?vendor_id='
> which returns {"errors":[{"message":"Expected integer - got
> string.","path":"\/vendor_id"}],"status":400}%

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.