[Koha-bugs] [Bug 32306] Hold modifications don't log correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #5)
> Nick, do you see a good reason to log before the exp date is modified?

I think we are inconsistent throughout the code of logging before or after
actions.

On one hand - storing the before should provide info on what was changed by
comparing to the current state

On the other, storing after means that the log preserves what was done

My preference would be to store both the before and after, or the diff to see
what changed (storing both would allow front end diffing)

I think at a minimum adding a "BEFORE" or "AFTER" param to the info would at
least make it obvious which we stored

-- 
You are receiving this mail because:
You are watching all bug changes.