[Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
QA comments:
1. There are still a couple of ref to tinymce in the template
2. Not blocker but it would be nice to see the codemirror code centralised in
an include file to avoid code duplication
3. You didn't modify all the occurrences of OPACUserCSS in template, is that on
purpose?

koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt:[% IF (
Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') |
$raw %]</style>[% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:[% IF (
Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') |
$raw %]</style>[% END %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:[% IF (
Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') |
$raw %]</style>[% END %]

I don't know if it's relevant, just asking.

4. There is one more QA failure
 FAIL   installer/data/mysql/atomicupdate/bug_32721-add_branch_level_js.pl
   FAIL   file permissions
                File must have the exec flag

-- 
You are receiving this mail because:
You are watching all bug changes.