[Koha-bugs] [Bug 31391] Staff-side recalls

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Doing a first round of testing here:

1) QA test tools

 FAIL  
installer/data/mysql/atomicupdate/bug_31391_-_add_HOLD_CANCELLATION-RECALLED_authorised_value.pl
   FAIL   file permissions
                File must have the exec flag

 FAIL  
installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref.pl
   FAIL   file permissions
                File must have the exec flag


2) Unit tests

There is a new warn that is not there when running the test on master, that
should be fixed to give a clean result:

t/db_dependent/Holds.t .. 76/77 An appropriate email address for borrower
myfirstname.whateversurname1 could not be found. at
/kohadevbox/koha/C4/Message.pm line 192.
No reserves HOLD_CANCELLATION letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 584.
t/db_dependent/Holds.t .. ok     
All tests successful.

3) Database update

* is idempotent
*
installer/data/mysql/atomicupdate/bug_31391_-_add_HOLD_CANCELLATION-RECALLED_authorised_value.
could be updated to also use the new style

3) Code review


+                            <th>Last location</th>
a) This might be a little confusing with the 'location' in item. Could we use
'Last library' or even 'holding library' here?

+                            [% IF ( item.itemlost || item.withdrawn ) %]
+                                <span class="lost">Unavailable (lost or
missing)</span>
+                            [% END %]

b) This looks like it should read "(lost or withdrawn)"

+                                    Patron has already placed a <a
href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% patron.borrowernumber
| uri %]#reserves">reserve</a> on this item.

c) Terminology: 'reserve' should be 'hold'.


4) GUI testing

a) The system preference RecallsInterface appears in the Curbside pickup
section instead of in recalls. Maybe a rebase issue.

b) Could be a separate bug: when placing a recall from the detail page, the
list of existing recalls needs the 'page-section' class to appear correctly in
the new staff interface design with white background.

c) Could be a separate bug: Cancel recalls on the same page should be a yellow
primary button.

d) Should I be able to to place a record level hold and a recall level hold for
the same patron at the same time? It seems like maybe we should have a warning
or a message there, maybe recommending to convert the existing hold.

e) When converting the hold, the recall action is 'Hiding' in the priorities. I
feel like a link or icon might be a little nicer as I almost missed it there.
Not blocker.


Stopping here for now, but I feel this will make the feature much more
flexible!

-- 
You are receiving this mail because:
You are watching all bug changes.