[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 147411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147411&action=edit
Bug 24499: New syspref EnhancedMessaging for clearer functionality

Actually there is EnhancedMessagingPreferences that can be set on
"Allow" or "Don't allow" to show or not show messaging preferences for
patrons.
But this syspref does not prevent notifications from being sent.

>From your comments, I decide to create a new syspref which show dialog
alert on patron details (Patron messaging preferences section) but
prevent misc/cronjobs/advance_notices.pl script.

EnhancedMessagingPreferences keep the same behavior I just took over
preferences descriptions to make clearer context (on
EnhancedMessagingPreferencesOPAC too).

Test plan :

1 - Be sure to have a patron with a loan
2 - Also be sure to have a model on your library in "Notices & slips"
3 - Set max days for advance_notices on patron details table
4 - Then set EnhancedMessagingPreferences to "Allow"
5 - On Patron details you will see the table for settings notifications
6 - Run the misc/cronjobs/advance_notices.pl script manually
7 - The script find a notice and add a message in message_queue table
8 - Set now EnhancedMessagingPreferences to "Don't allow"
9 - Repeat the step 5, you don't see the table right now
10 - Repeat the step 6, same behavior, a message is created and stored
11 - Now apply this patch and launch updatedatabase.pl
12 - You will see the new syspref "EnhanceMessaging"
13 - If you want you can repeat steps 4 to 10 - same behavior again
14 - But now, you can set to "Don't send" on EnhancedMessaging
15 - See on patron details page, there is a dialog alert to inform
16 - Run again the step 6, normally it will send you a warn and no
message was created or stored.

Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.