From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 21:58:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 20:58:36 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 21:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 20:58:41 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144855|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 144895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144895&action=edit Bug 32537: Add no-block option to SIP cli emulator This patch adds the option to pass a no-block option and use this in checkout/checkin/renew messages To test: 1 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 2 - Confirm out like: SEND: 09N20221227 20183920221227 201839APCPL|AOCPL|AB39999000010831|ACterm1|BIN| (Note the N after 09) 3 - Apply patch 4 - Restart SIP, repeat 1 5 - Confirm still an N 6 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n N 7 - Confirm still an N 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n Y 9 - Confirm the send has a Y after 09 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 22:13:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 21:13:38 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhanced adds the release notes| |no-block option to the SIP | |emulator for optional use | |in checkout/checkin/renew | |messages. --- Comment #3 from David Nind --- Koha testing notes (using KTD - used 39999000011418 as the item). I have included the responses I got for the commands as there were unitialized values reported in the output, and I don't know whether these are expected or not. 1. Response for step 1: root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 120. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20473320230101 204733APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 204734AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 2. To restart SIP: koha-sip --restart kohadev 3. Response for step 4: root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20543120230101 205431APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 205431AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 4. Response for step 6: root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n N Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20552620230101 205526APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 205526AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 5. Response for step 8: root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230101 20561720230101 205617APCPL|AOCPL|AB39999000011418|ACterm1|BIN| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 356, chunk 1. READ: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 22:33:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 21:33:31 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- To test, I: 1. Repeated the steps in bug 32537 (including applying that patch). 2. Applied this patch and restarted SIP (koha-sip --restart kohadev). 3. The response I got for step 4 was: root at kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230101 21213820230101 212138APCPL|AOCPL|AB39999000011418|ACterm1|BIN| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 356, chunk 1. READ: I'm not sure if this is what is expected (as it is pretty similar to what I got for bug 32537, except the second and third series of numbers in the SEND are different), but happy to sign off if it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:14:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 22:14:38 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 22:14:44 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144825|0 |1 is obsolete| | --- Comment #24 from David Nind --- Created attachment 144896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144896&action=edit Bug 30687: [alternate-alternate] Allow pickup locatoin to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 22:44:42 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #25 from David Nind --- I've tested and signed off the alternate-alternate patch. I've drafted a release note - I don't feel confident enough that I've got this right. Could someone check this, edit where appropriate, and add? Thanks! I'm akso not sure if this was introduced in 21.11. Draft release note: This fixes a regression introduced in Koha 21.11(???). Previously, if hold overrides were enabled (the AllowHoldPolicyOverride system preference) and there was no pickup location available (for example, if a library was not a pickup location), then it was still possible to select an alternative pickup location. This restores this ability - by default no pickup location is selected, but any location can now be selected from the dropdown list (each option now has an exclamation mark at the end with the message "This pickup location is not allowed according to circulation rules"). Note: the test plan says the exclamation mark is at the start of the option, but for me it displayed at the end. Also, does this need a note about how some libraries want to be able to place unfillable holds for a variety of reasons? (see comment #7 and following discussions). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:05:37 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:05:42 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144888|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 144897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144897&action=edit Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch item tools Test plan: 1. Apply patches 2. Check out an item with a different home branch than the library you're logged in as 3. Go to: 'Cataloguing' > 'Batch item deletion' 4. Into the barcode list area paste the checked-out item's barcode and the barcode of a non-checked out item (with the same home library as the branch you're logged in as) and submit the form 5. Observe in the table that loads the row containing the checked out item is highlighted yellow, and it has a red cross in the first column. 6. Hover over the red cross to see the reason why you cannot delete the item appears 7. Observe the non checked out item has a checkbox and is not highlighted yellow 8. Click 'Select all' and 'Clear all' links and notice the display of the checked out item remains unchanged 9. Change 'IndependentBranches' syspref = 'yes' 10. Log into the staff client as a patron with only the '(catalogue)', '(editcatalogue)', and '(tools)' permissions selected 11. Go to: 'Cataloguing' > 'Batch item modification' 12. Enter the checked-out item's barcode and a non-checked out item's barcode and submit the form 13. Observe the table row for the checked out item is again highlighted yellow, with a red cross. 14. Hover over the red cross and observe the text 'Cannot edit' is shown 15. Observe the non-checked out item is not highlighted yellow and does have a checkbox Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:05:48 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144890|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 144898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144898&action=edit Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record deletion tool Test plan: 1. Apply patch 2. Check out an item 3. Go to: 'Cataloguing' > 'Batch record deletion' 4. Into the 'Enter a list of record numbers' area paste in the biblionumber belonging to the checked-out item and that of a biblio without checked out items 5. Submit the form 6. Observe the row of the biblio with checked-out items is highlighted yellow, with a red cross in the first column 7. Hover over the red cross to see the reason why the biblio cannot be deleted 8. Observe the row of the biblio without checked-out items is not highlighted yellow, and does have a checkbox in the first column 9. Click 'Delete selected records' 10. Confirm the biblio without checked-out items is successfully deleted Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:12:55 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement more release notes| |clearly emphasises records | |that cannot be modified or | |deleted in the 'Batch | |record deletion', 'Batch | |item modification', and | |'Batch item deletion' | |tools. Rows are now | |highlighted in yellow, with | |a red 'X' in the first | |column (hovering over the | |red 'X' shows the reason it | |cannot be modified or | |deleted). Version(s)|More clearly emphasise | released in|records that cannot be | |modified/deleted in the | |'Batch record deletion', | |'Batch item modification', | |and 'Batch item deletion' | |tools. | CC| |david at davidnind.com --- Comment #17 from David Nind --- Moved release notes from the version(s) released in field to the text to go in the release notes field, and edited slightly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:50:16 +0000 Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:50:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:50:21 +0000 Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144869|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 144899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144899&action=edit Bug 31248: Fix responsiveness of tables on OPAC summary page This patch adds back the responsive styles of the tables on the OPAC summary page. This includes all of the following tables that may appear: opac-user-checkouts opac-user-relative-issues opac-user-overdues opac-user-fines opac-user-relative-fines opac-user-clubs opac-user-holds opac-user-recalls opac-user-article-requests opac-user-overdrive opac-user-recordedbooks To test: 1) Make sure you have checkouts in your account 2) Log into the OPAC --> In 'Your summary' current checkouts are in a table 3) Go to 'You checkout history' --> Current and previous checkouts are in a table 4) Switch to mobile view (in Firefox, Ctrl + Shift + M) --> Checkout history is still in a table and the last column is not entirely visible (depending on the content of the columns, I suppose) 5) Go to 'Your summary' --> Current checkouts are presented in list form instead of a table 6) Apply patch and rebuild the OPAC CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7) Try the tables again, they should appear in a list form when the screen is smaller than 608px. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:53:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2023 23:53:07 +0000 Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC after switch to Bootstrap tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Should I log a separate bug for the 'Checkout history' view (and maybe any others that need changing)? This still shows for me as a table and not a list, but is scrollable. Ideally, it should be as consistent as possible, and I agree with Caroline that the list view is easier to read on a mobile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 09:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 08:51:58 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Jonathan Druart --- I am getting a conflict, can you rebase please? Also, could you run the tidy script, I am seeing invalid changes: - licenses: [], + licenses: [], (space at the end of the line) Make sure you set up the pre-commit git hook https://wiki.koha-community.org/wiki/Tips_and_tricks#Hooks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 10:09:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 09:09:43 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 10:48:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 09:48:11 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Thibaud Guillot --- Anyone get the same error than David ? So I tested right now and it's working for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:10:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:10:54 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:11:00 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #15 from Thibaud Guillot --- Created attachment 144900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144900&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:15:01 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m --- Comment #16 from Thibaud Guillot --- (In reply to Katrin Fischer from comment #13) > 1) QA test tools: > > FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl > FAIL file permissions > File must have the exec flag > > 2) See comment#11, it looks like the original value was 0.01: > > + scale_height => 0.02, > > - my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # > this scales the barcode height to 10% of the label height > > 3) Defaults > > Just a question, maybe someone else can answer that one too: > > The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the > database and also sets the defaults in new. > > Should we do both or would one option suffice? > > 4) Changes to kohastructure.sql are missing Hello Katrin, Normally I fixed this things on my last 'push' For default value (repeat in sql and view on 'sub new()' I'm not an expert but it like the same than 'layout_name' for example (set to 'DEFAULT' in default sql value and also in the template when we passed vars). I hope this will be okay for everyone :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:15:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:15:26 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |thibaud.guillot at biblibre.co |u |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:16:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:16:31 +0000 Subject: [Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |thibaud.guillot at biblibre.co |u |m CC| |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:19:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:19:17 +0000 Subject: [Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 --- Comment #1 from Thibaud Guillot --- Hello all, I'm interested in your advice on this because like this comment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762#c3 (related to the original bug) it may - may need to change the way barcodes are generated for this improvement. What do you think about it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:22:30 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #6 from Jonathan Druart --- Created attachment 144901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144901&action=edit Bug 32528: Change return logic Back to 1 return statement Prevent the Koha::Result::Boolean instanciation duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:32:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:32:12 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #7 from Jonathan Druart --- This patch seems to simplify and make the method more readable, but I guess it's a matter of taste. Feel free to obsolete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:52:31 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31798 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 [Bug 31798] REST API: POST endpoint for Items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:52:31 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 [Bug 31799] REST API: PUT endpoint for Items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:52:37 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #1 from Agustín Moyano --- Created attachment 144902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144902&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:57:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:57:59 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143745|0 |1 is obsolete| | Attachment #143746|0 |1 is obsolete| | Attachment #143747|0 |1 is obsolete| | Attachment #143748|0 |1 is obsolete| | Attachment #143749|0 |1 is obsolete| | Attachment #143750|0 |1 is obsolete| | Attachment #143751|0 |1 is obsolete| | Attachment #143752|0 |1 is obsolete| | Attachment #143753|0 |1 is obsolete| | Attachment #143754|0 |1 is obsolete| | Attachment #143755|0 |1 is obsolete| | Attachment #143756|0 |1 is obsolete| | Attachment #143757|0 |1 is obsolete| | Attachment #143758|0 |1 is obsolete| | Attachment #143759|0 |1 is obsolete| | Attachment #143760|0 |1 is obsolete| | Attachment #143761|0 |1 is obsolete| | Attachment #143762|0 |1 is obsolete| | Attachment #143763|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 144903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144903&action=edit Bug 31095: Add Koha::Patron::Restriction(s) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:06 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #96 from Jonathan Druart --- Created attachment 144904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144904&action=edit Bug 31095: Add restrictions accessor to Koha::Patron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:13 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #97 from Jonathan Druart --- Created attachment 144905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144905&action=edit Bug 31095: Add type relation accessor to Koha::Patron::Restriction Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:20 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #98 from Jonathan Druart --- Created attachment 144906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144906&action=edit Bug 31095: Remove GetDebarments from circ/circulation.pl This patch remove the use of GetDebarments from circ/circulation.pl, replacing it with a reference to patron.restrictions in the template and includes. Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the checkout page for a user. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #99 from Jonathan Druart --- Created attachment 144907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144907&action=edit Bug 31095: Remove GetDebarments from members/moremember.pl This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the patron details page. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:33 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #100 from Jonathan Druart --- Created attachment 144908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144908&action=edit Bug 31095: Remove GetDebarments from members/memberentry.pl This patch removes the use of GetDebarments from members/memberentry.pl and replaces the references in the templates with patron.restrictions. Test plan 1. Add a new user and confirm that the patron restrictions section does not appear on the form 2. Edit the user and confirm the patron restrictions section now appears 3. Add a manual restriction using the patron edit form 4. Confirm the restriction appears on the patron edit form 5. Confirm you can remove the restriction usine the patron edit form Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:41 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #101 from Jonathan Druart --- Created attachment 144909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144909&action=edit Bug 31095: Remove borrower_debarments and patron_restrictions includes This patch removes the aforementioned includes and drops the last remaining reference to them. We have replaces these includes with patron-restrictions-tab.inc and restriction-types.inc. Test plan 1. Confirm the includes are no longer referenced anywhere in the codebase. 'git grep borrower_debarments.inc', 'git grep patron_restrictions.inc' Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:49 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #102 from Jonathan Druart --- Created attachment 144910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144910&action=edit Bug 31095: Remove keyed_on_code We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types as we have relation accessors for the relevent use cases and no longer reference the method anywhere in the codebase! Test plan 1. Confirm 'keyed_on_code' is no longer referenced anywhere in the codebase. `git grep keyed_on_code` Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:58:59 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #103 from Jonathan Druart --- Created attachment 144911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144911&action=edit Bug 31095: Remove GetDebarments from tools/modborrowers.pl This patch removes GetDebarments from the modborrowers tool controller and replaces it with $patron->restrictions as appropriate. Test plan 1. Confirm that the 'Batch patron modification' tool pages still load and perform as expected. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:07 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #104 from Jonathan Druart --- Created attachment 144912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144912&action=edit Bug 31095: Remove GetDebarments from Circulation.pm This patch removes GetDebarments from Circulation.pm replacing them with calls to $patron->restrictions and filtering using a chained search call. Test plan 1. Confirm that t/db_dependant/Circulation.t continues to pass Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:14 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #105 from Jonathan Druart --- Created attachment 144913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144913&action=edit Bug 31095: Remove GetDebarments from Circulation.t Replace GetDebarments with $patron->restrictions. Test plan 1. Run test prior to patch - all should pass 2. Run test after patch - all should pass 3. Confirm no tests were removed as part of the patch Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:21 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #106 from Jonathan Druart --- Created attachment 144914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144914&action=edit Bug 31095: Remove GetDebarments from Patron::Import This patch replaced GetDebarments with $patron->restrictions->search in Koha::Patron::Import. Test plan 1. Confirm that importing patrons with debarred and debarredcomment fields in the import still works as expected Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:27 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #107 from Jonathan Druart --- Created attachment 144915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144915&action=edit Bug 31095: Remove GetDebarments from maxsuspensiondays.t This patch replaces GetDebarments in maxsuspensiondays.t with calls to the restrictions accessor. Test plan 1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior to this patch 2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after this patch 3. Confirm no tests have been removed in this patch Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:35 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #108 from Jonathan Druart --- Created attachment 144916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144916&action=edit Bug 31095: Remove GetDebarments from MarkIssueReturned.t This patch removes GetDebarments from Ciculation/MarkIssueReturned.t Test plan 1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior to the patch 2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after the patch 3. Confirm no tests have been removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:41 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #109 from Jonathan Druart --- Created attachment 144917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144917&action=edit Bug 31095: Remove GetDebarments from Restriction/Type.t This patch replaces GetDebarments with $patron->restrictions in t/db_dependent/Koha/Patron/Restriction/Type.t Test plan 1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to the patch 2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after the patch 3. Confirm no tests were removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:48 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #110 from Jonathan Druart --- Created attachment 144918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144918&action=edit Bug 31095: Remove GetDebarments from Borrower_Debarments.t This patch replaces calls to GetDebarments with teh $patron->restritions->search() equivilents. Test plan 1. Run the test prior to the patch and confirm it passes 2. Run the test after the patch and confirm it passes 3. Confirm no tests were removed Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 14:59:54 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #111 from Jonathan Druart --- Created attachment 144919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144919&action=edit Bug 31095: Remove GetDebarments from Koha::Patron::Debarments This patch finally removes GetDebarments from the codebase. Test plan 1. Confirm GetDebarments is no longer mentioned in the codebase. `git grep GetDebarments` 2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 15:00:01 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #112 from Jonathan Druart --- Created attachment 144920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144920&action=edit Bug 31095: (QA follow-up) Fix after rebase Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:00:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 15:00:08 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 --- Comment #113 from Jonathan Druart --- Created attachment 144921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144921&action=edit Bug 31095: (follow-up) Iterate debarments in batch mod Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:35:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 15:35:06 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #14) > Might be something else ? I think so, it's passing for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 15:37:23 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 15:38:29 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 --- Comment #16 from Jonathan Druart --- Original problem found with the following warning: Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5719. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 16:19:44 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 16:19:48 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 --- Comment #5 from Jonathan Druart --- Created attachment 144922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144922&action=edit Bug 32505: Restore patron search by formatted dob Prior to the rewrite of the patron searches (bug 30063 and friends) it was possible to search for a patron using their date of birth, formatted following the dateformat syspref. Now it only works if the date is iso formatted. This patch is providing a fix to restore the behaviour, but does not make it consistent. Only searching patrons by date of birth is fixed here, when we actually want to fix the problem for the REST API DT wrapper instead. Test plan: Search for patrons given their date of birth. You need to select "date of birth" in the "Search field" dropdown, or set it in DefaultPatronSearchFields. Note that the column filtering is still not working, but I guess it was the case already in older versions. Ideally we will need to have a "datatype" attribute passed to the the 'th' and retrieved from datatables.js to add this same trick and build the query appropriately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 16:20:07 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 16:25:00 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #114 from Jonathan Druart --- 1. FAIL Koha/Patron/Restriction.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restriction.pm FAIL Koha/Patron/Restrictions.pm FAIL pod *** WARNING: empty section in previous paragraph in file Koha/Patron/Restrictions.pm 2. Koha/Patron/Restriction.pm:=head2 Relation accessors Why? This is not used anywhere else. We use "Class methods". 3. 64 I think it's always better to pass the parameter, even if not needed => [% PROCESS restriction_type_description restriction_type => restriction_type %] Nothing considering blocker, passing QA. Please go ahead with bug 31458 and friends, I will be happy to QA them! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 16:57:07 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:03:38 +0000 Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:03:43 +0000 Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144872|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 144923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144923&action=edit Bug 32531: Restore behaviour of 'include archived' filter In Suggestions management, there is a sidebar menu to organize and filter suggestions. In the "Suggestion information" filter section, there is a checkbox "Include archived". When this box us unchecked, the archived suggestions are not displayed. When this box is checked, all suggestions are displayed, archived, and not archived. This is not the case anymore, only archived suggestions are displayed, supposedly since patch for bug 23991. TO TEST: 1. On a Koha installation remove all suggestions (in the table). 2. Create two suggestions. Archive one of them. 3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is checked, you don't see anymore the unarchived suggestion. 4. Apply the patch. 5. Repeat 3, and confirm that the filter operates properly. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:04:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:04:19 +0000 Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_22_11_candidate Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | --- Comment #4 from Jonathan Druart --- Oops, silly mistake! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:19:35 +0000 Subject: [Koha-bugs] [Bug 32554] New: Test prediction pattern does not consider subscription length (uses only subscription end date) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Bug ID: 32554 Summary: Test prediction pattern does not consider subscription length (uses only subscription end date) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When creating a new serial subscription, it used to be that we could enter either a subscription length (number of issues, months or weeks) OR a subscription end date. When we would test the prediction pattern, it would show the right number of issues based on one of these values. Now it seems that if we only enter a number of issues for the subscription length and test the prediction pattern, not only does it tell us we're not being consistent with our end date (I thought it was optional?) but it also doesn't show the correct number of issues. To test: 1. For this, I created my own record, but you can skip this step and use any existing record 1.1. Go to Cataloging 1.2. Click on New record 1.3. Fill out the manadatory fields (in MARC21, typically 000, 003, 005, 008, 040$c, 245$a and 942$c) 1.4. Click Save 1.5. Note the record number, do not create an item 2. Create a serial subscription 2.1. Go to Serials 2.2. Click on New subscription 2.3. Enter the record number 2.4. Click Next (and confirm you're not using a vendor) 2.5. Fill out the second form as follows - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 24 - Subscription start date: 2023-01-01 - Subscription end date: leave empty - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 2.6. Click on Test prediction pattern --> Note there is a message saying "End date is not consistent with subscription length." even if, normally, only one is needed --> Only the issues until today are displayed (in my case, only the January 2023 issue), even if we said our subscription was for 24 issues There is no problem if we enter a subscription end date. This means either the subscription length problem is a bug, or end date is now mandatory and should be displayed in red like other mandatory fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:22:57 +0000 Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 --- Comment #1 from Caroline Cyr La Rose --- I tried this in 22.05.05 and it works fine with only a subscription length (without a subscription end date). So it's something that was changed recently. I haven't tried on a 22.11 though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:48:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:48:30 +0000 Subject: [Koha-bugs] [Bug 32555] New: Error when viewing serial in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 Bug ID: 32555 Summary: Error when viewing serial in OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I'm getting a 500 error when trying to view a serial with issues in the OPAC. The message is very long, but it starts with Template process failed: undef error - The method Koha::Serial::Item->serialseq is not covered by tests! To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number (I used 108) - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. --> It should open normally in another tab/window and the record displays without problem 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. Click Save 4. Go back to the OPAC tab and refresh --> Error I put this bug as "major", but maybe it should be higher... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 17:49:32 +0000 Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:04:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:04:52 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:05:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:05:28 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:06:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:06:09 +0000 Subject: [Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:06:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:06:26 +0000 Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:07:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:07:46 +0000 Subject: [Koha-bugs] [Bug 31793] REST API: DELETE endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | CC| |tomascohen at gmail.com Component|MARC Authority data support |REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:07:57 +0000 Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Component|MARC Authority data support |REST API CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:08:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:08:10 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Authority data support |REST API CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:08:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:08:21 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|MARC Authority data support |REST API CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:10:44 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 --- Comment #10 from Katrin Fischer --- (In reply to Fridolin Somers from comment #9) > Duplicate of Bug 29604? No, totally different thing. This is about showing an extra --> that has no content after. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:30:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 18:30:36 +0000 Subject: [Koha-bugs] [Bug 29911] Default amounts for fee types display with comma in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- It appears this was meanwhile fixed on another bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 19:26:48 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 21:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 20:21:36 +0000 Subject: [Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose --- I'm not sure if this is what you meant Nick, but I came across this situation and thought it was maybe the same. Let me know if it's completely different and I'll create a new bug for this. I'm trying to set up Koha so that only unavailable items can be put on hold, including those with negative not for loan values. (The exact use case is a library that wants to prevent on shelf holds, but want people to be able to put on hold the most recent issue of a serial even if it is for reference only while the other issue hasn't yet arrived. When the next issue arrives, the previous issue will be lent out, in order of the holds... Not sure if that makes sense, but it's the same principle as placing holds on "ordered" items.) I was not able to test this on master because of bug 32445, but I tried it on 22.05.05 To test: 1. Set up a circulation rule where on shelf holds are not allowed and force the choosing of an item (to facilitate the test) 1.1. Go to Administration > Circulation and fines rules 1.2. In the matrix, add a circulation like this - Patron category: All - Item type: Books - Current checkouts allowed: 10 - Current on-site checkouts allowed: 10 - Loan period: 21 - Holds allowed (total): 10 - Holds allowed (daily): 10 - Holds per record (count): 10 - On shelf holds allowed: If any unavailable - OPAC item level holds: Force 1.3. Click Save 2. Create a record with one "Ordered" item (or any negative value not for loan status) 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005, 008, 040$c, 245$a, and 942$c (942$c should be set to Books)) 2.4. Click Save 2.5. Fill out the following item fields - Not for loan: Ordered - Koha item type: Books 2.6. Click Add item 2.7. Click Normal to go to the detailed record 3. Try to place a hold on the "Ordered" item 3.1. From the detailed record, click OPAC view: Open in new window. --> Note that the "Place hold" option is not present 4. Add a second "Available" item 4.1. Back in the staff interface tab with the detailed record, click New > New item 4.2. Make sure the item type is set to Books 4.3. Add a barcode in p 4.4. Click Add item 5. Try again to place a hold on the "Ordered" item 5.1. Go back to the OPAC tab and refresh the page --> Note that the "Place hold" option is still not present 6. Check out the available item to a patron 6.1. In the staff interface tab, copy the barcode from the available item 6.2. Go to Patrons 6.3. Click on Search 6.4. Click Check out next to one of the patrons 6.5. Paste the barcode in the box and click Check out 7. Try again to place a hold on the "Ordered" item 7.1. Go back to the OPAC tab and refresh the page --> Note that the "Place hold" option is now present 7.2. Click Place hold --> Note that only the checked out item is available to place on hold, if you click Show unholdable items, it will show the Ordered item, but you can't place a hold on it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:18:49 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #34 from David Cook --- (In reply to Matthew Ross from comment #33) > I'm receiving the followin error, even after manually changing the > "borrowers" table to dynamic: > > --- > Upgrade to 22.06.00.006 [09:37:59]: Bug 21978 - Add middle_name to borrowers > table > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too > large. The maximum row size for the used table type, not counting BLOBs, is > 8126. This includes storage overhead, check the manual. You have to change > some columns to TEXT or BLOBs at /usr/share/koha/lib/C4/Installer.pm line 739 > --- Looking at bug 21978, it looks like you'll need to change the borrower_modifications and deletedborrowers tables too. Alternatively, you could follow the steps that Liz Rea outlines at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267#c20 to update all tables. That would be a more future-proofed solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:24:29 +0000 Subject: [Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #7) > But if you have 10 libraries owning the same item, which can well happen > with popular ones, you will have 10 librarians potentially running to the > shelf to get it... doesn't seem very effective. > > I was assuming the worst case: record level hold with multiple branches > holding it. Ahhh yes that would explain it. I forgot that not all holds are item-level holds. Since a hold could be either record-level or item-level, I don't think there's a consistent way of handling the email except emailing the patron's branch. Maybe the pickup library like you suggested before, but the current behaviour has been around for many years, and I think you've explained well why that's the case here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:31:41 +0000 Subject: [Koha-bugs] [Bug 32000] Add yellow buttons to administration > upload page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I think I probably meant Tools > Uploads and there are yellow buttons there now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:31:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:31:42 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 32000, which changed state. Bug 32000 Summary: Add yellow buttons to administration > upload page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:32:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:32:49 +0000 Subject: [Koha-bugs] [Bug 32001] Make submit button yellow when adding a new matching rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This button is also very yellow now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:32:50 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 32001, which changed state. Bug 32001 Summary: Make submit button yellow when adding a new matching rule https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:54:12 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2023 22:54:18 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #1 from Katrin Fischer --- Created attachment 144924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144924&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 02:42:54 +0000 Subject: [Koha-bugs] [Bug 30846] Notforloan status is not checked in CanBookBeReserved/CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:45:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 02:45:20 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- Yikes, where are we at with this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 02:46:15 +0000 Subject: [Koha-bugs] [Bug 32026] 'Search within results' and its input field in staff search results page are misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:25:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 08:25:23 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #11 from Katrin Fischer --- (In reply to David Cook from comment #10) > Yikes, where are we at with this one? Needing someone to assign the bug and write patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 08:54:02 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144901|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 144925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144925&action=edit Bug 32528: Change return logic Back to 1 return statement Prevent the Koha::Result::Boolean instanciation duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 08:54:47 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 10:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 09:22:35 +0000 Subject: [Koha-bugs] [Bug 32556] New: borrower_message_preference_id reaches limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Bug ID: 32556 Summary: borrower_message_preference_id reaches limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Symptom: Adding a new patron gives a 500 error. plack-error.log: C4::Members::Messaging::SetMessagingPreference(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'borrower_message_preference_id' at row 1 at /usr/share/koha/lib/C4/Form/MessagingPreferences.pm line 98 MariaDB [koha]> select max(borrower_message_preference_id) from borrower_message_preferences; +-------------------------------------+ | max(borrower_message_preference_id) | +-------------------------------------+ | 2147475728 | +-------------------------------------+ 1 row in set (0.000 sec) MariaDB [koha]> show create table borrower_message_preferences\G *************************** 1. row *************************** Table: borrower_message_preferences Create Table: CREATE TABLE `borrower_message_preferences` ( `borrower_message_preference_id` int(11) NOT NULL AUTO_INCREMENT, `borrowernumber` int(11) DEFAULT NULL, `categorycode` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `message_attribute_id` int(11) DEFAULT 0, `days_in_advance` int(11) DEFAULT 0, `wants_digest` tinyint(1) NOT NULL DEFAULT 0, PRIMARY KEY (`borrower_message_preference_id`), KEY `borrowernumber` (`borrowernumber`), KEY `categorycode` (`categorycode`), KEY `message_attribute_id` (`message_attribute_id`), CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_2` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB AUTO_INCREMENT=2147483648 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 1 row in set (0.000 sec) The site where this happens runs a nightly import from a student registration system, so patrons are updated frequently. Two questions: 1. How do we fix this for sites that reach the limit? I tried to disable foreign key checks and alter the column from signed to unsigned, but that did not work: MariaDB [koha]> SET FOREIGN_KEY_CHECKS=0; Query OK, 0 rows affected (0.000 sec) MariaDB [koha]> ALTER TABLE borrower_message_preferences MODIFY borrower_message_preference_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT; ERROR 1025 (HY000): Error on rename of './koha_hkr/#sql-3d8_41ab0' to './koha_hkr/borrower_message_preferences' (errno: 150 "Foreign key constraint is incorrectly formed") 2. How do we make sure this never happens? To extend the period before this happens, it might be a quick fix to change the borrower_message_preference_id column from SIGNED (the default) to UNSIGNED. As far as I can tell, this would double the number of IDs the column can hold. A better solution might be to make the borrower_message_preferences update in place, and not generate new borrower_message_preference_id's every time they are updated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 10:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 09:28:53 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Hans Pålsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson at hkr.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:18 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:24 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #12 from Jonathan Druart --- Created attachment 144926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144926&action=edit Bug 32445: Fix availability display on opac-course-details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:29 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #13 from Jonathan Druart --- Created attachment 144927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144927&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:34 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #14 from Jonathan Druart --- Created attachment 144928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144928&action=edit Bug 32445: Fix notforloan display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:39 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #15 from Jonathan Druart --- Created attachment 144929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144929&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:22:44 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #16 from Jonathan Druart --- Created attachment 144930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144930&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:23:29 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #17 from Jonathan Druart --- This patch set suggests to remove the non-Koha::Item support from item-status.inc in order to make it more reliable. We are removing some specific code from pl scripts (opac-basket.pl, opac-course-details.pl) and pass a Koha::Item to item-status.inc where it was not the case already. It's hard to provide a full test plan. You should mostly focus on item availability in opac-detail, opac-basket and opac-course-details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:23:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:23:59 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:33:01 +0000 Subject: [Koha-bugs] [Bug 28395] allow patron enrollment period to be set in days for patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28395 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:37:43 +0000 Subject: [Koha-bugs] [Bug 28395] allow patron enrollment period to be set in days for patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28395 --- Comment #1 from Holly --- I've been seeing some questions come in about having the option of setting an enrollment period by days, so it would be great to see some engagement on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:56:16 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12225 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 [Bug 12225] SIP does not respect the "no block" flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:56:16 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 [Bug 32537] Add 'no_block' option to sip_cli_emulator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 11:56:16 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32537 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:00:14 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 --- Comment #12 from Matt Blenkinsop --- (In reply to Katrin Fischer from comment #10) > Hi Matt, have a look at the KohaDates TT filter. It will format the date > nicely for you according to the DAteFormat system preference. Thanks for the hint Katrin, I have used the filter and also fixed the typo - resubmitted for sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:00:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:00:49 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144828|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop --- Created attachment 144931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144931&action=edit Bug 32373: Show patron restriction date When viewing a patron account with a restriction there is no way to see when the restriction was placed. This is available in the borrower_debarrments table and has now been added to the UI and matched to the 'dateformat' syspref. (Previous commit missed the moremember.tt render and the syspref formatting - this is now being done with the KohaDates template filter) Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:01:16 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:11:19 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #3 from Nick Clemens --- (In reply to David Nind from comment #2) > > I'm not sure if this is what is expected (as it is pretty similar to what I > got for bug 32537, except the second and third series of numbers in the SEND > are different), but happy to sign off if it is. Hi David, It looks like the SIP response is still failing on no-block, but I don't recreate Could you retest with 'restart_all' rather than just SIP to see if that works? Or try koha-sip --stop, confirm stopped, then koha-sip --start? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:24:23 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #36 from Jonathan Druart --- Can this be a candidate for an early push to 23.05 please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:33:25 +0000 Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer & add libhtml-parser-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062 --- Comment #7 from Thibaud Guillot --- Created attachment 144932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144932&action=edit Bug 10762: (follow-up) Add exec right on atomic update file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:35:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:35:38 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #17 from Thibaud Guillot --- Created attachment 144933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144933&action=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:36:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:36:19 +0000 Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer & add libhtml-parser-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144932|1 |0 is patch| | Attachment #144932|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot --- Comment on attachment 144932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144932 Bug 10762: (follow-up) Add exec right on atomic update file >From bb928a504c65f0b5c549d6b56dcdf7dcfc91b459 Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot >Date: Tue, 3 Jan 2023 13:32:16 +0100 >Subject: [PATCH] Bug 10762: (follow-up) Add exec right on atomic update file > >https://bugs.koha-community.org/show_bug.cgi?id=17062 >--- > installer/data/mysql/atomicupdate/update-BZ_10762.pl | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 installer/data/mysql/atomicupdate/update-BZ_10762.pl > >diff --git a/installer/data/mysql/atomicupdate/update-BZ_10762.pl b/installer/data/mysql/atomicupdate/update-BZ_10762.pl >old mode 100644 >new mode 100755 >-- >2.25.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:37:23 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #18 from Thibaud Guillot --- I forgot this file, fixed and push -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:59:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:59:02 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |28445 Status|NEW |ASSIGNED Severity|enhancement |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:59:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 12:59:02 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:02:04 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:02:09 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 --- Comment #1 from Jonathan Druart --- Created attachment 144934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144934&action=edit Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod The 'Clear on loan' link displayed at the top of the batch item modification tool has been broken by bug 28445. data-is-onloan attribute is supposed to be 1 or 0, but we passed the checkout (Koha::Checkout=HASH) Test plan: 1. Enter a checked-out barcode in the 'Batch item modification' page 2. Click 'Continue' 3. Notice a table is loaded displaying the on-loan item with a ticked checkbox 4. Click the 'Clear on loan' link above the table 5. Notice the on-loan item is no longer selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:02:47 +0000 Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32550 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32550 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:02:47 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31611 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31611 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611 [Bug 31611] More visibly highlight records that cannot be batch deleted/modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:12:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:12:50 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #4 from Kyle M Hall --- Created attachment 144935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144935&action=edit Bug 32537: (QA follow-up) Don't allow invalid no block values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:15:05 +0000 Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #5 from Kyle M Hall --- Created attachment 144936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144936&action=edit Bug 32537: (QA follow-up): Tidy code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:56:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 13:56:24 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 --- Comment #14 from Katrin Fischer --- I believe this could be removed again now, could you confirm? -use Koha::DateUtils qw( dt_from_string ); +use Koha::DateUtils qw( dt_from_string format_sqldatetime ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:10:48 +0000 Subject: [Koha-bugs] [Bug 32557] New: Implement SIP2 no block flag for checkin messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 Bug ID: 32557 Summary: Implement SIP2 no block flag for checkin messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The "no block" flag for SIP2 checkin messages has never been implemented. Bug 32515 fixed the issue where a non-existent subroutine was called if the no-block flag has passed. We should implement a no-block version of the checkin subroutine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:10:57 +0000 Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:10:57 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 [Bug 32557] Implement SIP2 no block flag for checkin messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:11:06 +0000 Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:11:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:11:24 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Created attachment 144925 [details] [review] > Bug 32528: Change return logic > > Back to 1 return statement > Prevent the Koha::Result::Boolean instanciation duplication I agree with the follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:12:31 +0000 Subject: [Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 --- Comment #26 from Jonathan Druart --- (In reply to Nick Clemens from comment #25) > (In reply to Jonathan Druart from comment #19) > > I think this change is coming whereas we don't use the same code to display > > the descriptions, and it could lead to confusion (theoretically at least): > > fetch from cache and fetch from DB. > > Can you explain this a bit more? Where are we not using this that could be a > conflict? Everywhere we fetch branchname, itemtype's description, av's lib (mainly from C4) > > There is at least one thing that could go wrong, itemtype's descriptions. > > First we only deal with 'en', then it is actually wrong with 'en': it could > > be overwritten by the "Translate into other languages" feature (yes that's a > > weird use case but the UI allows it). > In testing I can provide a French translation and the correct one shows when > changing languages in search results on both staff and OPAC Sorry, I think it didn't make sense. I guess I was referring to Koha::Itemtype->store + if ($flush) { + my $cache = Koha::Caches->get_instance(); + my $key = "enItemTypeDescriptions"; + $cache->clear_from_cache($key); + } But it actually sounds good after having a second look at it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:50:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:50:51 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 14:50:54 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144922|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 144937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144937&action=edit Bug 32505: Restore patron search by formatted dob Prior to the rewrite of the patron searches (bug 30063 and friends) it was possible to search for a patron using their date of birth, formatted following the dateformat syspref. Now it only works if the date is iso formatted. This patch is providing a fix to restore the behaviour, but does not make it consistent. Only searching patrons by date of birth is fixed here, when we actually want to fix the problem for the REST API DT wrapper instead. Test plan: Search for patrons given their date of birth. You need to select "date of birth" in the "Search field" dropdown, or set it in DefaultPatronSearchFields. Note that the column filtering is still not working, but I guess it was the case already in older versions. Ideally we will need to have a "datatype" attribute passed to the the 'th' and retrieved from datatables.js to add this same trick and build the query appropriately. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:07:14 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass --- (In reply to Katrin Fischer from comment #14) > I believe this could be removed again now, could you confirm? > -use Koha::DateUtils qw( dt_from_string ); > +use Koha::DateUtils qw( dt_from_string format_sqldatetime ); Yes, it looks like 'format_sqldatetime' is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:24:08 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:24:13 +0000 Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144847|0 |1 is obsolete| | Attachment #144925|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 144938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144938&action=edit Bug 32528: Make safe_to_delete exit earlier on error conditions This patch makes the `Koha::Item->safe_to_delete` method return right after one of the checked conditions is met. This way we avoid further DB queries and processing. No behavior change is expected To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests STILL pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Bug 32528: Change return logic Back to 1 return statement Prevent the Koha::Result::Boolean instanciation duplication Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:25:03 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:25:09 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134754|0 |1 is obsolete| | --- Comment #19 from Lucas Gass --- Created attachment 144939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144939&action=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:25:15 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144900|0 |1 is obsolete| | --- Comment #20 from Lucas Gass --- Created attachment 144940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144940&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:25:21 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144933|0 |1 is obsolete| | --- Comment #21 from Lucas Gass --- Created attachment 144941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144941&action=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:29:25 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 --- Comment #16 from Matt Blenkinsop --- Created attachment 144942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144942&action=edit Bug 32373: (follow-up) Show patron restriction date Unnecessary import of format_sqldatetime has now been removed Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:29:50 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:32:09 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:32:13 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144931|0 |1 is obsolete| | --- Comment #17 from Lucas Gass --- Created attachment 144943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144943&action=edit Bug 32373: Show patron restriction date When viewing a patron account with a restriction there is no way to see when the restriction was placed. This is available in the borrower_debarrments table and has now been added to the UI and matched to the 'dateformat' syspref. (Previous commit missed the moremember.tt render and the syspref formatting - this is now being done with the KohaDates template filter) Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:32:17 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144942|0 |1 is obsolete| | --- Comment #18 from Lucas Gass --- Created attachment 144944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144944&action=edit Bug 32373: (follow-up) Show patron restriction date Unnecessary import of format_sqldatetime has now been removed Test plan: 1) Create a restriction on a patron and navigate to that patron in Checkouts or the patron details page 2) There should be a message with details about the restriction but the creation date of the restriction won't be included in the message 3) Apply patch 4) The message should now say "Restricted since DATE" as in the screenshot attached. 5) Change the 'dateformat' syspref and refresh, the date should change to reflect the syspref Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:35:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:35:38 +0000 Subject: [Koha-bugs] [Bug 32558] New: Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Bug ID: 32558 Summary: Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:37:43 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:39:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:39:16 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:39:20 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144924|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 144945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144945&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:41:14 +0000 Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01,22.11.01 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:42:32 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:43:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:43:52 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:43:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:43:56 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #1 from Kyle M Hall --- Created attachment 144946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144946&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:46:48 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 slmontesdeoca at orem.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slmontesdeoca at orem.org --- Comment #7 from slmontesdeoca at orem.org --- My cataloging team and I are very interested in having the ability to edit authority records using the advanced editor. We are very focused on improving our authority database and being able to edit the authorities easier would be a big step in achieving that goal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 15:55:27 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #2 from Jonathan Druart --- Hi Kyle, you embedded unrelated changes (sip). This would make sense in some cases (job types), but I think it should default to 1 to keep the existing behaviour (we don't want 10 long tasks/batch mod running at the same time). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:24:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:24:47 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #3 from Kyle M Hall --- Created attachment 144947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144947&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:25:17 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144946|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:55:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:55:20 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #37 from Jonathan Druart --- Created attachment 144948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144948&action=edit Bug 30310: Replace one more occurrence to moment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:58:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:58:10 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to h1 headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #3 from Katrin Fischer --- Thanks, Lucas :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:58:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:58:44 +0000 Subject: [Koha-bugs] [Bug 32559] New: Support formatted date for column filtering (DT) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Bug ID: 32559 Summary: Support formatted date for column filtering (DT) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:59:33 +0000 Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 --- Comment #1 from Kyle M Hall --- I've been working on this, and I'm not actually convinced we need anything more than what Nick has done on bug 32515. If someone can point out a scenario where we need more please let me know! Kyle -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:59:34 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32559 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > Note that the column filtering is still not working, but I guess it was > the case already in older versions. Ideally we will need to have a > "datatype" attribute passed to the the 'th' and retrieved from > datatables.js to add this same trick and build the query appropriately. See bug 32559. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 [Bug 32559] Support formatted date for column filtering (DT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:59:34 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 [Bug 32505] Cannot search by dateofbirth in specified dateformat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 16:59:52 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #1 from Katrin Fischer --- Hm, maybe data-search could work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:10:05 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Tested with different iterations of this: $.ajax({ url: '/api/v1/biblios/55/items/117', method: 'PUT', data: JSON.stringify({ "collection_code": "COLLECTION1", "external_id": "123test", }), contentType: 'application/json', success: function(result) { console.log('altered') }, }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:10:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:10:48 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #5 from David Gustafsson --- Found tests that still needs fixing, working on this and then should be ready for review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:11:20 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:11:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:11:24 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144902|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 144949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144949&action=edit Bug 31799: Add REST endpoint to modify a biblio's item To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Get a biblio with an item 4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json body that represents an item to replace 5. Check that the item was modified 6. Sign off Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:12:41 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:18:08 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #38 from Jonathan Druart --- Created attachment 144950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144950&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:18:34 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 [Bug 30310] Replace Moment.js with Day.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:18:34 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 [Bug 32559] Support formatted date for column filtering (DT) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:21:19 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:21:23 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #2 from Jonathan Druart --- Created attachment 144951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144951&action=edit Bug 32559: Add support for formatted date when filtering on a column When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. Test plan: Assuming dateformat is set to metric Go to the main patron search, search for all patrons (don't provide a search term) In the "date of birth" column filter, enter "1958", notice that you see Henry Search using an iso formatted date 1958-05-30 Search using a metric formatted date 30/05/1958 Note that: - it's also working for "Expires on" on the same table. We may want to adjust other tables that are using the DT REST API wrapper and the column filters - You need to search for the full formatted date to make it work. "30/05" won't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:29:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:29:19 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Hm, maybe data-search could work? Nope, we need to deal with it "manually", we cannot rely on DT internals. Here we are using the REST API and don't have the data loaded in the DOM already. However I would be happy if someone else come with a better solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:33:12 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:43:37 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #3 from Lucas Gass --- This also effects wildcard searches. Previously you could search for a cardnumber like '2913*' and that would return all patrons with cardnumbers starting with '2913'. Now it tries searching for the exact match '2352*' and returns nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:44:27 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #3 from Agustín Moyano --- Created attachment 144952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144952&action=edit Bug 31798: (follow-up) Tidy up camel cased variables and unnecessary checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:46:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:46:10 +0000 Subject: [Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #2 from Jason Robb --- Not sure if this is the exact same issue but I'm on 22.05.07 and consistently getting the "Wrong CSRF Token" error any time I try to add a patron photo from any page of the account *other than* the Details (moremember.pl) tab. I've tested with both the snazzy new camera integration and by manually uploading a file, and in both cases, it only succeeds on moremember.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:47:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:47:46 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi --- Agustin, I think this is missing tests for the duplicate barcode use case. And in those tests it should be returning a 409 (conflict?) instead of a 500 because of the unhandled exception. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:55:09 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #5 from Agustín Moyano --- Created attachment 144953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144953&action=edit Bug 31798: (follow-up) Add duplicate barcode test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:57:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:57:58 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 --- Comment #6 from Agustín Moyano --- (In reply to Tomás Cohen Arazi from comment #4) > Agustin, I think this is missing tests for the duplicate barcode use case. > And in those tests it should be returning a 409 (conflict?) instead of a 500 > because of the unhandled exception. > > Thanks. Should we return 409 conflict or 400 bad request? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 17:58:16 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > This also effects wildcard searches. Previously you could search for a > cardnumber like '2913*' and that would return all patrons with cardnumbers > starting with '2913'. Now it tries searching for the exact match '2352*' and > returns nothing. I don't think * has worked, but it automatically did a begin with. % should probably still work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:00:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:00:16 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:00:19 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144951|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 144954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144954&action=edit Bug 32559: Add support for formatted date when filtering on a column When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. Test plan: Assuming dateformat is set to metric Go to the main patron search, search for all patrons (don't provide a search term) In the "date of birth" column filter, enter "1958", notice that you see Henry Search using an iso formatted date 1958-05-30 Search using a metric formatted date 30/05/1958 Note that: - it's also working for "Expires on" on the same table. We may want to adjust other tables that are using the DT REST API wrapper and the column filters - You need to search for the full formatted date to make it work. "30/05" won't work. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:30:37 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:30:41 +0000 Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144934|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 144955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144955&action=edit Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod The 'Clear on loan' link displayed at the top of the batch item modification tool has been broken by bug 28445. data-is-onloan attribute is supposed to be 1 or 0, but we passed the checkout (Koha::Checkout=HASH) Test plan: 1. Enter a checked-out barcode in the 'Batch item modification' page 2. Click 'Continue' 3. Notice a table is loaded displaying the on-loan item with a ticked checkbox 4. Click the 'Clear on loan' link above the table 5. Notice the on-loan item is no longer selected Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:32:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:32:28 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:32:32 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144952|0 |1 is obsolete| | Attachment #144953|0 |1 is obsolete| | --- Comment #7 from Agustín Moyano --- Created attachment 144956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144956&action=edit Bug 31798: (follow-up) Tidy up and add duplicate barcode test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:34:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 18:34:19 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:04:15 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:04:20 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144255|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 144957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144957&action=edit Bug 32353: Pick the default value for FK Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:04:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:04:25 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144279|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 144958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144958&action=edit Bug 32353: Don't generate item group for holds in tests See bug 31447, we don't want the tests to deal with potential failures because of some item groups. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:10:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:10:27 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 --- Comment #4 from Agustín Moyano --- Created attachment 144959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144959&action=edit Bug 31799: (follow-up) Tidy up and fix duplicate barcode handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:10:55 +0000 Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind --- Testing notes (using KTD): 1. Before the patches are applied, ran prove t/db_dependent/Circulation.t 2. Note that tests pass, but there are warnings: root at kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 60/64 Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5712. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=64, 26 wallclock secs ( 0.15 usr 0.02 sys + 18.55 cusr 2.50 csys = 21.22 CPU) Result: PASS 3. Applied patches and restarted everything. 4. Run test again. Note that "....60/64 Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line 5712." warning/output after running the tests is gone: root at kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 60/64 Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. Use of uninitialized value $rentalCharge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=64, 26 wallclock secs ( 0.13 usr 0.01 sys + 18.61 cusr 2.52 csys = 21.27 CPU) Result: PASS I hope this is sufficient for testing - I don't understand all the other stuff 8-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:49:58 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144947|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 144960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144960&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 19:55:51 +0000 Subject: [Koha-bugs] [Bug 32177] Tests failing for t/db_dependent/Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32177 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from David Nind --- This seems to have been fixed now - tests pass (with warnings) now on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 21:26:37 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 PPLCS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |admin at pplcs.net --- Comment #5 from PPLCS --- We desperately need this fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 22:27:33 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Hi Jan. Your patch works (yeah!), but I can't seem to sign it off. I get this message: root at kohadevbox:koha(bz32523)$ git bz attach -e 32523 HEAD /usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/bin/git-bz", line 2722, in do_attach(*args) File "/usr/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) I can sign off other patches (and my koha-testing-docker (KTD) is all up to date), so I don't think it is my setup (but I could be wrong!). Also, I think you will need to amend your patch for the QA Team to be happy, including: - Formatting title as Bug XXXXX: Title - Including the description and test plan in the patch See the commit message guidelines at https://wiki.koha-community.org/wiki/Commit_messages David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:38:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 22:38:38 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the standard release notes| |MARC editor so that the | |links for any errors go to | |the correct tab. Currently, | |the links only work if you | |are the correct tab. --- Comment #5 from David Nind --- I've added a draft release note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:44:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 22:44:28 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Hi Kyle, you embedded unrelated changes (sip). > This would make sense in some cases (job types), but I think it should > default to 1 to keep the existing behaviour (we don't want 10 long > tasks/batch mod running at the same time). Yep, that was an accident. It just took me a few minutes to untangle ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:45:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 22:45:58 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #6 from Kyle M Hall --- Created attachment 144961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144961&action=edit Bug 32558: (follow-up) Set default max processes to 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:01:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:01:45 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- An alternative would be to launch more background_jobs_worker.pl processes, although that would require updating the koha-worker script. Speaking of the koha-worker script, how would the max processes be configured for it? Perhaps something in debian/koha-common.init that can be overridden in /etc/default/koha-common? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:12:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:12:11 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:12:16 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144887|0 |1 is obsolete| | --- Comment #13 from Lucas Gass --- Created attachment 144962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144962&action=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:12:55 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 --- Comment #14 from Lucas Gass --- reset to 'Needs signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:15:46 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- > Two questions: > > 1. How do we fix this for sites that reach the limit? > > 2. How do we make sure this never happens? > > To extend the period before this happens, it might be a quick fix to change > the borrower_message_preference_id column from SIGNED (the default) to > UNSIGNED. As far as I can tell, this would double the number of IDs the > column can hold. It might make more sense to switch from SIGNED INT to SIGNED BIGINT as the maximum value for SIGNED BIGINT is 9,223,372,036,854,775,807 That would make it much less likely to hit the max value limit. > A better solution might be to make the borrower_message_preferences update > in place, and not generate new borrower_message_preference_id's every time > they are updated? That's probably a better solution although it would involve more elaborate coding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:16:10 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #4 from David Nind --- (In reply to Nick Clemens from comment #3) > (In reply to David Nind from comment #2) > > > > I'm not sure if this is what is expected (as it is pretty similar to what I > > got for bug 32537, except the second and third series of numbers in the SEND > > are different), but happy to sign off if it is. > > Hi David, > > It looks like the SIP response is still failing on no-block, but I don't > recreate > > Could you retest with 'restart_all' rather than just SIP to see if that > works? Or try koha-sip --stop, confirm stopped, then koha-sip --start? I'm getting a response now, so will sign off! The response is now: root at kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230103 23115420230103 231154APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230103 231155AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| Maybe I forgot to flush_memcached and restart_all after stopping and starting SIP 8-; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:17:53 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:17:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:17:58 +0000 Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine that does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144856|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 144963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144963&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:22:13 +0000 Subject: [Koha-bugs] [Bug 32560] New: Mark expired borrowers as having lost their card Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Bug ID: 32560 Summary: Mark expired borrowers as having lost their card Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz We have a library that marks expired borrowers as having lost their card. It would be nice to be able to upstream the cronjob they use to mark borrowers.lost = 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2023 23:39:34 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from David Nind --- Hi I'm getting this error when trying to apply the patch: root at kohadevbox:koha(bz29173)$ git bz apply 29173 Bug 29173 - Button "replace authority record via Z39/50/SRU" doesn't pre-fill 144867 - Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) error: sha1 information is lacking or useless (cataloguing/z3950_auth_search.pl). error: could not build fake ancestor Patch failed at 0001 Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 01:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 00:10:57 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #18 from David Nind --- I've tested, and this now fixes the display for: - the record in the staff interface and OPAC - the cart in the OPAC For course reserves, the status is shown as: - OPAC: Programming error, item-status.inc must be called with a Koha::Item object. - Staff interface: Available How I tested (using KTD): 1. Replicated the issue (as per the bug description), and in addition I added a record/item to a course reserve and the cart (for both the OPAC and staff interface). 2. Applied the patch, flush_memcached, restart_all and cleared the browser cache. 3. Refreshed the pages. 4. Results: - this worked fine for the record/item in the staff interface and OPAC; and the cart in the OPAC - Didn't work for course reserves: the status in the staff interface shows as 'Available' (I guess this is right as it is available but can't be borrowed?), and in the OPAC shows as 'Programming error, item-status.inc must be called with a Koha::Item object.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 01:56:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 00:56:31 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #7 from David Nind --- Hi Thibaud. Apologies for not retesting sooner! I'm getting this error trace message now after applying the patch: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Bareword "_description" not allowed while "strict subs" in use at /kohadevbox/koha/C4/ILSDI/Services.pm line 262. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... If I refresh the page again, I get this error trace message: Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload C4/ILSDI/Services.pm aborted. Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. at /usr/share/perl5/CGI/Compile.pm line 144 ... Maybe this is because koha-testing-docker is using strict mode for the database? (I don't know enough about these things to offer an informed opinion....or how to disable struct mode). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:04:33 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:04:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:04:38 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144810|0 |1 is obsolete| | --- Comment #20 from David Cook --- Created attachment 144964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144964&action=edit Bug 30962: REST API: Add endpoint /auth/password/validation This patch adds an endpoint for /auth/password/validation This allows a third-party, using an authenticated and authorized Koha API user, to check if the username and password given by a user is correct in Koha. For example, a Keycloak extension can be created using its User Storage SPI to use Koha as the user database for Keycloak. This API allows us to authenticate the user as a particular Koha user - without creating a Koha user session for them. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RESTBasicAuth 2. Enable "RESTBasicAuth" 3. Run the following commands while substituting correct values for and 3. curl -XPOST -H "Content-Type: application/json" -u : http://localhost:8081/api/v1/auth/password/validation -d '{ "username": ", "password": "" }' -v 4. Note "204 No Content" response 5. curl -XPOST -H "Content-Type: application/json" -u : http://localhost:8081/api/v1/auth/password/validation -d '{ "username": ", "password": "this is definitely not the password" }' -v 6. Note "400 Bad Request" response and error message {"error":"Validation failed"} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:04:43 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #21 from David Cook --- Created attachment 144965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144965&action=edit Bug 30962: Add unit tests for /auth/password/validation endpoint Test plan: 0. Apply patch 1. prove -v t/db_dependent/api/v1/password_validation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:05:29 +0000 Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint /auth/password/validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962 --- Comment #22 from David Cook --- (In reply to Jonathan Druart from comment #11) > 1. Missing tests (you must provide tons of tests to cover the different > situations) > 2. Route's name should not be a verb (/password/validation maybe?) > 3. Routes that returns empty should return 204 > 4. It's always returning "Invalid password" even for other failures (like > too many attempts) > 5. It allows you to check for pwd validation for a user you don't know their > userid (you can force brute only by knowing the patron's id). I don't think > it's a security concern as userid could be guessed anyway (?) > 6. following 5, you can lock any accounts if FailedLoginAttempts is set, no > need to know the userid list. How bad is that? I think that I've addressed all these points now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:16:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:16:08 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:16:13 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144962|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 144966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144966&action=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 5. The search results table should be listed, with the ability to hide the author, date_added, or call_number 6. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) 8. Turn on the item-level_itypes system preferecne which will add the item type column, make sure you can hide it and all other columns correctlly now. Note: I have also added the page-section class to this table. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:27:57 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 --- Comment #1 from Alex Buckley --- Created attachment 144967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144967&action=edit Bug 32560: Cronjob to mark expired borrowers as lost their card Test plan: 1. Edit a borrower to have an expiration date in the past - also make sure they have 'Lost card' set to 'No' 2. Run the set_expired_lost.pl script: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl 3. Notice you get output saying the number of borrowers are to be changed 4. View the borrower account from #1 and notice they have a 'Lost card' value of 'Yes' 5. Run the set_expired_lost.pl script again and observe no output is printed to the terminal - this is because all expired borrowers have already been marked as lost. Sponsored-by: Dalton McCaughey Library, Australia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:28:13 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 02:52:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 01:52:14 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 --- Comment #40 from David Cook --- (In reply to Tomás Cohen Arazi from comment #38) > I think we need some more tests here, particularly for the 'staff_authorize' > and 'prepare_template', unless I'm missing something. I noticed at first > glance a subtle issue with __koha__user__ vs. __koha_user__ that is not > caught by the provided tests. Good catch with __koha__user__. I hadn't used that return value anywhere yet. Following my unit tests on Bug 30962 and looking at t/Koha/REST/Plugin/Query.t, I think I now know how to write the tests you're talking about. I'll give it a go. > It would be great (also) if you could perltidy some of this code. I usually > select the code I want to tidy, and just ctrl+k ctrl+f on VScode. Please do > it inline. Thanks! I think there's a problem with the perltidy vim macro in KTD but otherwise I'm open to it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 05:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 04:08:22 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139313|0 |1 is obsolete| | --- Comment #41 from David Cook --- Created attachment 144968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144968&action=edit Koha Plugin with Mojolicious controller Updating attached plugin to use updated staff interface templates and to use some code updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 06:59:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 05:59:21 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140673|0 |1 is obsolete| | --- Comment #42 from David Cook --- Created attachment 144969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144969&action=edit Bug 31380: Allow Koha Plugins to run using Mojolicious controllers This patch adds a new mount point in plack.psgi, which makes Koha able to run Mojolicious controllers. For example: http://localhost:8081/cgi-bin/koha/staff/plugins/run 0a) Apply patch 0b) cp debian/templates/plack.psgi /etc/koha/sites/kohadev/plack.psgi 0c) koha-plack --restart kohadev 1) Upload Koha Plugin koha-plugin-mojolicious.kpz 2) koha-plack --restart kohadev 3) Go to http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl 4) Next to "Mojolicious Test", click "Actions", then click "Run tool" 5) Note that the web page looks perfect 6) Note that the URL is a bit different to normal: http://localhost:8081/cgi-bin/koha/staff/plugins/run?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool instead of: http://localhost:8081/cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3AProsentient%3A%3AMojolicious&method=tool Note: The test Koha plugin will only work with a Mojolicious controller, but it could be easily made to work with both 7) Run the above test using an unauthenticated user, use a staff user without plugin permissions, try with a staff user with plugin permissions, and try with a superlibrarian 8) Run tests prove t/db_dependent/Koha/Auth.t prove t/db_dependent/Koha/Mojo/Plugins/Core.t prove t/db_dependent/Koha/Template.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 06:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 05:59:26 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140674|0 |1 is obsolete| | --- Comment #43 from David Cook --- Created attachment 144970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144970&action=edit Bug 31380: Add plugin hook for choosing Mojolicious or CGI script controller This change checks for a "use_mojolicious" method in the plugin in order to determine whether it should use a Mojolicious controller or a CGI script controller. Note that the check is for the existence of the method, so it is backwards compatible with all existing Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 07:00:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 06:00:05 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 07:05:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 06:05:11 +0000 Subject: [Koha-bugs] [Bug 31380] Build Mojolicious controller for running Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31380 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #44 from David Cook --- I've added a lot more tests, streamlined the code more, and resolved an issue with the authorization process. I could probably add a couple more end-to-end tests but I've run out of time today and I'm away the next 5 days. Moving this back to "Needs Signoff" to get eyes on it in the meantime... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 08:16:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 07:16:40 +0000 Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Anne-Cécile Bories changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories at iepg.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:08:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:08:45 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #928 from Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt - [% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %] + [% INCLUDE 'item-status.inc' item=cr.course_item issue=cr.issue %] I don't understand this change, and I am going to revert it. I think it broke the availability display. Can you clarify on bug 32445 please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:10:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:10:26 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #19 from Jonathan Druart --- Created attachment 144971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144971&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:12:53 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #2 from Magnus Enger --- After reading https://stackoverflow.com/questions/10833530/how-to-change-mysql-primary-key-from-signed-to-unsigned I tried to: - Dump the database - Edit the CREATE TABLE statements for borrower_message_preferences.borrower_message_preference_id and borrower_message_transport_preferences.borrower_message_preference_id to make them BIGINT - Load the database back in But alas, this also gave a foreign key error: ERROR 1005 (HY000) at line 2442: Can't create table `koha_hkr`.`borrower_message_preferences` (errno: 150 "Foreign key constraint is incorrectly formed") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:13:28 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 --- Comment #20 from Jonathan Druart --- The changes made to opac-course-details seem to fix the availability there, that could have been broken by bug 19532. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:13:28 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:18:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:18:10 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #21 from Jonathan Druart --- Hi David, I fixed the "programming error", and the availability display at the OPAC for course reserves. But I think we need a separate bug to deal with it properly (as it exists in 22.05). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:18:29 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:26:06 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #8 from Jonathan Druart --- (In reply to David Cook from comment #7) > An alternative would be to launch more background_jobs_worker.pl processes, > although that would require updating the koha-worker script. Yes, that's exactly what I thought later yesterday night. Why should we need this flag instead of letting sysops start the number of workers they want? The first argument could be the memory footprint, but with bug 28413 it should not be a problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:27:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:27:59 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:28:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:28:03 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144867|0 |1 is obsolete| | --- Comment #38 from Thibaud Guillot --- Created attachment 144972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144972&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3)After go to "Edit"-> "Edit record" -> "Replace record via..." or choose "Replace Record.." directly 4) See that form is also prefilled with data now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:34:46 +0000 Subject: [Koha-bugs] [Bug 32561] New: background job worker is still running with all the modules in RAM Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Bug ID: 32561 Summary: background job worker is still running with all the modules in RAM Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28413, 30410 Regression of bug 28413, bug 30410 added a "use Koha::Plugins" statement at the top of Koha::BackgroundJob, and so all Koha module are loaded by the worker on startup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 [Bug 28413] background job worker is running with all the modules in RAM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 [Bug 30410] Add a way for plugins to register background tasks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:34:46 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 [Bug 32561] background job worker is still running with all the modules in RAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:34:46 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 [Bug 32561] background job worker is still running with all the modules in RAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:35:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:35:15 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32561 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > The first argument could be the memory footprint, but with bug 28413 it > should not be a problem. And just noticed that it's broken, see bug 32561. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:35:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:35:15 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32558 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:42:19 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #5 from Martin Renvoize --- This looks like a reasonable approach.. I did similar in another bug somewhere a while ago, but this implimentation is a little cleaner. Can we get some unit tests for it? There are tests for the dt wrapper right.. I can't entirely remember. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:58:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 08:58:32 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #39 from Thibaud Guillot --- (In reply to David Nind from comment #37) > Hi > > I'm getting this error when trying to apply the patch: > > root at kohadevbox:koha(bz29173)$ git bz apply 29173 > > Bug 29173 - Button "replace authority record via Z39/50/SRU" doesn't pre-fill > > 144867 - Bug 29173: Fixed pre-filling of the search form from the "Replace > record with ZR39.50/SRU" (Authority page detail) > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 29173: Fixed pre-filling of the search form from the "Replace > record with ZR39.50/SRU" (Authority page detail) > error: sha1 information is lacking or useless > (cataloguing/z3950_auth_search.pl). > error: could not build fake ancestor > Patch failed at 0001 Bug 29173: Fixed pre-filling of the search form from > the "Replace record with ZR39.50/SRU" (Authority page detail) > > David Hi David, Thanks for your feedback :) and best wishes for 2023 by the way ;) I squash my last commit and I test it in kohadevbox, it seems ok to me, can you re-test it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:09:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:09:15 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:09:19 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #1 from Jonathan Druart --- Created attachment 144973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144973&action=edit Bug 32561: Prevent worker to run with unecessary modules in memory Regression of bug 28413, bug 30410 added a "use Koha::Plugins" statement at the top of Koha::BackgroundJob, and so all Koha module are loaded by the worker on startup. See bug 28413 for more info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:09:47 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:15:42 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #2 from Jonathan Druart --- Created attachment 144974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144974&action=edit Bug 32561: Add test This test does not seem reliable enough, how could we improve it? I guess it will fail randomly, especially if ran in parallel with other processes/tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:16:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:16:43 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144974|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 144975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144975&action=edit Bug 32561: Add test This test does not seem reliable enough, how could we improve it? I guess it will fail randomly, especially if ran in parallel with other processes/tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:27:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:27:42 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #6 from Jonathan Druart --- (In reply to Martin Renvoize from comment #5) > This looks like a reasonable approach.. I did similar in another bug > somewhere a while ago, but this implimentation is a little cleaner. > > Can we get some unit tests for it? There are tests for the dt wrapper > right.. I can't entirely remember. Yes, t/db_dependent/selenium/patrons_search.t Good idea, I will provide them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:50:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 09:50:18 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #6 from Jan Kissig --- Created attachment 144976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144976&action=edit Bug 32523: Links to missing fields in MARC-editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:13:44 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #22 from David Nind --- (In reply to Jonathan Druart from comment #21) > Hi David, > I fixed the "programming error", and the availability display at the OPAC > for course reserves. But I think we need a separate bug to deal with it > properly (as it exists in 22.05). Thanks Jonathan! An additional nuance for course reserves: - If I add an item to course reserves using an item barcode, everything works fine and there is no error displayed. - However, if I add it using the bibliographic number (such as 262), then I get the same error message as before. - In addition, if I add more items to course reserves after adding one using the biblio number, they are displayed on the staff interface list, but don't display in the OPAC list (hope this makes sense). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:14:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:14:22 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:14:27 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #7 from Jonathan Druart --- Created attachment 144977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144977&action=edit Bug 32559: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:28:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:28:51 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #23 from Jonathan Druart --- Created attachment 144978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144978&action=edit Bug 32445: Deal with biblio course reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:29:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:29:15 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #24 from Jonathan Druart --- (In reply to David Nind from comment #22) Should be fixed now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:32:47 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #8 from Thibaud Guillot --- Created attachment 144979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144979&action=edit Bug 31550: (follow-up) fix bareword issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:33:22 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #9 from Thibaud Guillot --- (In reply to David Nind from comment #7) > Hi Thibaud. > > Apologies for not retesting sooner! > > I'm getting this error trace message now after applying the patch: > > Could not compile /kohadevbox/koha/opac/ilsdi.pl: Bareword "_description" > not allowed while "strict subs" in use at > /kohadevbox/koha/C4/ILSDI/Services.pm line 262. > Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. > BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. > at /usr/share/perl5/CGI/Compile.pm line 144 > ... > > If I refresh the page again, I get this error trace message: > > Could not compile /kohadevbox/koha/opac/ilsdi.pl: Attempt to reload > C4/ILSDI/Services.pm aborted. > Compilation failed in require at /kohadevbox/koha/opac/ilsdi.pl line 22. > BEGIN failed--compilation aborted at /kohadevbox/koha/opac/ilsdi.pl line 22. > at /usr/share/perl5/CGI/Compile.pm line 144 > ... > > > Maybe this is because koha-testing-docker is using strict mode for the > database? (I don't know enough about these things to offer an informed > opinion....or how to disable struct mode). > > David Now it will be better I think ;) Thanks for your feedback again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:35:35 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:36:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:36:16 +0000 Subject: [Koha-bugs] [Bug 22623] Item location and status details missing from Your Cart display on OPAC if any attached item has a status of Withdrawn. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22623 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:36:49 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #17 from Jonathan Druart --- And what about the 30 minutes timeout? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:40:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:40:57 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #40 from David Nind --- (In reply to Thibaud Guillot from comment #39) > Thanks for your feedback :) and best wishes for 2023 by the way ;) > > I squash my last commit and I test it in kohadevbox, it seems ok to me, can > you re-test it ? Best wishes to you for 2023 as well! The patch now applies, I am now testing... David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:43:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:43:26 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:53:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 10:53:01 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:00:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:00:35 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144885|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 144980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144980&action=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:00:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:00:39 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144886|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 144981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144981&action=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:00:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:00:44 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #8 from Martin Renvoize --- Created attachment 144982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144982&action=edit Bug 32503: Use first cancellation for date ordering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:01:25 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:02:59 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #7 from Jan Kissig --- Hi David, thank you for your feedback. I have no clue where the error in root at kohadevbox:koha(bug_32523)$ git bz attach -e 32523 HEAD comes from. I use koha-testing-docker and cloned koha as described: git clone https://git.koha-community.org/Koha-community/Koha.git koha and use it as SYNC_REPO. Created a branch bug_32523 and switched to it, changed the source, committed and checked if it worked after running ktd up Inside the ktd (ktd --shell) I run root at kohadevbox:koha(bug_32523)$ git bz attach -e 32523 HEAD and get the same error as you. Someone a clue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:06:39 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #18 from Jonathan Druart --- I think I recreate the problem this way: % more /etc/rabbitmq/rabbitmq.conf consumer_timeout = 15000 Add a sleep 10 in Koha::BackgroundJob::BatchUpdateItem->process Then enqueue several batch item mod jobs. However: 1. I don't see jobs stuck in "new" (without the patch) 2. I am seeing the following in the rabbitmq logs, with and without the patch 2023-01-04 11:01:03.041 [warning] <0.2774.0> Consumer Q_/queue/koha_kohadev-long_tasks on channel 1 has timed out waiting on consumer acknowledgement. Timeout used: 15000 ms 2023-01-04 11:01:03.041 [error] <0.2774.0> Channel error on connection <0.2764.0> (127.0.0.1:39578 -> 127.0.0.1:61613, vhost: '/', user: 'guest'), channel 1: operation none caused a channel exception precondition_failed: consumer ack timed out on channel 1 2023-01-04 11:01:03.042 [error] <0.2758.0> STOMP error frame sent: Message: precondition_failed Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" Server private detail: none 2023-01-04 11:01:03.042 [info] <0.2758.0> closing STOMP connection <0.2758.0> (127.0.0.1:39578 -> 127.0.0.1:61613) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:10:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:10:02 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:11:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:11:52 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #8 from Martin Renvoize --- Excellent, thanks Jonathan. Now we just need the blockers to get unblocked.. I'm chasing Marcel on that as I think he's the most recent touch on them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:13:18 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Is this at the right level? I'm wondering if we aught to instead have this bound to a data type in the field name or something so it can be used more generically in the ajax driven datatables stuff. I have a vague recollection of trying this stuff in another bug that got stuck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:16:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:16:01 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #5) > Hi > > I tried this: > > kohadev-koha at kohadevbox:/kohadevbox/koha$ perl -MTry::Tiny -e 'try { die > "Boo"; } catch { warn "catch"; } finally { warn "finally" if $@; };' > catch at -e line 1. > kohadev-koha at kohadevbox:/kohadevbox/koha$ perl -MTry::Tiny -e 'try { die > "Boo"; } catch { warn "catch"; } finally { warn "finally" if $_; };' > catch at -e line 1. > > > In both cases it never prints "finally", so I guess the error buffer is > cleared after the catch block. Do you think it would work if we just move > the $job->status('failed') to the catch block? It looks cleaner too. It's @_ % perl -MTry::Tiny -e 'try { die "Boo"; } catch { warn "catch"; } finally { warn "finally" if @_; };' catch at -e line 1. finally at -e line 1. IMO it's better in the finally block, in case we add more stuff in catch later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:18:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:18:07 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:18:13 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144972|0 |1 is obsolete| | --- Comment #41 from David Nind --- Created attachment 144983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144983&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3)After go to "Edit"-> "Edit record" -> "Replace record via..." or choose "Replace Record.." directly 4) See that form is also prefilled with data now Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:21:02 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #9 from Martin Renvoize --- The other bug I was talking about was 'Bug 29302 - The dataTables Koha RESTful API wrapper should allow picking match type at the column level'.. where I was trying to do this closer to the datatables JS instantiation rather than in the table header markup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:22:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:22:59 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #42 from David Nind --- It would be good if both pop up windows were the same size for the search. At the moment the pop up window is slightly narrower for Edit > Edit record > Replace record via Z39.40/SRU search. This causes the labels to be above the input fields, rather than nicely aligned to the left. I tried to work out where the window size is set, but had no luck... Maybe this should be on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:23:38 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:29:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:29:32 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #10 from Kyle M Hall --- (In reply to David Cook from comment #7) > An alternative would be to launch more background_jobs_worker.pl processes, > although that would require updating the koha-worker script. Would that work with the database polling method? I think that would require some re-engineering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:35:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:35:33 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144829|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:38:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:38:24 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #8 from Martin Renvoize --- OK, So Kyle suggests we can/should remove the debarred and debarredcomment fields from the borrowers table. We do however return a restricted boolean field in the current API.. I think it makes a fair bit of sense to continue to return this piece of primary information about the borrower there.. but it opens up the question.. should we actually remove the field from the table now and thus require a join for API queries or should I go ahead of convert the current date field to a proper boolean that's maintained by add_restriction and friends? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:40:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:40:14 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:41:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:41:00 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind --- The patch now no longer applies 8-(... Applying: Bug 32523: Links to missing fields in MARC-editor error Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32523: Links to missing fields in MARC-editor error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:41:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:41:17 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #8) > OK, So Kyle suggests we can/should remove the debarred and debarredcomment > fields from the borrowers table. > > We do however return a restricted boolean field in the current API.. I think > it makes a fair bit of sense to continue to return this piece of primary > information about the borrower there.. but it opens up the question.. should > we actually remove the field from the table now and thus require a join for > API queries or should I go ahead of convert the current date field to a > proper boolean that's maintained by add_restriction and friends? I did it a boolean so we can remove those heh. The idea is that we would just embed the restriction objects, each of which should include its own information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:53:31 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:53:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:53:34 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144973|0 |1 is obsolete| | Attachment #144975|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 144984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144984&action=edit Bug 32561: Prevent worker to run with unecessary modules in memory Regression of bug 28413, bug 30410 added a "use Koha::Plugins" statement at the top of Koha::BackgroundJob, and so all Koha module are loaded by the worker on startup. See bug 28413 for more info Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:53:45 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #5 from Kyle M Hall --- Created attachment 144985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144985&action=edit Bug 32561: Add test This test does not seem reliable enough, how could we improve it? I guess it will fail randomly, especially if ran in parallel with other processes/tests. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:53:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:53:49 +0000 Subject: [Koha-bugs] [Bug 32561] background job worker is still running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32561 --- Comment #6 from Kyle M Hall --- Created attachment 144986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144986&action=edit Bug 32561: Test loaded modules for background_jobs_worker.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:21 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:27 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144542|0 |1 is obsolete| | --- Comment #25 from David Nind --- Created attachment 144987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144987&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:32 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144926|0 |1 is obsolete| | --- Comment #26 from David Nind --- Created attachment 144988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144988&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:38 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144927|0 |1 is obsolete| | --- Comment #27 from David Nind --- Created attachment 144989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144989&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:43 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144928|0 |1 is obsolete| | --- Comment #28 from David Nind --- Created attachment 144990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144990&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:49 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144929|0 |1 is obsolete| | --- Comment #29 from David Nind --- Created attachment 144991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144991&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:57:55 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144930|0 |1 is obsolete| | --- Comment #30 from David Nind --- Created attachment 144992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144992&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:58:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:58:00 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144971|0 |1 is obsolete| | --- Comment #31 from David Nind --- Created attachment 144993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144993&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 11:58:06 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144978|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 144994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144994&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:04:44 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from David Nind --- Must have been something with my setup, now applies! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:07:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:07:38 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141859|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 144995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144995&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:07:43 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141860|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 144996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144996&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:07:48 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141861|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 144997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144997&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:07:53 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141862|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 144998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144998&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:07:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:07:58 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143173|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 144999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144999&action=edit Bug 30310: Add missing utc plugin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:08:03 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144948|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 145000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145000&action=edit Bug 30310: Replace one more occurrence to moment Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:08:08 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144950|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 145001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145001&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:08:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:08:58 +0000 Subject: [Koha-bugs] [Bug 32562] New: Reindent the about page template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Bug ID: 32562 Summary: Reindent the about page template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I would like to reformat the about page template (about.tt) in the staff interface so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:13:33 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #10 from David Nind --- Created attachment 145002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145002&action=edit Bug 32523: Links to missing fields in MARC-editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl? frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:17:06 +0000 Subject: [Koha-bugs] [Bug 32563] New: Reservedate becomes expirationdate in some cases Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 Bug ID: 32563 Summary: Reservedate becomes expirationdate in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: slavashishkin at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Database fields DATE/DATETIME/TIMESTAMP in DBIX-Class are automatically available as DateTime objects that we can perform operations on (for example add an interval). But there is a feature: addition or subtraction operations (->add in this case) change the main object in-place and return the new value as the result of the expression. Because of this feature, due to the fact that the address to ->reserve date was passed to the ->add function, ->reservedate itself was changed, and then the result was assigned to ->expirationdate. This implicit feature resulted in an error when both dates after the given operation were the same in the future. Solution: To not change the original DateTime object, it must be cloned: https://metacpan.org/pod/DateTime#$dt-%3Eclone , accordingly, the changes will be made in a temporary copy, and a new value will be assigned to expirationdate, and the original reservedate will not change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:19:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:19:14 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:19:18 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 --- Comment #1 from Slava Shishkin --- Created attachment 145003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145003&action=edit Bug 32563: HOTFIX: reservedate becomes expirationdate in some cases To reproduce: 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=DefaultHoldExpirationdate 2. Setup default expiration date to be 1 year from reserve date for example. 3. Switch to catalog to any biblio with item for example /cgi-bin/koha/catalogue/detail.pl?biblionumber=1 and place a hold for any borrower. 4. Check holds for this item, as by example /cgi-bin/koha/reserve/request.pl?biblionumber=1 5. Observe the field "Date" contains the same date as the "Expiration" which is wrong and both contains date 1 year in the future. "Date" should have a date the reservation made, i.e. now. 6. Apply the patch. 7. Make another hold, i.e. repeat steps 3-5 8. Observe the field "Date" contains correct date (today) but the "Expiration" date is 1 year in the future as set is step 2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:22 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144987|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 145004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145004&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:28 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144988|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 145005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145005&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:32 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144989|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 145006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145006&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:37 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144990|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 145007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145007&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:43 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144991|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 145008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145008&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:49 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144992|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 145009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145009&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:54 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144993|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 145010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145010&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:28:59 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144994|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 145011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145011&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:29:40 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #41 from Martin Renvoize --- Nice cleanup here Jonathan. All working as expected, no regressions found in testing. QA scripts happy too.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:40:37 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145002|0 |1 is obsolete| | --- Comment #11 from David Nind --- Comment on attachment 145002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145002 Bug 32523: Links to missing fields in MARC-editor error I've obsoleted my sign off - something weird going on with unicode errors when trying to sign off - possibly caused by the subject line: Subject: [PATCH] =?UTF-8?q?Bug=C2=A032523:=20Links=20to=20missing=20fields?= =?UTF-8?q?=20in=20MARC-editor=20error?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I don't know how to fix... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:47:44 +0000 Subject: [Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458 --- Comment #10 from Katrin Fischer --- We might need to put a warning again in any reports using these fields so people can see that they need to fix on update (I think we did this before with biblio_metadata)? Also: will the patron import change? People possibly rely on being able to set debarments on import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 13:54:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 12:54:24 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #10 from Jonathan Druart --- Ideally we could have use 'type' (https://datatables.net/reference/option/columns.type) with type=date. What I've tried first. But it got removed by DT because it's not useful when server-side processing is used: """Please note that if you are using server-side processing (serverSide) this option has no effect since the ordering and search actions are performed by a server-side script.)""" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:07:27 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:11:06 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #12 from Jan Kissig --- Created attachment 145012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145012&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:11:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:11:51 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144976|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:13:27 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145012|0 |1 is obsolete| | --- Comment #13 from Jan Kissig --- Created attachment 145013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145013&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:17:48 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #14 from Jan Kissig --- I am sorry for spamming that bug page. @David you were right, the subject was in case the problem. I created the commit message inside visual studio and it seems like this caused the strange formatted subject, which then caused git bz -e to fail. I marked the first attachment as obsolete and was able to submit again, but now with correct subject line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:32 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145004|0 |1 is obsolete| | --- Comment #42 from Nick Clemens --- Created attachment 145014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145014&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:37 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145005|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 145015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145015&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:42 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145006|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 145016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145016&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:47 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145007|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 145017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145017&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:52 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145008|0 |1 is obsolete| | --- Comment #46 from Nick Clemens --- Created attachment 145018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145018&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:44:56 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145009|0 |1 is obsolete| | --- Comment #47 from Nick Clemens --- Created attachment 145019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145019&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:45:01 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145010|0 |1 is obsolete| | --- Comment #48 from Nick Clemens --- Created attachment 145020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145020&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 14:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 13:45:07 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145011|0 |1 is obsolete| | --- Comment #49 from Nick Clemens --- Created attachment 145021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145021&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:08:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:08:47 +0000 Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Jan Kissig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek at th-wildau.de --- Comment #4 from Jan Kissig --- Great that this route is going to be implemented in core. There is plugin available at https://github.com/NatLibFi/koha-plugin-rest-biblios. I found that if MARCOverlayRules are used, f.e. protect field 100 from being overwritten, the field is overwritten if api is used. Can you verify this? A modified test plan would be 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Add Marc overlay rule in administration / MARC overlay rules module = source filter = * tag = 001 preset = protect 4. Set MARCOverlayRules to Use in system prefs 5. Pick a biblio to modify, and modify it's marc record especially field 001 6. Make a PUT request to /api/v1/biblios/:biblionumber with one of the following content type header - application/marcxml+xml - application/marc-in-json - application/marc 7. Add the following header in the request 'x-framework-id: ' 8. Check that the biblio was modified but not field 001 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:11:03 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #68 from Katrin Fischer --- (In reply to Heather from comment #65) > Created attachment 144456 [details] > Search results in OPAC without "In..." appearing > > In step 14 in the test plan, I expected to see "In..." appearing in the > search results for this record here in the OPAC, as I did in the staff > client, but I don't see it there. The test plan implies that I should? Hi Heather, I see the In: in your screenshot right below the title. Can you confirm maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:16:00 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:30:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:30:07 +0000 Subject: [Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #13 from Jonathan Druart --- Owen, what's your opinion on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:34:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:34:21 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:34:26 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144566|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 145022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145022&action=edit Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:34:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:34:31 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 --- Comment #12 from Jonathan Druart --- Created attachment 145023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145023&action=edit Bug 32349: Remove find-nonutf8 tests We don't run it and it does not seem very useful. Let's remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:34:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:34:53 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 --- Comment #13 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > Not good enough for me :) Oops, indeed! I decided to remove it, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:48:21 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144804|0 |1 is obsolete| | --- Comment #6 from David Gustafsson --- Created attachment 145024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145024&action=edit Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/api/v1/return_claims.t t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Reserves.t t/db_dependent/HoldsQueue.t t/db_dependent/selenium/regressions.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Plugins/Recall_hooks.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Circulation/_CalculateAndUpdateFine.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 14:49:31 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:02:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:02:40 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |CLOSED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/605 --- Comment #86 from Aude Charillon --- Manual updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:02:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:02:41 +0000 Subject: [Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Bug 17436 depends on bug 23838, which changed state. Bug 23838 Summary: Add ability to view item renew history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:05:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:05:06 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #7 from Jonathan Druart --- I like the idea, but the patch contains unrelated changes that may slow down its integration. For instance: - C4::Circulation::ReturnLostItem( $self->borrowernumber, - $debit->itemnumber ); + C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber ); In Koha::Hold::cancel - my ( undef, $next_hold ) = C4::Reserves::CheckReserves( $self->itemnumber ); + my ( undef, $next_hold ) = CheckReserves( $self->item ); I am suspecting this last one will explode, CheckReserves is not imported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:14:12 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #8 from Jonathan Druart --- As well as: * unrelated change: item_issued_to_other_patron * - my $issue = AddIssue( $patron_borrower->unblessed, $item_1->barcode); + my $issue = AddIssue( $patron->unblessed, $item_1->barcode); + my $issue = AddIssue( $renewing_borrower_obj->unblessed, $item_to_auto_renew->barcode, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } ); And other AddIssue calls. Should not unbless here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:14:47 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #9 from Jonathan Druart --- Sorry those 2 last comments were for the first patch of bug 31735. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:18:22 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #10 from Jonathan Druart --- And, sorry again. I actually mixed the 2 reviews, I had the patches from the 2 bugs applied, reviewed 31735 and compared with the code with both applied. The missing unblessed calls comment is not relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:28:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:28:33 +0000 Subject: [Koha-bugs] [Bug 32564] New: ILL request detail page has some style issues with new staff interface design Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 Bug ID: 32564 Summary: ILL request detail page has some style issues with new staff interface design Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 I see some stranger style issues in the ILL request detail page with the new staff interface design. To name some: * The page sections have alight blue background and when you hover over the section, the background turns light green * There are light green borders around the elements * There is a line below the section headings Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:28:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:28:33 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 [Bug 32564] ILL request detail page has some style issues with new staff interface design -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:28:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:28:55 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 --- Comment #51 from David Gustafsson --- Koha testing docker is really not working all that well for me, it keeps crashing erratically, some times starts up successfully, very often crashes for a host of different reasons. Thus it's very hard for me to currently judge if there are more tests then those listed affected by the changes. Feel free to run the test suite with and without the patch set, for me it seems to fail at various points in both cases, but it's possible the reason is my ktd-environment is screwed up someway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:29:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:29:19 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #69 from Heather --- Ah, Katrin--yes! Thank you! It *is* there right below the title and authors, but shouldn't it be near the "Online access..." at the bottom of the display, like in the staff client? I don't think users will look for it or notice it if it's near the title/authors--they are going to be looking near "Online access..." and "Availability..." as I did. I confess that I completely missed seeing it tucked under the authors, and I was looking for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:30:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:30:58 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > (In reply to Jonathan Druart from comment #8) > > The first argument could be the memory footprint, but with bug 28413 it > > should not be a problem. > > And just noticed that it's broken, see bug 32561. I had another thought triggered by bug 32561. Your solution on that bug only keeps the memory footprint down until the first time that the require for Koha::Plugins is evaluated. At that time the memory usage will jump back up and remain there. With this patch, those inflated processes will go away after processing that job. I think both techniques should be implemented for maximum flexibility. For example, someone may want to deploy a fast queue with 20 max processes, and a slow queue with 10 max processes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:31:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:31:33 +0000 Subject: [Koha-bugs] [Bug 32495] Required fields in API and UI form don't match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495 --- Comment #1 from Jonathan Druart --- Jonathan, what's correct here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:32:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:32:05 +0000 Subject: [Koha-bugs] [Bug 32565] New: Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Bug ID: 32565 Summary: Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If HoldsQueueSkipClosed is enabled and a hold is placed on a day when all libraries are closed (e.g. a holiday), that hold doesn't get added to any holds queue, because there are no valid queues to add it to at the time. This did not matter with the build-holds-queue cronjob, because the job would just add it to the queue later; however, if RealTimeHoldsQueue is also enabled, that hold will not get added to the holds queue when the libraries reopen unless something triggers a holds queue update on that biblio record, potentially leading to holds stuck in limbo. The exception is a hold that has copies available at the pickup location - those types of holds will still get added to the holds queue even if all libraries are closed. To recreate: 1. Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to satisfy holds from libraries only when they are open 2. Add a holiday to the calendar for all libraries for today 3. Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies 4. Verify that that hold got added to the holds queue 5. Place a bilbio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location 6. Verify that that hold was not added to any holds queue 7. Remove the holiday (or wait for the next day) and verify that the hold from step 5 is still not on the holds queue This could be solved by adding a check to the real-time holds queue to check whether all libraries are closed, and ignore HoldsQueueSkipClosed when that is the case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:32:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:32:23 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #12 from Kyle M Hall --- (In reply to Kyle M Hall from comment #11) > (In reply to Jonathan Druart from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > The first argument could be the memory footprint, but with bug 28413 it > > > should not be a problem. > > > > And just noticed that it's broken, see bug 32561. > > I had another thought triggered by bug 32561. Your solution on that bug only > keeps the memory footprint down until the first time that the require for > Koha::Plugins is evaluated. At that time the memory usage will jump back up > and remain there. With this patch, those inflated processes will go away > after processing that job. I think both techniques should be implemented for > maximum flexibility. For example, someone may want to deploy a fast queue > with 20 max processes, and a slow queue with 10 max processes. Just remembered that the process forks, so I think my memory concern is invalid. I do think the rest of my comment stands though ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:34:51 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #3 from Galen Charlton --- This could do it in-place: ALTER TABLE borrower_message_transport_preferences DROP FOREIGN KEY borrower_message_transport_preferences_ibfk_1; ALTER TABLE borrower_message_preferences0 MODIFY borrower_message_preference_id bigint(11) UNSIGNED NOT NULL AUTO_INCREMENT; ALTER TABLE borrower_message_transport_preferences MODIFY borrower_message_preference_id bigint(11) UNSIGNED NOT NULL DEFAULT 0; ALTER TABLE borrower_message_transport_preferences ADD CONSTRAINT borrower_message_transport_preferences_ibfk_1 FOREIGN KEY (`borrower_message_preference_id`) REFERENCES `borrower_message_preferences` (`borrower_message_preference_id`) ON DELETE CASCADE ON UPDATE CASCADE; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:38:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:38:27 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #4 from Galen Charlton --- Whoops, syntax error. I meant: ALTER TABLE borrower_message_transport_preferences DROP FOREIGN KEY borrower_message_transport_preferences_ibfk_1; ALTER TABLE borrower_message_preferences MODIFY borrower_message_preference_id bigint(11) UNSIGNED NOT NULL AUTO_INCREMENT; ALTER TABLE borrower_message_transport_preferences MODIFY borrower_message_preference_id bigint(11) UNSIGNED NOT NULL DEFAULT 0; ALTER TABLE borrower_message_transport_preferences ADD CONSTRAINT borrower_message_transport_preferences_ibfk_1 FOREIGN KEY (`borrower_message_preference_id`) REFERENCES `borrower_message_preferences` (`borrower_message_preference_id`) ON DELETE CASCADE ON UPDATE CASCADE; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:38:37 +0000 Subject: [Koha-bugs] [Bug 32566] New: Show show 'ILL request logs' button, when IllLog is turned off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566 Bug ID: 32566 Summary: Show show 'ILL request logs' button, when IllLog is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de When the IllLog system preference is turned off, the 'ILL request log' will always be empty. We should not show the button when the system preference is turned off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:44:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:44:17 +0000 Subject: [Koha-bugs] [Bug 32495] Required fields in API and UI form don't match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495 --- Comment #2 from Jonathan Field --- I would say that the Description could definitely be an optional field (in UI and therefore API). In fact, is_perpetual could also be deemed not required. It is in the UI right now as it's a Yes/No option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:50:11 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #5 from Galen Charlton --- By the way, I wonder if the error 150 you're seeing isn't about borrower_message_preference_id but rather one of the three foreign key contraints on borrower_message_preferences (i.e., borrowernumber, message_attribute_id, or categorycode). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:57:13 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #6 from Galen Charlton --- As a side note, I ran across this query that identifies cases where an auto_increment column is at risk of hitting its maximum value: SELECT c.TABLE_CATALOG, c.TABLE_SCHEMA, c.TABLE_NAME, c.COLUMN_NAME FROM information_schema.COLUMNS AS c JOIN information_schema.TABLES AS t USING (TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME) WHERE c.EXTRA LIKE '%auto_increment%' AND t.AUTO_INCREMENT / CASE c.DATA_TYPE WHEN 'TINYINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 255, 127) WHEN 'SMALLINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 65535, 32767) WHEN 'MEDIUMINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 16777215, 8388607) WHEN 'INT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', 4294967295, 2147483647) WHEN 'BIGINT' THEN IF(c.COLUMN_TYPE LIKE '% UNSIGNED', '18446744073709551615', 9223372036854775807) # need to quote because column type defaults to unsigned. ELSE 0 END > .9; # 10% buffer Source: https://stackoverflow.com/a/45171880 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:57:22 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:57:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:57:26 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144521|0 |1 is obsolete| | Attachment #144522|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 145025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145025&action=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping

tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 15:57:31 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #9 from Jonathan Druart --- Created attachment 145026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145026&action=edit Bug 31935: (follow-up) Make form look better Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:09:03 +0000 Subject: [Koha-bugs] [Bug 32567] New: Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Bug ID: 32567 Summary: Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Update value builder for unimarc_field_110 with some values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:09:10 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:11:27 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145024|0 |1 is obsolete| | --- Comment #11 from David Gustafsson --- Created attachment 145027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145027&action=edit Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm Refactor the most performance critical subroutines in Circulation.pm to take objects instead of unblessed ones to reduce unnecessary unblessings and generally clean up the code. To test: 1) Ensure the following tests all pass: t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/ILSDI_Services.t t/db_dependent/Illrequests.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/api/v1/return_claims.t t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Reserves.t t/db_dependent/HoldsQueue.t t/db_dependent/selenium/regressions.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Plugins/Recall_hooks.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Circulation/_CalculateAndUpdateFine.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:12:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:12:47 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144801|0 |1 is obsolete| | --- Comment #52 from David Gustafsson --- Created attachment 145028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145028&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:12:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:12:51 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144802|0 |1 is obsolete| | --- Comment #53 from David Gustafsson --- Created attachment 145029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145029&action=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:12:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:12:56 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144803|0 |1 is obsolete| | --- Comment #54 from David Gustafsson --- Created attachment 145030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145030&action=edit Bug 31735: Fix array that should be passed as reference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:13:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:13:25 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:13:28 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 --- Comment #1 from Thibaud Guillot --- Created attachment 145031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145031&action=edit Bug 32567: Update unimarc_field_110.pl with some values 'Script of title' values => e - b/c/d/e/f/g/h i - d/e j - f/g l - f n - b/c o - a p - a 'Translitteral code' values => 'g' and 'h' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:16:07 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 --- Comment #2 from Thibaud Guillot --- I hope there is no translation error, if someone tells me I will correct it. I took the opportunity to reorder the different fields in alphabetical order, it is easier to find your way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:16:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:16:28 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Translitteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:30:23 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #12 from David Gustafsson --- Ok, thanks for spotting that. The changes pertaining to CheckReserves have not been moved to bug 31735. In Koha/Hold.pm now using the fully qualified sub name for CheckResvere, there is a use line for C4::Reserves that can probably be removed but keeping it not to cause further issue. For some reason imported subroutines seems not to work inside of object methods so you are probably right it would have crashed. Fixing the formatting of C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber ); feels like such a minor change that would hardly merit it's own bug report, also noticed the if above is also incorrectly formatted. I can revert this change though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:35:14 +0000 Subject: [Koha-bugs] [Bug 32568] New: Add page section to list of checkins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 Bug ID: 32568 Summary: Add page section to list of checkins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 30952 When you check in one or more items, the list of checkins is missing the page-section class that woudl give it a white background. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:35:14 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 [Bug 32568] Add page section to list of checkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:35:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:35:28 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145028|0 |1 is obsolete| | --- Comment #55 from David Gustafsson --- Created attachment 145032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145032&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:36:43 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145032|0 |1 is obsolete| | --- Comment #56 from David Gustafsson --- Created attachment 145033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145033&action=edit Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:36:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:36:48 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145029|0 |1 is obsolete| | --- Comment #57 from David Gustafsson --- Created attachment 145034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145034&action=edit Bug 31735: Optimize OPAC checkouts view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:36:53 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145030|0 |1 is obsolete| | --- Comment #58 from David Gustafsson --- Created attachment 145035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145035&action=edit Bug 31735: Fix array that should be passed as reference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:37:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:37:39 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #13 from Jonathan Druart --- (In reply to David Gustafsson from comment #12) > Fixing the formatting of > C4::Circulation::ReturnLostItem( $self->borrowernumber, > $debit->itemnumber ); > feels like such a minor change that would hardly merit it's own bug report, > also noticed the if above is also incorrectly formatted. I can revert this > change though. Actually it does not need to be fixed, it's the expected format. The line is longer than x (I guess 80 is the default) chars and so perltidy is splitting it into 2 lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:41:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:41:09 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #70 from Heather --- Hi, Victor! This is great--very helpful for a newbie! Thank you!! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:27 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/600 Documentation| |Caroline Cyr La Rose contact| | --- Comment #111 from Caroline Cyr La Rose --- Manual has been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:29 +0000 Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be cataloged in the cataloguing home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523 Bug 5523 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:29 +0000 Subject: [Koha-bugs] [Bug 31476] Add tool tips to the buttons on the circulation start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 Bug 31476 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:30 +0000 Subject: [Koha-bugs] [Bug 31477] Switch icon for inventory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 Bug 31477 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:30 +0000 Subject: [Koha-bugs] [Bug 31478] Standardize upload/download icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 Bug 31478 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:30 +0000 Subject: [Koha-bugs] [Bug 31844] Clarify cataloging permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31844 Bug 31844 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:31 +0000 Subject: [Koha-bugs] [Bug 31992] t::lib::Mocks::Zebra still using old stage for import page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Bug 31992 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:31 +0000 Subject: [Koha-bugs] [Bug 32062] Add import tool to Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32062 Bug 32062 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:45:32 +0000 Subject: [Koha-bugs] [Bug 31417] Re-instate the cataloguing sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31417 Bug 31417 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:54:46 +0000 Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 --- Comment #14 from David Gustafsson --- Ok, there are other lines exceeding that line number in that file, but should in that case I would have formatted it as C4::Circulation::ReturnLostItem( $self->borrowernumber, $debit->itemnumber ); Also realize there are formatting/style related changes left. Took the opportunity to fix a few of the most egregious ones while going the code as would never get around to beak out into separate issues. I know it's not best practice, but figured would not be to much of an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 16:58:08 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #71 from Heather --- Hi, Katrin-- I went through the test plan again: --I still think that the "In:..." link should be moved in the OPAC, down to the "Online access..." and "Availability..." area, as it is in the staff client. --I did this step: "15. Delete the 773$w and confirm host item info still shows correctly but no longer links to biblio" And the host item info does still show correctly, but the record does still link to the host biblio. It can be seen in my sandbox here: https://staff-bug16522.sandbox.bywatersolutions.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=16&searchid= Could this be because there is a subfield 0 (zero) in the 773 field ("Host biblionumber") which is not actually a valid MARC21 subfield? (c.f. https://www.loc.gov/marc/bibliographic/bd773.html) --Also, there is a subfield 9 in the 773 to "Host itemnumber," which is nonsense (according to this cataloger)--analytic relationships should only exist at the title level/biblionumber level. If you have variation in contents at the item level, the items should not be on the same biblio (says the cataloger). These are minor quibbles, but I think it would be best for them to be fixed before going into master: --Move the "In:..." in the OPAC near the "Online access..." and/or "Availability:..." so users are more likely to notice it. --Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773, but actually use the valid $w field to contain the biblionumber --Don't retain/have an invalid itemnumber in the 773 field, since it's unnecessary and nonsense for this type of relationship, and really use the 773$w. If these quibbles are too minor, no problem--of course, I rely on y'all's expertise for such decisions! It's a great development!! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:01:22 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #19 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > I think I recreate the problem this way: > > % more /etc/rabbitmq/rabbitmq.conf > consumer_timeout = 15000 > > Add a sleep 10 in Koha::BackgroundJob::BatchUpdateItem->process > > Then enqueue several batch item mod jobs. > > However: > 1. I don't see jobs stuck in "new" (without the patch) > > 2. I am seeing the following in the rabbitmq logs, with and without the patch > > 2023-01-04 11:01:03.041 [warning] <0.2774.0> Consumer > Q_/queue/koha_kohadev-long_tasks on channel 1 has timed out waiting on > consumer acknowledgement. Timeout used: 15000 ms > > 2023-01-04 11:01:03.041 [error] <0.2774.0> Channel error on connection > <0.2764.0> (127.0.0.1:39578 -> 127.0.0.1:61613, vhost: '/', user: 'guest'), > channel 1: > operation none caused a channel exception precondition_failed: consumer ack > timed out on channel 1 > > 2023-01-04 11:01:03.042 [error] <0.2758.0> STOMP error frame sent: > > Message: precondition_failed > Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" > Server private detail: none > 2023-01-04 11:01:03.042 [info] <0.2758.0> closing STOMP connection > <0.2758.0> (127.0.0.1:39578 -> 127.0.0.1:61613) I played with this a bunch, and things seem to sometimes recover and sometimes not Setting rabbitmq.conf with: consumer_timeout = 10000 Adding "sleep 1;" in the Koha/BackgroundJob/UpdateElasticIndex.pm sudo koha-mysql kohadev DELETE FROM biblio WHERE biblionumber=269; DELETE FROM biblio WHERE biblionumber=72; Set SearchEngine syspref to 'Elastic' perl misc/maintenance/touch_all_biblios.pl With or without patch, I get errors like: 2023-01-04 16:49:40.689 [warning] <0.7712.0> Consumer Q_/queue/koha_kohadev-default on channel 1 has timed out waiting on consumer acknowledgement. Timeout used: 10000 ms 2023-01-04 16:49:40.692 [error] <0.7712.0> Channel error on connection <0.7703.0> (127.0.0.1:60178 -> 127.0.0.1:61613, vhost: '/', user: 'guest'), channel 1: operation none caused a channel exception precondition_failed: consumer ack timed out on channel 1 2023-01-04 16:49:40.692 [error] <0.7700.0> STOMP error frame sent: Message: precondition_failed Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" Server private detail: none 2023-01-04 16:49:40.693 [info] <0.7700.0> closing STOMP connection <0.7700.0> (127.0.0.1:60178 -> 127.0.0.1:61613) 2023-01-04 16:49:41.224 [info] <0.14720.0> accepting STOMP connection <0.14720.0> (127.0.0.1:60376 -> 127.0.0.1:61613) 2023-01-04 16:49:41.235 [error] <0.14732.0> Channel error on connection <0.14723.0> (127.0.0.1:60376 -> 127.0.0.1:61613, vhost: '/', user: 'guest'), channel 1: operation basic.ack caused a channel exception precondition_failed: unknown delivery tag 245 2023-01-04 16:49:41.239 [error] <0.14720.0> STOMP error frame sent: Message: precondition_failed Detail: "PRECONDITION_FAILED - unknown delivery tag 245\n" Server private detail: none 2023-01-04 16:49:41.239 [info] <0.14720.0> closing STOMP connection <0.14720.0> (127.0.0.1:60376 -> 127.0.0.1:61613) 2023-01-04 16:49:42.477 [info] <0.14736.0> accepting STOMP connection <0.14736.0> (127.0.0.1:60388 -> 127.0.0.1:61613) And varied number of jobs that remain in new -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:37:24 +0000 Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- I think the solution to this one may be server configuration - there is a need to run the holds queue cron daily/nightly to check for holds that may not have had an open library when placed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:40:01 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 --- Comment #15 from David Gustafsson --- Sure, personally I don't see major issues using closures if resulting in less boiler plate and thus less error prone code. But using your suggestion allows for flexibility with regards to flushing cache on uncached calls, so I guess that could be a good thing. A downside is that it would lead to more convoluted code if wishing to cache methods with arguments. But perhaps in those cases caching should be handled manually anyways. I slightly modified your suggesting calling different methods instead of relying on arguments to dispatch to different behaviors (clearing/retrieving cache), but should otherwise be equivalent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:40:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:40:31 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144771|0 |1 is obsolete| | --- Comment #16 from David Gustafsson --- Created attachment 145036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145036&action=edit Bug 32476: Add caching for relatively expensive patron methods To test: 1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:41:32 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145036|0 |1 is obsolete| | --- Comment #17 from David Gustafsson --- Created attachment 145037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145037&action=edit Bug 32476: Add caching for relatively expensive patron methods To test: 1) Ensure tests in t/db_dependant/Koha/Patrons.t all pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:44:40 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:44:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:44:43 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 --- Comment #1 from Lucas Gass --- Created attachment 145038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145038&action=edit Bug 32568: Add page-section to checkedin table To test: 1. Apply patch 2. Checkin some items that are checked out/ 3. Make sure the page-section looks right. Note: There are some indentation changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:44:59 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:45:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:45:56 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the release notes| |page-section class to the | |checkedin table on the | |returns page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 17:54:07 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #6 from Katrin Fischer --- (In reply to PPLCS from comment #5) > We desperately need this fixed! Can you explain the problem a bit more as it manifests for you? Has this worked before? I am not aware of it, but not totally user as we had some changes to patron search recently. As I said the problem with comma is that it's not part of the data, it's not failing because of being a special character. If the comma was in your data, you should be able to search for it without issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:02:14 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update plugin |Update plugin |unimarc_field_110.pl |unimarc_field_110.pl |'Script of title' and |'Script of title' and |'Translitteration code' |'Transliteration code' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:04:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:04:31 +0000 Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #2 from Katrin Fischer --- Could the script be modified to only check for missing holds that haven't been allocated yet? Otherwise it will delete the whole table, mess with all the timestamps etc which would be a real set back now that we have RT. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:23:09 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #72 from Katrin Fischer --- > These are minor quibbles, but I think it would be best for them to be fixed > before going into master: > --Move the "In:..." in the OPAC near the "Online access..." and/or > "Availability:..." so users are more likely to notice it. This could be done, although I the current placement also makes sense to me. Having the article and journal information close together. But moving it would be more consistent with other pages, I understand that argument. > --Don't use an invalid 773 subfield 0 (zero) with a biblionumber in the 773, > but actually use the valid $w field to contain the biblionumber > --Don't retain/have an invalid itemnumber in the 773 field, since it's > unnecessary and nonsense for this type of relationship, and really use the > 773$w. This is out of scope here. I'll explain: These subfields are added because you used EasyAnalytics: _0163 _9354 When you remove to $w there is a fallback to the biblionumber in these subfields. But we didn't add that - it's always been in the XSLTs. We would break things for people using EasyAnalytics changing this behaviour. But I think we can assume that libraries using $w won't have EasyAnalytics turned on, they are known to be incompatible. Try cataloguing things manually with UseControlNumber activated and EasyAnalytics turned off, all should work as you expect it then with $w used. Make sure your host has a 001. Then from the detail page use New > New child record and it should create a nice standard 773 for you. I wrote an adapted test plan that should cover that if you ignore the first paragraph: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39 > If these quibbles are too minor, no problem--of course, I rely on y'all's > expertise for such decisions! It's a great development!! > --h2 Thanks for testing this - very happy to see it get attention! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:29:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:29:35 +0000 Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #3 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #2) > Could the script be modified to only check for missing holds that haven't > been allocated yet? Otherwise it will delete the whole table, mess with all > the timestamps etc which would be a real set back now that we have RT. I second this - in addition to the reasons Katrin mentioned, we've found (at least in testing) that the real-time holds queue also distributes the holds more equitably among our libraries than the cron job, so we'd like to preserve that! Running a modified holds queue cron would also be more in keeping with the goals of Bug 31995. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:38:37 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:38:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:38:42 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145013|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 145039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145039&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:40:15 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #16 from David Nind --- (In reply to Jan Kissig from comment #14) > I am sorry for spamming that bug page. > > @David you were right, the subject was in case the problem. > I created the commit message inside visual studio and it seems like this > caused the strange formatted subject, which then caused git bz -e to fail. > > I marked the first attachment as obsolete and was able to submit again, but > now with correct subject line. No problem Jan! Glad you were able to figure out how to fix it. Now signed off. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:41:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:41:54 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:41:58 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 --- Comment #1 from Lucas Gass --- Created attachment 145040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145040&action=edit Bug 32400: Add page-section to aqbudgetperiods table To test: 1. Apply patch 2. Go to Administration -> Budgets 3. Close a budget 4. Make sure the page-section looks right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:42:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:42:13 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:42:47 +0000 Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Assignee|koha-bugs at lists.koha-commun |bibliothek at th-wildau.de |ity.org | --- Comment #17 from David Nind --- I've changed the assignee to yourself, as well as changing the version to master (needs back porting to 22.11). Good luck with the QA! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:44:58 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:50:33 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the alignment of release notes| |the serials subscription | |form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:51:58 +0000 Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:57:44 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:57:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:57:48 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140432|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 145041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145041&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values https://bugs.koha-community.org/show_bug.cgi?id=31550 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:57:53 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144979|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 145042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145042&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 18:58:57 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #12 from David Nind --- (In reply to Thibaud Guillot from comment #9) > Now it will be better I think ;) Thanks for your feedback again Thanks Thibaud! Now signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:06:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:06:19 +0000 Subject: [Koha-bugs] [Bug 32491] Special characters causes patron search to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #7 from PPLCS --- Entering in "Doe, John" in the patron search field worked before the last Koha update. As a librarian I'm hardwired to type in last name first, comma, first name. So this is a real problem when looking up patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:08:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:08:10 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Summary|Special characters causes |Can no longer search |patron search to fail |patrons in format Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:08:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:08:23 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can no longer search |Can no longer search |patrons in format |patrons in format 'surname, | |firstname' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:22:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:22:02 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #13 from Kyle M Hall --- Created attachment 145043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145043&action=edit Bug 32558: (follow-up) Allow configuration of max processes via env or koha conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:40:05 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145038|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 145044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145044&action=edit Bug 32568: Add page-section to checkedin table To test: 1. Apply patch 2. Checkin some items that are checked out/ 3. Make sure the page-section looks right. Note: There are some indentation changes. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:40:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:40:18 +0000 Subject: [Koha-bugs] [Bug 32568] Add page section to list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32568 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:57:32 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145040|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 145045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145045&action=edit Bug 32400: Add page-section to aqbudgetperiods table To test: 1. Apply patch 2. Go to Administration -> Budgets 3. Close a budget 4. Make sure the page-section looks right. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:57:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:57:40 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:57:44 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 --- Comment #1 from Owen Leonard --- Created attachment 145046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145046&action=edit Bug 32654: Update ILL template markup to conform to Bootstrap panels The ILL request detail template uses Bootstrap panel markup that isn't quite correct. This patch changes the markup around the details and comments panels so that they look correct. To test you must have ILL enabled and have at least one request to view. - Apply the patch and go to ILL requests -> Manage request - The page should display with the "Request details" panel expanded by default. - Expanding and collapsing the "Request details" and "Comments" panels should work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:57:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:57:48 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:58:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:58:04 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #73 from Heather --- Thank you SO much for all of this, Katrin! I'm going to go ahead and sign off because everything you say makes a lot of sense. Also, I followed the adapted test plan here: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522#c39 I imported an analytic record and its parent/host record; the child was linked to the parent (with the generated search using the record number in the $w of the child record to the 001 of the parent record). I deleted the $w from the 773 and the child remained linked to the parent because Koha then used the data in the 773 $t of the child record which retrieved the data in the 245 $a of the parent record. It does this even with the syspref "UseControlNumber" set to "Use" and "EasyAnalyticalRecords" set to "Don't Show." Maybe it shouldn't do this, but I like it--I like the fact that there is a fallback behavior when there is no Control Number (i.e. no $w) to use for searching. (And I will keep arguing that the "In:..." in the OPAC should be moved down to be consistent with other displays, but more folks in the community like it up near the title and author(s), then I'll probably start arguing to move it up there in the staff client!) I think this is a GREAT development, not at all minor, and will be of service to many libraries in getting to their users articles, chapters, papers, songs...all those great things that analytic records are used for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:58:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:58:32 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:59:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 19:59:22 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142843|0 |1 is obsolete| | --- Comment #74 from ByWater Sandboxes --- Created attachment 145047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145047&action=edit Bug 16522: (follow-up) If no 773$w, try to return host record Use host biblionumber or host itemnumber to return a host record if EasyAnalyticalRecords is enabled, or return an undef record and a string of host information when get_marc_host is called in list context. Confirm tests pass: - t/db_dependent/Koha/Biblio/host_record.t Signed-off-by: Heather Hernandez -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 20:02:34 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal Component|Staff interface |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 20:32:17 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #6) > Has this worked before? Patron searching works correctly in 22.05 with the comma included, so this is a regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 20:33:12 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #9 from Katrin Fischer --- (In reply to Owen Leonard from comment #8) > (In reply to Katrin Fischer from comment #6) > > > Has this worked before? > > Patron searching works correctly in 22.05 with the comma included, so this > is a regression. Thx for confirming, I already marked it as such and added Joubu in CC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 21:40:17 +0000 Subject: [Koha-bugs] [Bug 32538] Biblionumber problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32538 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Owen Leonard --- Koha mailing list https://koha-community.org/support/koha-mailing-lists #koha IRC channel https://koha-community.org/get-involved/irc/ Koha documentation: https://koha-community.org/documentation/ Options for paid support: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:02:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:02:38 +0000 Subject: [Koha-bugs] [Bug 32569] New: CloneSubfield() and CloneField() function can result in duplicate ID's when using the upload cataloging plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32569 Bug ID: 32569 Summary: CloneSubfield() and CloneField() function can result in duplicate ID's when using the upload cataloging plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This problem was exposed when trying to clone 856 fields while using the upload.pl cataloging plugin. To recreate: 1. Edit a framework so that the 856$u uses the upload.pl plugin. 2. Go to a record within that framework using the basic editor. 3. Create and 856u, if you don't already have one. 4. Now try and clone the entire field. Look at the ID on the upload button, it beings with 'buttonDot_tag_856_subfield_u_' 5. Notice that the ID is the same as the one you cloned it from. Because of this you cannot use the 2nd 'upload link'. 6. Save you changes and exit the basic editor. 7. Go back into the editor and the new fields now have a different ID and the upload links work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:02:47 +0000 Subject: [Koha-bugs] [Bug 32569] CloneSubfield() and CloneField() function can result in duplicate ID's when using the upload cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32569 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:21:03 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:21:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:21:08 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144595|0 |1 is obsolete| | --- Comment #37 from Lucas Gass --- Created attachment 145048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145048&action=edit Bug 30624: Add loggedinlibrary permission and DB update To test: 1. Apply patch, updatedatabase, restart_all 2. Have a user with superlibrarian privileges ( User1 ) 3. Have a user who has staff access and circulate privileges but is not a super librarian. ( User2 ) Make note of this users home library 4. Turn on the system preference 'CircSidebar'. -MAIN log in ( auth.tt ) 5. As User1, go to the main login screen and try logging in. You should be able to log in AND you should be able to properly chnage your branch BEFORE logging in. 6. As User2, to to the main login screnn amd try logging in. You should be able to but if you try and switch your libraray to anything beside the user's home branch it will not work. You will be logged in at your home branch. 7. For User2, set the new top level permission 'Allow staff to change logged in library (loggedinlibrary). 8. Now you should be able to successfully switch libraries before log in. 9. Turn the 'loggedinlibrary' permission back off for User2. -AFTER log in- 10. With User1, click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 11. With User2, click on your name/branch in the top right. If you have 'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see nothing. 12. Repeat step 7. 13. NOw if you click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 14. Repeat Step 9. -CircSideBar- 15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup) with User1. You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 16. Try with User2 and you will not see a 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set desk' link. 17. Repeat step 7. 18. For with User2 you go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup). You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 19. Repeat step 9. -Set library page- 20. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will see a dropdown for 'Set library'. Make sure you can change your library successfully. 21. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should NOT see see a dropdown for 'Set library'. 22. Repeat step 7. 23. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you should see a dropdown for 'Set library'. Signed-off by: Bob Bennhoff/AspenCat Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:21:13 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144596|0 |1 is obsolete| | --- Comment #38 from Lucas Gass --- Created attachment 145049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145049&action=edit Bug 30624: Unit tests Signed-off by: Bob Bennhoff/AspenCat Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:22:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 22:22:09 +0000 Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:02:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:02:51 +0000 Subject: [Koha-bugs] [Bug 32570] New: City is duplicated in patron search if the patron has both city and state Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 Bug ID: 32570 Summary: City is duplicated in patron search if the patron has both city and state Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Have a patron with both a city and state in their Main address. 2. Do a patron search that will return that patron among others. 3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:04:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:04:12 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Severity|enhancement |normal Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:06:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:06:25 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:06:29 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 --- Comment #1 from Lucas Gass --- Created attachment 145050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145050&action=edit Bug 32570: Display patron.state correctly To test: 1. Have a patron with both a city and state in their Main address. 2. Do a patron search that will return that patron among others. 3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state. 4. Apply patch 5. Try step 2 again, this time the city, state should display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:22:30 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:22:35 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144980|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 145051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145051&action=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:22:40 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144981|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 145052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145052&action=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 00:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2023 23:22:44 +0000 Subject: [Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144982|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 145053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145053&action=edit Bug 32503: Use first cancellation for date ordering Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 02:14:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 01:14:17 +0000 Subject: [Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Wes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsmith at marshallcolibrary.or | |g --- Comment #3 from Wes --- I'm experiencing the same issue as Jason Robb. Works fine on moremember.pl but csrf_token is empty in the html on any of the other patron tab/pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 08:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 07:30:33 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #7 from Magnus Enger --- Thanks for your input, Galen! I found a way to make my quickfix work: - Dump the database - Edit the dumped database and fix CREATE TABLE statements for borrower_message_preferences.borrower_message_preference_id and borrower_message_transport_preferences.borrower_message_preference_id to make them BIGINT - Drop the Koha database - Create the Koha database - Load the database-dump back in The problem was that I was trying to run the dumped database against a non-empty database. Next question then is: Should we change the schema and run Galen's solution as part of an upgrade, or should we just document the quickfix for those that run into the problem? And/or change how these message preferences are handled? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:18:59 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #8 from Hans Pålsson --- If there is a solution i.e. use BIGINT instead of INT it is better to use it in the schema instead of letting users run in to problems and having to find this solution here. Good job everyone! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:27:43 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:27:47 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #10 from Jonathan Druart --- Created attachment 145054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145054&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:29:09 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:29:09 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 [Bug 32491] Can no longer search patrons in format 'surname, firstname' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 09:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 08:32:57 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #11 from Jonathan Druart --- (In reply to Owen Leonard from comment #8) > (In reply to Katrin Fischer from comment #6) > > > Has this worked before? > > Patron searching works correctly in 22.05 with the comma included, so this > is a regression. Hum I am expecting a regression caused by 30063 or 30093 and both are in 22.05 Also I see, in 22.05.x includes/patron-search.inc 314 let patterns = pattern.split(' ').filter(function(s){ return s.length }); I haven't tested though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 11:48:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 10:48:28 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:01:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:01:36 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:01:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:01:40 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 --- Comment #1 from Owen Leonard --- Created attachment 145055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145055&action=edit Bug 32562: Reindent the about page template This patch reindents the about page template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the about page. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:01:44 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 --- Comment #2 from Owen Leonard --- Created attachment 145056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145056&action=edit Bug 32562: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:10:45 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:10:49 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 --- Comment #2 from David Nind --- Created attachment 145057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145057&action=edit Bug 32564: Update ILL template markup to conform to Bootstrap panels The ILL request detail template uses Bootstrap panel markup that isn't quite correct. This patch changes the markup around the details and comments panels so that they look correct. To test you must have ILL enabled and have at least one request to view. - Apply the patch and go to ILL requests -> Manage request - The page should display with the "Request details" panel expanded by default. - Expanding and collapsing the "Request details" and "Comments" panels should work correctly. https://bugs.koha-community.org/show_bug.cgi?id=32564 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:13:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:13:35 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I amended the commit message to fix the bug title (should be Bug 32564: ....)/ 2. Enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:14:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:14:18 +0000 Subject: [Koha-bugs] [Bug 32564] ILL request detail page has some style issues with new staff interface design In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32564 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:18:51 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #50 from Tomás Cohen Arazi --- Thanks, Jonathan. This ended up being a nice cleanup along with the fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:32 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:35 +0000 Subject: [Koha-bugs] [Bug 31935] Serials subscription form is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:38 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:41 +0000 Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #51 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:45 +0000 Subject: [Koha-bugs] [Bug 32529] Holds in processing should block item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32529 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:49 +0000 Subject: [Koha-bugs] [Bug 32529] Holds in processing should block item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32529 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:51 +0000 Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:26:54 +0000 Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows non-archived suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 12:53:45 +0000 Subject: [Koha-bugs] [Bug 32571] New: Use template wrapper to build tabbed components Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Bug ID: 32571 Summary: Use template wrapper to build tabbed components Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, testopia at bugs.koha-community.org In preparation for an upgrade to Bootstrap 5 I propose that we try to abstract the way we build some components. This will help reduce the number of template changes required during the update. Using Template::Toolkit WRAPPERs we can create the structural components for tabs separately from the tab content: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels This can be done gradually before the Bootstrap upgrade without causing any disruption. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:10:05 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:10:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:10:10 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145054|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 145058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145058&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:12:40 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff Depends on| |32562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 [Bug 32562] Reindent the about page template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:12:40 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:12:43 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 --- Comment #1 from Owen Leonard --- Created attachment 145059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145059&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:12:48 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 --- Comment #2 from Owen Leonard --- Created attachment 145060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145060&action=edit Bug 32571: (follow-up) Implement abstracted tabs on About page This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:16:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:16:41 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #13 from David Nind --- Testing notes (using KTD): 1. For me, this fixes the search from the 'Search for patron' box on the patrons page 2. In the header search it continues to work, however I note that if you search for example for 'burton' then this gives you the autocomplete results. However, if you search for 'Burton,' it doesn't show in autocomplete (but does give you the correct result when you click the button to search). Searching for 'burton mary' will give you the autocomplete results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:18:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:18:03 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #14 from Jonathan Druart --- From https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed "You have to ACK messages in same order as they arrive to your system" If this is correct, forking is not an option here. I have not found something similar in rabbitmq doc however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:22:55 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:23:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:23:00 +0000 Subject: [Koha-bugs] [Bug 32570] City is duplicated in patron search if the patron has both city and state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32570 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145050|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 145061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145061&action=edit Bug 32570: Display patron.state correctly To test: 1. Have a patron with both a city and state in their Main address. 2. Do a patron search that will return that patron among others. 3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state. 4. Apply patch 5. Try step 2 again, this time the city, state should display correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:24:09 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Carolyn Hughesman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman at cclsny.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:44:56 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Jonathan Druart --- There are 2 ack sent, because of the fork I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:52:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:52:56 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32393 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:52:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:52:56 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:58:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 13:58:03 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #20 from Jonathan Druart --- > operation basic.ack caused a channel exception precondition_failed: unknown delivery tag 245 I think it's the fork, I removed it and it seems to be ok now. Could someone confirm? > Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" I am still seeing this after I removed the fork, which means this patch does not fix the timeout problem. I am also seeing this: ':' expected, at character offset 49 (before "CONNECTED\nserver") at /kohadevbox/koha/misc/background_jobs_worker.pl line 97. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:05:03 +0000 Subject: [Koha-bugs] [Bug 31488] Rephrase "You have checked out too many items" to be friendlier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31488 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |CLOSED CC| |aude.charillon at ptfs-europe. | |com --- Comment #8 from Aude Charillon --- Checked manual: no mention or screenshot of this particular message. No need to document. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:06:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:06:32 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #21 from Jonathan Druart --- There is something scary happening here. I've added 3 debug statements, one displays the frame, 2 others are before the process and ack calls. {"record_ids":[295],"record_server":"biblioserver","job_id":1824} at /kohadevbox/koha/misc/background_jobs_worker.pl line 97. Processing 1824 at /kohadevbox/koha/misc/background_jobs_worker.pl line 105. Acking 1824 at /kohadevbox/koha/misc/background_jobs_worker.pl line 107. {"record_ids":[296],"job_id":1825,"record_server"CONNECTED server at /kohadevbox/koha/misc/background_jobs_worker.pl line 97. ':' expected, at character offset 49 (before "CONNECTED\nserver") at /kohadevbox/koha/misc/background_jobs_worker.pl line 98. {"record_server":"biblioserver","job_id":1879,"record_ids":[350]} at /kohadevbox/koha/misc/background_jobs_worker.pl line 97. Processing 1879 at /kohadevbox/koha/misc/background_jobs_worker.pl line 105. Acking 1879 at /kohadevbox/koha/misc/background_jobs_worker.pl line 107. => Frame for job 1825 is incorrect (?!), and we are losing jobs 1826-1878. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:18:56 +0000 Subject: [Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from v1.19.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Resolution|--- |FIXED Status|Needs documenting |CLOSED --- Comment #7 from Aude Charillon --- No update to Koha manual needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:20:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:20:38 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #15 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > From > https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed > > "You have to ACK messages in same order as they arrive to your system" > > If this is correct, forking is not an option here. > > I have not found something similar in rabbitmq doc however. You are correct. I've been reading a lot about ACK messages, and we are using them wrong. ACK isn't suppose to indicate a process has completed. It's only meant to indicate the a message has been received. In fact, sending ACK messages appears to be optional. This is from the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- I will submit a following so that we ACK the message before forking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:22:41 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #16 from Kyle M Hall --- Created attachment 145062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145062&action=edit Bug 32558: (follow-up) Ack the stomp message before forking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:36:27 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED CC| |aude.charillon at ptfs-europe. | |com --- Comment #43 from Aude Charillon --- Re-opening to add Documentation status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:40:09 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119904|0 |1 is obsolete| | --- Comment #12 from Andrew Nugged --- Created attachment 145063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145063&action=edit Bug 27507: Specify organization code when searching host record This allows now importing records to Koha database from multiple different organizations and keeps the "In: XXX" links in the catalogue/detail.pl page unique. To test: 1) Add host record with 001 and 003 values of "1234" and "TEST" 2) Add host record with 001 and 003 values of "1234" and "TEST2" 2) Add component record with 773w value of (TEST)1234 3) Notice the link in the component record goes to search page with two results 4) Apply patch 5) Notice the link in the component record goes directly to the first host record created with 001 = 1234 and 003 = TEST 6) Test also that if you modify the 773w link with just the value of "1234" the search will still work and give you two results Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:41:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 14:41:51 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #13 from Andrew Nugged --- (this one above is just rebased on the current master, let's see what to do further, our productions use this feature because it is related to related records so it's needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:15:03 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:26:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:26:17 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #17 from Jonathan Druart --- This contradicts https://metacpan.org/pod/Net::Stomp#ack """ This acknowledges that you have received and processed a frame and all frames before it (if you are using client acknowledgements) """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:30:33 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs documenting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:32:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:32:28 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:33:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:33:03 +0000 Subject: [Koha-bugs] [Bug 32572] New: We should have a background queue for each job type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Bug ID: 32572 Summary: We should have a background queue for each job type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In production we are seeing that ES updates and real time holds queue can overwhelm the background worker and fall behind from "real time" If we had a dedicated worker for each of these jobs we could batch the operations, e.g. Fetch ES jobs until we hit 100 records or run out of queue, then index 100 at a time Indexing 1 record at a time takes a long time for each record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:34:24 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32572 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:34:24 +0000 Subject: [Koha-bugs] [Bug 32572] We should have a background queue for each job type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32558 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:39:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:39:30 +0000 Subject: [Koha-bugs] [Bug 29798] [DOCS] Improve explanation of Allow auto-renewal button in Patron edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29798 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/550 Keywords|Manual |Manual-updated Resolution|--- |FIXED --- Comment #1 from Aude Charillon --- Manual updated July 2022 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:40:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:40:06 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #8 from Jonathan Druart --- Created attachment 145064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145064&action=edit Bug 32393: Remove fork -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:40:09 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #22 from Jonathan Druart --- The best solution I found is the 2 patches from bug 32393. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 15:42:25 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #23 from Jonathan Druart --- (In reply to Jonathan Druart from comment #22) > The best solution I found is the 2 patches from bug 32393. But still not idea, I still get gaps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:21:20 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #18 from Kyle M Hall --- (In reply to Jonathan Druart from comment #17) > This contradicts https://metacpan.org/pod/Net::Stomp#ack > > """ > This acknowledges that you have received and processed a frame and all > frames before it (if you are using client acknowledgements) > """ That interpretation contradicts the STOMP protocol specification: https://stomp.github.io/stomp-specification-1.2.html#ACK I think the problem here lay in the vagueness of the phrase "processed a frame". That doesn't mean "completed a task". It simply means the frame was successfully read by the client, and that we were able to decode the data within it, and nothing more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:28:16 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:28:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:28:20 +0000 Subject: [Koha-bugs] [Bug 32567] Update plugin unimarc_field_110.pl 'Script of title' and 'Transliteration code' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32567 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145031|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 145065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145065&action=edit Bug 32567: Update unimarc_field_110.pl with some values 'Script of title' values => e - b/c/d/e/f/g/h i - d/e j - f/g l - f n - b/c o - a p - a 'Translitteral code' values => 'g' and 'h' Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:29:09 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:32:37 +0000 Subject: [Koha-bugs] [Bug 32573] New: background_jobs_worker.pl should ACK a message before it forks and runs the job Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Bug ID: 32573 Summary: background_jobs_worker.pl should ACK a message before it forks and runs the job Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Splitting off this functionality from bug 32558. This is the comment that started this discussion: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558#c15 >From the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- >From https://www.rabbitmq.com/stomp.html --- RabbitMQ STOMP plugin supports auto, client, and client-individual subscription headers that affect how ACK on NACK operations work. The auto mode uses automatic acknowledgements. The client mode is manual (client-driven) acknowledgements of multiple messages at once. The client-individual is for message-by-message manual acknowledgement. --- If ACK is meant to be sent post-work, why would automatic acknowledgement exist? The interpretation that an ACK is meant to be sent after handling the processing of a job doesn't make sense. In summary, we should be sending back ACK messages as soon as we've successfully processed ( e.g. read and decoded the data ) of a frame. Only then should we process it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:32:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:32:56 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32558 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:32:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:32:56 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32573 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:33:54 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #19 from Kyle M Hall --- (In reply to Kyle M Hall from comment #18) > (In reply to Jonathan Druart from comment #17) > > This contradicts https://metacpan.org/pod/Net::Stomp#ack > > > > """ > > This acknowledges that you have received and processed a frame and all > > frames before it (if you are using client acknowledgements) > > """ > > That interpretation contradicts the STOMP protocol specification: > https://stomp.github.io/stomp-specification-1.2.html#ACK > > I think the problem here lay in the vagueness of the phrase "processed a > frame". That doesn't mean "completed a task". It simply means the frame was > successfully read by the client, and that we were able to decode the data > within it, and nothing more. Moving this discussion and patch to Bug 32573 to avoid scope creep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:34:38 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:34:38 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:34:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:34:42 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:37:37 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:37:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:37:41 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #1 from Kyle M Hall --- Created attachment 145066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145066&action=edit Bug 32573: Send ACK message to RabbitMQ before handling the job Splitting off this functionality from bug 32558. This is the comment that started this discussion: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558#c15 >From the O'Reilly book Mobile and Web Messaging: --- By default, the STOMP broker will consider the message automatically acknowledged when it is delivered to the consumer. However, there are cases in which the consumer may prefer to explicitly acknowledge the message. It leaves a window of opportunity to determine whether it can handle the message or not. For example, the client needs to write the message payload in a data store. There may be issues with opening a connection to the data store and the client could choose to acknowledge the message only after having successfully written its body to the data store. In case of failure, it will instead nack the message (explicitly refuse to take ownership of it). When the STOMP broker is informed of this negative acknowledgment, it may then decide to deliver the message to another consumer subscribed to the destination or try again some time later depending on its configuration. --- >From https://www.rabbitmq.com/stomp.html --- RabbitMQ STOMP plugin supports auto, client, and client-individual subscription headers that affect how ACK on NACK operations work. The auto mode uses automatic acknowledgements. The client mode is manual (client-driven) acknowledgements of multiple messages at once. The client-individual is for message-by-message manual acknowledgement. --- If ACK is meant to be sent post-work, why would automatic acknowledgement exist? The interpretation that an ACK is meant to be sent after handling the processing of a job doesn't make sense. In summary, we should be sending back ACK messages as soon as we've successfully processed ( e.g. read and decoded the data ) of a frame. Only then should we process it. Test Plan: 1) Apply this patch 2) Launch background_jobs_worker.pl 3) Note no changes in background job processing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:40:09 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:40:53 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144960|0 |1 is obsolete| | Attachment #144961|0 |1 is obsolete| | Attachment #145043|0 |1 is obsolete| | Attachment #145062|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 145067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145067&action=edit Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs simultaneously up to a limit Right now background_jobs_worker.pl only processes jobs in serial. It would make sense to handle jobs in parallel up to a user definable limit. Test Plan: 1) Apply this patch 2) Stop background_jobs_worker.pl 3) Generate some background jobs by editing records, placing holds, etc 4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep background_jobs_worker.pl' 5) Run background_jobs_worker.pl with parameter -p 3 or some other number of max processes 6) Note the multiple forked processes in the ps output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:41:02 +0000 Subject: [Koha-bugs] [Bug 26482] Add macros ability to basic editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:41:57 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:43:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 16:43:19 +0000 Subject: [Koha-bugs] [Bug 32275] Fill blank record in basic editor using ISBN with Google Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 18:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 17:12:07 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 18:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 17:12:07 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 [Bug 27507] Search host record using control number identifier / organization code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 18:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 17:24:32 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 --- Comment #14 from Martin Renvoize --- Right.. so going back to this.. I still think this patch is incorrect in it's implementation.. the idea taken forward in bug 11175 was to pass a prebuild query to the xslt rather than constructing it again.. i.e DRY coding so we don't fall out of sync again.. https://git.koha-community.org/Koha-community/Koha/src/branch/master/opac/opac-detail.pl#L621 - We pass the query to the template here.. seems it's moved out of the XSLT entirely now.. I can't remember without digging how it all fits together now. But the point is.. we don't want the query to get out of sync between what's used server-side and what's displayed client-side. I also still think the query needs work as bug 29268 highlights. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:02:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:02:53 +0000 Subject: [Koha-bugs] [Bug 32574] New: memberresultst table cannot be column configured in 22.05.x Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Bug ID: 32574 Summary: memberresultst table cannot be column configured in 22.05.x Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com memberresultst needs to use TablesSettings.GetTableSettings but it is using TablesSettings.GetColumns so table settings don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:07:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:07:08 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:07:11 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 --- Comment #1 from Lucas Gass --- Created attachment 145068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145068&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:21:33 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:41:30 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:41:33 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145068|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 145069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145069&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:50:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:50:30 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes an issue with release notes| |configuring the columns for | |patron search results in | |Koha 22.05 - this should | |now work as expected. The | |columns are now | |configurable using the | |Columns button in the | |search results and in the | |table settings | |(Administration > | |Additional parameters > | |Table settings > Patrons > | |member > memberresultst). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:51:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:51:56 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 --- Comment #3 from Owen Leonard --- Created attachment 145070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145070&action=edit Bug 32507: (follow-up) Change parameter name to avoid collisions The variable name "active" is very likely to already be set for other reasons, so changing the parameter name to "bc_active" to avoid problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:54:18 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:54:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:54:22 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145055|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 145071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145071&action=edit Bug 32562: Reindent the about page template This patch reindents the about page template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the about page. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:54:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 18:54:25 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145056|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 145072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145072&action=edit Bug 32562: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 20:06:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 19:06:41 +0000 Subject: [Koha-bugs] [Bug 27314] Update default Elastic mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 20:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 19:17:08 +0000 Subject: [Koha-bugs] [Bug 32574] memberresultst table cannot be column configured in 22.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145069|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose --- Created attachment 145073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145073&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 20:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 19:22:37 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Created attachment 145064 [details] [review] > Bug 32393: Remove fork Just a thought; removing that fork will cause the workers memory footprint to balloon as soon as the plugins require is evaluated which obviates the bug patch where you introduce the require. I think this pushes us farther in the direction of needing to ack each request before handling the job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 20:33:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 19:33:06 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #14 from Esther Melander --- In regards to the wild card searches in the patron field, Should this be a separate ticket? Prior to our upgrade to 22.05, we could do searches like 2913*3456 and have it return results. After the upgrade this no longer works. The % wildcard appears to work in the search example above. However the % as a wildcard is odd when compared with how other search indexes work. Most major search engines use either an asterisk or a question mark. The same is true with searching indexes at Ancestry or Family Search. The asterisk replaces multiple characters and the question mark replaces a single character. Most of our staff is accustomed to using an asterisk and trying to adapt to a different nomenclature and keyboard position has proven difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 20:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 19:42:52 +0000 Subject: [Koha-bugs] [Bug 27314] Update default Elastic mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #3 from Sarah Cornell --- Created attachment 145074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145074&action=edit ES mappings that were not included in default setup but are used by OPAC searches I reviewed all the searches that our OPAC generates and made sure that the fields they used were indexed. I found MANY missing indexes. Some of the searches SEEMED okay but were not because one of the 3 fields used in the automatically generated search was missing. So no one has to go through it again I will share the indexes I've added in an attachment. NB: the search that the OPAC generates that might use the 775at is still under discussion. We're not sure which index is best when the search generated is ti,phr. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 22:13:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 21:13:13 +0000 Subject: [Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #4 from Michael Adamyk --- Confirmed, I'm experiencing this issue after the 22.05 upgrade also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 23:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 22:25:43 +0000 Subject: [Koha-bugs] [Bug 15491] Disable the ability to suspend holds related to certain itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15491 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #1 from Benjamin Daeuber --- How much does this development overlap with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 00:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 23:21:26 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 00:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 23:21:31 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145059|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 145075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145075&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 00:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 23:21:36 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145060|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 145076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145076&action=edit Bug 32571: (follow-up) Implement abstracted tabs on About page This patch implements the proposed system for building tabs on the About page. To test, apply the patch and view the About page. It should look the same as before and all tabs should function correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 00:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2023 23:22:30 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. Everything looks OK to me after applying the patches and viewing the About page tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:10:23 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #10 from Martin Renvoize --- I agree that removing the fork is a bad idea.. it was implimented for the reasoning Kyle suggests I believe.. to keep the memory footprint from balooning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:10:23 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:10:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:10:28 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #15 from Jonathan Druart --- Created attachment 145077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145077&action=edit Bug 32491: Split patron search terms on comma - autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:10:52 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #16 from Jonathan Druart --- (In reply to David Nind from comment #13) > 2. In the header search it continues to work, however I note that if you > search for example for 'burton' then this gives you the autocomplete > results. However, if you search for 'Burton,' it doesn't show in > autocomplete (but does give you the correct result when you click the button > to search). Searching for 'burton mary' will give you the autocomplete > results. Good catch, that should be fixed here I think. The last patch is fixing it. (In reply to Esther Melander from comment #14) > In regards to the wild card searches in the patron field, Should this be a > separate ticket? Yes, please open a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:11:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:11:23 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32370 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:11:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:11:23 +0000 Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32393 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:17:04 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #11 from Jonathan Druart --- I left the patch here yesterday after my day work. I was working on bug 32481, and thought that this first patch was a good base to work on. So far I am only trying to make things work correctly. IMO we should not add anything new to the worker, but focus on fixing its behaviours instead. >From bug 32481 comment 22 "The best solution I found is the 2 patches from bug 32393." I didn't want to add the patches there and add more confusion so just dropped them here. I still don't have anything good to suggest, and remove the fork is indeed a very bad idea. But fixing the worker's behaviour is a higher priority than memory footprint right now anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:25:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:25:56 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #2 from Jonathan Druart --- I've tried this when working on bug 32481 but it didn't help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:34:16 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #12 from Martin Renvoize --- There's scope creep here.. the try encompasses the process_job which means it's also catching all sorts of other possible failures from each and every processor that's written. I think we should limit the scope of this bug to only catch bad JSON encoding and leave error handling for individual tasks to the tasks themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 09:52:41 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #13 from Martin Renvoize --- Also.. if we do want to only acknowledge on process completion, should we not do it within the forked worker? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 11:40:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 10:40:50 +0000 Subject: [Koha-bugs] [Bug 32575] New: gather_print_notices.pl sends HTML file as body of email Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32575 Bug ID: 32575 Summary: gather_print_notices.pl sends HTML file as body of email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org gather_print_notices.pl can send print notices to the library, as an HTML file attached to an email. At least some libraries report that the HTML does not come as an attached file, but as the body of the email. This breaks printing the notices properly. I am not sure if this is a problem with the emails generated by gather_print_notices.pl or with the email clients (or other software) used by the libraries that have this problem. A quick solution has been to add some body text to the emails generated by gather_print_notices.pl: 299 my $email = Koha::Email->create( 300 { 301 from => $from, 302 to => $to, 303 subject => 'Print notices for ' . $today_syspref, 304 text_body => 'See attached file.', # <==== Added this 305 } 306 ); This seems to force the attachment to be seen as an attachment, and not as the body of the email. In the headers of the emails sent by the standard gather_print_notices.pl I have seen this: Content-Transfer-Encoding: base64 Content-Type: text/html; charset=iso-8859-1 PCFET0NU... [lots of base64] When I have added some body text it looks more like this: Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="16633311691.0Ab5.3555417" --16633311691.0Ab5.3555417 Date: Fri, 16 Sep 2022 14:26:09 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable See attached file. --16633311691.0Ab5.3555417 Date: Fri, 16 Sep 2022 14:26:09 +0200 MIME-Version: 1.0 Content-Type: text/html; name="notices_all-2022-09-16-KOHA.html" Content-Disposition: attachment; filename="notices_all-2022-09-16-KOHA.html" Content-Transfer-Encoding: base64 PCFET0... [lots of base64] So unless something is changed on the way from Koha to the mail client, it looks like gather_print_notices.pl sends the HTML from the document as the body of the email. Not sure if this is a problem in Koha::Email->create that should be fixed there, or if it makes sense to just add some default text to the email, to fix the problem in the least obtrusive way? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 11:05:04 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:05:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 11:05:10 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145058|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 145078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145078&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 11:05:15 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145077|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 145079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145079&action=edit Bug 32491: Split patron search terms on comma - autocomplete Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:48:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 12:48:49 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 12:55:33 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #14 from Jonathan Druart --- (In reply to Martin Renvoize from comment #12) > I think we should limit the scope of this bug to only catch bad JSON > encoding and leave error handling for individual tasks to the tasks > themselves. We should not trust the job and catch potential crashes IMO, to prevent a bad job to take the worker down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 13:52:10 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #2 from Matt Blenkinsop --- Created attachment 145080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145080&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subrout ine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 13:54:51 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #3 from Matt Blenkinsop --- Created attachment 145081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145081&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:55:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 13:55:20 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 13:58:53 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows a release notes| |user to select which debit | |types should be included in | |deciding whether a patron | |should be restricted from | |checkouts (noissuescharge | |system preference). Three | |existing system preferences | |have been deleted | |(ManInvInNoissuesCharge, | |RentalsInNoissuesCharge, | |HoldsInNoissuesCharge) and | |the management of the debit | |types now sits in the Debit | |Types area of system | |preferences. The user can | |edit each debit type and | |select whether it should be | |included in the | |noissuescharge calculation, | |giving users much more | |flexibility over | |restrictions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:00:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 14:00:31 +0000 Subject: [Koha-bugs] [Bug 32572] We should have a background queue for each job type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- (In reply to Nick Clemens from comment #0) > Fetch ES jobs until we hit 100 records or run out of queue, then index 100 > at a time > Indexing 1 record at a time takes a long time for each record Isn't the problem koha-side actually, where we should batch update the index instead of call index_records for each record? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:13:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 14:13:52 +0000 Subject: [Koha-bugs] [Bug 32572] We should have a background queue for each job type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 --- Comment #2 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > (In reply to Nick Clemens from comment #0) > > Fetch ES jobs until we hit 100 records or run out of queue, then index 100 > > at a time > > Indexing 1 record at a time takes a long time for each record > > Isn't the problem koha-side actually, where we should batch update the index > instead of call index_records for each record? The problem is not for a batch action, but for a series of individual actions i.e. 10 checkins happening one after another, then scale that to a site with 50 branches, all checking in their dropbox - 500 single index actions enqueued -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:48:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 14:48:52 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #24 from Jonathan Druart --- Created attachment 145082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145082&action=edit Test background jobs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 14:51:41 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 14:51:58 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #25 from Jonathan Druart --- I am giving up, need help. I wrote this script to help adjusting the worker code and see how things went. To test: Edit /etc/rabbitmq/rabbitmq.conf consumer_timeout = 10000 # Delete existing jobs - not needed but better to track down what's going on MariaDB [koha_kohadev]> delete from background_jobs; # Watch the logs % sudo tail -f /var/log/koha/kohadev/* /var/log/rabbitmq/*.log # Run the script % perl test_bg.pl Wait 100 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:04:40 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:04:45 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145078|0 |1 is obsolete| | Attachment #145079|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 145083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145083&action=edit Bug 32491: Split patron search terms on comma Previous behaviour allowed search 'surname, firstname'. We should remove the comma from the search terms. Test plan: On the main patron search, search for "surname, firstname" and confirm that with this patch applied the search returns the expected results. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:04:56 +0000 Subject: [Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #20 from Kyle M Hall --- Created attachment 145084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145084&action=edit Bug 32491: Split patron search terms on comma - autocomplete Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:12:17 +0000 Subject: [Koha-bugs] [Bug 32576] New: ILL needs the page-section treatment Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32576 Bug ID: 32576 Summary: ILL needs the page-section treatment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 31757 The ILL module is using panels when it should now use page-section cards instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:12:17 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32576 [Bug 32576] ILL needs the page-section treatment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:15:09 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:18:36 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:18:40 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:34:35 +0000 Subject: [Koha-bugs] [Bug 32576] ILL needs the page-section treatment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32576 --- Comment #1 from Martin Renvoize --- Created attachment 145085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145085&action=edit Bug 32576: Move page-section outside of table include This patch drops the superflous div from the ill-list-table include and instead opts to wrap calls to it with a more appropriately positioned div instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:34:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 15:34:39 +0000 Subject: [Koha-bugs] [Bug 32576] ILL needs the page-section treatment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32576 --- Comment #2 from Martin Renvoize --- Created attachment 145086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145086&action=edit Bug 32576: Replace panels with page-sections -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:07:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:07:59 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:08:03 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145075|0 |1 is obsolete| | Attachment #145076|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 145087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145087&action=edit Bug 32571: Use template wrapper to build tabbed components This patch adds Template::Toolkit WRAPPER blocks to html_helpers.inc so that templates can build tabbed components while keeping tab structural markup separate. Each individual component of a Bootstrap tabbed interface is defined: - Main tab container - Tab links container - Individual tab links - Tab panel container - Individual tab panels Included is a usage example: [ WRAPPER tabs id= "tabs container id" ] [ WRAPPER tabs_nav ] [ WRAPPER tab_item tabname= "tab name 1" ] [ content ] [ END ] [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] ... [ END ] [ WRAPPER tab_panels ] [ WRAPPER tab_panel id="tab name 1"] [ content ] [ END ] [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] ... [ END ] [ END ] Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:13:39 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:13:42 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145071|0 |1 is obsolete| | Attachment #145072|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 145088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145088&action=edit Bug 32562: Reindent the about page template This patch reindents the about page template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the about page. Everything should look normal. All tabs should work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:13:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:13:53 +0000 Subject: [Koha-bugs] [Bug 32562] Reindent the about page template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32562 --- Comment #6 from Kyle M Hall --- Created attachment 145089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145089&action=edit Bug 32562: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:15:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:15:33 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:15:36 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 16:19:51 +0000 Subject: [Koha-bugs] [Bug 32577] New: Transactions table overflows window-size Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32577 Bug ID: 32577 Summary: Transactions table overflows window-size Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: matt.blenkinsop at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Created attachment 145090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145090&action=edit Image of issue When a transaction is added to a patron's account the table overflows the div and is cut-off by the window size. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 18:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 17:07:28 +0000 Subject: [Koha-bugs] [Bug 32577] Transactions table overflows window-size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32577 --- Comment #1 from Matt Blenkinsop --- Created attachment 145091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145091&action=edit Bug 32577: Transaction table overflows div The transations table on a patron's account overflows the window and needs to be scrollable Test plan: 1) Add a fine to a patron 2) Navigate to that Patrons detail page and click on the accounting tab from the menu on the left 3) Observe that the table overflows the window as per the image attached to this bug 4) Apply patch 5) Repeat step 2 6) The table should now have a scrollbar and be contained within its div rather than overflowing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 18:08:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 17:08:45 +0000 Subject: [Koha-bugs] [Bug 32577] Transactions table overflows window-size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32577 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com Status|NEW |Needs Signoff --- Comment #2 from Matt Blenkinsop --- There will probably be other examples of this - maybe something needs to be done to the KohaTable wrapper to fix this universally...? I've opted for an overflow scroll here, feedback on other/preferred options is welcome -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 18:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 17:13:16 +0000 Subject: [Koha-bugs] [Bug 32578] New: Wildcard searches do not work with asterisk Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32578 Bug ID: 32578 Summary: Wildcard searches do not work with asterisk Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org This bug is split off from bug 32491 and this is what I reported there: Prior to our upgrade to 22.05, we could do searches like 2913*3456 and have it return results. After the upgrade this no longer works. The % wildcard appears to work in the search example above. However the % as a wildcard is odd when compared with how other search indexes work. Most major search engines use either an asterisk or a question mark. The same is true with searching indexes at Ancestry or Family Search. The asterisk replaces multiple characters and the question mark replaces a single character. Most of our staff is accustomed to using an asterisk and trying to adapt to a different nomenclature and keyboard position has proven difficult. Since the asterisk worked prior to 22.05, it would be nice to return that functionality. Also Lucas Gass reported: This also effects wildcard searches. Previously you could search for a cardnumber like '2913*' and that would return all patrons with cardnumbers starting with '2913'. Now it tries searching for the exact match '2352*' and returns nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 19:00:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 18:00:17 +0000 Subject: [Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in Table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504 --- Comment #8 from Lucas Gass --- Slava, Shouldn't we use bKohaColumnsUseNames here? Like we do on detail.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 19:15:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 18:15:07 +0000 Subject: [Koha-bugs] [Bug 32578] Wildcard searches do not work with asterisk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:17:48 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:17:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:17:52 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144954|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 145094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145094&action=edit Bug 32559: Add support for formatted date when filtering on a column When dates are displayed formatted (following the dateformat syspref) in a DataTable table and that there is a filter for the column, we should filter correctly the data. Test plan: Assuming dateformat is set to metric Go to the main patron search, search for all patrons (don't provide a search term) In the "date of birth" column filter, enter "1958", notice that you see Henry Search using an iso formatted date 1958-05-30 Search using a metric formatted date 30/05/1958 Note that: - it's also working for "Expires on" on the same table. We may want to adjust other tables that are using the DT REST API wrapper and the column filters - You need to search for the full formatted date to make it work. "30/05" won't work. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:18:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:18:07 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144977|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 145095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145095&action=edit Bug 32559: Add tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:20:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:20:59 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:21:04 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144937|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 145096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145096&action=edit Bug 32505: Restore patron search by formatted dob Prior to the rewrite of the patron searches (bug 30063 and friends) it was possible to search for a patron using their date of birth, formatted following the dateformat syspref. Now it only works if the date is iso formatted. This patch is providing a fix to restore the behaviour, but does not make it consistent. Only searching patrons by date of birth is fixed here, when we actually want to fix the problem for the REST API DT wrapper instead. Test plan: Search for patrons given their date of birth. You need to select "date of birth" in the "Search field" dropdown, or set it in DefaultPatronSearchFields. Note that the column filtering is still not working, but I guess it was the case already in older versions. Ideally we will need to have a "datatype" attribute passed to the the 'th' and retrieved from datatables.js to add this same trick and build the query appropriately. Signed-off-by: Lucas Gass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:27:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:27:35 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144995|0 |1 is obsolete| | Attachment #144996|0 |1 is obsolete| | Attachment #144997|0 |1 is obsolete| | Attachment #144998|0 |1 is obsolete| | Attachment #144999|0 |1 is obsolete| | Attachment #145000|0 |1 is obsolete| | Attachment #145001|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 145097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145097&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:38:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:38:38 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145097|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 145098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145098&action=edit Bug 30310: Add dayjs timezone plugin Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:38:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:38:49 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #48 from Kyle M Hall --- Created attachment 145099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145099&action=edit Bug 30310: Adjust js-date-format Test plan: Confirm that the test plan from bug 24455 is still passing Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:38:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:38:53 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #49 from Kyle M Hall --- Created attachment 145100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145100&action=edit Bug 30310: Remove momentjs Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:38:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:38:57 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #50 from Kyle M Hall --- Created attachment 145101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145101&action=edit Bug 30310: Adjust about page Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:39:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:39:02 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #51 from Kyle M Hall --- Created attachment 145102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145102&action=edit Bug 30310: Add missing utc plugin Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:39:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:39:07 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #52 from Kyle M Hall --- Created attachment 145103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145103&action=edit Bug 30310: Replace one more occurrence to moment Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 20:39:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 19:39:11 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 --- Comment #53 from Kyle M Hall --- Created attachment 145104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145104&action=edit Bug 30310: Fix date_to_rfc3339 We need the customParseFormat plugin to provide a custom date format to the dayjs constructor. Found while working on bug 32559, don't remove this function, it will be used later. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 21:29:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 20:29:45 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Standardize tooltips on |Add tooltip to 'configure' |datatable controls |on datatable controls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 21:41:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 20:41:06 +0000 Subject: [Koha-bugs] [Bug 32579] New: Staged MARC Record match details return title of matching biblionumber record when importing authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32579 Bug ID: 32579 Summary: Staged MARC Record match details return title of matching biblionumber record when importing authorities Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: alexis at flo.org QA Contact: testopia at bugs.koha-community.org Created attachment 145105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145105&action=edit screenshot of authority being staged. text is from biblionumber 407534, but link correctly goes to authid 407534. When importing a set of authorities, if a match is found, the match details will say "Matches bibliographic record xxyy (score:) (Title and author from bib)" where xxyy is the id of the matching authority record. The record being linked to is the matching authority, not the bib. When viewing diffs, the records being compared are correct (incoming authority record and existing authority record are compared), and if imported, the correct authority record is updated while the bib remains untouched. This seems to just be a display bug where the match details text pulls in the biblio data regardless of import record type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:04:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:04:29 +0000 Subject: [Koha-bugs] [Bug 32580] New: Background job cancel button broken, leads to bakcground_jobs.pl with a kc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Bug ID: 32580 Summary: Background job cancel button broken, leads to bakcground_jobs.pl with a kc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: phil at chetcolibrary.org QA Contact: testopia at bugs.koha-community.org Depends on: 30982 Regression from bug 30982 which typoed background_jobs.pl as bakcground_jobs.pl - if you try to cancel a background job, you get a 404 error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 [Bug 30982] Use the REST API for background job list view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:04:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:04:29 +0000 Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 [Bug 32580] Background job cancel button broken, leads to bakcground_jobs.pl with a kc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:07:21 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:07:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:07:25 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 --- Comment #1 from Katrin Fischer --- Created attachment 145106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145106&action=edit Bug 31962: Add tooltip to 'configure' on datatable controls This makes sure that the last button on the datatable controls also has a tooltip, like the other buttons. To test: * Without the patch: * Check out an item and look at the table of checkouts * Look at the detail page of a record with at least one item * Confirm that the 'configure' button doesn't have a tooltip appear as a bubble like the other buttons * Apply patch * Restart_all and reload pages * Make sure the styling of the 'configure' tooltip now matches that of the other buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:07:40 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:18:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:18:42 +0000 Subject: [Koha-bugs] [Bug 32581] New: Update dateexpiry on categorycode change Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32581 Bug ID: 32581 Summary: Update dateexpiry on categorycode change Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you change a patron's category code, nothing checks whether their existing dateexpiry is valid for their category. An immediate renewal will correct this, but without that step, you could have someone move from a category with longer enrollment into a shorter enrollment period without anything prompting a check if that dateexpiry is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:26:34 +0000 Subject: [Koha-bugs] [Bug 32582] New: Mailmap maps to wrong email address Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32582 Bug ID: 32582 Summary: Mailmap maps to wrong email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:28:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:28:35 +0000 Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144107|0 |1 is obsolete| | CC| |michael.hafen at washk12.org --- Comment #6 from Michael Hafen --- Created attachment 145107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145107&action=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed [Rebase 2023-01-06] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:28:49 +0000 Subject: [Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:32:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:32:55 +0000 Subject: [Koha-bugs] [Bug 32582] Mailmap maps to wrong email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:32:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:32:58 +0000 Subject: [Koha-bugs] [Bug 32582] Mailmap maps to wrong email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32582 --- Comment #1 from Katrin Fischer --- Created attachment 145108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145108&action=edit Bug 32582: Fix error in .mailmap The .mailmap had the addresses in the wrong sequence. The .83 address is actually the correct one. How this works is easiest to see in git: * Apply one of my patches, like bug 31962 * Do a git log * You'll see the email address without .83 as author * Apply this patch * You should see the correct email now in both, matching the one in the patch file on bugzilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:39:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:39:28 +0000 Subject: [Koha-bugs] [Bug 31659] Add SMSAlertNumber to options in borrowers.primary_contact_method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31659 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com --- Comment #1 from hebah at bywatersolutions.com --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:40:25 +0000 Subject: [Koha-bugs] [Bug 32583] New: Restore display of only one item in catalogue/moredetails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Bug ID: 32583 Summary: Restore display of only one item in catalogue/moredetails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:41:30 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Background job cancel |Background job cancel |button broken, leads to |button broken, leads to |bakcground_jobs.pl with a |background_jobs.pl with a |kc |kc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:45:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:45:43 +0000 Subject: [Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | --- Comment #1 from Michael Hafen --- Created attachment 145109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145109&action=edit Bug 32583 - Restore display of only one item in catalogue/moredetails Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:49:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:49:10 +0000 Subject: [Koha-bugs] [Bug 32517] Patron search dies on case mismatch of patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32517 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Just noting that this issue (I think) was raised on the general mailing list: https://lists.katipo.co.nz/pipermail/koha/2023-January/058867.html Has a slightly different error message, but seems related to case sensitivity with patron category values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 22:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 21:57:10 +0000 Subject: [Koha-bugs] [Bug 32517] Patron search dies on case mismatch of patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32517 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes patron search so release notes| |that searching by category | |will work regardless of the | |patron category code case | |(upper, lower, and sentence | |case). Before this, | |category codes in upper | |case were expected - where | |they weren't this caused | |the search to fail, | |resulting in no search | |results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:16:00 +0000 Subject: [Koha-bugs] [Bug 31954] Patron search has no h1 heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:16:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:16:04 +0000 Subject: [Koha-bugs] [Bug 31954] Patron search has no h1 heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 --- Comment #1 from Katrin Fischer --- Created attachment 145110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145110&action=edit Bug 31954: Add h1 heading to patron search results page Havin an h1 heading on every page has been one of our accessibility goals, but patron search results don't have one so far. To test: * Apply patch * Do a patron search * Verify there is now an h1 heading between the toolbar and the patron search results table reading: Patron search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:16:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:16:28 +0000 Subject: [Koha-bugs] [Bug 31954] Patron search has no h1 heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:33:40 +0000 Subject: [Koha-bugs] [Bug 31957] Translation : Ability to change the sentence structure in branches.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:33:58 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure in branches.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation : Ability to |Translation: Ability to |change the sentence |change the sentence |structure in branches.tt |structure in branches.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:36:43 +0000 Subject: [Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145109|0 |1 is obsolete| | --- Comment #2 from Michael Hafen --- Created attachment 145111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145111&action=edit Bug 32583 - Restore display of only one item in catalogue/moredetails Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:38:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:38:20 +0000 Subject: [Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31315 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:38:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:38:20 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:43:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:43:10 +0000 Subject: [Koha-bugs] [Bug 32584] New: Can't update po files on master, because of missing UNIMARC files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32584 Bug ID: 32584 Summary: Can't update po files on master, because of missing UNIMARC files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When following the instructions on https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation you currently have 2 errors running gulp po:update: [22:41:06] Error: File not found with singular glob: /kohadevbox/koha/misc/translator/po/si-installer-UNIMARC.po (if this was purposeful, use `allowEmpty` option) at Glob. (/kohadevbox/koha/node_modules/glob-stream/readable.js:84:17) at Object.onceWrapper (events.js:520:26) at Glob.emit (events.js:400:28) at Glob.emit (domain.js:475:12) at Glob._finish (/kohadevbox/koha/node_modules/glob/glob.js:197:8) at done (/kohadevbox/koha/node_modules/glob/glob.js:182:14) at Glob._processSimple2 (/kohadevbox/koha/node_modules/glob/glob.js:688:12) at /kohadevbox/koha/node_modules/glob/glob.js:676:10 at Glob._stat2 (/kohadevbox/koha/node_modules/glob/glob.js:772:12) at lstatcb_ (/kohadevbox/koha/node_modules/glob/glob.js:764:12) When you create the file, you notice a second file missing: [22:42:33] 'po_update_installer_unimarc' errored after 85 ms [22:42:33] Error: File not found with singular glob: /kohadevbox/koha/misc/translator/po/tk-installer-UNIMARC.po (if this was purposeful, use `allowEmpty` option) at Glob. (/kohadevbox/koha/node_modules/glob-stream/readable.js:84:17) at Object.onceWrapper (events.js:520:26) at Glob.emit (events.js:400:28) at Glob.emit (domain.js:475:12) at Glob._finish (/kohadevbox/koha/node_modules/glob/glob.js:197:8) at done (/kohadevbox/koha/node_modules/glob/glob.js:182:14) at Glob._processSimple2 (/kohadevbox/koha/node_modules/glob/glob.js:688:12) at /kohadevbox/koha/node_modules/glob/glob.js:676:10 at Glob._stat2 (/kohadevbox/koha/node_modules/glob/glob.js:772:12) at lstatcb_ (/kohadevbox/koha/node_modules/glob/glob.js:764:12) [22:42:33] 'po:update' errored after 1.63 s This hinders testing, but I also wonder why we are missing the files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:54:32 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure in branches.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:54:36 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure in branches.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 --- Comment #1 from Katrin Fischer --- Created attachment 145112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145112&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:55:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:55:17 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure on library administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation: Ability to |Translation: Ability to |change the sentence |change the sentence |structure in branches.tt |structure on library | |administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 22:58:42 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure on library administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145112|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 145113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145113&action=edit Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:05:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:05:46 +0000 Subject: [Koha-bugs] [Bug 30993] Translation: Unbreak sentence in upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:10:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:10:30 +0000 Subject: [Koha-bugs] [Bug 32585] New: Followup on Bug 32583 - fix some variable references Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585 Bug ID: 32585 Summary: Followup on Bug 32583 - fix some variable references Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org Two variable references need to be changed after Bug 32583 changed the item variable from a hash to an object. One effects the host biblionumber, which isn't used in the template. The other effects the Acquisition backet number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:10:45 +0000 Subject: [Koha-bugs] [Bug 32585] Followup on Bug 32583 - fix some variable references In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31315 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:10:45 +0000 Subject: [Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:12:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:12:27 +0000 Subject: [Koha-bugs] [Bug 30993] Translation: Unbreak sentence in upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:12:32 +0000 Subject: [Koha-bugs] [Bug 30993] Translation: Unbreak sentence in upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30993 --- Comment #1 from Katrin Fischer --- Created attachment 145114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145114&action=edit Bug 30993: Improve translatabilty of UPLOAD av hint Improve translatability on the hint for AV UPLOAD on the upload tool page. To test: * Go to tools > uploads * Verify that the hint below the 'Browse...' displayes nicely and the link to the UPLOAD AV works correctly * Apply patch * Verify the link still works and the sentence reads correctly. NOTE: now only UPLOAD will be linked. If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:12:43 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure on library administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:12:43 +0000 Subject: [Koha-bugs] [Bug 30993] Translation: Unbreak sentence in upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:13:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:13:19 +0000 Subject: [Koha-bugs] [Bug 32585] Followup on Bug 32583 - fix some variable references In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32585 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Michael Hafen --- Created attachment 145115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145115&action=edit Bug 32585 - followup on Bug 32583 - fix some variable references Bug 32583 change the $item variable from a hash to an object. Trivial patch to change some hash references to object method calls. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:13:47 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:27:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:27:45 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:27:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:27:49 +0000 Subject: [Koha-bugs] [Bug 32580] Background job cancel button broken, leads to background_jobs.pl with a kc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32580 --- Comment #1 from Katrin Fischer --- Created attachment 145116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145116&action=edit Bug 32580: Fix typo in cancel link on background jobs page One way to test: * Make sure you are using Elasticsearch * Edit a record in your catalog * Go to: /cgi-bin/koha/admin/background_jobs.pl * Uncheck 'Current jobs only' * Cancel the job, you'll see a 404 error * Apply patch * Repeat, now the redirect should work right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:34:07 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:35:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:35:27 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 --- Comment #3 from Katrin Fischer --- This patch doesn't fix what was reported :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:39:39 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > This patch doesn't fix what was reported :( Actually, I need to be more careful at this time of day with my comments. It's a partial fix, I'll provide the second half. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:49:28 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:49:32 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145045|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 145117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145117&action=edit Bug 32400: Add page-section to aqbudgetperiods table To test: 1. Apply patch 2. Go to Administration -> Budgets 3. Close a budget 4. Make sure the page-section looks right. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:49:36 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 --- Comment #6 from Katrin Fischer --- Created attachment 145118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145118&action=edit Bug 32400: (follow-up) Add page-section to table of moved orders To test: * Make sure you have at least one open order, basket closed * Go to Administration > budgets * Clone the budget * Close the budget * Choose your new budget and save * Confirm 'can't undo later...' question * Verify the table of moved orders has the white background from the added page-section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:55:52 +0000 Subject: [Koha-bugs] [Bug 2635] Allow validation of price related item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow validation of item |Allow validation of price |fields (price, dates) |related item fields --- Comment #8 from Katrin Fischer --- Validation for dates exists now, so we can reduce this bug report to prices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 00:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2023 23:57:55 +0000 Subject: [Koha-bugs] [Bug 3310] Add mouse-over with column heading to table cells In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- We now have the option of having the table header scroll with the table which I feel is a little nicer as it leaves a mouse over to cells to hints on the content. I am closing WONTFIX, please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:00:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:00:00 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145117|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 145119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145119&action=edit Bug 32400: Add page-section to aqbudgetperiods table To test: 1. Apply patch 2. Go to Administration -> Budgets 3. Close a budget 4. Make sure the page-section looks right. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:00:07 +0000 Subject: [Koha-bugs] [Bug 32400] Add page-section to tables for end of year rollover (acq) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145118|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 145120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145120&action=edit Bug 32400: (follow-up) Add page-section to table of moved orders To test: * Make sure you have at least one open order, basket closed * Go to Administration > budgets * Clone the budget * Close the budget * Choose your new budget and save * Confirm 'can't undo later...' question * Verify the table of moved orders has the white background from the added page-section Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:05:07 +0000 Subject: [Koha-bugs] [Bug 32586] New: Reindent items with no checkouts reports template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Bug ID: 32586 Summary: Reindent items with no checkouts reports template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:29:13 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:29:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:29:17 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 --- Comment #1 from Katrin Fischer --- Created attachment 145121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145121&action=edit Bug 32586: Reindent items with no checkouts report template The indentation in the template was off and also full of tab characters, so this does some clean-up prior to doing some other small changes on separate bugs. To test: * Run the 'Items with no checkouts' report in the report module * Note: If you get an error in this step, you need to turn of sql_strict_mode in your koha-conf.xml, but this bug is out of scope here. * Apply patch * Rerun the report, it should appear unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:31:28 +0000 Subject: [Koha-bugs] [Bug 32587] New: Add page-section to items with no checkouts report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Bug ID: 32587 Summary: Add page-section to items with no checkouts report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 30952, 32586 Blocks: 31757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 [Bug 32586] Reindent items with no checkouts reports template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:31:28 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 [Bug 32587] Add page-section to items with no checkouts report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:31:28 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 [Bug 32587] Add page-section to items with no checkouts report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:31:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:31:28 +0000 Subject: [Koha-bugs] [Bug 31757] Add 'page-section' where it's missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 [Bug 32587] Add page-section to items with no checkouts report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:40:53 +0000 Subject: [Koha-bugs] [Bug 32588] New: Filters on top of 'Items with no checkouts' report are untranslatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Bug ID: 32588 Summary: Filters on top of 'Items with no checkouts' report are untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When you run the "items with no checkouts" report, on top you see something like: Filtered on: Doc Type = BK limit = 10 These are problematic in several ways: * the labels are untranslatable * BK and library code should be translated to their descriptions * limit should be Limit * Doc Type should be Item type * Branch should be library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:45:54 +0000 Subject: [Koha-bugs] [Bug 32589] New: Improve heading on results table for 'checkouts with no items' report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Bug ID: 32589 Summary: Improve heading on results table for 'checkouts with no items' report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 32586 When no group criteria is selected, the table heading above the results will read NULL on the 'checkouts with no items' report. This is not nice. If item type or library are selected, it will show the codes instead of the descriptions. This isn't nice either. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 [Bug 32586] Reindent items with no checkouts reports template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 01:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 00:45:54 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 [Bug 32589] Improve heading on results table for 'checkouts with no items' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:33:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:33:18 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:33:22 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 --- Comment #1 from Katrin Fischer --- Created attachment 145122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145122&action=edit Bug 32587: Add page-section to 'items with no checkouts' report This adds page sections to the summary and result tables for the 'items with no checkouts' report. To test: * Run the 'item with no checkouts' report with different settings * Confirm result tables are missing the white brackground from page-section * Apply patch * Confirm the result tables now do have the white background -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:33:54 +0000 Subject: [Koha-bugs] [Bug 32589] Improve heading on results table for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32586 |32587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 [Bug 32586] Reindent items with no checkouts reports template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 [Bug 32587] Add page-section to items with no checkouts report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:33:54 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 [Bug 32589] Improve heading on results table for 'checkouts with no items' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:33:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:33:54 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 [Bug 32589] Improve heading on results table for 'checkouts with no items' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:34:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:34:45 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on results table for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve heading on results |Improve headings on results |table for 'checkouts with |table for 'checkouts with |no items' report |no items' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:35:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:35:03 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve headings on results |Improve headings on result |table for 'checkouts with |tables for 'checkouts with |no items' report |no items' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:37:58 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 02:38:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 01:38:02 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #1 from Katrin Fischer --- Created attachment 145123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145123&action=edit Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 03:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 02:11:10 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 03:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 02:11:10 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 [Bug 32589] Improve headings on result tables for 'checkouts with no items' report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 03:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 02:15:38 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 03:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 02:15:42 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 --- Comment #1 from Katrin Fischer --- Created attachment 145124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145124&action=edit Bug 32588: Make filters on 'items with no checkouts' report translatable This makes the filters on top of the 'items with no checkouts' report translatable. The descriptions of the filters used the wrong terms and were also pulled from the .pl file, making them untranslatable. To test: * Without patch: Run the 'items with no checkouts' report with various settigs. * Verify, that the display on top doesn't use standard terminology Doc type = item type, Branch = library * Apply patch * Verify display is improved and standard terminology is used If you know how to, you can also confirm strings show up nicely in translations: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 09:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 08:02:46 +0000 Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utility testing (some bugs in git-bz? researching) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com Summary|Ticket for git-bz utiliti |Ticket for git-bz utility |testing (some bugs in |testing (some bugs in |git-bz? researching) |git-bz? researching) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 09:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 08:03:26 +0000 Subject: [Koha-bugs] [Bug 30558] Ticket for git-bz utility testing (some bugs in git-bz? researching) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30558 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nugged at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:55:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 09:55:17 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:55:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 09:55:22 +0000 Subject: [Koha-bugs] [Bug 32586] Reindent items with no checkouts reports template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32586 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145121|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians --- Created attachment 145125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145125&action=edit Bug 32586: Reindent items with no checkouts report template The indentation in the template was off and also full of tab characters, so this does some clean-up prior to doing some other small changes on separate bugs. To test: * Run the 'Items with no checkouts' report in the report module * Note: If you get an error in this step, you need to turn of sql_strict_mode in your koha-conf.xml, but this bug is out of scope here. * Apply patch * Rerun the report, it should appear unchanged Signed-off-by: Frédéric Demians → Nice to the eyes, and no regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:17:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:17:11 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:17:15 +0000 Subject: [Koha-bugs] [Bug 32587] Add page-section to items with no checkouts report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32587 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145122|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians --- Created attachment 145126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145126&action=edit Bug 32587: Add page-section to 'items with no checkouts' report This adds page sections to the summary and result tables for the 'items with no checkouts' report. To test: * Run the 'item with no checkouts' report with different settings * Confirm result tables are missing the white brackground from page-section * Apply patch * Confirm the result tables now do have the white background Signed-off-by: Frédéric Demians → Confirm both problem and solution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:18:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:18:42 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145080|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 145127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145127&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subrout ine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:18:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:18:45 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145081|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 145128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145128&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:37:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:37:50 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:37:54 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145123|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians --- Created attachment 145129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145129&action=edit Bug 32589: Improve headings on result tables for 'Items with no checkouts' When no filter was selected on the search form, the heading on the results table showed as NULL. When library or item type were selected the codes instead of the descriptions showed. To test: * Without patch: * Run the 'items with no checkouts' report with different settings for 'By:'. Verify the headings on the tables are not nice. * Apply patch * Rerun reports * Headings should be "Ungrouped, item type or library descriptions * Summary table also shows item type and library descriptions Signed-off-by: Frédéric Demians → OK. Would be nice to have decoding also in 'Filtered on' top section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:41:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:41:22 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Frédéric Demians --- Forget my comment about decoding top section: solved by bug 32588 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:44:16 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:44:21 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145124|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians --- Created attachment 145130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145130&action=edit Bug 32588: Make filters on 'items with no checkouts' report translatable This makes the filters on top of the 'items with no checkouts' report translatable. The descriptions of the filters used the wrong terms and were also pulled from the .pl file, making them untranslatable. To test: * Without patch: Run the 'items with no checkouts' report with various settigs. * Verify, that the display on top doesn't use standard terminology Doc type = item type, Branch = library * Apply patch * Verify display is improved and standard terminology is used If you know how to, you can also confirm strings show up nicely in translations: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Signed-off-by: Frédéric Demians -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:52:28 +0000 Subject: [Koha-bugs] [Bug 31954] Patron search has no h1 heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 11:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 10:52:33 +0000 Subject: [Koha-bugs] [Bug 31954] Patron search has no h1 heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31954 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145110|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 145131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145131&action=edit Bug 31954: Add h1 heading to patron search results page Havin an h1 heading on every page has been one of our accessibility goals, but patron search results don't have one so far. To test: * Apply patch * Do a patron search * Verify there is now an h1 heading between the toolbar and the patron search results table reading: Patron search results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 12:00:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 11:00:49 +0000 Subject: [Koha-bugs] [Bug 32582] Mailmap maps to wrong email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32582 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 12:00:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 11:00:54 +0000 Subject: [Koha-bugs] [Bug 32582] Mailmap maps to wrong email address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32582 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145108|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 145132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145132&action=edit Bug 32582: Fix error in .mailmap The .mailmap had the addresses in the wrong sequence. The .83 address is actually the correct one. How this works is easiest to see in git: * Apply one of my patches, like bug 31962 * Do a git log * You'll see the email address without .83 as author * Apply this patch * You should see the correct email now in both, matching the one in the patch file on bugzilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 12:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 11:10:55 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 12:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 11:11:00 +0000 Subject: [Koha-bugs] [Bug 31962] Add tooltip to 'configure' on datatable controls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145106|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 145133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145133&action=edit Bug 31962: Add tooltip to 'configure' on datatable controls This makes sure that the last button on the datatable controls also has a tooltip, like the other buttons. To test: * Without the patch: * Check out an item and look at the table of checkouts * Look at the detail page of a record with at least one item * Confirm that the 'configure' button doesn't have a tooltip appear as a bubble like the other buttons * Apply patch * Restart_all and reload pages * Make sure the styling of the 'configure' tooltip now matches that of the other buttons Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 12:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 11:13:08 +0000 Subject: [Koha-bugs] [Bug 32584] Can't update po files on master, because of missing UNIMARC files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32584 --- Comment #1 from Frédéric Demians --- I confirm that those 2 files are missing: misc/translator/po/si-installer-UNIMARC.po misc/translator/po/tk-installer-UNIMARC.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 14:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 13:45:53 +0000 Subject: [Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 --- Comment #3 from Katrin Fischer --- Thank you, Frédéric! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 14:46:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 13:46:59 +0000 Subject: [Koha-bugs] [Bug 32589] Improve headings on result tables for 'checkouts with no items' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32589 --- Comment #4 from Katrin Fischer --- (In reply to Frédéric Demians from comment #3) > Forget my comment about decoding top section: solved by bug 32588 Yes, I tried to break it up into smaller steps - thx for working through the tree :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 17:01:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 16:01:11 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 21:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 20:57:45 +0000 Subject: [Koha-bugs] [Bug 4090] Subscription ID showing in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|subscription ID showing in |Subscription ID showing in |OPAC - confusing |OPAC is confusing --- Comment #6 from Katrin Fischer --- Maybe a solution here would be to make the ID less prominent, using something like library, callnumber (ID) as the display name? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:02:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:02:11 +0000 Subject: [Koha-bugs] [Bug 4115] Print a batch of patron cards from an import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Summary|print a batch of patron |Print a batch of patron |cards from an import |cards from an import Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- (In reply to Marc Véron from comment #2) > What about enhancing patron import to have the importet patrons in a patron > list? > List name could default to the filename the import comes from, maybe > including date an dtime of import. > > The list could be used for printing patron cards (and other patron list > based actions as well). This has been implemented as Marc described. When importing patrons, you can add them to a list and then print patron cards for this list. Closing this as WORKSFORME. Please reopen if you disagree. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:04:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:04:31 +0000 Subject: [Koha-bugs] [Bug 4134] Add bibliographic tagging to staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add bibliographic tagging |Add bibliographic tagging |to staff interface |to staff interface --- Comment #2 from Katrin Fischer --- Social tagging has come out of fashion a little, but I think in some contexts this would still be a very useful feature, especially enabling staff to tag easily instead of relying on OPAC users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:08:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:08:43 +0000 Subject: [Koha-bugs] [Bug 4148] Sorting by author is confusing to users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced Search not sorting |Sorting by author is |by author |confusing to users --- Comment #8 from Katrin Fischer --- Changed the bug description a little since we have concluded that it works ok. Thinking about it, maybe it should use 100, 110, 111, but I am not sure if using the 700 will not give even more confusing results unless we can limit to certain relator terms... and then it would require them to be catalogued correctly too. Maybe the safest bet would be to handle the 'no 1xx to sort' by sorting them to the end if possible? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:13:49 +0000 Subject: [Koha-bugs] [Bug 4225] Cloning of rules in smart-rules.pl only clones top table of rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I've tested this by adding rules to all configuration tables and they all cloned to the other library perfectly. I assume this could have been fixed with the move from issuingrules to circulation_rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:28:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:28:26 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #11 from Katrin Fischer --- We had some behaviour changes that possibly affect this, like bug 18014. We nowadays enforce the 001 to be Koha's authid consistently. I am going to close this as INVALID, please reopen if you disagree! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:29:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:29:23 +0000 Subject: [Koha-bugs] [Bug 4229] Need feature to view label/card batches from all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need feature to view |Need feature to view |Label/Card batches from all |label/card batches from all |branches |libraries -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:32:38 +0000 Subject: [Koha-bugs] [Bug 4230] New icon for move to lowest priority on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|new icon for move to lowest |New icon for move to lowest |priority on holds |priority on holds Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #4) > This might be resolved by bug 16421 We have since changed all the icons for changing the holds priorities on bug 29057. Marking as RESOLVED DUPLICATE. *** This bug has been marked as a duplicate of bug 29057 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:32:38 +0000 Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #30 from Katrin Fischer --- *** Bug 4230 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:39:41 +0000 Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I have done tests with 2 different use cases: * Item from A is checked out to user in B * Hold is placed with pickup in C * Items return home * Item is checked in at B * Transfer is to library C for hold pickup Similar as above, but the item is not checked out, when returned in B: * Transfer is to library C for hold pickup And then to verify that the holds behavior took precedence: * Item from A (without holds) is checked in at B * Item is sent to return to A I assume that this is fixed, please reopen if I missed something! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:39:42 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Bug 22160 depends on bug 4234, which changed state. Bug 4234 Summary: Automatic transfer shouldn't take precedence over a hold transit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:41:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:41:42 +0000 Subject: [Koha-bugs] [Bug 4264] Categories/Groups for authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4264 --- Comment #4 from Katrin Fischer --- This might still be a pretty handy optional feature. For example we have several Authorised value categories that belong to the ERM module now and this is repeatedly stated in the description, but it would be so much nicer to have a separate sortable/searchable column for these. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:45:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:45:56 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 --- Comment #16 from Katrin Fischer --- I am not sure if this is a feature that we should implement given the possible security/spam implications. A bot or human misusing the feature could get the library's email address blacklisted for example. Would someone else support a CLOSED WONTFIX? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:49:28 +0000 Subject: [Koha-bugs] [Bug 4304] autoBarcode should increment from user defined value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED Summary|autoBarcode should |autoBarcode should |increment from user defind |increment from user defined |value |value --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > The easiest way around this right now is to create the first item with your > 'start number' and then Koha will count from that as always the highest > existing barcode is used. I wonder if this is not easier than having to > maintain a different setting? I am closing this WONTFIX as the existing workaround seems a good option. Please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:51:36 +0000 Subject: [Koha-bugs] [Bug 4330] Copyright statements out of date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #49 from Katrin Fischer --- Is this still something we shoudl/could fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:53:46 +0000 Subject: [Koha-bugs] [Bug 4363] Support the patron internet resources field in Sip2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|colin.campbell at ptfs-europe. |martin.renvoize at ptfs-europe |com |.com --- Comment #4 from Katrin Fischer --- Martin or Kyle, could you have a look at this old bug from Colin please? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 22:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 21:56:30 +0000 Subject: [Koha-bugs] [Bug 4373] Placing and processing items simultaneously causes multiple issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Placing and Processing |Placing and processing |Items Simultaneously causes |items simultaneously causes |multiple issues |multiple issues --- Comment #4 from Katrin Fischer --- The mentioned bug 4201 has been fixed since. I haven't seen newer reports on this, but it could still be an issue for bigger consortiums I guess. Could anyone weigh in here with their experience maybe? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:06:21 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|hugh at davenport.net.nz |koha-bugs at lists.koha-commun | |ity.org --- Comment #15 from Katrin Fischer --- acq.js appears to be the non-external library that still uses XMLHttpRequest: koha-tmpl/intranet-tmpl/prog/js/acq.js In: totalExceedsBudget() budgetExceedsParent() checkBudgetParent() The others are: koha-tmpl/opac-tmpl/bootstrap/js/Gettext.js koha-tmpl/opac-tmpl/bootstrap/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/opac-tmpl/bootstrap/lib/jquery/jquery-3.6.0.min.js koha-tmpl/opac-tmpl/lib/verovio/000_acoustic_grand_piano.js koha-tmpl/opac-tmpl/lib/verovio/verovio-toolkit.js I am resetting assignee since this hasn't had an update in several years. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:06:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:06:28 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:09:00 +0000 Subject: [Koha-bugs] [Bug 4439] Two acq webservices should use REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|hugh at davenport.net.nz |koha-bugs at lists.koha-commun | |ity.org Summary|two acq webservices should |Two acq webservices should |use C4::Service |use REST API --- Comment #7 from Katrin Fischer --- Resetting assignee since this hasn't been updated in several years. Also updated the bug description as per David's comment. Assume that the patch would need a complete rewrite. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:09:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:09:07 +0000 Subject: [Koha-bugs] [Bug 4439] Two acq webservices should use REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:11:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:11:17 +0000 Subject: [Koha-bugs] [Bug 4455] Language specific order claims notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Language Specific Claims |Language specific order |Notices |claims notices --- Comment #1 from Katrin Fischer --- What might be missing here might be a preferred language setting for the vendor. Or alternatively maybe a setting for the notice template to use? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:22:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:22:07 +0000 Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040 --- Comment #12 from Katrin Fischer --- I tried testing this (hopefully correctly). There is only one dialog now consistently that asks for "confirm hold and transfer". I believe the current behaviour is correct, please reopen if I missed something! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:22:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:22:17 +0000 Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:27:08 +0000 Subject: [Koha-bugs] [Bug 4034] Checking out an item on hold for that patron (but not waiting) results in incorrect message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4034 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- > ---- Reported by oleonard at myacpl.org 2010-01-11 15:09:33 ---- > > Steps to reproduce: > > - Item is on hold for a patron, but item has not been made waiting > - Check the item out to that patron > > An message will appear: "Please Confirm Checkout * Item is on reserve for > [this patron]" > > The message implies that you're checking out something that is on hold for a > *different* patron. This works nicely now: * No confirmation message * Hold is marked as filled/resolved -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:31:15 +0000 Subject: [Koha-bugs] [Bug 4031] Ability to turn off search history for users not logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4031 --- Comment #6 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > We have just had a library 'complaining' about the fact that the anon > history is added to the patron account on log in. This is especially a > problem if the library offers computers for searching the OPAC in the > library that get frequented by a lot of different users. > > I think this configuration option Matts proposed would be really helpful > there. We also have LoadSearchHistoryToTheFirstLoggedUser now that allows to determine what happens with the anonymous searches once a patron logs in. But it's still possible to see what other users searched for when you are using a public computer. So it might still be nice to have the option to limit search history logging to logged in users. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:37:37 +0000 Subject: [Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fast Add Framework Should |Add a warning/hint when FA |not be Deletable |framework is missing Status|In Discussion |ASSIGNED --- Comment #12 from Katrin Fischer --- Trying to free this from In discussion by agreeing with the last 2 comments :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:37:43 +0000 Subject: [Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:39:54 +0000 Subject: [Koha-bugs] [Bug 3831] Add a warning/hint when FA framework is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:42:24 +0000 Subject: [Koha-bugs] [Bug 3796] Place a hold on a specific copy allows impossible items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3796 --- Comment #6 from Katrin Fischer --- (In reply to Christopher Brannon from comment #5) > We don't have specifics yet. All we have is the evidence left the table. > > I think that there should be a check somewhere...a cron job, or something, > that checks the validity of the reserves table. Particularly between the > item number and bib number. And perhaps against the patron account. There > are two problems evident: > > 1) Mismatched item and bib numbers in the reserves table. > 2) Reserves showing in the reserves table, and not showing in the patron > account. Most likely because of issue 1. > > Is it necessary to have a bib number in the reserves table when the item > number is recorded for an item level hold? Seems redundant if the bib > number is in the items table. That would be the simplest remedy for this > issue. So, rather than using the bib number in the reserves table for any > holds functions, it could be referenced from the items table. > > Otherwise, we might need a checkpoint to verify accuracy. > > As I said, we don't have an answer as to how this is happening. I can think > of a few ways it might happen, but I don't think one of them is the case, > since it happened to a couple of items with the same patron. > > One way it could happen is that a patron is reconstructing the URL manually > and blending mismatched info. > > The second way is that a hold is placed on an item. The item record is then > turned into a different item and attached to a different bib. OR better > yet, an item is created and accidently attached to the wrong bib, and after > the hold is placed, the item is moved to the correct bib. > > It seems that maybe when items are moved from one bib to another, a check > should take place to verify any possible holds in the reserves table. > > I don't know if this helps, but that's my two cents. > > Christopher Hi Christopher, are this still issues you see in current versions? Is there any step by step that we could use to reproduce the issue? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:48:13 +0000 Subject: [Koha-bugs] [Bug 3492] Move hold fee setting into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set hold fees by item type |Move hold fee setting into |and charge when hold placed |circulation rules --- Comment #14 from Katrin Fischer --- I have updated the bug description per the discussion below. HoldFeeMode already allows to charge when placing a hold. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:50:57 +0000 Subject: [Koha-bugs] [Bug 3417] Items with no checkouts report won't output to a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3417 --- Comment #2 from Katrin Fischer --- The report produces at least 2 different tables, a summary and another with detailed results. If you group by item type or library, it will split the second label into a separate one per itemtype/library. This might be why the export option into a file wasn't implemented back then and why it might be a little harder than for the other tables. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:53:46 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 --- Comment #4 from Katrin Fischer --- Still valid, changes to priority are not logged with HoldsLog activated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:56:12 +0000 Subject: [Koha-bugs] [Bug 2954] Holds queue report should show date/time of last update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2954 --- Comment #5 from Katrin Fischer --- As we have RealTimeHoldsQueue now, maybe we could not only have a global date, but a timestamp column for the holds queue table itself? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 22:57:32 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show user comments in staff |Show user comments in staff |client |interface Assignee|chris at bigballofwax.co.nz |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- Would still make a nice addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:03:11 +0000 Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #22 from Katrin Fischer --- The display of fines/charges and credits have radically changed (for the better) since this bug was files and the patch written. * NotifyId and Level are long gone * Accuunt type is a nice description instead of a code now * Credits handling was revamped so they can be applied against open fines/fees I am positive this can be resolved - please consider opening new bugs with issues that might still remain! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:12:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:12:59 +0000 Subject: [Koha-bugs] [Bug 5388] Circulation of related/requiring items (like Book and CD sets) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5388 --- Comment #2 from Katrin Fischer --- I wonder if we could mark this resolved now that we have item bundles as an option to handle this use case? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:16:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:16:22 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- It looks like this is resolved as bug 22744 removed the 'Do not notify' column altogether. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:16:23 +0000 Subject: [Koha-bugs] [Bug 22745] Need a "Do not notify" option in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22745 Bug 22745 depends on bug 5501, which changed state. Bug 5501 Summary: Improve the 'do not notify' option https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:18:47 +0000 Subject: [Koha-bugs] [Bug 5598] Ability to clone circulation rules to list of patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|More Granular Cloning |Ability to clone |Circulation & Fine Rules |circulation rules to list | |of patron categories -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:21:40 +0000 Subject: [Koha-bugs] [Bug 5704] Optionally show record level item type icons in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5704 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bib level item type icon |Optionally show record |should display on search |level item type icons in |results |search results -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:26:15 +0000 Subject: [Koha-bugs] [Bug 5785] Holds should catch new acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- I imagine Jared meant that the item should show up on the holds queue and I assume with RealTimeHoldsQueue it will now as every change to the record/items will trigger an update. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346#c15 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:29:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:29:17 +0000 Subject: [Koha-bugs] [Bug 6422] Editable help files for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > Bug 15326 allowing to add additional pages to the OPAC might be helpful here. I believe we can mark this as resolved with bug 15326. Please reopen if you disagree! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:37:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:37:32 +0000 Subject: [Koha-bugs] [Bug 6729] Block received order lines from editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Katrin Fischer --- There have been no more replies to this one, closing as per comment#5. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:42:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:42:52 +0000 Subject: [Koha-bugs] [Bug 7126] Transfer does not prompt with hold information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126 --- Comment #4 from Katrin Fischer --- This appears to be fixed: * Place holds on record * Manually transfer item to another library: Hold found for koha (42) (51). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:43:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:43:48 +0000 Subject: [Koha-bugs] [Bug 7126] Transfer does not prompt with hold information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:43:49 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Bug 22160 depends on bug 7126, which changed state. Bug 7126 Summary: Transfer does not prompt with hold information https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7126 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:47:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:47:08 +0000 Subject: [Koha-bugs] [Bug 7223] Move borrowerRelationship to authorised values list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move borrowerRelationship |Move borrowerRelationship |to Authorised Values list |to authorised values list --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:51:07 +0000 Subject: [Koha-bugs] [Bug 7520] JSON script to return advanced search types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|json script to return |JSON script to return |advanced search types |advanced search types Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #28 from Katrin Fischer --- I think this should probably be implemented as a public REST API route nowadays. It should also take into account if an itemtype has been marked to not display in advanced search in configuration. As this is really old I'll mark as WONTFIX, please reopen if you disagree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:53:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:53:49 +0000 Subject: [Koha-bugs] [Bug 7525] Some database fields are displayed 'as is' when they are linked to authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- Closing as WONTFIX as per my suggestion from 2019, please reopen with more information if you disagree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:53:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:53:50 +0000 Subject: [Koha-bugs] [Bug 7515] authorized value code showing in opac for public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Bug 7515 depends on bug 7525, which changed state. Bug 7525 Summary: Some database fields are displayed 'as is' when they are linked to authorised values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7525 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:55:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:55:21 +0000 Subject: [Koha-bugs] [Bug 7515] Authorized value code showing in OPAC for public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|authorized value code |Authorized value code |showing in opac for public |showing in OPAC for public |note |note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:58:05 +0000 Subject: [Koha-bugs] [Bug 29880] Item cataloguing should be split into add and edit permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7536 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2023 23:58:05 +0000 Subject: [Koha-bugs] [Bug 7536] New permission for deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29880 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:00:33 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #25 from Katrin Fischer --- I believe this was fixed by bug 12318 now. *** This bug has been marked as a duplicate of bug 12318 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:00:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:00:33 +0000 Subject: [Koha-bugs] [Bug 12318] Show subscription shelving location on subscription tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #10 from Katrin Fischer --- *** Bug 7654 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:03:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:03:33 +0000 Subject: [Koha-bugs] [Bug 7655] Runtime parameters: Allow for an "optional" field tag, versus the need for % In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7655 --- Comment #2 from Katrin Fischer --- We also have :all now, that works on drop down lists and adds an entry with % that is pre-selected. Having a % for date or free text is probably not as easy to resolve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:04:47 +0000 Subject: [Koha-bugs] [Bug 7655] Runtime parameters: Allow for making free text and date fields optional without the need for users to enter % In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Runtime parameters: Allow |Runtime parameters: Allow |for an "optional" field |for making free text and |tag, versus the need for % |date fields optional | |without the need for users | |to enter % -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:07:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:07:03 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #22 from Katrin Fischer --- We just recently had a request to change the link targets - so this is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:09:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:09:13 +0000 Subject: [Koha-bugs] [Bug 7754] Displaying the number of days an item is late on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7754 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #4 from Katrin Fischer --- This would still be quite nice :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:22:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:22:58 +0000 Subject: [Koha-bugs] [Bug 32590] New: Add FK constraint for search_history.userid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32590 Bug ID: 32590 Summary: Add FK constraint for search_history.userid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Make sure that when the patron is deleted, the userid (borrowernumber) is either set to NULL or the entries be deleted in search_history. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:24:20 +0000 Subject: [Koha-bugs] [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED --- Comment #5 from Katrin Fischer --- >alert.borrowernumber (with ON DELETE CASCADE) CONSTRAINT `alert_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE >statistics.borrowernumber (with ON DELETE SET NULL) I think this could be debatable. I am pretty sure libraries look-up in deletedborrowers for statistical reports regularly and this is a statistics table. I consider it WONTFIX. >messages.borrowernumber (with ON DELETE SET NULL) CONSTRAINT `messages_borrowernumber` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, I believe the ON DELETE CASCADE is correct, you don't want to keep those messages without the patrons as they might contain sensitive information. >reserveconstraints.borrowernumber (with ON DELETE CASCADE) Table no longer exists. >reviews.borrowernumber (with ON DELETE CASCADE) CONSTRAINT `reviews_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE, I believe the ON DELETE SET NULL is what most libraries would want. >saved_sql.borrowernumber (with ON DELETE SET NULL) NOT FIXED, but already filed separately and stuck in discussion: Bug 13668 - Creator of an SQL report shoudl be NULL when the staff patron is deleted >search_history.borrowernumber (with ON DELETE CASCADE) -the borrowernumber field is called userid atm, see below- NOT FIXED Now filed separately: Bug 32590 - Add FK constraint for search_history.userid >suggestions.suggestedby, suggestion.managedby, acceptedby, rejectedby (with ON DELETE SET NULL) CONSTRAINT `suggestions_ibfk_managedby` FOREIGN KEY (`managedby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE, CONSTRAINT `suggestions_ibfk_rejectedby` FOREIGN KEY (`rejectedby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE, CONSTRAINT `suggestions_ibfk_suggestedby` FOREIGN KEY (`suggestedby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE CONSTRAINT `suggestions_ibfk_acceptedby` FOREIGN KEY (`acceptedby`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:24:20 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 7811, which changed state. Bug 7811 Summary: borrowers.borrowernumber should be a foreign key for 8 tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:25:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:25:56 +0000 Subject: [Koha-bugs] [Bug 7812] Add markup to staff interface templates to increase customization options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add markup to staff client |Add markup to staff |templates to increase |interface templates to |customization options |increase customization | |options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:27:55 +0000 Subject: [Koha-bugs] [Bug 7856] Alphabetizing of filters in advanced search by column instead of row In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|alphabetizing of filters on |Alphabetizing of filters in |Advanced Search |advanced search by column | |instead of row --- Comment #1 from Katrin Fischer --- Not sure about this one - is this a WONTFIX or is there interest to have this changed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:35:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:35:37 +0000 Subject: [Koha-bugs] [Bug 7901] Add option to delete_borrowers.pl for using a file with cardnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add batch delete borrowers |Add option to |script |delete_borrowers.pl for | |using a file with | |cardnumbers Status|In Discussion |Failed QA --- Comment #12 from Katrin Fischer --- (In reply to Katrin Fischer from comment #8) > I wonder if those options should be added to the delete_borrowers.pl script > that already is in Koha. If we have 2 scripts, we should make clear where > the differences are and they should both delete patrons the same way, taking > fines, holds etc. into account. I see that delete_borrowers.pl already has a --file option that works with a list of borrowernumber. I really think it would make most sense now to extend the existing script now so that we only have one script dealing with patron deletes from CLI. --file Delete patrons whose borrower numbers are in this file. If other criteria are defined it will only delete those in the file that match those criteria. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:38:45 +0000 Subject: [Koha-bugs] [Bug 7908] Record more information about payment on invoice level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 --- Comment #6 from Katrin Fischer --- The new feature for having configurable additional fields on invoices might help a little here, even if it doesn't cover the full feature set from the attached patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:42:07 +0000 Subject: [Koha-bugs] [Bug 9999] Reconstruct system preference values via action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reconstruct pref values via |Reconstruct system |action_logs |preference values via | |action_logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:53:31 +0000 Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for anonymisation errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #3 from Katrin Fischer --- Code is different now, but the FIXME remained: # Anonymising all members 146 if ($do_anonym) { 147 #FIXME: anonymisation errors are not handled 148 my $rows = Koha::Old::Checkouts 149 ->filter_by_anonymizable 150 ->filter_by_last_update({ 151 to => $last_issue_date, timestamp_column_name => 'returndate' }) 152 ->anonymize; 153 154 $template->param( 155 do_anonym => $rows, 156 ); 157 } 158 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:57:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:57:05 +0000 Subject: [Koha-bugs] [Bug 32591] New: Batch patron deletion and anonymization tool form is misaligned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32591 Bug ID: 32591 Summary: Batch patron deletion and anonymization tool form is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:57:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:57:05 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32591 [Bug 32591] Batch patron deletion and anonymization tool form is misaligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 01:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 00:59:08 +0000 Subject: [Koha-bugs] [Bug 9893] Koha::DateUtils::output_pref should not use $dateonly parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Katrin Fischer --- Martin or Joubu, could you assist me in my quest to clean up the 4 digit bugs and let me know if this is still desirable? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:03:44 +0000 Subject: [Koha-bugs] [Bug 9872] Logs explode with messages when adding a new order in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9872 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- koha-plack-err and koha-intra-err remain empty with the test plan now. Wow, I'll take it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:12:05 +0000 Subject: [Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842 --- Comment #4 from Katrin Fischer --- I am not sure how to set up the config files in order to make these tests pass (or not). Could someone else confirm if they are still failing or not maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:14:35 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #19 from Katrin Fischer --- (In reply to Koha Team University Lyon 3 from comment #17) > No, I gave up this patch > > Olivier Crouzet Setting to WONTFIX - please reopen if you disagree! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:18:29 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #13 from Katrin Fischer --- (In reply to Fridolin Somers from comment #12) > Merge from shelves is more a cataloguing action non ? > Should be a permission under "editcatalogue". > It is actually depending on "edit_catalogue" permission. I think maybe merging could be a general permission applying to merging in the cataloguing module or in lists and be listed under cataloguing. And I would recommend splitting this bug into 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:31:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:31:00 +0000 Subject: [Koha-bugs] [Bug 9753] Add series information to holds queue list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make it possible to |Add series information to |customize display of |holds queue list |bibliographic information | |on holds queue | --- Comment #1 from Katrin Fischer --- We have since added more information to the holds queue display with CSS classes to hide/display (300, edition, publication details, ...) I suggest changing this for just adding the series information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:32:39 +0000 Subject: [Koha-bugs] [Bug 32592] New: Extent title information shown in holds queue list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32592 Bug ID: 32592 Summary: Extent title information shown in holds queue list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment it appears that the holds queue shows a lot of bibliographic information, but is missing subtitle, part name, part title and medium that could indeed be quite useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:32:39 +0000 Subject: [Koha-bugs] [Bug 9753] Add series information to holds queue list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32592 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:36:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:36:49 +0000 Subject: [Koha-bugs] [Bug 9453] Update records according to the new UNIMARCField100Language system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update records acording to |Update records according to |the new |the new |UNIMARCField100Language |UNIMARCField100Language |system preference |system preference Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:39:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:39:28 +0000 Subject: [Koha-bugs] [Bug 9524] Let patrons create custom search filters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Let patrons create search |Let patrons create custom |groups |search filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:42:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:42:21 +0000 Subject: [Koha-bugs] [Bug 9537] Add a list of the patches that have been applied to a Koha installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Summary|Add a list of the patches |Add a list of the patches |that have been applied to a |that have been applied to a |koha installation |Koha installation Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- I agree with David on this one. It would also be hard to keep this information current, make it nicely searchable etc. We do note on bugzilla now which versions a patch has been released with, so things have improved since this has been filed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:48:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:48:50 +0000 Subject: [Koha-bugs] [Bug 9227] Items in transit can be checked out without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9227 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|items in transit can be |Items in transit can be |checked out without warning |checked out without warning --- Comment #4 from Katrin Fischer --- (In reply to Owen Leonard from comment #3) > I suspect that this is not a high priority bug for a lot of folks. My > library, for instance, give priority to the patron checking out the item. If > the an in-transit item made it to the shelf by mistake that's not the > patron's fault. > > (In reply to Rendi from comment #2) > > > In addition, once the item is checked > > out rather than sent in transit, it becomes almost like an item specific > > hold > > This I agree is a problem, and should probably be addressed as a separate > bug. Can you detail the bug a bit more? I am not sure why checking out an in transit is bad as long as the transit gets cancelled or restarted when it's returned again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:55:45 +0000 Subject: [Koha-bugs] [Bug 9121] C4::Serial SQL possible collision on subscription.subscriptionid and subscriptionhistory.subscriptionid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9121 --- Comment #1 from Katrin Fischer --- When looking at the table structure for subscriptions for a migration I realized that you always need to set all the tables in order to have a working and adjustable subscription: subscription, subsriptionhistory and also a first serial - I wonder if this wouldn't be more of a data issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:57:33 +0000 Subject: [Koha-bugs] [Bug 9083] Remove <> form list of placeholders for CHECKIN/CHECKOUT notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|<> in |Remove <> |checkin/checkout notices |form list of placeholders |does nothing |for CHECKIN/CHECKOUT | |notices --- Comment #4 from Katrin Fischer --- I have adjusted my bug description - I think the real issue is the list in the editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 02:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 01:59:17 +0000 Subject: [Koha-bugs] [Bug 9060] Update custom.sql for nb-NO webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Data update for nb-NO |Update custom.sql for nb-NO |webinstaller |webinstaller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 03:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 02:04:16 +0000 Subject: [Koha-bugs] [Bug 8871] Many "subroutine redefined" warnings from C4 modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8871 --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #4) > This is not specific to C4/Reserves.pm. We have circular dependencies in all > our C4 modules. How should we go about this? Is there a chance to fix those or is this more a matter of moving more things to Koha: to clean up the code more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 03:05:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 02:05:21 +0000 Subject: [Koha-bugs] [Bug 8855] Link from receipt to invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 03:30:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 02:30:05 +0000 Subject: [Koha-bugs] [Bug 20005] Posibility to change the number of results shown by default in label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Label/patron card printing Assignee|koha-bugs at lists.koha-commun |cnighswonger at foundations.ed |ity.org |u Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 03:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 02:37:45 +0000 Subject: [Koha-bugs] [Bug 19903] Add Koha::Patron::Restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31457 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 03:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 02:37:45 +0000 Subject: [Koha-bugs] [Bug 31457] Move Koha::Patron::Debarment into Koha::Object based classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 19903 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 04:07:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 03:07:41 +0000 Subject: [Koha-bugs] [Bug 6615] Add shelving location option to transfers page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6615 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Hi Owen, is this resolved with the item batch edit features? Or maybe UpdateItemLocationOnCheckin? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 04:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 03:09:11 +0000 Subject: [Koha-bugs] [Bug 6456] Optionally display barcode in search results in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display of barcode in |Optionally display barcode |search results in staff |in search results in staff |client |interface -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 04:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 03:15:44 +0000 Subject: [Koha-bugs] [Bug 8038] Enable network printing when UsePrintQueues is on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #5 from Katrin Fischer --- The depending bug has been marked WONTFIX and the printer related code has been removed from Koha. I am not sure where we are with this one, but it's at least BLOCKED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 17:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 16:37:15 +0000 Subject: [Koha-bugs] [Bug 10567] Ability to add a hidden/suppressed library branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- We don't have a central switch, but we have several features that you can achieve this with: * OpacSuppression and OpacHiddenItems * Libraries: Is a pick-up location * libraries: Is public So maybe we can consider this fixed :) Please reopen if you disagree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 21:34:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 20:34:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #929 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #928) > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt > > - [% INCLUDE 'item-status.inc' > item=cr.item issue=cr.issue %] > + [% INCLUDE 'item-status.inc' > item=cr.course_item issue=cr.issue %] > > I don't understand this change, and I am going to revert it. I think it > broke the availability display. Can you clarify on bug 32445 please? Likely leftover from old upstream requirements. Your fix on Bug 32445 is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:07:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:07:36 +0000 Subject: [Koha-bugs] [Bug 24679] Allow to apply a MARC modification template in export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- This could help to add more feature parity with other library systems... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:27:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:27:09 +0000 Subject: [Koha-bugs] [Bug 4330] Copyright statements out of date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #50 from David Cook --- (In reply to Katrin Fischer from comment #49) > Is this still something we shoudl/could fix? I wonder this as well. I wonder if Catalyst's lawyers could advise on this one. Copyright statements in source code seems like an unclear area even these days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:42:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:42:05 +0000 Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 --- Comment #15 from David Cook --- We need to keep the fork, and catching all exceptions makes sense to me. You could say that the background job worker is really a background job server and servers really shouldn't go down. They should be reporting on the failures. Of course the tough part here is that the job ID is in the JSON, so if the JSON can't be decoded, there is no way to fail the job and it just stays stuck in "new" forever. I haven't been following the bad JSON bugs carefully enough though. Since we control both ends, we shouldn't be creating and transmitting bad JSON... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:49:15 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I don't think there's 100% perfect answer for this topic. If you look at "Message acknowledgement" on the following work queue tutorial, it explicitly says that you should ACK after the work task has completed. It does note how the 30 minute default timeout can be an issue. https://www.rabbitmq.com/tutorials/tutorial-two-python.html "Doing a task can take a few seconds, you may wonder what happens if a consumer starts a long task and it terminates before it completes. With our current code once RabbitMQ delivers message to the consumer, it immediately marks it for deletion. In this case, if you terminate a worker, the message it was just processing is lost. The messages that were dispatched to this particular worker but were not yet handled are also lost. But we don't want to lose any tasks. If a worker dies, we'd like the task to be delivered to another worker. In order to make sure a message is never lost, RabbitMQ supports message acknowledgments. An ack(nowledgement) is sent back by the consumer to tell RabbitMQ that a particular message had been received, processed and that RabbitMQ is free to delete it. If a consumer dies (its channel is closed, connection is closed, or TCP connection is lost) without sending an ack, RabbitMQ will understand that a message wasn't processed fully and will re-queue it. If there are other consumers online at the same time, it will then quickly redeliver it to another consumer. That way you can be sure that no message is lost, even if the workers occasionally die." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:51:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:51:01 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #4 from David Cook --- If you were doing a big batch record modification and you suffered a power outage on the machine where the background job worker is running, then that task can't be re-started since the RabbitMQ message was already ACKed before the real work began. (Of course, in the case of Koha, we have the "database failover", so in theory it might get recovered, but it's not standard design.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2023 23:57:57 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #21 from David Cook --- (In reply to Jonathan Druart from comment #14) > From > https://www.grzegorowski.com/rabbitmq-406-channel-closed-precondition-failed > > "You have to ACK messages in same order as they arrive to your system" > > If this is correct, forking is not an option here. Or rather, Kyle's patch is just forking at the wrong point. I've just reviewed the patches again, and I notice that this is a forking job server style, but we need a pre-forking job server style. That is, following GetOptions, we should fork, and each child process gets its own connection with RabbitMQ. Then each child process ACKs the messages in the same order it receives on its own separate connection (and channel). That way, it's functionally the same thing as running 4 separate background job worker processes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:01:17 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #26 from David Cook --- (In reply to Jonathan Druart from comment #17) > And what about the 30 minutes timeout? That's always a danger. If 1 message takes 30+ minutes to process, then we'll have problems when using a "worker queue" (as described at https://www.rabbitmq.com/tutorials/tutorial-two-python.html) style of background job processing. Options that come to mind are increasing the timeout value (which is tough to do programmatically with RabbitMQ via the koha-common package) or breaking down long running tasks into smaller easier to process chunks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:04:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:04:50 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #27 from David Cook --- (In reply to Jonathan Druart from comment #25) > I am giving up, need help. > > I wrote this script to help adjusting the worker code and see how things > went. > > To test: > Edit /etc/rabbitmq/rabbitmq.conf > > consumer_timeout = 10000 > > # Delete existing jobs - not needed but better to track down what's going on > MariaDB [koha_kohadev]> delete from background_jobs; > > # Watch the logs > % sudo tail -f /var/log/koha/kohadev/* /var/log/rabbitmq/*.log > > # Run the script > % perl test_bg.pl > > Wait 100 seconds I'm not sure I understand. That timeout is 10 seconds but the problem happens after 100 seconds? I'll give the test a go, since those missing frames are disturbing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:14:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:14:36 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #28 from David Cook --- Looks like the test plan is missing a step since without restarting the koha background job worker you'll just get the following: Exception 'Koha::Exception' thrown 'test is not a valid job_type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:21:55 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #29 from David Cook --- Ok I see the timeout happening 10 seconds after it probably got the first message on the connection/channel. Although according to the logs it processed 51 tasks. That seems odd... I'm going to dive deeper... 622 2023-01-09 00:14:38.291 [info] <0.2408.0> accepting STOMP connection <0.2408.0> (127.0.0.1:58134 -> 127.0.0.1:61613) 623 2023-01-09 00:15:39.033 [warning] <0.2420.0> Consumer Q_/queue/koha_kohadev-default on channel 1 has timed out waiting on consumer acknowledgement. Timeout used: 10000 ms 624 2023-01-09 00:15:39.170 [error] <0.2420.0> Channel error on connection <0.2411.0> (127.0.0.1:58134 -> 127.0.0.1:61613, vhost: '/', user: 'guest'), channel 1: 625 operation none caused a channel exception precondition_failed: consumer ack timed out on channel 1 626 2023-01-09 00:15:39.182 [error] <0.2408.0> STOMP error frame sent: 627 Message: precondition_failed 628 Detail: "PRECONDITION_FAILED - consumer ack timed out on channel 1\n" 629 Server private detail: none 630 2023-01-09 00:15:39.307 [info] <0.2408.0> closing STOMP connection <0.2408.0> (127.0.0.1:58134 -> 127.0.0.1:61613) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:50:00 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #30 from David Cook --- I'm thinking that the prefetch config I provided isn't working with Net::Stomp... I enqueue 100 messages and then I look at the channel. root at kohadevbox:kohadevbox$ rabbitmqctl list_channels Listing channels ... pid user consumer_count messages_unacknowledged guest 1 0 guest 1 99 According to https://www.rabbitmq.com/rabbitmqctl.8.html, messages_unacknowledged means that many messages have been delivered but haven't been acknowledged. The Net::Stomp library was set up to work with ActiveMQ, and I made the mistake of assuming that some of the config option naming was labelled for ActiveMQ but could be used for other providers. That's my bad. I'm working on a better fix now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 01:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 00:58:12 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #31 from David Cook --- Created attachment 145134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145134&action=edit Bug 32481: Use correct prefetch syntax for RabbitMQ According to https://www.rabbitmq.com/stomp.html the header to use for managing the prefetch is "prefetch-count". You can verify the number of delivered and unacknowledged messages on a channel on a connection by running "rabbitmqctl list_channels" on the RabbitMQ host. This will tell you how many messages have been delivered and are awaiting acknowledgement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 02:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 01:04:13 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #32 from David Cook --- (In reply to Jonathan Druart from comment #25) > I am giving up, need help. I am terribly sorry for wasting your time on this one, Jonathan. I solved this problem on a different project using https://metacpan.org/pod/Net::AMQP::RabbitMQ but couldn't directly translate it across, and just assumed the first thing that said "prefetch" on https://metacpan.org/pod/Net::Stomp#subscribe would be correct... Thanks for providing your testing patch, as that helped me to figure out the prefetch config wasn't working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 02:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 01:08:15 +0000 Subject: [Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #33 from David Cook --- That 3rd patch "Bug 32481: Use correct prefetch syntax for RabbitMQ" uses the correct syntax, so the worker only fetches 1 message at a time ( see https://www.rabbitmq.com/stomp.html#pear.p ) Jonathan's test_bg.pl script completes perfectly with it. No time outs. You can verify it using "rabbitmqctl list_channels" as well. Once testers are happy, I'd suggest obsoleting Jonathan's patch and then squashing my 2 patches together. -- Of course, as I note above, the 30 minute timeout will still be an issue for any 1 job that takes longer than 30 minutes. But now I'm confident that Nick's case of 6 jobs of 6 minutes each will be resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 02:19:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 01:19:20 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #22 from David Cook --- Was tempted to Fail QA this one, but I haven't actually tested if the current patch won't work in practice. But I think moving the forking up as I describe above would be a wise move. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 06:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 05:11:01 +0000 Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process multiple jobs simultaneously up to a limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558 --- Comment #23 from David Cook --- (In reply to Kyle M Hall from comment #10) > Would that work with the database polling method? I think that would require > some re-engineering. Upon review, that won't work with having multiple pre-forked processes either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 06:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 05:12:53 +0000 Subject: [Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #18 from David Cook --- Do we have any examples of this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 08:03:38 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 --- Comment #17 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #16) > I am not sure if this is a feature that we should implement given the > possible security/spam implications. A bot or human misusing the feature > could get the library's email address blacklisted for example. > > Would someone else support a CLOSED WONTFIX? Yes, we should close it. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 08:26:48 +0000 Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276 --- Comment #4 from Michaela Sieber --- +1 I totally agree with Kelly ! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 08:37:37 +0000 Subject: [Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:49:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 08:49:05 +0000 Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25655 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:49:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 08:49:05 +0000 Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18412 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:31:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 09:31:33 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:35:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 09:35:14 +0000 Subject: [Koha-bugs] [Bug 32593] New: Item search option location breaks with only one location defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32593 Bug ID: 32593 Summary: Item search option location breaks with only one location defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When there is only one location (LOC) configured, the search option for locations on item search is not generated correctly. It shows the 'all locations' option and then 3 empty (no description) entries: As soon as a second location is configured, the list will be generated correctly. To test: * delete all LOC entried, but one, I left REF in the sandbox * Go to item search * Verify that only 'all locations displays' with 3 clickable empty entries below * Add another LOC entry * Verify the list now works again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:03:00 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 --- Comment #10 from Martin Renvoize --- Created attachment 145135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145135&action=edit Bug 32505: [ALT] Use column 'type' to pre-process search patterns This patch adds the option to pass 'type' at the 'column' definition level and then binds on that type to add date parsing to queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:03:39 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:04:44 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 --- Comment #11 from Martin Renvoize --- Could you take a quick look at my alternative patch Jonathan? If you disagree with it, then we can just drop it and revert the status to PQA, but I wanted to show my option at the datatables.js level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:06:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:06:45 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #12 from Martin Renvoize --- Ack, ignore that.. this is about the left side search, not the column filters.. dropping my patch and reverting to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:06:58 +0000 Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:13:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:13:22 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #13 from Martin Renvoize --- (In reply to Jonathan Druart from comment #10) > Ideally we could have use 'type' > (https://datatables.net/reference/option/columns.type) with type=date. What > I've tried first. > But it got removed by DT because it's not useful when server-side processing > is used: > """Please note that if you are using server-side processing (serverSide) > this option has no effect since the ordering and search actions are > performed by a server-side script.)""" Interesting.. I tried with 'type' instead of 'datatype' and it didn't get dropped for me.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:14:34 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 --- Comment #14 from Martin Renvoize --- Created attachment 145136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145136&action=edit Bug 32559: [ALT] Use column 'type' to pre-process search patterns This patch adds the option to pass 'type' at the 'column' definition level and then binds on that type to add date parsing to queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:15:42 +0000 Subject: [Koha-bugs] [Bug 24231] Create classes to the message that was created with sys pref UpdateItemLocationOnCheckin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24231 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:15:57 +0000 Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering (DT) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Martin Renvoize --- Temporarily in discussion whilst I catch Jonathan... I'm still of the opinion his patchset is a bit more functional than mine.. but I am interested to see why the 'type' term didn't work for him when it worked in my patch? Assuming I'm mis-understanding something somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:38:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:38:51 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:38:54 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #3 from Jacob O'Mara --- Created attachment 145137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145137&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 10:39:36 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Assignee|koha-bugs at lists.koha-commun |jacob.omara at ptfs-europe.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From michael.karani at puea.ac.ke Mon Jan 9 11:40:07 2023 From: michael.karani at puea.ac.ke (Karani, Michael) Date: Mon, 9 Jan 2023 13:40:07 +0300 Subject: [Koha-bugs] What is the solution to bug 14783 Message-ID: 'm getting the following while trying to upgrade, my koha schema? If possible, provide me with the solution on how to solve it. Upgrade to 22.06.00.064 [13:41:05]: Bug 14783 - Allow patrons to change pickup location for non-waiting holds ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You can't specify target table 'systempreferences' for update in FROM clause at /usr/share/koha/lib/C4/Installer.pm line 739 Added new system preference 'OPACAllowUserToChangeBranch' ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You can't specify target table 'systempreferences' for update in FROM clause at /usr/share/koha/lib/C4/Installer.pm line 739 -- * * *Disclaimer*: This e-mail and attachments are confidential and may be privileged and protected from discovery or disclosure. If you are not the intended recipient, be aware that any disclosure, copying, dissemination, or use of this e-mail or any attachments is prohibited. If you have received this e-mail in error, please notify the sender immediately and erase all copies of the message and its attachments. Any views expressed are those of the individual sender(s) and may not necessarily reflect the views of The Presbyterian University of East Africa -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:16:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:16:48 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:16:56 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:17:04 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:23:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:23:44 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:23:50 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145137|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 145138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145138&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:26:49 +0000 Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:27:29 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #6 from Martin Renvoize --- Comment on attachment 145127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145127 Bug 32450: Noissuescharge debit type exclusions Review of attachment 145127: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32450&attachment=145127) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +711,5 @@ > my ($self) = @_; > > + my @fines; > + my $dbh=C4::Context->dbh; > + my $sth = $dbh->prepare("SELECT code FROM account_debit_types WHERE no_issues_charge = 1"); Sorry Matt, this will need to be converted to a DBIC style lookup rather than using a handle.. we dis-sallow direct SQL in the Koha:: namespace. https://metacpan.org/pod/DBIx::Class::ResultSet#search is a good starting place for how this works.. especially the WHERE clause link from it. tl:dr; It'll be something along the lines my $blocking_types => Koha::Debit::Types->search({ no_issues_charge => 1 }, { columns => 'code' }); Then the ->lines->search could use it inline. $self->lines->search( { debit_type_code => { '-in' => $blocking_types } } ); This so pseudo code untested ;P ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt @@ +220,2 @@ > > + [% IF !debit_type.archived %] Hmm, I wonder if at least some of the fields in system level types need to be marked as read only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:27:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:27:41 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:32:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:32:16 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #7 from Martin Renvoize --- Comment on attachment 145128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145128 Bug 32450: Update db to add noissuescharge flag and remove sysprefs Review of attachment 145128: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32450&attachment=145128) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl @@ +6,5 @@ > + up => sub { > + my ($args) = @_; > + my ($dbh, $out) = @$args{qw(dbh out)}; > + > + if( !column_exists( 'account_debit_types', 'no_issues_charge' ) ) { I'd be tempted to name this 'blocks_issue' or 'prevents_issue' or something as opposed to 'no_issues_charge'. @@ +15,5 @@ > + say $out "Added column 'account_debit_types.no_issues_charge'"; > + } > + > + $dbh->do(q{ > + DELETE FROM systempreferences WHERE variable = 'ManInvInNoissuesCharge' We'll need an extra step in here I'm afraid.. We're not accounting for the current state of the system preference at upgrade time. You'll want to check the current value of ManInvInNoissuesCharge and set the boolean flag for the appropriate, prior to this patch hard coded, set of debit types based on it. @@ +19,5 @@ > + DELETE FROM systempreferences WHERE variable = 'ManInvInNoissuesCharge' > + }); > + > + $dbh->do(q{ > + DELETE FROM systempreferences WHERE variable = 'RentalsInNoissuesCharge' As above @@ +22,5 @@ > + $dbh->do(q{ > + DELETE FROM systempreferences WHERE variable = 'RentalsInNoissuesCharge' > + }); > + $dbh->do(q{ > + DELETE FROM systempreferences WHERE variable = 'HoldsInNoissuesCharge' As above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:32:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:32:55 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This adds the "Price paid" release notes| |column to the inter-library | |loan requests table. This | |column is also configurable | |using the Columns button | |and in the table settings | |(Administration > | |Additional parameters > | |Table settings > | |Interlibrary loans > | |ill-requests). --- Comment #5 from David Nind --- Hi Jacob. One minor thing that needs fixing - the column title should be in sentence case, so "Price paid" instead of "Price Paid". I've also added a draft release note. David Testing notes (using KTD): 1. I enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:46:52 +0000 Subject: [Koha-bugs] [Bug 4363] Support the patron internet resources field in Sip2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4363 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > Martin or Kyle, could you have a look at this old bug from Colin please? Enhancement bug filed 12 years ago. Definitely something that could be implemented but a plan would need to be developed. Considering the length of time since filing I'd like to know from Martin if it's still needed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:49:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:49:57 +0000 Subject: [Koha-bugs] [Bug 20473] "Item information" tab should not appear if item is not created upon placing an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal Text to go in the|This updates adding an | release notes|order to a basket from a | |staged file (when the | |setting for the basket is | |to not create items until | |the order is received or | |catalogued) so that the | |'Item information' tab | |doesn't appear, as it is | |not used. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 12:59:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 11:59:06 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #5 from Kyle M Hall --- (In reply to David Cook from comment #4) > If you were doing a big batch record modification and you suffered a power > outage on the machine where the background job worker is running, then that > task can't be re-started since the RabbitMQ message was already ACKed before > the real work began. > > (Of course, in the case of Koha, we have the "database failover", so in > theory it might get recovered, but it's not standard design.) Considering batch record modifications are not atomic, I don't think that's necessarily a compelling argument. I can't see any scenario where either: A) We should ack before processing. We are stymying Koha's ability to do background processing by running extrememly long processes in serial with no way to fork multiple background jobs at one. B) RabbitMQ/STOMP is the wrong tool for the job and we should remove it's use from Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:03:03 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145138|0 |1 is obsolete| | --- Comment #6 from Jacob O'Mara --- Created attachment 145139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145139&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:04:36 +0000 Subject: [Koha-bugs] [Bug 32573] background_jobs_worker.pl should ACK a message before it forks and runs the job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32573 --- Comment #6 from Kyle M Hall --- > I can't see any scenario where either: > A) We should ack before processing. We are stymying Koha's ability to do > background processing by running extrememly long processes in serial with no > way to fork multiple background jobs at one. > > B) RabbitMQ/STOMP is the wrong tool for the job and we should remove it's > use from Koha. Actually, I can revise A a bit. We can fork and give the existing rabbit connection to the child process, and have the parent start a new connection to pass off again. That mains we can parallel process without acking first. It doesn't solve the 30 minutes time limit ( which is why I'm going to continue advocating for acking first ) but it does improve the situation greatly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:04:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:04:55 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145139|0 |1 is obsolete| | --- Comment #7 from Jacob O'Mara --- Created attachment 145140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145140&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:07:48 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:07:52 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145022|0 |1 is obsolete| | Attachment #145023|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 145141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145141&action=edit Bug 32349: Remove TEST_QA There is an env var that we are passing from koha-testing-docker, TEST_QA. It's used in Koha from a single test file, t/00-testcritic.t. If not set, no test is run. Do we really need this? libtest-perl-critic-perl is packaged and automatically installed. Signed-off-by: Mason James Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:07:57 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 --- Comment #15 from Marcel de Rooy --- Created attachment 145142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145142&action=edit Bug 32349: Remove find-nonutf8 tests We don't run it and it does not seem very useful. Let's remove it. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:08:03 +0000 Subject: [Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20809 CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- I suspect the issue is from bug 20809, members-menu.js: + $(".edit-patronimage").on("click", function(e){ + e.preventDefault(); + var borrowernumber = $(this).data("borrowernumber"); + $.get("/cgi-bin/koha/members/moremember.pl", { borrowernumber : borrowernumber }, function( data ){ + var image_form = $(data).find("#picture-upload"); + image_form.show().find(".cancel").remove(); + $("#patronImageEdit .modal-body").html( image_form ); + }); + var modalTitle = $(this).attr("title"); + $("#patronImageEdit .modal-title").text(modalTitle); + $("#patronImageEdit").modal("show"); + }); It looks like we are fetching the form via JS, maybe is causing the CSRF mismatch? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 [Bug 20809] Link patron image to patron image add/edit form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:08:03 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 [Bug 31492] Patron image upload fails on first attempt with CSRF failure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:08:40 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Marcel de Rooy --- Moving furter to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:09:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:09:05 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > I decided to remove it, what do you think? Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:09:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:09:21 +0000 Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:09:22 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #8 from Jacob O'Mara --- Hi David, Thanks for the above, casing has been amended on the column and the commit has been reattached. Jacob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:11:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:11:57 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144720|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop --- Created attachment 145143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145143&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:36:39 +0000 Subject: [Koha-bugs] [Bug 31221] Buttons overflow in OPAC search results in mobile view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Owen Leonard --- I think adding "flex-wrap: wrap" to the pagination links is the correct solution, but I think it should be applied more broadly. I would put it in opac.scss at line 1420: .pagination { flex-wrap: wrap; margin: 0; } } The number of pagination links depends entirely on the number of search results, so we can't assume that they'll overflow at any particular browser width. The wrapping pagination links aren't as clean-looking, but it's a better option than the horizontal scroll. Also: Please be careful about your indentation in patches: We use 4 spaces, not tab characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:37:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:37:38 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145143|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop --- Created attachment 145144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145144&action=edit Bug 32474: Ajax based infinite scroll selects I have created a reuseable component called InfiniteScrollSelect which allows v-selects to load options in a paginated manner through Ajax requests rather than making expensive Ajax calls when the select box is first opened. All v-selects that are likely to need this functionality have been updated for Agreements, Licenses, Packages and Vendors. Test Plan: To test this requires adding enough dummy data to show the pagination fully. I have written a script that does this, please see the attachments if you wish to use this. 1) Navigate to a window that offers a dropdown menu for either Vendors, Agreements, Licenses, Packages. 2) Observe that all data is already pre-loaded into the options list and only one request is made for this data regardless of data size 3) Apply patch 4) Navigate to the same select box and observe that only the first 20 values are available with paginated Ajax requests being made as you scroll down -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:38:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:38:36 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:38:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 12:38:48 +0000 Subject: [Koha-bugs] [Bug 4363] Support the patron internet resources field in Sip2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4363 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Martin Renvoize --- I can't remember who was using this but it hasn't come up in upgrades any time recently.. lets kill it off here -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:05:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:05:56 +0000 Subject: [Koha-bugs] [Bug 32594] New: Add a dedicated ES indexing background worker Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Bug ID: 32594 Summary: Add a dedicated ES indexing background worker Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com When pushing the ES indexing jobs to the background queue, we have found it is hard for the workers to keep up in production. During high circulation times there are many single record reindexes produced. It would be nice to have a dedicated ES worker that can batch these to reduce the processing time and reduce the hits to the ES server -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:28:06 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:29:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:29:41 +0000 Subject: [Koha-bugs] [Bug 32595] New: Price format cost in ILL requests table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32595 Bug ID: 32595 Summary: Price format cost in ILL requests table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de The table with all ILL requests on the start page of the ILL module shows the Cost as 4.00 indepent of the PriceFormat system preference. It needs to have price formatting applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:32:00 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #9 from Katrin Fischer --- I just filed a bug about the missing price formatting - it might apply to this column as well (maybe a new bug?) Bug 32595 - Price format cost in ILL requests table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:43:36 +0000 Subject: [Koha-bugs] [Bug 31651] Log message incorrect in Auth_with_shibboleth.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:47:37 +0000 Subject: [Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:49:28 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:49:38 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:52:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:52:39 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:52:44 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 --- Comment #1 from Nick Clemens --- Created attachment 145145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145145&action=edit Bug 32594: Add a dedicated Elasticsearch biblio indexing background queue Currently we generate large numebrs if single record reindex for circulation and other actions. It can take a long time to process these as we need to load the ES settings for each. This patch updates the Elasticsearch background jobs to throw records into a new queue that can be processed by it's own worker and adds a dedicated worker that batches the jobs every 1 second. To test: 1 - Apply patches, set SearchEngine system preference to 'Elasticsearch' 2 - perl misc/search_tools/es_indexer_daemon.pl 3 - Leave the running in terminal and perform actions in staff interface: - Checking out a bib - Returning a bib - Editing a single bib - Editing a single item - Batch editing bibs - Batch editing items 4 - Confirm for each action that records are updated in search/search results 5 - Stop the script 6 - set SearchEngine system preference to 'Zebra' 7 - perl misc/search_tools/es_indexer_daemon.pl 8 - Script dies as Elasticsearch not enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:53:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:53:35 +0000 Subject: [Koha-bugs] [Bug 32594] Add a dedicated ES indexing background worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Blocks| |32572 CC| |dcook at prosentient.com.au, | |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 [Bug 32572] We should have a background queue for each job type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 14:53:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 13:53:35 +0000 Subject: [Koha-bugs] [Bug 32572] We should have a background queue for each job type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32572 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 [Bug 32594] Add a dedicated ES indexing background worker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:09:08 +0000 Subject: [Koha-bugs] [Bug 32596] New: Background jobs viewer not showing finished jobs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Bug ID: 32596 Summary: Background jobs viewer not showing finished jobs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It seems that the filters are based on 'started_on' - I think 'enqueued_on' makes more sense To recreate: 1 - Do a bunch of stuff in the staff interface the will generate background jobs 2 - Wait a bit to make sure all the jobs are done 3 - Visit Admin->Jobs 4 - Note there is nothing shown 5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour' 6 - Note that nothing is shown, but header says '(filtered from X jobs)' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:10:29 +0000 Subject: [Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:10:33 +0000 Subject: [Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 --- Comment #1 from Nick Clemens --- Created attachment 145146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145146&action=edit Bug 32596: Filter jobs by enqueued on, not started on To test: 1 - Do a bunch of stuff in the staff interface the will generate background jobs 2 - Wait a bit to make sure all the jobs are done 3 - Visit Admin->Jobs 4 - Note there is nothing shown 5 - uncheck 'Current jobs only' and 'Only include jobs started in the last hour' 6 - Note that nothing is shown, but header says '(filtered from X jobs)' 7 - Apply patch 8 - Reload table 9 - Confirm you can see the finished jobs now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:10:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:10:42 +0000 Subject: [Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:10:49 +0000 Subject: [Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:11:03 +0000 Subject: [Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:13:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:13:05 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #62 from Marcel de Rooy --- Looking back at these patches, I am wondering if the misc script can support multiple queues in one process but koha-worker does not ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:32:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:32:06 +0000 Subject: [Koha-bugs] [Bug 27783] Introduce background job queues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #62) > Looking back at these patches, I am wondering if the misc script can support > multiple queues in one process but koha-worker does not ? True. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2023 14:53:45 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144754|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 145147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145147&action=edit Bug 32507: Use template wrapper to build breadcrumb navigation This patch lays the groundwork for updating the way we build breadcrumb navigation on each page, and implements it on the cities administration page as a proof of concept. The page creates two blocks, 'breadcrumbs' and 'breadcrumb_item' 'breadcrumbs' builds the outer structure of the menu, currently: