From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 21:58:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 20:58:36 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 21:58:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 20:58:41 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144855|0 |1
is obsolete| |
--- Comment #2 from David Nind ---
Created attachment 144895
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144895&action=edit
Bug 32537: Add no-block option to SIP cli emulator
This patch adds the option to pass a no-block option and use this
in checkout/checkin/renew messages
To test:
1 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp
term1 -m checkin --item 39999000010831
2 - Confirm out like:
SEND: 09N20221227 20183920221227
201839APCPL|AOCPL|AB39999000010831|ACterm1|BIN|
(Note the N after 09)
3 - Apply patch
4 - Restart SIP, repeat 1
5 - Confirm still an N
6 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp
term1 -m checkin --item 39999000010831 -n N
7 - Confirm still an N
8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp
term1 -m checkin --item 39999000010831 -n Y
9 - Confirm the send has a Y after 09
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 22:13:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 21:13:38 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
Text to go in the| |This enhanced adds the
release notes| |no-block option to the SIP
| |emulator for optional use
| |in checkout/checkin/renew
| |messages.
--- Comment #3 from David Nind ---
Koha testing notes (using KTD - used 39999000011418 as the item). I have
included the responses I got for the commands as there were unitialized values
reported in the output, and I don't know whether these are expected or not.
1. Response for step 1:
root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p
6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 120.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09N20230101 20473320230101
204733APCPL|AOCPL|AB39999000011418|ACterm1|BIN|
READ: 101YNN20230101 204734AOCPL|AB39999000011418|AQCPL|AJProgramming Perl
/|CRREF|
2. To restart SIP: koha-sip --restart kohadev
3. Response for step 4:
root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p
6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 124.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09N20230101 20543120230101
205431APCPL|AOCPL|AB39999000011418|ACterm1|BIN|
READ: 101YNN20230101 205431AOCPL|AB39999000011418|AQCPL|AJProgramming Perl
/|CRREF|
4. Response for step 6:
root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p
6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n N
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 124.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09N20230101 20552620230101
205526APCPL|AOCPL|AB39999000011418|ACterm1|BIN|
READ: 101YNN20230101 205526AOCPL|AB39999000011418|AQCPL|AJProgramming Perl
/|CRREF|
5. Response for step 8:
root at kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p
6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 124.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09Y20230101 20561720230101
205617APCPL|AOCPL|AB39999000011418|ACterm1|BIN|
Use of uninitialized value $data in concatenation (.) or string at
misc/sip_cli_emulator.pl line 356, chunk 1.
READ:
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 22:33:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 21:33:31 +0000
Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine
that does not exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #2 from David Nind ---
To test, I:
1. Repeated the steps in bug 32537 (including applying that patch).
2. Applied this patch and restarted SIP (koha-sip --restart kohadev).
3. The response I got for step 4 was:
root at kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p
6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 124.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09Y20230101 21213820230101
212138APCPL|AOCPL|AB39999000011418|ACterm1|BIN|
Use of uninitialized value $data in concatenation (.) or string at
misc/sip_cli_emulator.pl line 356, chunk 1.
READ:
I'm not sure if this is what is expected (as it is pretty similar to what I got
for bug 32537, except the second and third series of numbers in the SEND are
different), but happy to sign off if it is.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:14:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 22:14:38 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
locations are available
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:14:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 22:14:44 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
locations are available
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144825|0 |1
is obsolete| |
--- Comment #24 from David Nind ---
Created attachment 144896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144896&action=edit
Bug 30687: [alternate-alternate] Allow pickup locatoin to be forced when
override is allowed
This is Julian's patch with some extra cleanup to reduce repeated code
If AllowHoldPolicyOverride is enabled and only some pickup locations are
available, you still have the possibility to force one of the others
pickup locations.
But when there are zero pickup locations available, that is not
possible.
This patch change that by always displaying the list of pickup locations
when AllowHoldPolicyOverride is enabled.
Test plan:
1. Apply patch
2. Disable AllowHoldPolicyOverride
3. Create a biblio B with an item I at library A.
4. Configure this library A to not be a pickup location
5. Add a "Default holds policy by item type" for item I type where "Hold
pickup library match" is "item's home library"
6. Try to place a hold on biblio B
You should not be able to place a hold because there is no valid
pickup locations
7. Enable AllowHoldPolicyOverride
8. Try to place a hold on biblio B
You should now see all valid pickup locations in a dropdown list
(with an exclamation mark in front of each option) with none selected
by default
9. Verify you can place a title-level hold and an item-level hold
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:44:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 22:44:42 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
locations are available
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #25 from David Nind ---
I've tested and signed off the alternate-alternate patch.
I've drafted a release note - I don't feel confident enough that I've got this
right. Could someone check this, edit where appropriate, and add? Thanks! I'm
akso not sure if this was introduced in 21.11.
Draft release note:
This fixes a regression introduced in Koha 21.11(???). Previously, if hold
overrides were enabled (the AllowHoldPolicyOverride system preference) and
there was no pickup location available (for example, if a library was not a
pickup location), then it was still possible to select an alternative pickup
location. This restores this ability - by default no pickup location is
selected, but any location can now be selected from the dropdown list (each
option now has an exclamation mark at the end with the message "This pickup
location is not allowed according to circulation rules").
Note: the test plan says the exclamation mark is at the start of the option,
but for me it displayed at the end.
Also, does this need a note about how some libraries want to be able to place
unfillable holds for a variety of reasons? (see comment #7 and following
discussions).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:37 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:05:37 +0000
Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot
be batch deleted/modified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:05:42 +0000
Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot
be batch deleted/modified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144888|0 |1
is obsolete| |
--- Comment #15 from David Nind ---
Created attachment 144897
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144897&action=edit
Bug 31611: Clearly highlight items that cannot be modified/deleted in the Batch
item tools
Test plan:
1. Apply patches
2. Check out an item with a different home branch than the library
you're logged in as
3. Go to: 'Cataloguing' > 'Batch item deletion'
4. Into the barcode list area paste the checked-out item's barcode and the
barcode of a non-checked out item (with the same home library as the branch
you're logged in as) and submit the form
5. Observe in the table that loads the row containing the checked out item is
highlighted
yellow, and it has a red cross in the first column.
6. Hover over the red cross to see the reason why you cannot delete the
item appears
7. Observe the non checked out item has a checkbox and is not
highlighted yellow
8. Click 'Select all' and 'Clear all' links and notice the display of
the checked out item remains unchanged
9. Change 'IndependentBranches' syspref = 'yes'
10. Log into the staff client as a patron with only the '(catalogue)',
'(editcatalogue)', and '(tools)'
permissions selected
11. Go to: 'Cataloguing' > 'Batch item modification'
12. Enter the checked-out item's barcode and a non-checked out item's
barcode and submit the form
13. Observe the table row for the checked out item is again highlighted
yellow, with a red cross.
14. Hover over the red cross and observe the text 'Cannot edit' is shown
15. Observe the non-checked out item is not highlighted yellow and does
have a checkbox
Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:05:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:05:48 +0000
Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot
be batch deleted/modified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144890|0 |1
is obsolete| |
--- Comment #16 from David Nind ---
Created attachment 144898
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144898&action=edit
Bug 31611: Clearly highlight biblios that cannot be deleted in the Batch record
deletion tool
Test plan:
1. Apply patch
2. Check out an item
3. Go to: 'Cataloguing' > 'Batch record deletion'
4. Into the 'Enter a list of record numbers' area paste in the
biblionumber belonging to the checked-out item and that of a biblio without
checked out items
5. Submit the form
6. Observe the row of the biblio with checked-out items is highlighted yellow,
with a
red cross in the first column
7. Hover over the red cross to see the reason why the biblio cannot be
deleted
8. Observe the row of the biblio without checked-out items is not
highlighted yellow, and does have a checkbox in the first column
9. Click 'Delete selected records'
10. Confirm the biblio without checked-out items is successfully deleted
Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:12:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:12:55 +0000
Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot
be batch deleted/modified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |This enhancement more
release notes| |clearly emphasises records
| |that cannot be modified or
| |deleted in the 'Batch
| |record deletion', 'Batch
| |item modification', and
| |'Batch item deletion'
| |tools. Rows are now
| |highlighted in yellow, with
| |a red 'X' in the first
| |column (hovering over the
| |red 'X' shows the reason it
| |cannot be modified or
| |deleted).
Version(s)|More clearly emphasise |
released in|records that cannot be |
|modified/deleted in the |
|'Batch record deletion', |
|'Batch item modification', |
|and 'Batch item deletion' |
|tools. |
CC| |david at davidnind.com
--- Comment #17 from David Nind ---
Moved release notes from the version(s) released in field to the text to go in
the release notes field, and edited slightly...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:50:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:50:16 +0000
Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC
after switch to Bootstrap tabs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:50:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:50:21 +0000
Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC
after switch to Bootstrap tabs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144869|0 |1
is obsolete| |
--- Comment #5 from David Nind ---
Created attachment 144899
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144899&action=edit
Bug 31248: Fix responsiveness of tables on OPAC summary page
This patch adds back the responsive styles of the tables on the OPAC summary
page. This includes all of the following tables that may appear:
opac-user-checkouts
opac-user-relative-issues
opac-user-overdues
opac-user-fines
opac-user-relative-fines
opac-user-clubs
opac-user-holds
opac-user-recalls
opac-user-article-requests
opac-user-overdrive
opac-user-recordedbooks
To test:
1) Make sure you have checkouts in your account
2) Log into the OPAC
--> In 'Your summary' current checkouts are in a table
3) Go to 'You checkout history'
--> Current and previous checkouts are in a table
4) Switch to mobile view (in Firefox, Ctrl + Shift + M)
--> Checkout history is still in a table and the last column is not entirely
visible (depending on the content of the columns, I suppose)
5) Go to 'Your summary'
--> Current checkouts are presented in list form instead of a table
6) Apply patch and rebuild the OPAC CSS (
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface
)
7) Try the tables again, they should appear in a list form when the screen is
smaller than 608px.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 00:53:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jan 2023 23:53:07 +0000
Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC
after switch to Bootstrap tabs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #6 from David Nind ---
Should I log a separate bug for the 'Checkout history' view (and maybe any
others that need changing)? This still shows for me as a table and not a list,
but is scrollable.
Ideally, it should be as consistent as possible, and I agree with Caroline that
the list view is easier to read on a mobile.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 09:51:58 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 08:51:58 +0000
Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #6 from Jonathan Druart ---
I am getting a conflict, can you rebase please?
Also, could you run the tidy script, I am seeing invalid changes:
- licenses: [],
+ licenses: [],
(space at the end of the line)
Make sure you set up the pre-commit git hook
https://wiki.koha-community.org/wiki/Tips_and_tricks#Hooks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 10:09:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 09:09:43 +0000
Subject: [Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in
MARC-Editor don't work as expected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523
Jan Kissig changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 10:48:11 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 09:48:11 +0000
Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #6 from Thibaud Guillot ---
Anyone get the same error than David ? So I tested right now and it's working
for me
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:10:54 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:10:54 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:11:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:11:00 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
--- Comment #15 from Thibaud Guillot ---
Created attachment 144900
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144900&action=edit
Bug 10762: (follow-up) Update test plan, add kohastructure.sql files
I also change the default value for scale_height to '0.01'
Test plan:
1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout
2)Make a new layout or edit an existing one
3)Notice the 2 new fields "Barcode width/Barcode height"
4)Save it like this
5)Create a batch of barcode and export if in PDF
6)Notice the size of barcode
7)Go back to your existing layout
8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save
9)Take back your batch of barcode and export it in PDF
10)The barcode should be 2x bigger
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:15:01 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:15:01 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |thibaud.guillot at biblibre.co
| |m
--- Comment #16 from Thibaud Guillot ---
(In reply to Katrin Fischer from comment #13)
> 1) QA test tools:
>
> FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl
> FAIL file permissions
> File must have the exec flag
>
> 2) See comment#11, it looks like the original value was 0.01:
>
> + scale_height => 0.02,
>
> - my $barcode_y_scale_factor = 0.01 * $self->{'height'}; #
> this scales the barcode height to 10% of the label height
>
> 3) Defaults
>
> Just a question, maybe someone else can answer that one too:
>
> The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the
> database and also sets the defaults in new.
>
> Should we do both or would one option suffice?
>
> 4) Changes to kohastructure.sql are missing
Hello Katrin,
Normally I fixed this things on my last 'push'
For default value (repeat in sql and view on 'sub new()' I'm not an expert but
it like the same than 'layout_name' for example (set to 'DEFAULT' in default
sql value and also in the template when we passed vars).
I hope this will be okay for everyone :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:15:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:15:26 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|cnighswonger at foundations.ed |thibaud.guillot at biblibre.co
|u |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:16:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:16:31 +0000
Subject: [Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|cnighswonger at foundations.ed |thibaud.guillot at biblibre.co
|u |m
CC| |thibaud.guillot at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:19:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:19:17 +0000
Subject: [Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819
--- Comment #1 from Thibaud Guillot ---
Hello all,
I'm interested in your advice on this because like this comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762#c3 (related to
the original bug) it may - may need to change the way barcodes are generated
for this improvement. What do you think about it ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:22:30 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:22:30 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
--- Comment #6 from Jonathan Druart ---
Created attachment 144901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144901&action=edit
Bug 32528: Change return logic
Back to 1 return statement
Prevent the Koha::Result::Boolean instanciation duplication
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:32:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:32:12 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
--- Comment #7 from Jonathan Druart ---
This patch seems to simplify and make the method more readable, but I guess
it's a matter of taste. Feel free to obsolete it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:52:31 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |31798
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798
[Bug 31798] REST API: POST endpoint for Items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:52:31 +0000
Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |31799
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
[Bug 31799] REST API: PUT endpoint for Items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:52:37 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:52:37 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
--- Comment #1 from Agustín Moyano ---
Created attachment 144902
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144902&action=edit
Bug 31799: Add REST endpoint to modify a biblio's item
To test:
1. Apply patch
2. Set RESTBasicAuth preference to true
3. Get a biblio with an item
4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json
body that represents an item to replace
5. Check that the item was modified
6. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:57:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:57:59 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #143745|0 |1
is obsolete| |
Attachment #143746|0 |1
is obsolete| |
Attachment #143747|0 |1
is obsolete| |
Attachment #143748|0 |1
is obsolete| |
Attachment #143749|0 |1
is obsolete| |
Attachment #143750|0 |1
is obsolete| |
Attachment #143751|0 |1
is obsolete| |
Attachment #143752|0 |1
is obsolete| |
Attachment #143753|0 |1
is obsolete| |
Attachment #143754|0 |1
is obsolete| |
Attachment #143755|0 |1
is obsolete| |
Attachment #143756|0 |1
is obsolete| |
Attachment #143757|0 |1
is obsolete| |
Attachment #143758|0 |1
is obsolete| |
Attachment #143759|0 |1
is obsolete| |
Attachment #143760|0 |1
is obsolete| |
Attachment #143761|0 |1
is obsolete| |
Attachment #143762|0 |1
is obsolete| |
Attachment #143763|0 |1
is obsolete| |
--- Comment #95 from Jonathan Druart ---
Created attachment 144903
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144903&action=edit
Bug 31095: Add Koha::Patron::Restriction(s)
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:06 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #96 from Jonathan Druart ---
Created attachment 144904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144904&action=edit
Bug 31095: Add restrictions accessor to Koha::Patron
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:13 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #97 from Jonathan Druart ---
Created attachment 144905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144905&action=edit
Bug 31095: Add type relation accessor to Koha::Patron::Restriction
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:20 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #98 from Jonathan Druart ---
Created attachment 144906
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144906&action=edit
Bug 31095: Remove GetDebarments from circ/circulation.pl
This patch remove the use of GetDebarments from circ/circulation.pl,
replacing it with a reference to patron.restrictions in the template and
includes.
Test plan
1. Confirm that the 'Restrictions (x)' tab still appears on the checkout
page for a user.
2. Confirm that the 'Restrictions (x)' tab count is correct
3. Confirm that the 'Restrictions (x)' tab table functions
4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form
works as expected
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:27 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #99 from Jonathan Druart ---
Created attachment 144907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144907&action=edit
Bug 31095: Remove GetDebarments from members/moremember.pl
This patch removes the use of GetDebarments from members/moremember.pl
and replaces template references with patrons.restrictions and the new
includes introduced in the prior patch
Test plan
1. Confirm that the 'Restrictions (x)' tab still appears on the patron
details page.
2. Confirm that the 'Restrictions (x)' tab count is correct
3. Confirm that the 'Restrictions (x)' tab table functions
4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form
works as expected
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:33 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #100 from Jonathan Druart ---
Created attachment 144908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144908&action=edit
Bug 31095: Remove GetDebarments from members/memberentry.pl
This patch removes the use of GetDebarments from members/memberentry.pl
and replaces the references in the templates with patron.restrictions.
Test plan
1. Add a new user and confirm that the patron restrictions section does
not appear on the form
2. Edit the user and confirm the patron restrictions section now appears
3. Add a manual restriction using the patron edit form
4. Confirm the restriction appears on the patron edit form
5. Confirm you can remove the restriction usine the patron edit form
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:41 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #101 from Jonathan Druart ---
Created attachment 144909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144909&action=edit
Bug 31095: Remove borrower_debarments and patron_restrictions includes
This patch removes the aforementioned includes and drops the last
remaining reference to them.
We have replaces these includes with patron-restrictions-tab.inc and
restriction-types.inc.
Test plan
1. Confirm the includes are no longer referenced anywhere in the
codebase. 'git grep borrower_debarments.inc', 'git grep
patron_restrictions.inc'
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:49 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #102 from Jonathan Druart ---
Created attachment 144910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144910&action=edit
Bug 31095: Remove keyed_on_code
We no longer require keyed_on_code from Koha::Patron::Restrictoin::Types
as we have relation accessors for the relevent use cases and no longer
reference the method anywhere in the codebase!
Test plan
1. Confirm 'keyed_on_code' is no longer referenced anywhere in the
codebase.
`git grep keyed_on_code`
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:58:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:58:59 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #103 from Jonathan Druart ---
Created attachment 144911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144911&action=edit
Bug 31095: Remove GetDebarments from tools/modborrowers.pl
This patch removes GetDebarments from the modborrowers tool controller
and replaces it with $patron->restrictions as appropriate.
Test plan
1. Confirm that the 'Batch patron modification' tool pages still load
and perform as expected.
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:07 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #104 from Jonathan Druart ---
Created attachment 144912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144912&action=edit
Bug 31095: Remove GetDebarments from Circulation.pm
This patch removes GetDebarments from Circulation.pm replacing them with
calls to $patron->restrictions and filtering using a chained search
call.
Test plan
1. Confirm that t/db_dependant/Circulation.t continues to pass
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:14 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #105 from Jonathan Druart ---
Created attachment 144913
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144913&action=edit
Bug 31095: Remove GetDebarments from Circulation.t
Replace GetDebarments with $patron->restrictions.
Test plan
1. Run test prior to patch - all should pass
2. Run test after patch - all should pass
3. Confirm no tests were removed as part of the patch
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:21 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #106 from Jonathan Druart ---
Created attachment 144914
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144914&action=edit
Bug 31095: Remove GetDebarments from Patron::Import
This patch replaced GetDebarments with $patron->restrictions->search in
Koha::Patron::Import.
Test plan
1. Confirm that importing patrons with debarred and debarredcomment
fields in the import still works as expected
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:27 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #107 from Jonathan Druart ---
Created attachment 144915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144915&action=edit
Bug 31095: Remove GetDebarments from maxsuspensiondays.t
This patch replaces GetDebarments in maxsuspensiondays.t with calls to
the restrictions accessor.
Test plan
1. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes prior
to this patch
2. Confirm t/db_dependent/Circulation/maxsuspensiondays.t passes after
this patch
3. Confirm no tests have been removed in this patch
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:35 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #108 from Jonathan Druart ---
Created attachment 144916
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144916&action=edit
Bug 31095: Remove GetDebarments from MarkIssueReturned.t
This patch removes GetDebarments from Ciculation/MarkIssueReturned.t
Test plan
1. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes prior
to the patch
2. Confirm t/db_dependent/Circulation/MarkIssueReturned.t passes after
the patch
3. Confirm no tests have been removed
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:41 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #109 from Jonathan Druart ---
Created attachment 144917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144917&action=edit
Bug 31095: Remove GetDebarments from Restriction/Type.t
This patch replaces GetDebarments with $patron->restrictions in
t/db_dependent/Koha/Patron/Restriction/Type.t
Test plan
1. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes prior to
the patch
2. Confirm t/db_dependent/Koha/Patron/Restriction/Type.t passes after
the patch
3. Confirm no tests were removed
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:48 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #110 from Jonathan Druart ---
Created attachment 144918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144918&action=edit
Bug 31095: Remove GetDebarments from Borrower_Debarments.t
This patch replaces calls to GetDebarments with teh
$patron->restritions->search() equivilents.
Test plan
1. Run the test prior to the patch and confirm it passes
2. Run the test after the patch and confirm it passes
3. Confirm no tests were removed
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 15:59:54 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 14:59:54 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #111 from Jonathan Druart ---
Created attachment 144919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144919&action=edit
Bug 31095: Remove GetDebarments from Koha::Patron::Debarments
This patch finally removes GetDebarments from the codebase.
Test plan
1. Confirm GetDebarments is no longer mentioned in the codebase. `git
grep GetDebarments`
2. Confirm t/db_dependent/Patron/Borrower_Debarments.t continues to pass
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:00:01 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 15:00:01 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #112 from Jonathan Druart ---
Created attachment 144920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144920&action=edit
Bug 31095: (QA follow-up) Fix after rebase
Signed-off-by: Nick Clemens
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:00:08 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 15:00:08 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
--- Comment #113 from Jonathan Druart ---
Created attachment 144921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144921&action=edit
Bug 31095: (follow-up) Iterate debarments in batch mod
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:35:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 15:35:06 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
in tests by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353
--- Comment #15 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #14)
> Might be something else ?
I think so, it's passing for me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:37:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 15:37:23 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
in tests by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 16:38:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 15:38:29 +0000
Subject: [Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined
in tests by default
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353
--- Comment #16 from Jonathan Druart ---
Original problem found with the following warning:
Odd number of elements in anonymous hash at t/db_dependent/Circulation.t line
5719.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:19:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 16:19:44 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:19:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 16:19:48 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
--- Comment #5 from Jonathan Druart ---
Created attachment 144922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144922&action=edit
Bug 32505: Restore patron search by formatted dob
Prior to the rewrite of the patron searches (bug 30063 and friends) it
was possible to search for a patron using their date of birth, formatted
following the dateformat syspref.
Now it only works if the date is iso formatted.
This patch is providing a fix to restore the behaviour, but does not
make it consistent. Only searching patrons by date of birth is fixed
here, when we actually want to fix the problem for the REST API DT
wrapper instead.
Test plan:
Search for patrons given their date of birth. You need to select "date
of birth" in the "Search field" dropdown, or set it in
DefaultPatronSearchFields.
Note that the column filtering is still not working, but I guess it was
the case already in older versions. Ideally we will need to have a
"datatype" attribute passed to the the 'th' and retrieved from
datatables.js to add this same trick and build the query appropriately.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:20:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 16:20:07 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
|ity.org |com
CC| |jonathan.druart+koha at gmail.
| |com
Severity|minor |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:25:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 16:25:00 +0000
Subject: [Koha-bugs] [Bug 31095] Remove
Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in
preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #114 from Jonathan Druart ---
1.
FAIL Koha/Patron/Restriction.pm
FAIL pod
*** WARNING: empty section in previous paragraph in file
Koha/Patron/Restriction.pm
FAIL Koha/Patron/Restrictions.pm
FAIL pod
*** WARNING: empty section in previous paragraph in file
Koha/Patron/Restrictions.pm
2. Koha/Patron/Restriction.pm:=head2 Relation accessors
Why? This is not used anywhere else. We use "Class methods".
3. 64
I think it's always better to pass the parameter, even if not needed
=> [% PROCESS restriction_type_description restriction_type => restriction_type
%]
Nothing considering blocker, passing QA. Please go ahead with bug 31458 and
friends, I will be happy to QA them!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:57:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 16:57:07 +0000
Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t
is_going_to_expire fails on U18
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:03:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:03:38 +0000
Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows
non-archived suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:03:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:03:43 +0000
Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows
non-archived suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144872|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 144923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144923&action=edit
Bug 32531: Restore behaviour of 'include archived' filter
In Suggestions management, there is a sidebar menu to organize and
filter suggestions. In the "Suggestion information" filter section,
there is a checkbox "Include archived". When this box us unchecked, the
archived suggestions are not displayed. When this box is checked, all
suggestions are displayed, archived, and not archived. This is not the
case anymore, only archived suggestions are displayed, supposedly since
patch for bug 23991.
TO TEST:
1. On a Koha installation remove all suggestions (in the table).
2. Create two suggestions. Archive one of them.
3. Check/Uncheck filter 'Include Archived'. Confirm that when the box is
checked, you don't see anymore the unarchived suggestion.
4. Apply the patch.
5. Repeat 3, and confirm that the filter operates properly.
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:04:19 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:04:19 +0000
Subject: [Koha-bugs] [Bug 32531] Filter 'Include archived' no longer shows
non-archived suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
Keywords| |rel_22_11_candidate
Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr
|ity.org |
--- Comment #4 from Jonathan Druart ---
Oops, silly mistake!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:19:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:19:35 +0000
Subject: [Koha-bugs] [Bug 32554] New: Test prediction pattern does not
consider subscription length (uses only subscription end date)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554
Bug ID: 32554
Summary: Test prediction pattern does not consider subscription
length (uses only subscription end date)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: caroline.cyr-la-rose at inlibro.com
QA Contact: testopia at bugs.koha-community.org
When creating a new serial subscription, it used to be that we could enter
either a subscription length (number of issues, months or weeks) OR a
subscription end date. When we would test the prediction pattern, it would show
the right number of issues based on one of these values. Now it seems that if
we only enter a number of issues for the subscription length and test the
prediction pattern, not only does it tell us we're not being consistent with
our end date (I thought it was optional?) but it also doesn't show the correct
number of issues.
To test:
1. For this, I created my own record, but you can skip this step and use any
existing record
1.1. Go to Cataloging
1.2. Click on New record
1.3. Fill out the manadatory fields (in MARC21, typically 000, 003, 005,
008, 040$c, 245$a and 942$c)
1.4. Click Save
1.5. Note the record number, do not create an item
2. Create a serial subscription
2.1. Go to Serials
2.2. Click on New subscription
2.3. Enter the record number
2.4. Click Next (and confirm you're not using a vendor)
2.5. Fill out the second form as follows
- First issue publication date: 2023-01-01
- Frequency: 1/month
- Subscription length: issues 24
- Subscription start date: 2023-01-01
- Subscription end date: leave empty
- Numbering pattern: Number
- Locale: leave empty
- Begins with: 42
- Inner counter: leave empty
2.6. Click on Test prediction pattern
--> Note there is a message saying "End date is not consistent with
subscription length." even if, normally, only one is needed
--> Only the issues until today are displayed (in my case, only the January
2023 issue), even if we said our subscription was for 24 issues
There is no problem if we enter a subscription end date. This means either the
subscription length problem is a bug, or end date is now mandatory and should
be displayed in red like other mandatory fields.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:22:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:22:57 +0000
Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider
subscription length (uses only subscription end date)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554
--- Comment #1 from Caroline Cyr La Rose ---
I tried this in 22.05.05 and it works fine with only a subscription length
(without a subscription end date). So it's something that was changed recently.
I haven't tried on a 22.11 though.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:48:30 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:48:30 +0000
Subject: [Koha-bugs] [Bug 32555] New: Error when viewing serial in OPAC
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555
Bug ID: 32555
Summary: Error when viewing serial in OPAC
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: caroline.cyr-la-rose at inlibro.com
QA Contact: testopia at bugs.koha-community.org
I'm getting a 500 error when trying to view a serial with issues in the OPAC.
The message is very long, but it starts with
Template process failed: undef error - The method Koha::Serial::Item->serialseq
is not covered by tests!
To test:
1. Create a serial subscription
1.1. Go to Serials
1.2. Click on New subscription
1.3. Fill out the first form
- Vendor: leave empty
- Record: enter a record number (I used 108)
- Create an item record when receiving this serial
- When there is an irregular issue: Keep issue number
- Manual history: leave unchecked
- Call number: leave empty
- Library: Centerville
- Public/nonpublic note: leave empty
- Patron notification: None
- Location: None
- Collection: None
- Item type: Continuing resources
- Grace period: leave empty
- Number of issues to display: leave both empty
1.4. Click Next (and confirm you are not using a vendor)
1.5. Fill out the second form
- First issue publication date: 2023-01-01
- Frequency: 1/month
- Subscription length: issues 12
- Subscription start date: 2023-01-01
- Subscription end date: 2024-01-01
- Numbering pattern: Number
- Locale: leave empty
- Begins with: 42
- Inner counter: leave empty
1.6. Click Test prediction pattern
1.7. Click Save subscription
2. Click OPAC view: Open in new window.
--> It should open normally in another tab/window and the record displays
without problem
3. Back in the staff interface tab, receive an issue
3.1. Click Receive
3.2. In Status, choose Arrived for No. 42
3.3. Click Save
4. Go back to the OPAC tab and refresh
--> Error
I put this bug as "major", but maybe it should be higher...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 18:49:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 17:49:32 +0000
Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider
subscription length (uses only subscription end date)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:04:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:04:52 +0000
Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Trivial patch |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:05:28 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:05:28 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Trivial patch |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:06:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:06:09 +0000
Subject: [Koha-bugs] [Bug 31800] REST API: POST endpoint for Biblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Trivial patch |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:06:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:06:26 +0000
Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Trivial patch |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:07:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:07:46 +0000
Subject: [Koha-bugs] [Bug 31793] REST API: DELETE endpoint for Authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31793
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |
|y.org |
CC| |tomascohen at gmail.com
Component|MARC Authority data support |REST API
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:07:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:07:57 +0000
Subject: [Koha-bugs] [Bug 31794] REST API: GET endpoint for Authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31794
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |
|y.org |
Component|MARC Authority data support |REST API
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:08:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:08:10 +0000
Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|MARC Authority data support |REST API
CC| |tomascohen at gmail.com
QA Contact|testopia at bugs.koha-communit |
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:08:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:08:21 +0000
Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|MARC Authority data support |REST API
CC| |tomascohen at gmail.com
QA Contact|testopia at bugs.koha-communit |
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:10:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:10:44 +0000
Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703
--- Comment #10 from Katrin Fischer ---
(In reply to Fridolin Somers from comment #9)
> Duplicate of Bug 29604?
No, totally different thing. This is about showing an extra --> that has no
content after.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:30:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 18:30:36 +0000
Subject: [Koha-bugs] [Bug 29911] Default amounts for fee types display with
comma in some cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Katrin Fischer ---
It appears this was meanwhile fixed on another bug :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:26:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 19:26:48 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |caroline.cyr-la-rose at inlibr
| |o.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 21:21:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 20:21:36 +0000
Subject: [Koha-bugs] [Bug 30846] Notforloan status is not checked in
CanBookBeReserved/CanItemBeReserved
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |caroline.cyr-la-rose at inlibr
| |o.com
--- Comment #1 from Caroline Cyr La Rose ---
I'm not sure if this is what you meant Nick, but I came across this situation
and thought it was maybe the same. Let me know if it's completely different and
I'll create a new bug for this.
I'm trying to set up Koha so that only unavailable items can be put on hold,
including those with negative not for loan values. (The exact use case is a
library that wants to prevent on shelf holds, but want people to be able to put
on hold the most recent issue of a serial even if it is for reference only
while the other issue hasn't yet arrived. When the next issue arrives, the
previous issue will be lent out, in order of the holds... Not sure if that
makes sense, but it's the same principle as placing holds on "ordered" items.)
I was not able to test this on master because of bug 32445, but I tried it on
22.05.05
To test:
1. Set up a circulation rule where on shelf holds are not allowed and force the
choosing of an item (to facilitate the test)
1.1. Go to Administration > Circulation and fines rules
1.2. In the matrix, add a circulation like this
- Patron category: All
- Item type: Books
- Current checkouts allowed: 10
- Current on-site checkouts allowed: 10
- Loan period: 21
- Holds allowed (total): 10
- Holds allowed (daily): 10
- Holds per record (count): 10
- On shelf holds allowed: If any unavailable
- OPAC item level holds: Force
1.3. Click Save
2. Create a record with one "Ordered" item (or any negative value not for loan
status)
2.1. Go to Cataloging
2.2. Click New record
2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005,
008, 040$c, 245$a, and 942$c (942$c should be set to Books))
2.4. Click Save
2.5. Fill out the following item fields
- Not for loan: Ordered
- Koha item type: Books
2.6. Click Add item
2.7. Click Normal to go to the detailed record
3. Try to place a hold on the "Ordered" item
3.1. From the detailed record, click OPAC view: Open in new window.
--> Note that the "Place hold" option is not present
4. Add a second "Available" item
4.1. Back in the staff interface tab with the detailed record, click New >
New item
4.2. Make sure the item type is set to Books
4.3. Add a barcode in p
4.4. Click Add item
5. Try again to place a hold on the "Ordered" item
5.1. Go back to the OPAC tab and refresh the page
--> Note that the "Place hold" option is still not present
6. Check out the available item to a patron
6.1. In the staff interface tab, copy the barcode from the available item
6.2. Go to Patrons
6.3. Click on Search
6.4. Click Check out next to one of the patrons
6.5. Paste the barcode in the box and click Check out
7. Try again to place a hold on the "Ordered" item
7.1. Go back to the OPAC tab and refresh the page
--> Note that the "Place hold" option is now present
7.2. Click Place hold
--> Note that only the checked out item is available to place on hold, if
you click Show unholdable items, it will show the Ordered item, but you can't
place a hold on it.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:18:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:18:49 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
--- Comment #34 from David Cook ---
(In reply to Matthew Ross from comment #33)
> I'm receiving the followin error, even after manually changing the
> "borrowers" table to dynamic:
>
> ---
> Upgrade to 22.06.00.006 [09:37:59]: Bug 21978 - Add middle_name to borrowers
> table
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too
> large. The maximum row size for the used table type, not counting BLOBs, is
> 8126. This includes storage overhead, check the manual. You have to change
> some columns to TEXT or BLOBs at /usr/share/koha/lib/C4/Installer.pm line 739
> ---
Looking at bug 21978, it looks like you'll need to change the
borrower_modifications and deletedborrowers tables too.
Alternatively, you could follow the steps that Liz Rea outlines at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267#c20 to update
all tables. That would be a more future-proofed solution.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:24:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:24:29 +0000
Subject: [Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch
rather than item branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|NEW |RESOLVED
--- Comment #8 from David Cook ---
(In reply to Katrin Fischer from comment #7)
> But if you have 10 libraries owning the same item, which can well happen
> with popular ones, you will have 10 librarians potentially running to the
> shelf to get it... doesn't seem very effective.
>
> I was assuming the worst case: record level hold with multiple branches
> holding it.
Ahhh yes that would explain it. I forgot that not all holds are item-level
holds.
Since a hold could be either record-level or item-level, I don't think there's
a consistent way of handling the email except emailing the patron's branch.
Maybe the pickup library like you suggested before, but the current behaviour
has been around for many years, and I think you've explained well why that's
the case here.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:31:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:31:41 +0000
Subject: [Koha-bugs] [Bug 32000] Add yellow buttons to administration >
upload page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Katrin Fischer ---
I think I probably meant Tools > Uploads and there are yellow buttons there
now.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:31:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:31:42 +0000
Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main
action button where it's missing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947
Bug 31947 depends on bug 32000, which changed state.
Bug 32000 Summary: Add yellow buttons to administration > upload page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32000
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:32:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:32:49 +0000
Subject: [Koha-bugs] [Bug 32001] Make submit button yellow when adding a new
matching rule
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Katrin Fischer ---
This button is also very yellow now :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:32:50 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:32:50 +0000
Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main
action button where it's missing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947
Bug 31947 depends on bug 32001, which changed state.
Bug 32001 Summary: Make submit button yellow when adding a new matching rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32001
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:54:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:54:12 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:54:18 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jan 2023 22:54:18 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
--- Comment #1 from Katrin Fischer ---
Created attachment 144924
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144924&action=edit
Bug 32003: Add page-section to order search results and fix heading hierarchy
This adds a page-section to the order search results and moves
the former second h1 heading 'search results' to a h2 heading
below 'Order search', so we have a proper hierarchy
In acquisitions:
* Make sure you have an order with at least one order line
* Do an empty orders search
* Verify there are 2 h1 headings on the page and the results table doesn't
have a white background
* Apply patch
* Verify the results list now has a white background and the second
now smaller heading has been moved into this area
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:42:54 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 02:42:54 +0000
Subject: [Koha-bugs] [Bug 30846] Notforloan status is not checked in
CanBookBeReserved/CanItemBeReserved
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:45:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 02:45:20 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #10 from David Cook ---
Yikes, where are we at with this one?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 03:46:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 02:46:15 +0000
Subject: [Koha-bugs] [Bug 32026] 'Search within results' and its input field
in staff search results page are misaligned
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32026
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:25:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 08:25:23 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #11 from Katrin Fischer ---
(In reply to David Cook from comment #10)
> Yikes, where are we at with this one?
Needing someone to assign the bug and write patches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:54:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 08:54:02 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144901|0 |1
is obsolete| |
--- Comment #8 from Jonathan Druart ---
Created attachment 144925
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144925&action=edit
Bug 32528: Change return logic
Back to 1 return statement
Prevent the Koha::Result::Boolean instanciation duplication
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:54:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 08:54:47 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 10:22:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 09:22:35 +0000
Subject: [Koha-bugs] [Bug 32556] New: borrower_message_preference_id reaches
limit
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556
Bug ID: 32556
Summary: borrower_message_preference_id reaches limit
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: magnus at libriotech.no
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Symptom: Adding a new patron gives a 500 error.
plack-error.log: C4::Members::Messaging::SetMessagingPreference(): DBI
Exception: DBD::mysql::st execute failed: Out of range value for column
'borrower_message_preference_id' at row 1 at
/usr/share/koha/lib/C4/Form/MessagingPreferences.pm line 98
MariaDB [koha]> select max(borrower_message_preference_id) from
borrower_message_preferences;
+-------------------------------------+
| max(borrower_message_preference_id) |
+-------------------------------------+
| 2147475728 |
+-------------------------------------+
1 row in set (0.000 sec)
MariaDB [koha]> show create table borrower_message_preferences\G
*************************** 1. row ***************************
Table: borrower_message_preferences
Create Table: CREATE TABLE `borrower_message_preferences` (
`borrower_message_preference_id` int(11) NOT NULL AUTO_INCREMENT,
`borrowernumber` int(11) DEFAULT NULL,
`categorycode` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
`message_attribute_id` int(11) DEFAULT 0,
`days_in_advance` int(11) DEFAULT 0,
`wants_digest` tinyint(1) NOT NULL DEFAULT 0,
PRIMARY KEY (`borrower_message_preference_id`),
KEY `borrowernumber` (`borrowernumber`),
KEY `categorycode` (`categorycode`),
KEY `message_attribute_id` (`message_attribute_id`),
CONSTRAINT `borrower_message_preferences_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE
ON UPDATE CASCADE,
CONSTRAINT `borrower_message_preferences_ibfk_2` FOREIGN KEY
(`message_attribute_id`) REFERENCES `message_attributes`
(`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT `borrower_message_preferences_ibfk_3` FOREIGN KEY (`categorycode`)
REFERENCES `categories` (`categorycode`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB AUTO_INCREMENT=2147483648 DEFAULT CHARSET=utf8mb4
COLLATE=utf8mb4_unicode_ci
1 row in set (0.000 sec)
The site where this happens runs a nightly import from a student registration
system, so patrons are updated frequently.
Two questions:
1. How do we fix this for sites that reach the limit?
I tried to disable foreign key checks and alter the column from signed to
unsigned, but that did not work:
MariaDB [koha]> SET FOREIGN_KEY_CHECKS=0;
Query OK, 0 rows affected (0.000 sec)
MariaDB [koha]> ALTER TABLE borrower_message_preferences MODIFY
borrower_message_preference_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT;
ERROR 1025 (HY000): Error on rename of './koha_hkr/#sql-3d8_41ab0' to
'./koha_hkr/borrower_message_preferences' (errno: 150 "Foreign key constraint
is incorrectly formed")
2. How do we make sure this never happens?
To extend the period before this happens, it might be a quick fix to change the
borrower_message_preference_id column from SIGNED (the default) to UNSIGNED. As
far as I can tell, this would double the number of IDs the column can hold.
A better solution might be to make the borrower_message_preferences update in
place, and not generate new borrower_message_preference_id's every time they
are updated?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 10:28:53 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 09:28:53 +0000
Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556
Hans Pålsson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hans.palsson at hkr.se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:18 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:18 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:24 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #12 from Jonathan Druart ---
Created attachment 144926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144926&action=edit
Bug 32445: Fix availability display on opac-course-details
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:29 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #13 from Jonathan Druart ---
Created attachment 144927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144927&action=edit
Bug 32445: Fix availability display on opac-basket
Also fix holding branch
Will display an empty span if no location, big deal?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:34 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #14 from Jonathan Druart ---
Created attachment 144928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144928&action=edit
Bug 32445: Fix notforloan display
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:39 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #15 from Jonathan Druart ---
Created attachment 144929
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144929&action=edit
Bug 32445: Remove non-Koha::Item support from item-status.inc
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:22:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:22:44 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #16 from Jonathan Druart ---
Created attachment 144930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144930&action=edit
Bug 32445: include item-status-schema-org.inc
Can be discussed, but it will prevent to fetch several times the same
related objects
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:23:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:23:29 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
--- Comment #17 from Jonathan Druart ---
This patch set suggests to remove the non-Koha::Item support from
item-status.inc in order to make it more reliable. We are removing some
specific code from pl scripts (opac-basket.pl, opac-course-details.pl) and pass
a Koha::Item to item-status.inc where it was not the case already.
It's hard to provide a full test plan. You should mostly focus on item
availability in opac-detail, opac-basket and opac-course-details.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:23:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:23:59 +0000
Subject: [Koha-bugs] [Bug 32445] Status display of 'not for loan' items is
broken in OPAC/staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_22_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:33:01 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:33:01 +0000
Subject: [Koha-bugs] [Bug 28395] allow patron enrollment period to be set in
days for patron categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28395
Holly changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hc at interleaf.ie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:37:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:37:43 +0000
Subject: [Koha-bugs] [Bug 28395] allow patron enrollment period to be set in
days for patron categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28395
--- Comment #1 from Holly ---
I've been seeing some questions come in about having the option of setting an
enrollment period by days, so it would be great to see some engagement on this.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:56:16 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12225
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32515
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225
[Bug 12225] SIP does not respect the "no block" flag
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:56:16 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32537
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
[Bug 32537] Add 'no_block' option to sip_cli_emulator
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:56:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 11:56:16 +0000
Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine
that does not exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32537
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:00:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:00:14 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
--- Comment #12 from Matt Blenkinsop ---
(In reply to Katrin Fischer from comment #10)
> Hi Matt, have a look at the KohaDates TT filter. It will format the date
> nicely for you according to the DAteFormat system preference.
Thanks for the hint Katrin, I have used the filter and also fixed the typo -
resubmitted for sign-off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:00:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:00:49 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144828|0 |1
is obsolete| |
--- Comment #13 from Matt Blenkinsop ---
Created attachment 144931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144931&action=edit
Bug 32373: Show patron restriction date
When viewing a patron account with a restriction there is no way to see when
the restriction was placed. This is available in the borrower_debarrments table
and has now been added to the UI and matched to the 'dateformat' syspref.
(Previous commit missed the moremember.tt render and the syspref formatting -
this is now being done with the KohaDates template filter)
Test plan:
1) Create a restriction on a patron and navigate to that patron in Checkouts or
the patron details page
2) There should be a message with details about the restriction but the
creation date of the restriction won't be included in the message
3) Apply patch
4) The message should now say "Restricted since DATE" as in the screenshot
attached.
5) Change the 'dateformat' syspref and refresh, the date should change to
reflect the syspref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:01:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:01:16 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:11:19 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:11:19 +0000
Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine
that does not exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515
--- Comment #3 from Nick Clemens ---
(In reply to David Nind from comment #2)
>
> I'm not sure if this is what is expected (as it is pretty similar to what I
> got for bug 32537, except the second and third series of numbers in the SEND
> are different), but happy to sign off if it is.
Hi David,
It looks like the SIP response is still failing on no-block, but I don't
recreate
Could you retest with 'restart_all' rather than just SIP to see if that works?
Or try koha-sip --stop, confirm stopped, then koha-sip --start?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:24:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:24:23 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310
--- Comment #36 from Jonathan Druart ---
Can this be a candidate for an early push to 23.05 please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:33:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:33:25 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
& add libhtml-parser-perl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
--- Comment #7 from Thibaud Guillot ---
Created attachment 144932
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144932&action=edit
Bug 10762: (follow-up) Add exec right on atomic update file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:35:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:35:38 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
--- Comment #17 from Thibaud Guillot ---
Created attachment 144933
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144933&action=edit
Bug 10762: (follow-up) Add exec right on atomic update file
https://bugs.koha-community.org/show_bug.cgi?id=17062
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:36:19 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:36:19 +0000
Subject: [Koha-bugs] [Bug 17062] debian/control.in update: change maintainer
& add libhtml-parser-perl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062
Thibaud Guillot changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144932|1 |0
is patch| |
Attachment #144932|0 |1
is obsolete| |
--- Comment #8 from Thibaud Guillot ---
Comment on attachment 144932
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144932
Bug 10762: (follow-up) Add exec right on atomic update file
>From bb928a504c65f0b5c549d6b56dcdf7dcfc91b459 Mon Sep 17 00:00:00 2001
>From: Thibaud Guillot
>Date: Tue, 3 Jan 2023 13:32:16 +0100
>Subject: [PATCH] Bug 10762: (follow-up) Add exec right on atomic update file
>
>https://bugs.koha-community.org/show_bug.cgi?id=17062
>---
> installer/data/mysql/atomicupdate/update-BZ_10762.pl | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 installer/data/mysql/atomicupdate/update-BZ_10762.pl
>
>diff --git a/installer/data/mysql/atomicupdate/update-BZ_10762.pl b/installer/data/mysql/atomicupdate/update-BZ_10762.pl
>old mode 100644
>new mode 100755
>--
>2.25.1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:37:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:37:23 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
--- Comment #18 from Thibaud Guillot ---
I forgot this file, fixed and push
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:59:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:59:02 +0000
Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item
modification doesn't untick on loan items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
Depends on| |28445
Status|NEW |ASSIGNED
Severity|enhancement |major
Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
|ity.org |com
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445
[Bug 28445] Use the task queue for the batch delete and update items tool
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:59:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 12:59:02 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
update items tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32550
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
[Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on
loan items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:02:04 +0000
Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item
modification doesn't untick on loan items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:02:09 +0000
Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item
modification doesn't untick on loan items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
--- Comment #1 from Jonathan Druart ---
Created attachment 144934
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144934&action=edit
Bug 32550: (bug 28445 follow-up) Fix 'Clear on loan' link on item batch mod
The 'Clear on loan' link displayed at the top of the batch item
modification tool has been broken by bug 28445.
data-is-onloan attribute is supposed to be 1 or 0, but we passed the
checkout (Koha::Checkout=HASH)
Test plan:
1. Enter a checked-out barcode in the 'Batch item modification' page
2. Click 'Continue'
3. Notice a table is loaded displaying the on-loan item with a ticked checkbox
4. Click the 'Clear on loan' link above the table
5. Notice the on-loan item is no longer selected
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:02:47 +0000
Subject: [Koha-bugs] [Bug 31611] More visibly highlight records that cannot
be batch deleted/modified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |32550
See Also|https://bugs.koha-community |
|.org/bugzilla3/show_bug.cgi |
|?id=32550 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
[Bug 32550] 'Clear on loan' link on Batch item modification doesn't untick on
loan items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:02:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:02:47 +0000
Subject: [Koha-bugs] [Bug 32550] 'Clear on loan' link on Batch item
modification doesn't untick on loan items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32550
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |31611
See Also|https://bugs.koha-community |
|.org/bugzilla3/show_bug.cgi |
|?id=31611 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611
[Bug 31611] More visibly highlight records that cannot be batch
deleted/modified
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:12:50 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:12:50 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
--- Comment #4 from Kyle M Hall ---
Created attachment 144935
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144935&action=edit
Bug 32537: (QA follow-up) Don't allow invalid no block values
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:15:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:15:05 +0000
Subject: [Koha-bugs] [Bug 32537] Add 'no_block' option to sip_cli_emulator
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537
--- Comment #5 from Kyle M Hall ---
Created attachment 144936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144936&action=edit
Bug 32537: (QA follow-up): Tidy code
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 14:56:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 13:56:24 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
--- Comment #14 from Katrin Fischer ---
I believe this could be removed again now, could you confirm?
-use Koha::DateUtils qw( dt_from_string );
+use Koha::DateUtils qw( dt_from_string format_sqldatetime );
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:10:48 +0000
Subject: [Koha-bugs] [Bug 32557] New: Implement SIP2 no block flag for
checkin messages
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557
Bug ID: 32557
Summary: Implement SIP2 no block flag for checkin messages
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
The "no block" flag for SIP2 checkin messages has never been implemented. Bug
32515 fixed the issue where a non-existent subroutine was called if the
no-block flag has passed. We should implement a no-block version of the checkin
subroutine.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:10:57 +0000
Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin
messages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |32515
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515
[Bug 32515] SIP2 no block flag on checkin calls routine that does not exist
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:10:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:10:57 +0000
Subject: [Koha-bugs] [Bug 32515] SIP2 no block flag on checkin calls routine
that does not exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32557
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557
[Bug 32557] Implement SIP2 no block flag for checkin messages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:11:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:11:06 +0000
Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin
messages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:11:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:11:24 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
--- Comment #9 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #8)
> Created attachment 144925 [details] [review]
> Bug 32528: Change return logic
>
> Back to 1 return statement
> Prevent the Koha::Result::Boolean instanciation duplication
I agree with the follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:12:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:12:31 +0000
Subject: [Koha-bugs] [Bug 30920] Add caching to
C4::Biblio::GetAuthorisedValueDesc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920
--- Comment #26 from Jonathan Druart ---
(In reply to Nick Clemens from comment #25)
> (In reply to Jonathan Druart from comment #19)
> > I think this change is coming whereas we don't use the same code to display
> > the descriptions, and it could lead to confusion (theoretically at least):
> > fetch from cache and fetch from DB.
>
> Can you explain this a bit more? Where are we not using this that could be a
> conflict?
Everywhere we fetch branchname, itemtype's description, av's lib (mainly from
C4)
> > There is at least one thing that could go wrong, itemtype's descriptions.
> > First we only deal with 'en', then it is actually wrong with 'en': it could
> > be overwritten by the "Translate into other languages" feature (yes that's a
> > weird use case but the UI allows it).
> In testing I can provide a French translation and the correct one shows when
> changing languages in search results on both staff and OPAC
Sorry, I think it didn't make sense. I guess I was referring to
Koha::Itemtype->store
+ if ($flush) {
+ my $cache = Koha::Caches->get_instance();
+ my $key = "enItemTypeDescriptions";
+ $cache->clear_from_cache($key);
+ }
But it actually sounds good after having a second look at it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:50:51 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:50:51 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:50:54 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 14:50:54 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144922|0 |1
is obsolete| |
--- Comment #6 from Lucas Gass ---
Created attachment 144937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144937&action=edit
Bug 32505: Restore patron search by formatted dob
Prior to the rewrite of the patron searches (bug 30063 and friends) it
was possible to search for a patron using their date of birth, formatted
following the dateformat syspref.
Now it only works if the date is iso formatted.
This patch is providing a fix to restore the behaviour, but does not
make it consistent. Only searching patrons by date of birth is fixed
here, when we actually want to fix the problem for the REST API DT
wrapper instead.
Test plan:
Search for patrons given their date of birth. You need to select "date
of birth" in the "Search field" dropdown, or set it in
DefaultPatronSearchFields.
Note that the column filtering is still not working, but I guess it was
the case already in older versions. Ideally we will need to have a
"datatype" attribute passed to the the 'th' and retrieved from
datatables.js to add this same trick and build the query appropriately.
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:07:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:07:14 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |lucas at bywatersolutions.com
--- Comment #15 from Lucas Gass ---
(In reply to Katrin Fischer from comment #14)
> I believe this could be removed again now, could you confirm?
> -use Koha::DateUtils qw( dt_from_string );
> +use Koha::DateUtils qw( dt_from_string format_sqldatetime );
Yes, it looks like 'format_sqldatetime' is not needed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:24:08 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:24:08 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:24:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:24:13 +0000
Subject: [Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should
short-circuit earlier
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144847|0 |1
is obsolete| |
Attachment #144925|0 |1
is obsolete| |
--- Comment #10 from Jonathan Druart ---
Created attachment 144938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144938&action=edit
Bug 32528: Make safe_to_delete exit earlier on error conditions
This patch makes the `Koha::Item->safe_to_delete` method return right
after one of the checked conditions is met. This way we avoid further DB
queries and processing.
No behavior change is expected
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Item.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests STILL pass!
4. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
Bug 32528: Change return logic
Back to 1 return statement
Prevent the Koha::Result::Boolean instanciation duplication
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:25:03 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:25:09 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #134754|0 |1
is obsolete| |
--- Comment #19 from Lucas Gass ---
Created attachment 144939
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144939&action=edit
Bug 10762: Change the size of barcodes in label creator
Test plan:
1)Home > Tools > Label creator > Manage Layout or New Layout
2)Make a new layout or edit an existing one
3)Notice the 2 new fields "Barcode width/Barcode height"
4)Save it like this
5)Create a batch of barcode and export if in PDF
6)Notice the size of barcode
7)Go back to your existing layout
8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save
9)Take back your batch of barcode and export it in PDF
10)The barcode should be 2x bigger
Signed-off-by: Owen Leonard
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:15 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:25:15 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144900|0 |1
is obsolete| |
--- Comment #20 from Lucas Gass ---
Created attachment 144940
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144940&action=edit
Bug 10762: (follow-up) Update test plan, add kohastructure.sql files
I also change the default value for scale_height to '0.01'
Test plan:
1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout
2)Make a new layout or edit an existing one
3)Notice the 2 new fields "Barcode width/Barcode height"
4)Save it like this
5)Create a batch of barcode and export if in PDF
6)Notice the size of barcode
7)Go back to your existing layout
8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save
9)Take back your batch of barcode and export it in PDF
10)The barcode should be 2x bigger
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:25:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:25:21 +0000
Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode
height and width on labels
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144933|0 |1
is obsolete| |
--- Comment #21 from Lucas Gass ---
Created attachment 144941
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144941&action=edit
Bug 10762: (follow-up) Add exec right on atomic update file
https://bugs.koha-community.org/show_bug.cgi?id=17062
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:29:25 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
--- Comment #16 from Matt Blenkinsop ---
Created attachment 144942
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144942&action=edit
Bug 32373: (follow-up) Show patron restriction date
Unnecessary import of format_sqldatetime has now been removed
Test plan:
1) Create a restriction on a patron and navigate to that patron in Checkouts or
the patron details page
2) There should be a message with details about the restriction but the
creation date of the restriction won't be included in the message
3) Apply patch
4) The message should now say "Restricted since DATE" as in the screenshot
attached.
5) Change the 'dateformat' syspref and refresh, the date should change to
reflect the syspref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:50 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:29:50 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:32:09 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:32:13 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144931|0 |1
is obsolete| |
--- Comment #17 from Lucas Gass ---
Created attachment 144943
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144943&action=edit
Bug 32373: Show patron restriction date
When viewing a patron account with a restriction there is no way to see when
the restriction was placed. This is available in the borrower_debarrments table
and has now been added to the UI and matched to the 'dateformat' syspref.
(Previous commit missed the moremember.tt render and the syspref formatting -
this is now being done with the KohaDates template filter)
Test plan:
1) Create a restriction on a patron and navigate to that patron in Checkouts or
the patron details page
2) There should be a message with details about the restriction but the
creation date of the restriction won't be included in the message
3) Apply patch
4) The message should now say "Restricted since DATE" as in the screenshot
attached.
5) Change the 'dateformat' syspref and refresh, the date should change to
reflect the syspref
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:32:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:32:17 +0000
Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144942|0 |1
is obsolete| |
--- Comment #18 from Lucas Gass ---
Created attachment 144944
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144944&action=edit
Bug 32373: (follow-up) Show patron restriction date
Unnecessary import of format_sqldatetime has now been removed
Test plan:
1) Create a restriction on a patron and navigate to that patron in Checkouts or
the patron details page
2) There should be a message with details about the restriction but the
creation date of the restriction won't be included in the message
3) Apply patch
4) The message should now say "Restricted since DATE" as in the screenshot
attached.
5) Change the 'dateformat' syspref and refresh, the date should change to
reflect the syspref
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:35:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:35:38 +0000
Subject: [Koha-bugs] [Bug 32558] New: Allow background_jobs_worker.pl to
process multiple jobs simultaneously up to a limit
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Bug ID: 32558
Summary: Allow background_jobs_worker.pl to process multiple
jobs simultaneously up to a limit
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Right now background_jobs_worker.pl only processes jobs in serial. It would
make sense to handle jobs in parallel up to a user definable limit.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:37:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:37:43 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com,
| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:39:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:39:16 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:39:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:39:20 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144924|0 |1
is obsolete| |
--- Comment #2 from Lucas Gass ---
Created attachment 144945
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144945&action=edit
Bug 32003: Add page-section to order search results and fix heading hierarchy
This adds a page-section to the order search results and moves
the former second h1 heading 'search results' to a h2 heading
below 'Order search', so we have a proper hierarchy
In acquisitions:
* Make sure you have an order with at least one order line
* Do an empty orders search
* Verify there are 2 h1 headings on the page and the results table doesn't
have a white background
* Apply patch
* Verify the results list now has a white background and the second
now smaller heading has been moved into this area
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:41:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:41:14 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|23.05.00,22.11.01,22.11.01 |23.05.00,22.11.01
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:42:32 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:42:32 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:43:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:43:52 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:43:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:43:56 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #1 from Kyle M Hall ---
Created attachment 144946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144946&action=edit
Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs
simultaneously up to a limit
Right now background_jobs_worker.pl only processes jobs in serial. It would
make sense to handle jobs in parallel up to a user definable limit.
Test Plan:
1) Apply this patch
2) Stop background_jobs_worker.pl
3) Generate some background jobs by editing records, placing holds, etc
4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep
background_jobs_worker.pl'
5) Run background_jobs_worker.pl
6) Note the multiple forked processes in the ps output
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:46:48 +0000
Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor)
for authority records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232
slmontesdeoca at orem.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |slmontesdeoca at orem.org
--- Comment #7 from slmontesdeoca at orem.org ---
My cataloging team and I are very interested in having the ability to edit
authority records using the advanced editor. We are very focused on improving
our authority database and being able to edit the authorities easier would be a
big step in achieving that goal.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:55:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 15:55:27 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #2 from Jonathan Druart ---
Hi Kyle, you embedded unrelated changes (sip).
This would make sense in some cases (job types), but I think it should default
to 1 to keep the existing behaviour (we don't want 10 long tasks/batch mod
running at the same time).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:24:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:24:47 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
--- Comment #3 from Kyle M Hall ---
Created attachment 144947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144947&action=edit
Bug 32558: Add ability for background_jobs_worker.pl to process multiple jobs
simultaneously up to a limit
Right now background_jobs_worker.pl only processes jobs in serial. It would
make sense to handle jobs in parallel up to a user definable limit.
Test Plan:
1) Apply this patch
2) Stop background_jobs_worker.pl
3) Generate some background jobs by editing records, placing holds, etc
4) Watch processes in a new terminal: watch -n 0.1 'ps aux | grep
background_jobs_worker.pl'
5) Run background_jobs_worker.pl
6) Note the multiple forked processes in the ps output
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:25:17 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:25:17 +0000
Subject: [Koha-bugs] [Bug 32558] Allow background_jobs_worker.pl to process
multiple jobs simultaneously up to a limit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32558
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144946|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:55:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:55:20 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310
--- Comment #37 from Jonathan Druart ---
Created attachment 144948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144948&action=edit
Bug 30310: Replace one more occurrence to moment
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:58:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:58:10 +0000
Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has to
h1 headings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003
--- Comment #3 from Katrin Fischer ---
Thanks, Lucas :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:58:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:58:44 +0000
Subject: [Koha-bugs] [Bug 32559] New: Support formatted date for column
filtering (DT)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559
Bug ID: 32559
Summary: Support formatted date for column filtering (DT)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Staff interface
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
When dates are displayed formatted (following the dateformat syspref) in a
DataTable table and that there is a filter for the column, we should filter
correctly the data.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:59:33 +0000
Subject: [Koha-bugs] [Bug 32557] Implement SIP2 no block flag for checkin
messages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557
--- Comment #1 from Kyle M Hall ---
I've been working on this, and I'm not actually convinced we need anything more
than what Nick has done on bug 32515. If someone can point out a scenario where
we need more please let me know!
Kyle
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:59:34 +0000
Subject: [Koha-bugs] [Bug 32505] Cannot search by dateofbirth in specified
dateformat
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32559
--- Comment #7 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #5)
> Note that the column filtering is still not working, but I guess it was
> the case already in older versions. Ideally we will need to have a
> "datatype" attribute passed to the the 'th' and retrieved from
> datatables.js to add this same trick and build the query appropriately.
See bug 32559.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559
[Bug 32559] Support formatted date for column filtering (DT)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:59:34 +0000
Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering
(DT)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |32505
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32505
[Bug 32505] Cannot search by dateofbirth in specified dateformat
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:59:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 16:59:52 +0000
Subject: [Koha-bugs] [Bug 32559] Support formatted date for column filtering
(DT)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32559
--- Comment #1 from Katrin Fischer ---
Hm, maybe data-search could work?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:10:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 17:10:05 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--- Comment #2 from Lucas Gass ---
Tested with different iterations of this:
$.ajax({
url: '/api/v1/biblios/55/items/117',
method: 'PUT',
data: JSON.stringify({
"collection_code": "COLLECTION1",
"external_id": "123test",
}),
contentType: 'application/json',
success: function(result) {
console.log('altered')
},
});
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:10:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 17:10:48 +0000
Subject: [Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects
in Circulation.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #5 from David Gustafsson ---
Found tests that still needs fixing, working on this and then should be ready
for review.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:11:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 17:11:20 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:11:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Jan 2023 17:11:24 +0000
Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144902|0 |1
is obsolete| |
--- Comment #3 from Lucas Gass ---
Created attachment 144949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144949&action=edit
Bug 31799: Add REST endpoint to modify a biblio's item
To test:
1. Apply patch
2. Set RESTBasicAuth preference to true
3. Get a biblio with an item
4. Make a PUT request to /api/v1/biblios/:biblio_id/items/:item_id with a json
body that represents an item to replace
5. Check that the item was modified
6. Sign off
Signed-off-by: Lucas Gass