[Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #114 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1.
 FAIL   Koha/Patron/Restriction.pm
   FAIL   pod
                *** WARNING: empty section in previous paragraph  in file
Koha/Patron/Restriction.pm

 FAIL   Koha/Patron/Restrictions.pm
   FAIL   pod
                *** WARNING: empty section in previous paragraph  in file
Koha/Patron/Restrictions.pm

2. Koha/Patron/Restriction.pm:=head2 Relation accessors

Why? This is not used anywhere else. We use "Class methods".

3. 64                                    <option value="[% code | html %]">[%
PROCESS restriction_type_description %]</option>

I think it's always better to pass the parameter, even if not needed
=> [% PROCESS restriction_type_description restriction_type => restriction_type
%]

Nothing considering blocker, passing QA. Please go ahead with bug 31458 and
friends, I will be happy to QA them!

-- 
You are receiving this mail because:
You are watching all bug changes.