[Koha-bugs] [Bug 32353] reserves.item_group_id should be undefined in tests by default

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32353

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #19 from David Nind <david at davidnind.com> ---
Testing notes (using KTD):

1. Before the patches are applied, ran prove t/db_dependent/Circulation.t

2. Note that tests pass, but there are warnings:

root at kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t 
t/db_dependent/Circulation.t .. 60/64 Odd number of elements in anonymous hash
at t/db_dependent/Circulation.t line 5712.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. ok     
All tests successful.
Files=1, Tests=64, 26 wallclock secs ( 0.15 usr  0.02 sys + 18.55 cusr  2.50
csys = 21.22 CPU)
Result: PASS

3. Applied patches and restarted everything.

4. Run test again. Note that "....60/64 Odd number of elements in anonymous
hash at t/db_dependent/Circulation.t line 5712." warning/output after running
the tests is gone:

root at kohadevbox:koha(bz32353)$ prove t/db_dependent/Circulation.t 
t/db_dependent/Circulation.t .. 60/64 Use of uninitialized value $rentalCharge
in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
Use of uninitialized value $rentalCharge in numeric gt (>) at
/kohadevbox/koha/C4/Circulation.pm line 1119.
t/db_dependent/Circulation.t .. ok     
All tests successful.
Files=1, Tests=64, 26 wallclock secs ( 0.13 usr  0.01 sys + 18.61 cusr  2.52
csys = 21.27 CPU)
Result: PASS

I hope this is sufficient for testing - I don't understand all the other stuff
8-).

-- 
You are receiving this mail because:
You are watching all bug changes.