[Koha-bugs] [Bug 32523] Shortcuts / Links to missing fields in MARC-Editor don't work as expected

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Hi Jan.

Your patch works (yeah!), but I can't seem to sign it off. I get this message:

root at kohadevbox:koha(bz32523)$ git bz attach -e 32523 HEAD
/usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to
convert both arguments to Unicode - interpreting them as being unequal
  obsoleted = (initial_description == patch.description)
Traceback (most recent call last):
  File "/usr/bin/git-bz", line 2722, in <module>
    do_attach(*args)
  File "/usr/bin/git-bz", line 2074, in do_attach
    attach_commits(bug, commits, edit_comments=global_options.edit)
  File "/usr/bin/git-bz", line 1988, in attach_commits
    description, body, obsoletes, statuses, patch_complexities, depends =
edit_attachment_comment(bug, commit.subject, body)
  File "/usr/bin/git-bz", line 1940, in edit_attachment_comment
    lines = edit_template(template.getvalue())
  File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue
    self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal
not in range(128)

I can sign off other patches (and my koha-testing-docker (KTD) is all up to
date), so I don't think it is my setup (but I could be wrong!).

Also, I think you will need to amend your patch for the QA Team to be happy,
including:
- Formatting title as Bug XXXXX: Title
- Including the description and test plan in the patch

See the commit message guidelines at
https://wiki.koha-community.org/wiki/Commit_messages

David

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.