[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 4 16:05:06 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I like the idea, but the patch contains unrelated changes that may slow down
its integration.

For instance:

-                C4::Circulation::ReturnLostItem( $self->borrowernumber,
-                    $debit->itemnumber );
+                C4::Circulation::ReturnLostItem( $self->borrowernumber,
$debit->itemnumber );

In Koha::Hold::cancel
-        my ( undef, $next_hold ) = C4::Reserves::CheckReserves(
$self->itemnumber );
+        my ( undef, $next_hold ) = CheckReserves( $self->item );

I am suspecting this last one will explode, CheckReserves is not imported.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list