[Koha-bugs] [Bug 32565] New: Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565

            Bug ID: 32565
           Summary: Holds placed when all libraries are closed do not get
                    added to holds queue if HoldsQueueSkipClosed and
                    RealTimeHoldsQueue are enabled
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emily.lamancusa at montgomerycountymd.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If HoldsQueueSkipClosed is enabled and a hold is placed on a day when all
libraries are closed (e.g. a holiday), that hold doesn't get added to any holds
queue, because there are no valid queues to add it to at the time. This did not
matter with the build-holds-queue cronjob, because the job would just add it to
the queue later; however, if RealTimeHoldsQueue is also enabled, that hold will
not get added to the holds queue when the libraries reopen unless something
triggers a holds queue update on that biblio record, potentially leading to
holds stuck in limbo.

The exception is a hold that has copies available at the pickup location -
those types of holds will still get added to the holds queue even if all
libraries are closed.

To recreate:
1. Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to satisfy holds from
libraries only when they are open
2. Add a holiday to the calendar for all libraries for today
3. Place a biblio-level hold on a biblio record and set the pickup location to
a library that has available copies
4. Verify that that hold got added to the holds queue
5. Place a bilbio-level hold on a biblio record where there are no other holds
and copies are available at another location, but not the pickup location
6. Verify that that hold was not added to any holds queue
7. Remove the holiday (or wait for the next day) and verify that the hold from
step 5 is still not on the holds queue

This could be solved by adding a check to the real-time holds queue to check
whether all libraries are closed, and ignore HoldsQueueSkipClosed when that is
the case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.