[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145080|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 145127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145127&action=edit
Bug 32450: Noissuescharge debit type exclusions

Currently the debit types to be excluded from the noissuescharge syspref are
hardcoded in non_issues_charges which gives no flexibility for selecting which
debit types should be included. This patch amends the subrout
ine to use a database flag to identify which debit types should be included. It
also adds a column to the table in the Debit Types area of System Preferences
which shows which debit types are included. The ability to
edit all debit types has been added rather than just the non-system ones and
the flag to include/exclude the debit type from noissuescharge can be changed
by clicking that edit button.

Test plan:
1) Choose a patron and add some fines to this patron that have different
debit_types
2) Navigate to system preferences and observe that currently you can only amend
the noissuescharge included debit types using three preferences:
ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge
3) Apply both commits attached to this bug
4) Navigate as above and observe that these three system preferences are now
gone
5) Navigate to Debit Types in System Preferences, the table should have a
column called No issues charge that shows whether a debit_type is Included or
Not included
6) Click the edit button and there should be a checkbox for Included in
noissuescharge
7) Change some of the debit_types using this option and observe that the patron
you added fines to will either be blocked from checkouts or able to checkout
depending on which debit_types you include and the value of
these fines.

Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.