[Koha-bugs] [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |MOVED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

>alert.borrowernumber (with ON DELETE CASCADE)
CONSTRAINT `alert_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers`
(`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE

>statistics.borrowernumber (with ON DELETE SET NULL)
I think this could be debatable.
I am pretty sure libraries look-up in deletedborrowers for statistical reports
regularly and this is a statistics table. I consider it WONTFIX.

>messages.borrowernumber (with ON DELETE SET NULL)
CONSTRAINT `messages_borrowernumber` FOREIGN KEY (`borrowernumber`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE,
I believe the ON DELETE CASCADE is correct, you don't want to keep those
messages without the patrons as they might contain sensitive information.

>reserveconstraints.borrowernumber (with ON DELETE CASCADE)
Table no longer exists.

>reviews.borrowernumber (with ON DELETE CASCADE)
CONSTRAINT `reviews_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE,
I believe the ON DELETE SET NULL is what most libraries would want. 

>saved_sql.borrowernumber (with ON DELETE SET NULL)
NOT FIXED, but already filed separately and stuck in discussion:
Bug 13668 - Creator of an SQL report shoudl be NULL when the staff patron is
deleted

>search_history.borrowernumber (with ON DELETE CASCADE) -the borrowernumber field is called userid atm, see below-
NOT FIXED
Now filed separately: 
Bug 32590 - Add FK constraint for search_history.userid

>suggestions.suggestedby, suggestion.managedby, acceptedby, rejectedby (with ON DELETE SET NULL)
CONSTRAINT `suggestions_ibfk_managedby` FOREIGN KEY (`managedby`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE,
CONSTRAINT `suggestions_ibfk_rejectedby` FOREIGN KEY (`rejectedby`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE,
CONSTRAINT `suggestions_ibfk_suggestedby` FOREIGN KEY (`suggestedby`)
REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE
CONSTRAINT `suggestions_ibfk_acceptedby` FOREIGN KEY (`acceptedby`) REFERENCES
`borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE,

-- 
You are receiving this mail because:
You are watching all bug changes.