[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145171|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 145189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145189&action=edit
Bug 32450: Update db to add noissuescharge flag and remove sysprefs

This commit updates the database to add a new flag to show which debit_types
are
included in noissuescharge. It also deletes the current sysprefs that are
hardcoded for this as these are now redundant.

Test plan:
1) Choose a patron and add some fines to this patron that have different
debit_types
2) Navigate to system preferences and observe that currently you can only amend
the
   noissuescharge included debit types using three preferences:
ManInvInNoissuesCharge,
   RentalsInNoissuesCharge, HoldsInNoissuesCharge
3) Apply both commits attached to this bug
4) Navigate as above and observe that these three system preferences are now
gone
5) Navigate to Debit Types in System Preferences, the table should have a
column
   called No issues charge that shows whether a debit_type is Included or Not
included
6) Click the edit button and there should be a checkbox for Included in
noissuescharge
7) Change some of the debit_types using this option and observe that the patron
you
   added fines to will either be blocked from checkouts or able to checkout
depending
   on which debit_types you include and the value of these fines.

Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.