[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 10 15:54:43 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I restored the signoff lines and split the dbic build out of the first patch..
it's customary to commit that one separately as it's the most likely one to
clash on rebases.

Code is looking good now, but I think we need the Unit tests updating..

Calls to 'non_issues_charges' appear to be present in db_dependent/Accounts.t
and db_dependent/Koha/Patron.t.

It's worth running them, and perhaps the other accounts related tests in ktd to
see if they still pass Matt.. and maybe worth looking to check that your change
is now covered in those tests too ;P

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list