[Koha-bugs] [Bug 32393] background job worker explodes if JSON is incorrect

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #12)
> There's scope creep here.. the try encompasses the process_job which means
> it's also catching all sorts of other possible failures from each and every
> processor that's written.
> 
> I think we should limit the scope of this bug to only catch bad JSON
> encoding and leave error handling for individual tasks to the tasks
> themselves.

Actually, after looking at the code again, I think that Martin might be right.

I'd have to test it, but in theory the forked process won't hit the "exit" in
process_job if it throws a fatal error. 

Ah and that will be why you get that 2nd ACK.

-- 
You are receiving this mail because:
You are watching all bug changes.