[Koha-bugs] [Bug 19822] Add system preferences for ILL Module

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822

--- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Katrin, please note the below comments and let me know if you agree.

Should be a sys pref:

partner_code:
- Only used by generic_confirm in Koha/Illrequest.pm;
- Requires backend to have GENREQ request status to have "Place request with
partners" button available and show the UI screen that uses partner_code;
- Requires patron of <partner_code> category to have a primary email else it's
not listed in the partners list;
- Sys pref would maintain current default ILLLIBS value;
- @Katrin should we have a separate bug to update sample_patron.yml and
patron_categories.yml in the sample data's patron category from IL to ILLLIBS?

staff_request_comments and reply_date:
- Are both 'censorship' flags handled in load_configuration in
Illrequest/Config.pm
- Unfortunately these are strings and code is checking if they match 'hide'.
Converting these into sys pref, they should be renamed to
hide_staff_request_comments and hide_reply_date and be boolean.

digital_recipient:
- Either 'borrower' or 'branch'. Illrequest/Config.pm has a getter for this but
it's only used by backends as far as I can tell.
- As a sys pref, would be a dropdown with both values.


Should stay in config:

backend_directory;

branch:
- A check is made for if <branch> element exists in koha-conf.xml;
- The <branch> block is repeatable.

branch/code and branch/prefix:
- I believe these are only to be used in tandem with each other, to
possibilitate different request ID prefixes for different branches;

-- 
You are receiving this mail because:
You are watching all bug changes.