[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
+        my $sth = $dbh->prepare($sql);
+        $sth->execute($database);
+        my $row = $sth->fetchrow_arrayref;
+        my $count = $row->[0];
+        if ($count){
+            $result{count} = $count;
+        }
Why do you test $count here? And why not shorter like : $result{count} =
$dbh->selectrow_arrayref->[0] ?

+    $schema->storage->txn_begin;
+    my $dbh = C4::Context->dbh;
+    $dbh->do("ALTER TABLE tags row_format=COMPACT;");

False idea of security? The txn cant have an ALTER TABLE, right?

-- 
You are receiving this mail because:
You are watching all bug changes.