[Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 145567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145567&action=edit
Screenshot - no title and input box for notices and slips

I've worked through all the areas in the test plan (using KTD) - but with so
many areas, I'm sure I have missed something...

I think I have identified some issues with ERM and Notices and slips. I have
also recorded some other issues I noticed that aren't related to this bug.

ERM
~~~

Before and after the patch is applied: 
- If you click through the sidebar options (Agreements, Packages, and Titles)
the header search doesn't change
- If you change the header to another option, for example 'Search titles', then
perform a search, the header then goes back to 'Agreement search'

After the patch was applied, I did a yarn build_js

Also, after the patch was applied, the header options don't have the active
option underlined.

Notices and slips
~~~~~~~~~~~~~~~~~

There is no name and input box when you click on Notices and slips. See the
screenshot.

However, if you click through the options (Check out, Search catalog, then
Search notices) it appears. As soon as you click on Notices and slips on the
sidebar menu, it disappears again.

Other things I noticed
~~~~~~~~~~~~~~~~~~~~~~

These aren't related to this bug, but if someone can confirm them, I will log
separate bugs (if they haven't been logged already):

- Z39.50/SRU servers administration: Both before and after the patch I don't
get any search results for any content in any of the columns, such as the
target, database, hostname/port.

- Acquisitions - vendor contract search: I get an error trace (both before and
after the patch is applied): 
  . Go to Acquisitions > search for a vendor
  . Click on contracts
  . Use the search in the header
  . Error trace:

    Can't call method "name" on an undefined value at
/kohadevbox/koha/admin/aqcontract.pl line 54

         in (eval) at /kohadevbox/koha/admin/aqcontract.pl line 54

            51:     }
            52: );
            53: 
            54: $template->param(
            55:     contractnumber => $contractnumber,
            56:     booksellerid   => $booksellerid,
            57:     booksellername => $bookseller->name,
    .....

Also, I wasn't aware of the shortcuts before - they are great!

-- 
You are receiving this mail because:
You are watching all bug changes.