[Koha-bugs] [Bug 32609] Remove compiled files from src

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 24 23:32:55 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #17 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #15)
> (In reply to David Cook from comment #12)
> > If we create a Perl script to run these commands, we can include it in
> > Makefile.PL, plus manually call it for "ktd" and sandboxes, so... that
> > should be pretty straightforward overall.
> 
> Actually it's not obvious at all for me how this can be done easily.
> 
> There are dev paths in gulpfile...
> 
> We could rely no an env var (or an option?) that would pass the path.
> 
> Like:
>   css_path=/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/css/ yarn
> css:build:prod
> 
> I've done this already.
> For the js/vue dist file, it's a bit more tricky (node path, relative js
> path, modules, etc.)

In my mind, you would only be running the build from the source directory and
not a deployed directory, so the paths should always be those dev paths.

We should just need to add a script to Koha for running the JS build, and then
for ktd and sandboxes, we invoke it (targeting the git checkouts) via their
respective toolchains. We add a call to that script in Makefile.PL as well to
build the JS for single/standard/dev installs (and package installs which use
the standard install implicitly). 

--

Of course, I might be missing something here. 

If you can tell me which commands we need to build the JS and CSS, I'm happy to
give this a try...

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list