[Koha-bugs] [Bug 27432] Add report run to action logs

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432

--- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #29)
> Note that we should not fetch the report if ReportsLog is off.
Correct.

I see in execute_query() :
    my ( $is_sql_valid, $errors ) = Koha::Report->new({ savedsql => $sql
})->is_sql_valid;
    return (undef, @{$errors}[0]) unless $is_sql_valid;

Should we replace with :
my $report = Koha::Reports->find($report_id) if $report_id;
...
$report->is_sql_valid

Plus :
======
I see an issue with this feature.
Some public reports maybe run very often via JSON, like webservices.
Maybe we should log only runs via the staff interface ?

-- 
You are receiving this mail because:
You are watching all bug changes.