[Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I tested this successfully on my Koha Testing Docker, but got an error when
trying to sign off. I then tried to add a signoff via the sandbox and it
attached a patch from another bug. Here's the error I got in KTD:

root at kohadevbox:koha(master)$ git bz attach -e 28314 HEAD
/usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to
convert both arguments to Unicode - interpreting them as being unequal
  obsoleted = (initial_description == patch.description)
Traceback (most recent call last):
  File "/usr/bin/git-bz", line 2722, in <module>
    do_attach(*args)
  File "/usr/bin/git-bz", line 2074, in do_attach
    attach_commits(bug, commits, edit_comments=global_options.edit)
  File "/usr/bin/git-bz", line 1988, in attach_commits
    description, body, obsoletes, statuses, patch_complexities, depends =
edit_attachment_comment(bug, commit.subject, body)
  File "/usr/bin/git-bz", line 1940, in edit_attachment_comment
    lines = edit_template(template.getvalue())
  File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue
    self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal
not in range(128)

I've gotten this error on other patches, too. I don't believe it's anything to
go with this code in particular. This patch works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.