[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #17 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Jonathan Druart from comment #15)
> Hi Andreas,
Hi Jonathan!

I appreciate your feedback -- please see my replies inline below:

> The test is failing for me:
> 
> kohadev-koha at kohadevbox:/kohadevbox/koha$ prove
> t/db_dependent/selenium/opacshelfbrowser.t
> t/db_dependent/selenium/opacshelfbrowser.t ..     # No tests run!
> t/db_dependent/selenium/opacshelfbrowser.t .. 1/3 
> #   Failed test 'No tests run for subtest "OPAC Shelf browser - Check
> display of local cover images (OpacSeparateHoldings set to "Don't
> separate")"'
> #   at t/db_dependent/selenium/opacshelfbrowser.t line 137.
> upload_file: no such file: ./opacshelfbrowser-test-image1.jpg at
> t/db_dependent/selenium/opacshelfbrowser.t line 120.
I hardcoded a relative path for the location of the JPGs to upload,
which is why the test only ran properly if you changed directory to
t/db_dependent/selenium/ first. I've now made adjustments to the test
script so that it will run just fine when called from any directory.

> Also:
> +    # test image by Kourosh Qaffari on Unsplash
> (https://unsplash.com/photos/RrhhzitYizg)
> The Unspash license does not seem GPLv3 compatible:
> https://unsplash.com/license
> 
> To avoid an unnecessary discussion about the license (which is not at all
> the goal here :D), and to prevent a 50kb to be added to the git repo,
> shouldn't we go with 1px images?
I agree, let's try that. I tried uploading a 1x1 pixel black PNG but
could not get it to work (it might have to do with the resizing that
is applied to local cover images when thumbnails are generated).
A 2x2 pixel black PNG worked fine though, so I suggest we go with
that instead. The 2x2 PNG file is only 72 bytes long ;-)

(In reply to Jonathan Druart from comment #16)
> I would also create a "data" directory, not at the same level of the other
> .t files.
Hmmm, there's actually a "data" directory inside t/db_dependent
which contains all sorts of files used by other tests. In my
revised patches I've chosen to add my sample PNG in there.

Please let me know if you'd like us to handle this differently.

Thank you very much for your patience with this bug report!
Apologies for taking so long to reply.

-- 
You are receiving this mail because:
You are watching all bug changes.