[Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display local cover images

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138016|0                           |1
        is obsolete|                            |
 Attachment #138017|0                           |1
        is obsolete|                            |

--- Comment #18 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 145805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145805&action=edit
Bug 31207: Fix the display of local cover images in the OPAC Shelf browser

This patch adds back Template Toolkit and JavaScript code that
was removed in commit fad97080e97da5bc77724c68b9394aba15518847
(Bug 28180), thus fixing the problem of Shelf browser images
not being loaded in the OPAC Details page for a biblio.

This feature stopped working in v21.11.00, and these conditions
must be met to be able to reproduce the problem:
a) Exclusive use of local cover images, and
b) Covers uploaded at the biblio level only.

Test plan:

0) Configure the following System Preferences:
   - OPACShelfBrowser           => 'Show'
   - LocalCoverImages           => 'Show'
   - OPACLocalCoverImages       => 'Show'
     (ensure no other cover image provider is enabled)
   - OpacSeparateHoldings       => 'Don't separate'
   - OpacSeparateHoldingsBranch => 'home library'

1) Create a bibliographic record that has:
   - a local cover image at the biblio level (use the 'Images' tab
     in the Details page of the record to upload a test image)
   - a single item with a Call number (the Call number value can
     be anything, it's only needed to trigger the Shelf browser)

2) In the OPAC, visit the Details page of the record you just added,
   and click on the 'Browse shelf' link found in the 'Call number'
   column of the 'Holdings' tab. When the Shelf browser expands,
   there will be no cover image displayed.

3) Apply the patch and refresh the page with CTRL-F5. The Shelf
   browser will now display the local cover image associated with
   your test record.

4) Make sure the relevant unit test passes:

   prove -v t/db_dependent/ShelfBrowser.t

-- 
You are receiving this mail because:
You are watching all bug changes.