[Koha-bugs] [Bug 32504] Empty column name, misaligning visibility, and export for basket/orders in table settings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32504

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #144767|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 145828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145828&action=edit
Bug 32504: Fix misalignment of visibility of basket orders table columns and
missing export columns

To reproduce:
1. Go to /cgi-bin/koha/admin/columns_settings.pl
2. In the section Acquisition > Basket > Orders uncheck all checkboxes in the
table settings
3. Go to a separate browser window to /cgi-bin/koha/acqui/booksellers.pl and
open/create a new basket and add one book to it so the basket table will have
rows in the "Order" table which we will configure below:
4. Click on the ["Columns" settings] for the table.
5. In the dropdown menu, observe that all Columns are marked as visible and
correspond to the current table display.
6. Also check the export table feature: Click on "Export" and choose print, you
will see that Columns up to GST (goods_and_services_tax) are displayed, and
Fund and Estimated delivery date are missing.
7. Go back to table settings (like it was in steps.1-2)
8. Make the estimated_delivery_date column 'invisible by default' by checking
out the appropriate checkbox and saving the changes.
9. Refresh the basket window/page (like in step 3).
10. Observe that in the table the whole columns "Estimated delivery date" is
visible but "Fund" is gone.
11. Click on the ["Columns" settings] for the table.
12. In the dropdown menu observe that the wrong column is disabled ("Fund"
instead of "Estimated delivery date").
13. Apply the patch.
14. Go through steps 3-12 and make sure that everything mentioned in those
steps now works correctly: when you hide any columns in columns_settings.pl
they are correctly hidden for the "Order" table, as well when exporting the
table, the Fund, and Estimated delivery date columns are now exported.

Note: this patch also respects Koha.Preference('EDIFACT') setting and when it's
enabled it also correctly hides/shows and exports the 'supplier_report' column.

Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.