[Koha-bugs] [Bug 32609] Remove compiled files from src

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 31 03:42:12 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609

--- Comment #29 from David Cook <dcook at prosentient.com.au> ---
Ok, so I've fixed it, so that the CSS and JS get compiled every time "make"[1]
is called, so they'll always be updated for source/package installs (which use
"make" and "make install") and git dev installs (if they use "make" and "make
upgrade").

For "ktd" and sandboxes (and git dev installs that don't use "make"), just call
"build-resources.PL" to compile the CSS and JS.

--

My patch updates the Makefile so that the "all" target relies on a new
"compile_css_js" target which runs build-resources.PL. That's fairly elegant.

The only non-elegant part is needing to list all the compiled files in
Makefile.PL so that they get correctly copied into the "blib" directory at
build time.

That code could be further streamlined to reduce boilerplate and the chance of
human error, although ultimately we will need to provide a list of generated
files at "perl Makefile.PL" time, or else the generated files won't get
deployed. In theory, this list should not change often.

--

[1] Note that someone many many years made the "install" target depend on
"all", so "make install" actually re-runs "make" effectively.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list