[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #8 from Phil Ringnalda <phil at chetcolibrary.org> ---
Oy. It hasn't been that way for over 17 years, it's been that way for 16 years,
since
https://git.koha-community.org/Koha-community/Koha/commit/af466ca41ab02150f4f6c60bf6262b079b2e6e85
looked at the pointless code that was

my $series       = 0;

if ( $biblio->{'seriestitle'} ) { $series = 1 }

and said "well, $series is unused, there's no biblio.series for it to set, but
serial is just two letters differnt than series so they must have meant

# set the series flag
my $serial = 0;
if ( $biblio->{'seriestitle'} ) { $serial = 1 }
"

so this whole stupid thing is because someone looked at dead code and instead
of deleting it, made it do something very wrong instead.

-- 
You are receiving this mail because:
You are watching all bug changes.