[Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I like where this is going towards.

There's one thing that bugs me: the header.

While I agree with using a header for controlling this behavior (to send or not
send), I find it weird that the spec says it should contain the word `email`,
but there's no check on this.

Could you consider for a bit using the 'email' value? And what about other
transports? Shouldn't we make the `x-koha-welcome` header be defined as:

      - name: x-koha-welcome
        in: header
        required: false
        description: The transport to use for sending a WELCOME message. Empty
means no message is sent.
        type: array
        items:
          type: string
          enum:
            - email
            - sms
            - pidgeon
        collectionFormat: csv

-- 
You are receiving this mail because:
You are watching all bug changes.