[Koha-bugs] [Bug 23336] Add an API endpoint for checking an item out to a patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_23_05_candidate         |additional_work_needed

--- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi, this needs more work:

1) prove xt/api.t => FAIL. It seems you either need to add an exception ofr the
added route or add the `additionalProperties: false` on the object definition.

2) prove t/db_dependent/Circulation.t => FAIL. 

38139718f534f308e5eb846f5e26ef54c01c3376 is the first bad commit
commit 38139718f534f308e5eb846f5e26ef54c01c3376
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Oct 3 17:07:20 2022 +0100

    Bug 23336: Fix inconsistent return of AddIssue

    AddIssue can on occasion create a renewal instead of a fresh issue and
    in such a case we currently return undefined. We should be consistent
    and return the existing issue object for the renewal.

    Signed-off-by: Silvia Meakins <smeakins at eso.org>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

 C4/Circulation.pm | 1 +

So probably just a matter of adjusting the tests BUT I'd like you to check the
uses of AddIssue, in case there's some stray case in which it is expecting an
empty string.

-- 
You are receiving this mail because:
You are watching all bug changes.