[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092

--- Comment #28 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Hey! Thanks for checking this Joubu, I was hoping you would!

(In reply to Jonathan Druart from comment #27)
> I don't understand why we move isolated code (patron_autocomplete.js) to a
> huge generic staff-global.js file. Can you explain please?

Interesting! My thought process was the exact opposite:
Why do we have an isolated file for this when we already have staff-global.js
that holds lots of global functions used throughout all of Staff UI, and this
is such a case.

That said, I don't have any preference on the matter! And I'm on board with
whichever.

The only thing I was really invested in was to have somewhat duplicate code be
consolidated into a single function. This should allow us to maintain it and
enhance it more easily, and allow future work that requires searching on
patrons to make use of this new buildPatronSearchQuery, auto-complete or not.

-- 
You are receiving this mail because:
You are watching all bug changes.