[Koha-bugs] [Bug 33132] Searching by DOB still broken in 22.05.x

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33132

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Applies to 22.05.x. Not tested.

koha-tmpl/intranet-tmpl/prog/en/includes/js-date-format.inc:       
window.$date_to_rfc3339 = function(value, options) {
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:                    
               let d = $date_to_rfc3339(pattern);

        window.$date_to_rfc3339 = function(value, options) {
            var dateformat = (options&&options.dateformat)||def_date_format;
            let m = moment(value, get_date_pattern(dateformat));
            return m.format("YYYY-MM-DD");
        }

Just some observations, not blocking:
Why do you have options if you do not use them?
Why do you call get_date_pattern if you format YMD later on?
Looks good to me for the rest.

-- 
You are receiving this mail because:
You are watching all bug changes.