[Koha-bugs] [Bug 34188] Require library selection when logging in

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Sam, 

congrats on your patch :)

Some notes:

1) The patch description should always describe the fix, not the problem. For
example here:

Add system preference to make library required on login

2) Always run the QA test tools:

 FAIL   installer/data/mysql/atomicupdate/bug_34188.pl
   FAIL   file permissions
                File must have the exec flag
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
   FAIL   filters
                missing_filter at line 121 (            <label for="branch"
class="[% libraryClass %]">Library:</label>)
                missing_filter at line 122 (            <select name="branch"
id="branch" class="input" tabindex="3" [% libraryRequired %]>)
   FAIL   tt_valid
                lines 122

There is a script in misc/devel that can help you fix the filters quickly:
add_missing_filters.pl

The TT valid points to some template issue, double check your changes for this
one.

Overall this looks good - close!

-- 
You are receiving this mail because:
You are watching all bug changes.