[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure what/how to test... but I just started anyway :)

1) QA test tools

 FAIL   t/db_dependent/Koha/Object.t
   FAIL   forbidden patterns
                forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 991)

Fixed in a follow-up.


2) Unit tests 

Passed.

Note: we have a 'dirty' test somewhere: I ended up with 4 new testbuilder-style
itemtypes in my db. They should have been cleaned up by the test creating them.

3) Did some GUI testing:

* Checkouts with rental feeds
* Backdated checkouts
* Renewal
* Checkin
** Fines calculated
** Suspension days added

4) Went through the code, found a typo:

-C<$item> item hashref
+C<$item> patron object

Fixed in follow-up.

I added my sign-off lines to this, feel free to switch to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.