[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 153523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153523&action=edit
Bug 34292: Format the check out date with dt_from_string()

In the current master, checking out an item to a patron results
in a 'Checked out on' date of the form '2023-07-16 12:44:18'
when viewing the patron's 'Checkouts' table. This is due to commit
1000ab402b from Bug 33804 which changed the `mDataProp` property
of the 'Checked out on' column from "issuedate_formatted" to plain
"issuedate" (for both the issues and relatives' issues DataTables).

"issuedate" comes straight from the issues.issuedate DB column
(which has `datetime` format), whereas "issuedate_formatted" is
formatted using Koha::DateUtils::dt_from_string() which takes
into account the `dateformat` System Preference.

This patch restores the original behaviour w.r.t. the formatting
of the 'Checked out on' column.

Note: in `svc/checkouts` we don't pass `as_due_date => 1` for
`issuedate_formatted` because we *do* want to show a check out
date with a time component of 23:59.

Test plan:

1) Without applying this patch, issue an item to a patron and
   notice that in the 'Checkouts' table the 'Checked out on'
   date is of the form YYYY-MM-DD HH:MM:SS.

2) Apply this patch, restart Plack if necessary.

3) Refresh the patron 'Checkouts' table: this time the 'Checked
   out on' date will observe the setting of your `dateformat`
   System Preference.

4) Extra credit: repeat step 3) for different `dateformat`
   settings, each time you should get a 'Checked out on' date
   that matches the date format you chose.

-- 
You are receiving this mail because:
You are watching all bug changes.